Page MenuHomePhabricator

will (William Wang)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 21 2023, 1:50 PM (34 w, 2 d)

Recent Activity

Thu, May 16

will closed D12081: [keyserver] upgrade docker keyserver MariaDB from 10.8 to 10.11.
Thu, May 16, 3:49 PM
will committed rCOMM33c3f65a5e43: [keyserver] upgrade docker keyserver MariaDB from 10.8 to 10.11 (authored by will).
[keyserver] upgrade docker keyserver MariaDB from 10.8 to 10.11
Thu, May 16, 3:49 PM
will accepted D12017: [protos] Add initial_device_list field.
Thu, May 16, 12:05 PM
will added a comment to D12017: [protos] Add initial_device_list field.

The rust looks good to me

Thu, May 16, 12:04 PM
will requested review of D12081: [keyserver] upgrade docker keyserver MariaDB from 10.8 to 10.11.
Thu, May 16, 10:40 AM

Wed, May 15

will closed D12000: [native/web] make `findUserIdentities` RPC available to native and web.
Wed, May 15, 8:30 PM
will committed rCOMMfb67cd1ec8a1: [native/web] make `findUserIdentities` RPC available to native and web (authored by will).
[native/web] make `findUserIdentities` RPC available to native and web
Wed, May 15, 8:30 PM
will closed D11998: [native] implement 'FindUserIdentities' RPC in `native_rust_library`.
Wed, May 15, 8:30 PM
will closed D11999: [CommRustModule] add JSI bindings for `findUserIdentities` RPC.
Wed, May 15, 8:30 PM
will committed rCOMMc502d1d24936: [native] implement 'FindUserIdentities' RPC in `native_rust_library` (authored by will).
[native] implement 'FindUserIdentities' RPC in `native_rust_library`
Wed, May 15, 8:30 PM
will committed rCOMMfdf6492c7fa5: [CommRustModule] add JSI bindings for `findUserIdentities` RPC (authored by will).
[CommRustModule] add JSI bindings for `findUserIdentities` RPC
Wed, May 15, 8:30 PM
will closed D11952: [identity] modify get user identity rpc to take user ids and return identity map with farcaster id.
Wed, May 15, 8:30 PM
will committed rCOMMca5fa9314dd8: [identity] modify get user identity rpc to take user ids and return identity… (authored by will).
[identity] modify get user identity rpc to take user ids and return identity…
Wed, May 15, 8:30 PM
will closed D11951: Refactor get user identifier to return identity with farcaster id.
Wed, May 15, 8:30 PM
will closed D11859: [lib] Rename action type to set aux user fids.
Wed, May 15, 8:30 PM
will committed rCOMM9a2f04e09c7f: Refactor get user identifier to return identity with farcaster id (authored by will).
Refactor get user identifier to return identity with farcaster id
Wed, May 15, 8:30 PM
will committed rCOMM9958ccbb501e: [lib] Rename action type to set aux user fids (authored by will).
[lib] Rename action type to set aux user fids
Wed, May 15, 8:30 PM
will updated the diff for D12000: [native/web] make `findUserIdentities` RPC available to native and web.

rebase

Wed, May 15, 8:01 PM
will updated the diff for D12000: [native/web] make `findUserIdentities` RPC available to native and web.

rebase

Wed, May 15, 7:34 PM
will accepted D12059: [native] fix error alert detail casing in AddKeyserver.
Wed, May 15, 1:24 PM
will updated the diff for D12000: [native/web] make `findUserIdentities` RPC available to native and web.

rebase

Wed, May 15, 12:18 PM
will updated the diff for D12000: [native/web] make `findUserIdentities` RPC available to native and web.

rebase before landing

Wed, May 15, 12:16 PM
will accepted D12058: [native] fix casing of error alert details.
Wed, May 15, 12:07 PM
will updated the diff for D11952: [identity] modify get user identity rpc to take user ids and return identity map with farcaster id.

review feedback

Wed, May 15, 8:51 AM
will updated the diff for D11952: [identity] modify get user identity rpc to take user ids and return identity map with farcaster id.

review feedback

Wed, May 15, 8:42 AM
will added inline comments to D11952: [identity] modify get user identity rpc to take user ids and return identity map with farcaster id.
Wed, May 15, 8:37 AM
will updated the diff for D11951: Refactor get user identifier to return identity with farcaster id.

review feedback

Wed, May 15, 8:31 AM
will closed D12003: [terraform] set all rust services to debug on staging.
Wed, May 15, 8:01 AM
will committed rCOMM6746dbe0c7f1: [terraform] set all rust services to debug on staging (authored by will).
[terraform] set all rust services to debug on staging
Wed, May 15, 8:01 AM
will closed D12002: [terraform] display comm-lib debug logs on identity.
Wed, May 15, 8:01 AM
will committed rCOMM2f146282117d: [terraform] display comm-lib debug logs on identity (authored by will).
[terraform] display comm-lib debug logs on identity
Wed, May 15, 8:01 AM
will closed D12040: [nix] remove extra comma.
Wed, May 15, 7:59 AM
will committed rCOMMae8840c8a0ba: [nix] remove extra comma (authored by will).
[nix] remove extra comma
Wed, May 15, 7:59 AM

Tue, May 14

will updated the diff for D12000: [native/web] make `findUserIdentities` RPC available to native and web.

use farcasterID instead of farcasterID on native/web

Tue, May 14, 11:22 PM
will updated the diff for D11998: [native] implement 'FindUserIdentities' RPC in `native_rust_library`.

farcasterId to farcasterID in native_rust_library

Tue, May 14, 11:22 PM
will requested review of D12040: [nix] remove extra comma.
Tue, May 14, 10:22 PM
will updated the diff for D12003: [terraform] set all rust services to debug on staging.

replace comm-lib and feature-flags with underscores in env var

Tue, May 14, 9:17 PM
will updated the diff for D12002: [terraform] display comm-lib debug logs on identity.

Fix comm-lib as comm_lib in env variable

Tue, May 14, 9:16 PM
will closed D12022: [nix] upgrade mariadb from 10.8 to 10.11.
Tue, May 14, 9:55 AM
will committed rCOMM57b16fd87e6a: [nix] upgrade mariadb from 10.8 to 10.11 (authored by will).
[nix] upgrade mariadb from 10.8 to 10.11
Tue, May 14, 9:55 AM
will closed D12021: [keyserver][nix] remove dbType from db-config.js.
Tue, May 14, 9:55 AM
will committed rCOMM508243212382: [keyserver][nix] remove dbType from db-config.js (authored by will).
[keyserver][nix] remove dbType from db-config.js
Tue, May 14, 9:55 AM
will updated the diff for D12021: [keyserver][nix] remove dbType from db-config.js.

Remove unnecessary spread syntax

Tue, May 14, 9:34 AM
will updated the summary of D12022: [nix] upgrade mariadb from 10.8 to 10.11.
Tue, May 14, 8:20 AM

Mon, May 13

will added inline comments to D12011: [lib] dispatch actions and populate aux user store with fids.
Mon, May 13, 3:59 PM
will requested review of D12022: [nix] upgrade mariadb from 10.8 to 10.11.
Mon, May 13, 3:56 PM
will planned changes to D12000: [native/web] make `findUserIdentities` RPC available to native and web.

Planning changes to address Ashoat's comment on changing farcasterId to farcasterID

Mon, May 13, 3:44 PM
will requested review of D12021: [keyserver][nix] remove dbType from db-config.js.
Mon, May 13, 3:44 PM
will closed D12004: [terraform] rename alarm names to be uppercase to match other alarm names.
Mon, May 13, 7:28 AM
will committed rCOMM015ee68ce154: [terraform] rename alarm names to be uppercase to match other alarm names (authored by will).
[terraform] rename alarm names to be uppercase to match other alarm names
Mon, May 13, 7:28 AM
will closed D12001: [identity] remove unnecessary error log for identity search connection close.
Mon, May 13, 7:28 AM
will committed rCOMM25fae03d75d0: [identity] remove unnecessary error log for identity search connection close (authored by will).
[identity] remove unnecessary error log for identity search connection close
Mon, May 13, 7:28 AM

Sun, May 12

will requested review of D12011: [lib] dispatch actions and populate aux user store with fids.
Sun, May 12, 8:27 PM

Sat, May 11

will requested review of D12004: [terraform] rename alarm names to be uppercase to match other alarm names.
Sat, May 11, 11:25 AM
will retitled D12002: [terraform] display comm-lib debug logs on identity from [terraform] display comm-lib debug logs to [terraform] display comm-lib debug logs on identity.
Sat, May 11, 11:08 AM
will requested review of D12003: [terraform] set all rust services to debug on staging.
Sat, May 11, 11:06 AM
will requested review of D12002: [terraform] display comm-lib debug logs on identity.
Sat, May 11, 11:04 AM
will requested review of D12001: [identity] remove unnecessary error log for identity search connection close.
Sat, May 11, 11:03 AM

Fri, May 10

will requested review of D12000: [native/web] make `findUserIdentities` RPC available to native and web.
Fri, May 10, 10:15 PM
will requested review of D11999: [CommRustModule] add JSI bindings for `findUserIdentities` RPC.
Fri, May 10, 10:05 PM
will requested review of D11998: [native] implement 'FindUserIdentities' RPC in `native_rust_library`.
Fri, May 10, 10:04 PM
will accepted D11985: [identity] Add gRPC request tracing span.
Fri, May 10, 7:39 AM
will added a comment to D11985: [identity] Add gRPC request tracing span.

This is great. Thanks for introducing this

Fri, May 10, 7:38 AM
will accepted D11983: [identity] Reduce log level for gRPC interceptors.
Fri, May 10, 7:36 AM

Thu, May 9

will closed D11977: [terraform] update staging identity server image to 0.16-staging.
Thu, May 9, 9:11 PM
will committed rCOMMeba3b88f30fc: [terraform] update staging identity server image to 0.16-staging (authored by will).
[terraform] update staging identity server image to 0.16-staging
Thu, May 9, 9:11 PM
will requested review of D11977: [terraform] update staging identity server image to 0.16-staging.
Thu, May 9, 11:24 AM
will added inline comments to D11952: [identity] modify get user identity rpc to take user ids and return identity map with farcaster id.
Thu, May 9, 10:53 AM
will accepted D11957: [identity] Extract function to ed25519 verify message.
Thu, May 9, 9:39 AM

Wed, May 8

will requested review of D11952: [identity] modify get user identity rpc to take user ids and return identity map with farcaster id.
Wed, May 8, 10:56 PM
will requested review of D11951: Refactor get user identifier to return identity with farcaster id.
Wed, May 8, 10:49 PM
will updated the diff for D11859: [lib] Rename action type to set aux user fids.

rebase and include payload

Wed, May 8, 10:26 PM
will closed D11853: [terraform] metric filters for error logs in identity service.
Wed, May 8, 10:33 AM
will closed D11854: [terraform] identity service cloudwatch alarms.
Wed, May 8, 10:33 AM
will closed D11892: [terraform] Create an alarm for when the identity ECS task stops.
Wed, May 8, 10:33 AM
will closed D11852: [identity] Add prefixes to error logs for filtering.
Wed, May 8, 10:33 AM
will committed rCOMM62b0317c350e: [terraform] identity service cloudwatch alarms (authored by will).
[terraform] identity service cloudwatch alarms
Wed, May 8, 10:33 AM
will committed rCOMM98a5b78ebcf7: [terraform] Create an alarm for when the identity ECS task stops (authored by will).
[terraform] Create an alarm for when the identity ECS task stops
Wed, May 8, 10:33 AM
will committed rCOMMa416e996d6d6: [terraform] metric filters for error logs in identity service (authored by will).
[terraform] metric filters for error logs in identity service
Wed, May 8, 10:33 AM
will closed D11830: [identity] add span tracing to token.rs.
Wed, May 8, 10:33 AM
will closed D11831: [identity] add span tracing to identity farcaster.rs.
Wed, May 8, 10:33 AM
will committed rCOMM6190b986ef59: [identity] Add prefixes to error logs for filtering (authored by will).
[identity] Add prefixes to error logs for filtering
Wed, May 8, 10:33 AM
will committed rCOMM4ac28163b7e2: [identity] add span tracing to identity farcaster.rs (authored by will).
[identity] add span tracing to identity farcaster.rs
Wed, May 8, 10:33 AM
will committed rCOMMa52239d609b6: [identity] add span tracing to token.rs (authored by will).
[identity] add span tracing to token.rs
Wed, May 8, 10:33 AM
will closed D11829: [identity] Add span tracing to one_time_keys.rs.
Wed, May 8, 10:33 AM
will closed D11828: [identity] add span tracing to identity device_list.rs functions.
Wed, May 8, 10:33 AM
will closed D11827: [identity] add span tracing to identity database.rs file.
Wed, May 8, 10:33 AM
will committed rCOMM03069109e929: [identity] Add span tracing to one_time_keys.rs (authored by will).
[identity] Add span tracing to one_time_keys.rs
Wed, May 8, 10:33 AM
will committed rCOMM872a76c9132d: [identity] add span tracing to identity device_list.rs functions (authored by will).
[identity] add span tracing to identity device_list.rs functions
Wed, May 8, 10:33 AM
will committed rCOMMb0272d49b183: [identity] add span tracing to identity database.rs file (authored by will).
[identity] add span tracing to identity database.rs file
Wed, May 8, 10:33 AM
will closed D11826: [identity] add span tracing to identity websocket server.
Wed, May 8, 10:33 AM
will closed D11825: [identity] Add span tracing to grpc handlers.
Wed, May 8, 10:33 AM
will committed rCOMM40c5c2d8756c: [identity] Add span tracing to grpc handlers (authored by will).
[identity] Add span tracing to grpc handlers
Wed, May 8, 10:33 AM
will committed rCOMM9e76db7ca555: [identity] add span tracing to identity websocket server (authored by will).
[identity] add span tracing to identity websocket server
Wed, May 8, 10:33 AM
will closed D11824: [terraform] add comm_services_use_json_logs env variable for json tracing.
Wed, May 8, 10:33 AM
will committed rCOMMdca1fe62a915: [terraform] add comm_services_use_json_logs env variable for json tracing (authored by will).
[terraform] add comm_services_use_json_logs env variable for json tracing
Wed, May 8, 10:33 AM

Tue, May 7

will updated the diff for D11852: [identity] Add prefixes to error logs for filtering.

review feedback and whitespace

Tue, May 7, 8:04 AM
will added inline comments to D11852: [identity] Add prefixes to error logs for filtering.
Tue, May 7, 7:18 AM

Mon, May 6

will updated the diff for D11853: [terraform] metric filters for error logs in identity service.

add sync pattern

Mon, May 6, 2:16 PM
will updated the diff for D11852: [identity] Add prefixes to error logs for filtering.

review feedback

Mon, May 6, 12:27 PM