Page MenuHomePhabricator

will (William Wang)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 21 2023, 1:50 PM (31 w, 1 d)

Recent Activity

Today

will accepted D11799: [lib] Search for users in thread list search.

Looks good to me

Fri, Apr 26, 7:51 PM

Yesterday

will closed D11744: [identity] add env var conditional json tracing.
Thu, Apr 25, 9:28 PM
will committed rCOMM0b3bd2ef4147: [identity] add env var conditional json tracing (authored by will).
[identity] add env var conditional json tracing
Thu, Apr 25, 9:28 PM
will updated the diff for D11744: [identity] add env var conditional json tracing.

rebase

Thu, Apr 25, 9:25 PM
will updated the diff for D11744: [identity] add env var conditional json tracing.

rebase

Thu, Apr 25, 9:18 PM
will closed D11743: [terraform] Warning message typo.
Thu, Apr 25, 9:16 PM
will committed rCOMM36426c2b3761: [terraform] Warning message typo (authored by will).
[terraform] Warning message typo
Thu, Apr 25, 9:16 PM
will closed D11745: [identity] Convert unwraps in sync identity search to expects.
Thu, Apr 25, 9:15 PM
will committed rCOMMcf544ccfab3a: [identity] Convert unwraps in sync identity search to expects (authored by will).
[identity] Convert unwraps in sync identity search to expects
Thu, Apr 25, 9:15 PM
will accepted D11783: [terraform] enable debug logs by default on staging.
Thu, Apr 25, 11:32 AM

Tue, Apr 23

will requested review of D11745: [identity] Convert unwraps in sync identity search to expects.
Tue, Apr 23, 12:16 PM
will requested review of D11744: [identity] add env var conditional json tracing.
Tue, Apr 23, 12:01 PM
will requested review of D11743: [terraform] Warning message typo.
Tue, Apr 23, 11:55 AM
will accepted D11740: [lib] Rename `getMinimallyEncodedCurrentUser` -> `getCurrentUser`.
Tue, Apr 23, 11:08 AM

Fri, Apr 19

will accepted D11704: bump identity version and introduce script for identity releases.
Fri, Apr 19, 1:10 PM
will closed D11618: [native][web] Read thread activity entries from SQLite on app start.
Fri, Apr 19, 1:09 PM
will committed rCOMMa11214af00e9: [native][web] Read thread activity entries from SQLite on app start (authored by will).
[native][web] Read thread activity entries from SQLite on app start
Fri, Apr 19, 1:09 PM
will closed D11665: [web] convert updating thread activity `lastThreadNavigatedTo` on web to use sqlite.
Fri, Apr 19, 1:09 PM
will closed D11617: [native][web] Start processing thread activity store with sqlite operations.
Fri, Apr 19, 1:09 PM
will committed rCOMMd82518d49a1b: [web] convert updating thread activity `lastThreadNavigatedTo` on web to use… (authored by will).
[web] convert updating thread activity `lastThreadNavigatedTo` on web to use…
Fri, Apr 19, 1:08 PM
will closed D11616: [native] migrate threadActivityStore to SQLite.
Fri, Apr 19, 1:08 PM
will committed rCOMM107293bdf1bf: [native][web] Start processing thread activity store with sqlite operations (authored by will).
[native][web] Start processing thread activity store with sqlite operations
Fri, Apr 19, 1:08 PM
will committed rCOMM408f153e9e31: [native] migrate threadActivityStore to SQLite (authored by will).
[native] migrate threadActivityStore to SQLite
Fri, Apr 19, 1:08 PM
will closed D11615: [sqlite] Implement processing thread activity on web worker.
Fri, Apr 19, 1:08 PM
will committed rCOMMc175e1714d27: [sqlite] Implement processing thread activity on web worker (authored by will).
[sqlite] Implement processing thread activity on web worker
Fri, Apr 19, 1:08 PM
will closed D11614: [sqlite] Implement C++ code for native to get sqlite thread activity entries.
Fri, Apr 19, 1:08 PM
will closed D11584: [sqlite/native] Make C++ thread activity sqlite ops available to native.
Fri, Apr 19, 1:08 PM
will committed rCOMM9567929ea151: [sqlite] Implement C++ code for native to get sqlite thread activity entries (authored by will).
[sqlite] Implement C++ code for native to get sqlite thread activity entries
Fri, Apr 19, 1:08 PM
will committed rCOMMf2f89a5bf164: [sqlite/native] Make C++ thread activity sqlite ops available to native (authored by will).
[sqlite/native] Make C++ thread activity sqlite ops available to native
Fri, Apr 19, 1:08 PM
will closed D11581: [sqlite] Implement C++ methods for thread activity.
Fri, Apr 19, 1:08 PM
will committed rCOMM7aa6f6dc604f: [sqlite] Implement C++ methods for thread activity (authored by will).
[sqlite] Implement C++ methods for thread activity
Fri, Apr 19, 1:08 PM
will closed D11579: [lib] return ops from thread activity reducer.
Fri, Apr 19, 1:06 PM
will committed rCOMM44fd4370b83c: [lib] return ops from thread activity reducer (authored by will).
[lib] return ops from thread activity reducer
Fri, Apr 19, 1:06 PM
will updated the diff for D11579: [lib] return ops from thread activity reducer.

fix tests

Fri, Apr 19, 12:42 PM
will closed D11578: [lib] refactor thread activity reducer to use sqlite operations.
Fri, Apr 19, 12:32 PM
will committed rCOMM68fc96783930: [lib] refactor thread activity reducer to use sqlite operations (authored by will).
[lib] refactor thread activity reducer to use sqlite operations
Fri, Apr 19, 12:32 PM
will closed D11576: [native/sqlite] Create thread activity table in sqlite.
Fri, Apr 19, 12:32 PM
will committed rCOMMedad6555237f: [native/sqlite] Create thread activity table in sqlite (authored by will).
[native/sqlite] Create thread activity table in sqlite
Fri, Apr 19, 12:32 PM
will closed D11575: [lib] Add thread activity store ops.
Fri, Apr 19, 12:25 PM
will committed rCOMM6f981993537e: [lib] Add thread activity store ops (authored by will).
[lib] Add thread activity store ops
Fri, Apr 19, 12:25 PM
will closed D11622: [lib] Make `lastPruned` and `lastNavigatedTo` type optional for thread activity entry.
Fri, Apr 19, 12:05 PM
will committed rCOMMc37e98658ab9: [lib] Make `lastPruned` and `lastNavigatedTo` type optional for thread activity… (authored by will).
[lib] Make `lastPruned` and `lastNavigatedTo` type optional for thread activity…
Fri, Apr 19, 12:05 PM
will updated the diff for D11618: [native][web] Read thread activity entries from SQLite on app start.

rebase before landing

Fri, Apr 19, 11:42 AM
will updated the diff for D11616: [native] migrate threadActivityStore to SQLite.

rebase before landing

Fri, Apr 19, 11:42 AM
will updated the test plan for D11618: [native][web] Read thread activity entries from SQLite on app start.
Fri, Apr 19, 11:39 AM
will updated the diff for D11618: [native][web] Read thread activity entries from SQLite on app start.

style. rebase before landing

Fri, Apr 19, 11:35 AM
will planned changes to D11618: [native][web] Read thread activity entries from SQLite on app start.
Fri, Apr 19, 11:29 AM
will updated the diff for D11618: [native][web] Read thread activity entries from SQLite on app start.

Do not assert equality of threadActivity on web

Fri, Apr 19, 11:28 AM

Thu, Apr 18

will closed D11672: create new aux user store action for clearing fids.
Thu, Apr 18, 9:13 PM
will committed rCOMM2b05aaf6d911: create new aux user store action for clearing fids (authored by will).
create new aux user store action for clearing fids
Thu, Apr 18, 9:13 PM
will closed D11671: Makes fid optionally null so that we can delete the fid later.
Thu, Apr 18, 9:13 PM
will committed rCOMM97e642832c6e: Makes fid optionally null so that we can delete the fid later (authored by will).
Makes fid optionally null so that we can delete the fid later
Thu, Apr 18, 9:13 PM
will updated the diff for D11672: create new aux user store action for clearing fids.

rename clear to not include friends

Thu, Apr 18, 8:32 PM

Wed, Apr 17

will added a comment to D11672: create new aux user store action for clearing fids.

Removing the language of friends. This action type will encompass wiping all aux user store data irregardless of whether or not the user is friends with them or not.

Wed, Apr 17, 10:31 AM
will abandoned D11639: [lib] Add farcaster friend fids to sqlite.
Wed, Apr 17, 10:23 AM
will added a comment to D11639: [lib] Add farcaster friend fids to sqlite.

Updated linear project with new tasks: https://linear.app/comm/project/farcaster-sqlite-followups-a2415120f443.

Wed, Apr 17, 10:22 AM
will added a comment to D11672: create new aux user store action for clearing fids.

but I'm also thinking we might be able to run it when we disconnect our farcaster accounts?

What's the purpose of the aux user store? If it's for showing Farcaster IDs in user profiles, I guess we should be showing those regardless of whether the users are Farcaster friends, and regardless of whether the viewer even has associated a Farcaster account.

Wed, Apr 17, 9:13 AM
will added a comment to D11639: [lib] Add farcaster friend fids to sqlite.

Separately, thinking about this a bit more... is the purpose of putting FIDs in the aux user store so that we can show Farcaster accounts on user profiles in Comm? If >> so, shouldn't we fetch FIDs for all users in the UserStore, and not just for Farcaster friends?

Wed, Apr 17, 8:40 AM
will closed D11673: [native] check for null fid before adding to sqlite database.
Wed, Apr 17, 8:07 AM
will committed rCOMMc017019752b0: [native] check for null fid before adding to sqlite database (authored by will).
[native] check for null fid before adding to sqlite database
Wed, Apr 17, 8:07 AM
will published D11673: [native] check for null fid before adding to sqlite database for review.
Wed, Apr 17, 8:03 AM
will added a comment to D11672: create new aux user store action for clearing fids.

but I'm also thinking we might be able to run it when we disconnect our farcaster accounts?

What's the purpose of the aux user store? If it's for showing Farcaster IDs in user profiles, I guess we should be showing those regardless of whether the users are Farcaster friends, and regardless of whether the viewer even has associated a Farcaster account.

Wed, Apr 17, 6:56 AM
will added reviewers for D11672: create new aux user store action for clearing fids: ashoat, atul, ginsu.
Wed, Apr 17, 6:55 AM

Tue, Apr 16

will updated the diff for D11618: [native][web] Read thread activity entries from SQLite on app start.

rebase

Tue, Apr 16, 10:19 PM
will updated the diff for D11665: [web] convert updating thread activity `lastThreadNavigatedTo` on web to use sqlite.

review feedback

Tue, Apr 16, 10:18 PM
will closed D11630: [lib/native] Delete FIDProvider.
Tue, Apr 16, 9:24 PM
will committed rCOMM609c93977002: [lib/native] Delete FIDProvider (authored by will).
[lib/native] Delete FIDProvider
Tue, Apr 16, 9:24 PM
will closed D11629: [native][lib] Replace usages of FIDProvider with Synced Metadata Store.
Tue, Apr 16, 9:24 PM
will closed D11628: [lib] Make synced metadata name field an enum.
Tue, Apr 16, 9:24 PM
will committed rCOMM8ce3feec147e: [native][lib] Replace usages of FIDProvider with Synced Metadata Store (authored by will).
[native][lib] Replace usages of FIDProvider with Synced Metadata Store
Tue, Apr 16, 9:24 PM
will committed rCOMM051c63bec1d7: [lib] Make synced metadata name field an enum (authored by will).
[lib] Make synced metadata name field an enum
Tue, Apr 16, 9:24 PM
will closed D11627: Rename addSyncedMetadata and removeSyncedMetadata action types to set and clear.
Tue, Apr 16, 9:24 PM
will committed rCOMM340733ee63e9: Rename addSyncedMetadata and removeSyncedMetadata action types to set and clear (authored by will).
Rename addSyncedMetadata and removeSyncedMetadata action types to set and clear
Tue, Apr 16, 9:24 PM
will updated the diff for D11616: [native] migrate threadActivityStore to SQLite.

rebase

Tue, Apr 16, 9:04 PM
will updated the diff for D11618: [native][web] Read thread activity entries from SQLite on app start.

rebase

Tue, Apr 16, 8:59 PM
will updated the diff for D11614: [sqlite] Implement C++ code for native to get sqlite thread activity entries.

thread_activity_store_entry => threadActivityStoreEntry

Tue, Apr 16, 8:58 PM
will requested review of D11672: create new aux user store action for clearing fids.
Tue, Apr 16, 3:36 PM
will added a comment to D11639: [lib] Add farcaster friend fids to sqlite.

Given that we're already checking farcaster friends in a useEffect, should we possibly consider a syncing action type instead that not only adds new farcaster friends but also removes farcaster friends that we've unfollowed as well?

Tue, Apr 16, 3:31 PM
will added a comment to D11639: [lib] Add farcaster friend fids to sqlite.
Tue, Apr 16, 3:29 PM
will updated the test plan for D11639: [lib] Add farcaster friend fids to sqlite.
Tue, Apr 16, 3:27 PM
will updated the summary of D11639: [lib] Add farcaster friend fids to sqlite.
Tue, Apr 16, 3:25 PM
will updated the diff for D11639: [lib] Add farcaster friend fids to sqlite.

update to use commFCUsers and also clear prior fids

Tue, Apr 16, 3:21 PM
will requested review of D11671: Makes fid optionally null so that we can delete the fid later.
Tue, Apr 16, 2:50 PM
will updated the summary of D11639: [lib] Add farcaster friend fids to sqlite.
Tue, Apr 16, 2:35 PM
will added inline comments to D11629: [native][lib] Replace usages of FIDProvider with Synced Metadata Store.
Tue, Apr 16, 11:50 AM
will updated the diff for D11629: [native][lib] Replace usages of FIDProvider with Synced Metadata Store.

create useCurrentUserFID hook instead of get function

Tue, Apr 16, 11:48 AM
will accepted D11667: [lib] Fix legacy register and SIWE.
Tue, Apr 16, 11:34 AM

Mon, Apr 15

will updated the diff for D11629: [native][lib] Replace usages of FIDProvider with Synced Metadata Store.

replace useSelector with function

Mon, Apr 15, 9:31 PM
will requested review of D11665: [web] convert updating thread activity `lastThreadNavigatedTo` on web to use sqlite.
Mon, Apr 15, 2:45 PM
will updated the summary of D11618: [native][web] Read thread activity entries from SQLite on app start.
Mon, Apr 15, 2:30 PM
will updated the test plan for D11616: [native] migrate threadActivityStore to SQLite.
Mon, Apr 15, 7:09 AM
will updated the diff for D11618: [native][web] Read thread activity entries from SQLite on app start.

entrie to entries

Mon, Apr 15, 6:32 AM
will updated the diff for D11578: [lib] refactor thread activity reducer to use sqlite operations.

rebase

Mon, Apr 15, 6:27 AM
will updated the diff for D11584: [sqlite/native] Make C++ thread activity sqlite ops available to native.

add new line

Mon, Apr 15, 5:22 AM
will updated the test plan for D11576: [native/sqlite] Create thread activity table in sqlite.
Mon, Apr 15, 5:14 AM
will added a comment to D11622: [lib] Make `lastPruned` and `lastNavigatedTo` type optional for thread activity entry.

It's not possible for ThreadActivityStoreEntry to be an empty object?

Mon, Apr 15, 5:07 AM

Fri, Apr 12

will updated the summary of D11629: [native][lib] Replace usages of FIDProvider with Synced Metadata Store.
Fri, Apr 12, 9:02 AM
will closed D11640: [lib] rewrite integrityInfos ThreadHashes.
Fri, Apr 12, 9:01 AM
will committed rCOMMa00666640f0d: [lib] rewrite integrityInfos ThreadHashes (authored by will).
[lib] rewrite integrityInfos ThreadHashes
Fri, Apr 12, 9:01 AM

Thu, Apr 11

will planned changes to D11639: [lib] Add farcaster friend fids to sqlite.
Thu, Apr 11, 11:46 AM