Page MenuHomePhabricator

will (William Wang)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 21 2023, 1:50 PM (44 w, 1 d)

Recent Activity

Yesterday

will accepted D12888: [identity] Add function to batch-get device lists.
Fri, Jul 26, 8:09 AM

Thu, Jul 25

will closed D12623: [identity] downgrade no auth message error to warning.
Thu, Jul 25, 2:38 PM
will committed rCOMM200062e6eea2: [identity] downgrade no auth message error to warning (authored by will).
[identity] downgrade no auth message error to warning
Thu, Jul 25, 2:38 PM
will closed D12877: [terraform] Update terraform.tfvars.example and use json format.
Thu, Jul 25, 2:23 PM
will committed rCOMMf4fceed7f2ba: [terraform] Update terraform.tfvars.example and use json format (authored by will).
[terraform] Update terraform.tfvars.example and use json format
Thu, Jul 25, 2:23 PM
will closed D12876: [terraform] Making user created vpc false by default.
Thu, Jul 25, 2:23 PM
will committed rCOMMc8b96f13ef8f: [terraform] Making user created vpc false by default (authored by will).
[terraform] Making user created vpc false by default
Thu, Jul 25, 2:23 PM
will closed D12875: [terraform] create separate lb security groups for landing and web.
Thu, Jul 25, 2:23 PM
will committed rCOMMfe8af3b57b72: [terraform] create separate lb security groups for landing and web (authored by will).
[terraform] create separate lb security groups for landing and web
Thu, Jul 25, 2:22 PM
will closed D12874: [terraform] up maximum deployment and minimum deployment percents.
Thu, Jul 25, 2:22 PM
will committed rCOMM45876077b05e: [terraform] up maximum deployment and minimum deployment percents (authored by will).
[terraform] up maximum deployment and minimum deployment percents
Thu, Jul 25, 2:22 PM
will updated the diff for D12623: [identity] downgrade no auth message error to warning.

rebase

Thu, Jul 25, 2:19 PM
will added a comment to D12623: [identity] downgrade no auth message error to warning.

This was triggered recently and might've been a websocket health check or something related.

It's worth checking if clients aren't broken and they do send the message

Thu, Jul 25, 2:18 PM
will updated the diff for D12875: [terraform] create separate lb security groups for landing and web.

rebase

Thu, Jul 25, 11:15 AM
will closed D12883: [web] Fixes the emscripten CI build by allowing curl redirects.
Thu, Jul 25, 11:13 AM
will committed rCOMM6b04b56d9534: [web] Fixes the emscripten CI build by allowing curl redirects (authored by will).
[web] Fixes the emscripten CI build by allowing curl redirects
Thu, Jul 25, 11:13 AM
will requested review of D12883: [web] Fixes the emscripten CI build by allowing curl redirects.
Thu, Jul 25, 10:41 AM
will closed D12686: [lib] remove integrity store assertion and use sqlite.
Thu, Jul 25, 9:45 AM
will committed rCOMM3a325b4a239f: [lib] remove integrity store assertion and use sqlite (authored by will).
[lib] remove integrity store assertion and use sqlite
Thu, Jul 25, 9:45 AM
will updated the diff for D12875: [terraform] create separate lb security groups for landing and web.

rebase

Thu, Jul 25, 9:37 AM
will updated the diff for D12875: [terraform] create separate lb security groups for landing and web.

update descriptions for landing and webapp security groups

Thu, Jul 25, 7:12 AM
will added inline comments to D12875: [terraform] create separate lb security groups for landing and web.
Thu, Jul 25, 7:08 AM

Wed, Jul 24

will requested review of D12877: [terraform] Update terraform.tfvars.example and use json format.
Wed, Jul 24, 1:40 PM
will requested review of D12876: [terraform] Making user created vpc false by default.
Wed, Jul 24, 1:34 PM
will updated the diff for D12686: [lib] remove integrity store assertion and use sqlite.

review feedback and rebase

Wed, Jul 24, 1:26 PM
will accepted D12873: [terraform] bump prod identity to 0.33.
Wed, Jul 24, 1:21 PM
will requested review of D12875: [terraform] create separate lb security groups for landing and web.
Wed, Jul 24, 1:15 PM
will closed D12863: [terraform] move image config to aws_ecs and add custom image variable.
Wed, Jul 24, 12:58 PM
will closed D12868: [terraform] Rename `aws_ecs` to `keyserver_cluster` and move shared security group.
Wed, Jul 24, 12:58 PM
will committed rCOMMbec3fcefbe5c: [terraform] move image config to aws_ecs and add custom image variable (authored by will).
[terraform] move image config to aws_ecs and add custom image variable
Wed, Jul 24, 12:58 PM
will committed rCOMMdb7d3c76c3e2: [terraform] Rename `aws_ecs` to `keyserver_cluster` and move shared security… (authored by will).
[terraform] Rename `aws_ecs` to `keyserver_cluster` and move shared security…
Wed, Jul 24, 12:58 PM
will closed D12862: [terraform] update variables.tf self-host descriptions.
Wed, Jul 24, 12:58 PM
will committed rCOMMec09585a102e: [terraform] update variables.tf self-host descriptions (authored by will).
[terraform] update variables.tf self-host descriptions
Wed, Jul 24, 12:58 PM
will requested review of D12874: [terraform] up maximum deployment and minimum deployment percents.
Wed, Jul 24, 12:54 PM
will closed D12861: [terraform] Actually use db_instance_class for mariadb.
Wed, Jul 24, 12:35 PM
will committed rCOMMbcf60c546342: [terraform] Actually use db_instance_class for mariadb (authored by will).
[terraform] Actually use db_instance_class for mariadb
Wed, Jul 24, 12:35 PM
will updated the diff for D12863: [terraform] move image config to aws_ecs and add custom image variable.

rebase

Wed, Jul 24, 12:34 PM
will requested review of D12868: [terraform] Rename `aws_ecs` to `keyserver_cluster` and move shared security group.
Wed, Jul 24, 9:06 AM

Tue, Jul 23

will closed D12864: [terraform] upgrade the disk image to 1.0.102.
Tue, Jul 23, 6:27 PM
will committed rCOMMd6cfb6f862ae: [terraform] upgrade the disk image to 1.0.102 (authored by will).
[terraform] upgrade the disk image to 1.0.102
Tue, Jul 23, 6:27 PM
will requested review of D12864: [terraform] upgrade the disk image to 1.0.102.
Tue, Jul 23, 5:27 PM
will requested review of D12863: [terraform] move image config to aws_ecs and add custom image variable.
Tue, Jul 23, 11:45 AM
will requested review of D12862: [terraform] update variables.tf self-host descriptions.
Tue, Jul 23, 11:43 AM
will requested review of D12861: [terraform] Actually use db_instance_class for mariadb.
Tue, Jul 23, 9:56 AM

Mon, Jul 22

will closed D12849: [terraform] Avoid including Terraform *.tfstate.backup in keyserver docker images.
Mon, Jul 22, 6:13 PM
will committed rCOMM139ef005b33b: [terraform] Avoid including Terraform *.tfstate.backup in keyserver docker… (authored by will).
[terraform] Avoid including Terraform *.tfstate.backup in keyserver docker…
Mon, Jul 22, 6:13 PM
will closed D12847: [keyserver] only run keyserver cron jobs if primary node besides geoip cron job.
Mon, Jul 22, 4:49 PM
will committed rCOMM83950aa49edf: [keyserver] only run keyserver cron jobs if primary node besides geoip cron job (authored by will).
[keyserver] only run keyserver cron jobs if primary node besides geoip cron job
Mon, Jul 22, 4:49 PM
will closed D12846: [keyserver] move `isPrimaryNode` to keyserver utils.
Mon, Jul 22, 4:49 PM
will committed rCOMM4e4b683f5de8: [keyserver] move `isPrimaryNode` to keyserver utils (authored by will).
[keyserver] move `isPrimaryNode` to keyserver utils
Mon, Jul 22, 4:49 PM
will requested review of D12848: [nix] revert nix watchman to use brew.
Mon, Jul 22, 12:47 PM
will requested review of D12847: [keyserver] only run keyserver cron jobs if primary node besides geoip cron job.
Mon, Jul 22, 12:34 PM
will requested review of D12846: [keyserver] move `isPrimaryNode` to keyserver utils.
Mon, Jul 22, 12:31 PM
will accepted D12845: [terraform] bump staging identity to 0.33-staging.
Mon, Jul 22, 12:15 PM
will added inline comments to D12814: [terraform] webapp terraform config.
Mon, Jul 22, 11:10 AM

Sat, Jul 20

will closed D12821: [terraform] make allowed_ip a list of valid ips.
Sat, Jul 20, 12:01 AM
will committed rCOMMe1239d588992: [terraform] make allowed_ip a list of valid ips (authored by will).
[terraform] make allowed_ip a list of valid ips
Sat, Jul 20, 12:01 AM

Fri, Jul 19

will published D12821: [terraform] make allowed_ip a list of valid ips for review.
Fri, Jul 19, 11:59 PM
will closed D12817: [terraform] upgrade self host image to 1.0.101.
Fri, Jul 19, 11:22 PM
will closed D12815: [terraform] landing terraform config.
Fri, Jul 19, 11:22 PM
will committed rCOMMcbe600f24166: [terraform] upgrade self host image to 1.0.101 (authored by will).
[terraform] upgrade self host image to 1.0.101
Fri, Jul 19, 11:22 PM
will closed D12814: [terraform] webapp terraform config.
Fri, Jul 19, 11:22 PM
will committed rCOMM15bcdda59137: [terraform] landing terraform config (authored by will).
[terraform] landing terraform config
Fri, Jul 19, 11:22 PM
will committed rCOMMefb6e368088b: [terraform] webapp terraform config (authored by will).
[terraform] webapp terraform config
Fri, Jul 19, 11:22 PM
will closed D12813: [terraform] add webapp, landing domains and rename keyserver domain variables.
Fri, Jul 19, 11:22 PM
will committed rCOMM422c1c6bdb33: [terraform] add webapp, landing domains and rename keyserver domain variables (authored by will).
[terraform] add webapp, landing domains and rename keyserver domain variables
Fri, Jul 19, 11:22 PM
will closed D12812: [terraform] run keyserver isolated from webapp and landing.
Fri, Jul 19, 11:22 PM
will committed rCOMM105ddca5585b: [terraform] run keyserver isolated from webapp and landing (authored by will).
[terraform] run keyserver isolated from webapp and landing
Fri, Jul 19, 11:22 PM
will requested review of D12817: [terraform] upgrade self host image to 1.0.101.
Fri, Jul 19, 10:13 PM
will accepted D12816: Don't include .env files from self-host directory in Docker images.
Fri, Jul 19, 8:57 PM
will published D12815: [terraform] landing terraform config for review.
Fri, Jul 19, 8:49 PM
will closed D12810: [keyserver] run webapp, landing, and keyserver conditionally.
Fri, Jul 19, 8:49 PM
will committed rCOMM083b66c6c741: [keyserver] run webapp, landing, and keyserver conditionally (authored by will).
[keyserver] run webapp, landing, and keyserver conditionally
Fri, Jul 19, 8:49 PM
will published D12814: [terraform] webapp terraform config for review.
Fri, Jul 19, 8:49 PM
will requested review of D12813: [terraform] add webapp, landing domains and rename keyserver domain variables.
Fri, Jul 19, 8:49 PM
will updated the diff for D12810: [keyserver] run webapp, landing, and keyserver conditionally.

newline

Fri, Jul 19, 8:48 PM
will closed D12808: [keyserver] remove unnecessary inviteResponder line in keyserver.js.
Fri, Jul 19, 8:39 PM
will committed rCOMMc372d8492061: [keyserver] remove unnecessary inviteResponder line in keyserver.js (authored by will).
[keyserver] remove unnecessary inviteResponder line in keyserver.js
Fri, Jul 19, 8:39 PM
will requested review of D12812: [terraform] run keyserver isolated from webapp and landing.
Fri, Jul 19, 5:37 PM
will requested review of D12810: [keyserver] run webapp, landing, and keyserver conditionally.
Fri, Jul 19, 4:17 PM
will requested review of D12808: [keyserver] remove unnecessary inviteResponder line in keyserver.js.
Fri, Jul 19, 2:32 PM

Thu, Jul 18

will closed D12800: [terraform] use `.env` in self-host folder for keyserver config variables instead of specifying values in terraform.tfvars or terraform.tfvars.json.
Thu, Jul 18, 8:46 PM
will committed rCOMMd39ad4ec4ac3: [terraform] use `.env` in self-host folder for keyserver config variables… (authored by will).
[terraform] use `.env` in self-host folder for keyserver config variables…
Thu, Jul 18, 8:46 PM
will closed D12791: [terraform] change keyserver version tag.
Thu, Jul 18, 8:46 PM
will committed rCOMMf1f110c6ed9e: [terraform] change keyserver version tag (authored by will).
[terraform] change keyserver version tag
Thu, Jul 18, 8:46 PM
will closed D12731: [terraform] Migration script for for self-hosted keyserver.
Thu, Jul 18, 8:46 PM
will committed rCOMM2407fdb79d16: [terraform] Migration script for for self-hosted keyserver (authored by will).
[terraform] Migration script for for self-hosted keyserver
Thu, Jul 18, 8:46 PM
will updated the diff for D12800: [terraform] use `.env` in self-host folder for keyserver config variables instead of specifying values in terraform.tfvars or terraform.tfvars.json.

revert mariadb sg description to Allow inbound traffic on port 3307 and all outbound traffic to avoid downtime

Thu, Jul 18, 6:48 PM
will updated the summary of D12791: [terraform] change keyserver version tag.
Thu, Jul 18, 6:21 PM
will updated the diff for D12791: [terraform] change keyserver version tag.

change to 1.0.100

Thu, Jul 18, 6:21 PM
will updated the diff for D12800: [terraform] use `.env` in self-host folder for keyserver config variables instead of specifying values in terraform.tfvars or terraform.tfvars.json.

final changes before landing

Thu, Jul 18, 6:19 PM
will added inline comments to D12731: [terraform] Migration script for for self-hosted keyserver.
Thu, Jul 18, 6:10 PM
will updated the diff for D12731: [terraform] Migration script for for self-hosted keyserver.

feedback

Thu, Jul 18, 6:06 PM
will added a comment to D12800: [terraform] use `.env` in self-host folder for keyserver config variables instead of specifying values in terraform.tfvars or terraform.tfvars.json.

Great work on this – looks really elegant!

Where did we land the MariaDB params – can those be specified only in the .env file, or will they need to be additionally specified to Terraform somehow?

Thu, Jul 18, 5:51 PM
will updated the summary of D12800: [terraform] use `.env` in self-host folder for keyserver config variables instead of specifying values in terraform.tfvars or terraform.tfvars.json.
Thu, Jul 18, 3:38 PM
will requested review of D12800: [terraform] use `.env` in self-host folder for keyserver config variables instead of specifying values in terraform.tfvars or terraform.tfvars.json.
Thu, Jul 18, 3:38 PM
will accepted D12798: [terraform] bump staging identity to 0.31-staging.
Thu, Jul 18, 3:22 PM
will accepted D12792: [terraform] Increase Identity memory to 2048.
Thu, Jul 18, 8:03 AM

Wed, Jul 17

will published D12791: [terraform] change keyserver version tag for review.
Wed, Jul 17, 7:21 PM
will closed D12730: [terraform] Ensure that the primary service is running before deploying secondary service.
Wed, Jul 17, 7:03 PM