Page MenuHomePhabricator
Differential D12888

[identity] Add function to batch-get device lists
ClosedPublic
Actions

Authored by bartek on Jul 26 2024, 2:55 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Sep 6, 12:15 PM
Unknown Object (File)
Fri, Aug 30, 11:22 AM
Unknown Object (File)
Tue, Aug 27, 6:36 PM
Unknown Object (File)
Tue, Aug 27, 3:19 AM
Unknown Object (File)
Mon, Aug 26, 11:05 AM
Unknown Object (File)
Mon, Aug 26, 2:45 AM
Unknown Object (File)
Sat, Aug 24, 7:28 PM
Unknown Object (File)
Fri, Aug 23, 6:17 PM
View All 34 Files
Subscribers
ashoat
tomek

Details

Reviewers
varun
will
kamil
Commits
rCOMM52e8224b3e28: [identity] Add function to batch-get device lists
Summary

Part of GetDeviceListsForUsers RPC rewrite. Details in ENG-8843.

Added a function that fetches latest device lists by using the timestamp attribute from users table. This way, we can get primary keys for device lists
without using Query, and thus can do BatchGet

Test Plan

Detailed test plan in ENG-8843.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek created this revision.Jul 26 2024, 2:55 AM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 26 2024, 2:55 AM
bartek added a child revision: D12889: [identity] Add function to batch-get platform details.Jul 26 2024, 2:56 AM
bartek mentioned this in D12890: [identity] Rewrite GetDeviceLists RPC to use batch functions.
Harbormaster completed remote builds in B30687: Diff 42803.Jul 26 2024, 3:15 AM
bartek published this revision for review.Jul 26 2024, 3:45 AM
will accepted this revision.Jul 26 2024, 8:09 AM
varun accepted this revision.Jul 26 2024, 12:29 PM
This revision is now accepted and ready to land.Jul 26 2024, 12:29 PM
varun added inline comments.Jul 26 2024, 12:30 PM
services/identity/src/database/device_list.rs
1064 ↗(On Diff #42803)

do we want a tracing instrument here?

bartek added inline comments.Jul 30 2024, 6:00 AM
services/identity/src/database/device_list.rs
1064 ↗(On Diff #42803)

Yeah good idea

Closed by commit rCOMM52e8224b3e28: [identity] Add function to batch-get device lists (authored by bartek). · Explain WhyJul 30 2024, 6:04 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMM52e8224b3e28: [identity] Add function to batch-get device lists.
bartek mentioned this in rCOMMc54e535c5b84: [identity] Rewrite GetDeviceLists RPC to use batch functions.

Revision Contents
Changeset List

PathSize
services/
identity/
src/
database/
93 lines

Diff 42966

View Options

services/identity/src/database/device_list.rs

Loading...