Paths

Table of Contentst

-
services/identity/src/database/
-
identity/
-
src/
-
database/
-
device_list.rs

[identity] Add function to batch-get device lists
ClosedPublic
Actions

Authored by bartek on Jul 26 2024, 2:55 AM.

Details

Reviewers

varun
will
kamil

Commits

rCOMM52e8224b3e28: [identity] Add function to batch-get device lists

Summary

Part of GetDeviceListsForUsers RPC rewrite. Details in ENG-8843.

Added a function that fetches latest device lists by using the timestamp attribute from users table. This way, we can get primary keys for device lists
without using Query, and thus can do BatchGet

Test Plan

Detailed test plan in ENG-8843.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Jul 26 2024, 2:55 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 26 2024, 2:55 AM

bartek added a child revision: D12889: [identity] Add function to batch-get platform details.Jul 26 2024, 2:56 AM

bartek mentioned this in D12890: [identity] Rewrite GetDeviceLists RPC to use batch functions.

Harbormaster completed remote builds in B30687: Diff 42803.Jul 26 2024, 3:15 AM

bartek published this revision for review.Jul 26 2024, 3:45 AM

will accepted this revision.Jul 26 2024, 8:09 AM

varun accepted this revision.Jul 26 2024, 12:29 PM

This revision is now accepted and ready to land.Jul 26 2024, 12:29 PM

varun added inline comments.Jul 26 2024, 12:30 PM

services/identity/src/database/device_list.rs
1064 ↗	(On Diff #42803)	do we want a tracing instrument here?

bartek added inline comments.Jul 30 2024, 6:00 AM

services/identity/src/database/device_list.rs
1064 ↗	(On Diff #42803)	Yeah good idea

Closed by commit rCOMM52e8224b3e28: [identity] Add function to batch-get device lists (authored by bartek). · Explain WhyJul 30 2024, 6:04 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM52e8224b3e28: [identity] Add function to batch-get device lists.

bartek mentioned this in rCOMMc54e535c5b84: [identity] Rewrite GetDeviceLists RPC to use batch functions.

Revision Contents
Changeset List

Path

Size

services/

identity/

src/

database/

device_list.rs

93 lines

Diff 42966

View Options

services/identity/src/database/device_list.rs

Show First 20 Lines • Show All 501 Lines • ▼ Show 20 Lines	export type ProcessDMOpsPayload = {
// were queued on Tunnelbroker.		// were queued on Tunnelbroker.
+composableMessageID: ?string,		+composableMessageID: ?string,
+notificationsCreationData: ?NotificationsCreationData,		+notificationsCreationData: ?NotificationsCreationData,
};		};

export const queueDMOpsActionType = 'QUEUE_DM_OPS';		export const queueDMOpsActionType = 'QUEUE_DM_OPS';
export type QueueDMOpsPayload = {		export type QueueDMOpsPayload = {
+operation: DMOperation,		+operation: DMOperation,
+threadID: string,
+timestamp: number,		+timestamp: number,
		+condition:
		\| {
		+type: 'thread',
		+threadID: string,
		}
		\| {
		+type: 'entry',
		+entryID: string,
		}
		\| {
		+type: 'message',
		+messageID: string,
		}
		\| {
		+type: 'membership',
		+threadID: string,
		+userID: string,
		},
};		};

export const pruneDMOpsQueueActionType = 'PRUNE_DM_OPS_QUEUE';		export const pruneDMOpsQueueActionType = 'PRUNE_DM_OPS_QUEUE';
export type PruneDMOpsQueuePayload = {		export type PruneDMOpsQueuePayload = {
+pruneMaxTimestamp: number,		+pruneMaxTimestamp: number,
};		};

export const clearQueuedThreadDMOpsActionType = 'CLEAR_QUEUED_THREAD_DM_OPS';		export const clearQueuedThreadDMOpsActionType = 'CLEAR_QUEUED_THREAD_DM_OPS';
export type ClearQueuedThreadDMOpsPayload = {		export type ClearQueuedThreadDMOpsPayload = {
+threadID: string,		+threadID: string,
};		};

		export const clearQueuedMessageDMOpsActionType = 'CLEAR_QUEUED_MESSAGE_DM_OPS';
		export type ClearQueuedMessageDMOpsPayload = {
		+messageID: string,
		};

		export const clearQueuedEntryDMOpsActionType = 'CLEAR_QUEUED_ENTRY_DM_OPS';
		export type ClearQueuedEntryDMOpsPayload = {
		+entryID: string,
		};

		export const clearQueuedMembershipDMOpsActionType =
		'CLEAR_QUEUED_MEMBERSHIP_DM_OPS';
		export type ClearQueuedMembershipDMOpsPayload = {
		+threadID: string,
		+userID: string,
		};

export type OperationsQueue = $ReadOnlyArray<{		export type OperationsQueue = $ReadOnlyArray<{
+operation: DMOperation,		+operation: DMOperation,
+timestamp: number,		+timestamp: number,
}>;		}>;

export type QueuedDMOperations = {		export type QueuedDMOperations = {
+threadQueue: {		+threadQueue: {
+[threadID: string]: OperationsQueue,		+[threadID: string]: OperationsQueue,
Show All 13 Lines

[identity] Add function to batch-get device listsClosedPublicActions