bartek (Bartłomiej Klocek)
Animal

Projects

User does not belong to any projects.

User Details

User Since: Sep 30 2022, 5:22 AM (121 w, 12 h)

IMG_6395.JPG (537×680 px, 67 KB)

If it works and/or looks nice, then:

Ship it

Recent Activity
View All

Wed, Jan 22

bartek accepted D14246: [native] wait with migration to new flow for Tunnelbroker connection.

Wed, Jan 22, 4:15 AM

Tue, Jan 21

bartek added inline comments to D14246: [native] wait with migration to new flow for Tunnelbroker connection.

Tue, Jan 21, 7:23 AM

bartek accepted D14244: [native] extract code in `BackupHandler` to callbacks.

Tue, Jan 21, 7:21 AM

bartek accepted D14245: [native] allow migrating to new flow on secondary device.

Tue, Jan 21, 7:20 AM

bartek accepted D14243: [native] move retrieving `AuthMetadata` to `useCurrentIdentityUserState`.

Tue, Jan 21, 6:48 AM

bartek accepted D14242: [native][lib] implement `useDeviceKind` hook.

Tue, Jan 21, 6:42 AM

bartek closed D14219: [identity] Allow migration for non-primary device.

Tue, Jan 21, 6:40 AM

bartek committed rCOMM64d7734d884e: [identity] Allow migration for non-primary device (authored by bartek).

[identity] Allow migration for non-primary device

Tue, Jan 21, 6:40 AM

bartek closed D14218: [web] Use legacy logout when web is primary.

Tue, Jan 21, 6:40 AM

bartek committed rCOMM915a3a3c3cf6: [web] Use legacy logout when web is primary (authored by bartek).

[web] Use legacy logout when web is primary

Tue, Jan 21, 6:40 AM

bartek closed D14208: [identity] Bump minimum supported client version.

Tue, Jan 21, 6:40 AM

bartek committed rCOMMf9be95c6b6c7: [identity] Bump minimum supported client version (authored by bartek).

[identity] Bump minimum supported client version

Tue, Jan 21, 6:40 AM

Fri, Jan 17

bartek accepted D14214: [native] improve conditions about performing migration.

The conditions look correct, I only added a suggestion on how to improve reliability. I analyzed the following cases:

Fri, Jan 17, 4:27 AM

bartek accepted D14217: [native] fix creating new device list in `reorderAndSignDeviceList`.

Fri, Jan 17, 4:16 AM

bartek accepted D14216: [native] handle errors when running migration to new flow.

Fri, Jan 17, 4:15 AM

bartek accepted D14213: [native] cleanup code related to getting device list and add code comments.

Fri, Jan 17, 3:44 AM

bartek accepted D14212: [native] extract migrating to new flow to a hook.

Fri, Jan 17, 3:41 AM

bartek accepted D14211: [native][lib] extract retrieving current user device list to a hook.

I recall there are other places where this hook might also be useful, but I couldn't quickly identify them.

Fri, Jan 17, 3:40 AM

bartek accepted D14210: [native] move code for testing backup restoration to `BackupMenu`.

Fri, Jan 17, 3:38 AM

bartek published D14219: [identity] Allow migration for non-primary device for review.

Fri, Jan 17, 3:36 AM

bartek published D14218: [web] Use legacy logout when web is primary for review.

Fri, Jan 17, 3:35 AM

Wed, Jan 15

bartek accepted D14209: [script] fix `skip_password_reset` usage.

Thank you

Wed, Jan 15, 6:26 AM

bartek published D14208: [identity] Bump minimum supported client version for review.

Wed, Jan 15, 4:13 AM

bartek closed D14206: [web] Move KeyserverConnectionHandler into ConnectedApp.

Wed, Jan 15, 3:18 AM

bartek committed rCOMM85fe02279ea6: [web] Move KeyserverConnectionHandler into ConnectedApp (authored by bartek).

[web] Move KeyserverConnectionHandler into ConnectedApp

Wed, Jan 15, 3:18 AM

Tue, Jan 14

bartek published D14206: [web] Move KeyserverConnectionHandler into ConnectedApp for review.

Tue, Jan 14, 11:57 PM

bartek closed D14202: [native] Wait for backup before processing QR code.

Tue, Jan 14, 5:52 AM

bartek committed rCOMM11ddcd94260c: [native] Wait for backup before processing QR code (authored by bartek).

[native] Wait for backup before processing QR code

Tue, Jan 14, 5:52 AM

bartek closed D14201: [native] Update BackupHandler logic to avoid pruning DDB.

Tue, Jan 14, 5:52 AM

bartek committed rCOMMc9327ed645b1: [native] Update BackupHandler logic to avoid pruning DDB (authored by bartek).

[native] Update BackupHandler logic to avoid pruning DDB

Tue, Jan 14, 5:52 AM

bartek added inline comments to D14201: [native] Update BackupHandler logic to avoid pruning DDB.

Tue, Jan 14, 5:40 AM

bartek published D14202: [native] Wait for backup before processing QR code for review.

Tue, Jan 14, 5:25 AM

bartek published D14201: [native] Update BackupHandler logic to avoid pruning DDB for review.

Tue, Jan 14, 5:24 AM

bartek closed D14200: [identity] Support skip_password_reset in PrivilegedResetUserPassword RPC.

Tue, Jan 14, 4:19 AM

bartek closed D14199: [keyserver] Pass skipPasswordReset value to the RPC call.

Tue, Jan 14, 4:19 AM

bartek committed rCOMM2860bee506e5: [keyserver] Pass skipPasswordReset value to the RPC call (authored by bartek).

[keyserver] Pass skipPasswordReset value to the RPC call

Tue, Jan 14, 4:19 AM

bartek committed rCOMM7fde3f6bddaf: [identity] Support skip_password_reset in PrivilegedResetUserPassword RPC (authored by bartek).

[identity] Support skip_password_reset in PrivilegedResetUserPassword RPC

Tue, Jan 14, 4:19 AM

bartek closed D14198: [protos] Add skipPasswordReset field to PrivilegedResetUserPassword.

Tue, Jan 14, 4:19 AM

bartek committed rCOMMbfa565f46076: [protos] Add skipPasswordReset field to PrivilegedResetUserPassword (authored by bartek).

[protos] Add skipPasswordReset field to PrivilegedResetUserPassword

Tue, Jan 14, 4:19 AM

Mon, Jan 13

bartek published D14200: [identity] Support skip_password_reset in PrivilegedResetUserPassword RPC for review.

Mon, Jan 13, 7:19 AM

bartek published D14199: [keyserver] Pass skipPasswordReset value to the RPC call for review.

Mon, Jan 13, 7:19 AM

bartek published D14198: [protos] Add skipPasswordReset field to PrivilegedResetUserPassword for review.

Mon, Jan 13, 7:19 AM

bartek closed D14190: [native][backup_client] Handle BackupNotFound in retrieve_latest_backup_info.

Mon, Jan 13, 6:56 AM

bartek committed rCOMM5e98f07c70b3: [native][backup_client] Handle BackupNotFound in retrieve_latest_backup_info (authored by bartek).

[native][backup_client] Handle BackupNotFound in retrieve_latest_backup_info

Mon, Jan 13, 6:56 AM

bartek closed D14189: [native] Make retrieveLatestBackupInfo return type nullable.

Mon, Jan 13, 6:56 AM

bartek committed rCOMM7fa801fc07cb: [native] Make retrieveLatestBackupInfo return type nullable (authored by bartek).

[native] Make retrieveLatestBackupInfo return type nullable

Mon, Jan 13, 6:56 AM

bartek added inline comments to D14190: [native][backup_client] Handle BackupNotFound in retrieve_latest_backup_info.

Mon, Jan 13, 6:55 AM

bartek published D14189: [native] Make retrieveLatestBackupInfo return type nullable for review.

Mon, Jan 13, 12:11 AM

bartek published D14190: [native][backup_client] Handle BackupNotFound in retrieve_latest_backup_info for review.

Mon, Jan 13, 12:11 AM

Thu, Jan 9

bartek closed D14179: [lib] Refactor useLogOut to auto-detect logout flow.

Thu, Jan 9, 7:41 AM

bartek committed rCOMM3da407dd3a60: [lib] Refactor useLogOut to auto-detect logout flow (authored by bartek).

[lib] Refactor useLogOut to auto-detect logout flow

Thu, Jan 9, 7:41 AM

bartek updated the diff for D14179: [lib] Refactor useLogOut to auto-detect logout flow.

rename logOutOptions to legacyLogOutOptions

Thu, Jan 9, 2:04 AM

Tue, Jan 7

bartek accepted D14180: [native] Fall back to v1 login when the user doesn't have a backup.

Because pf https://linear.app/comm/issue/ENG-10039/allow-checking-if-a-user-has-a-backup I had to hack it a bit: instead of calling retrieveLatestBackupInfo I hardcoded its return value to null. Then for both password and SIWE user verified that it is possible to log in.

Tue, Jan 7, 7:20 AM

bartek closed D14178: [terraform] Bump staging Identity to 0.48.

Tue, Jan 7, 7:17 AM

bartek committed rCOMMc9dcc62c9557: [terraform] Bump staging Identity to 0.48 (authored by bartek).

[terraform] Bump staging Identity to 0.48

Tue, Jan 7, 7:17 AM

bartek closed D14177: [terraform] Bump prod Identity to 0.47.

Tue, Jan 7, 7:17 AM

bartek committed rCOMM5b11e1ba47d9: [terraform] Bump prod Identity to 0.47 (authored by bartek).

[terraform] Bump prod Identity to 0.47

Tue, Jan 7, 7:17 AM

Mon, Jan 6

bartek added inline comments to D14179: [lib] Refactor useLogOut to auto-detect logout flow.

Mon, Jan 6, 11:57 PM

bartek added inline comments to D14179: [lib] Refactor useLogOut to auto-detect logout flow.

Mon, Jan 6, 11:54 PM

Dec 20 2024

bartek published D14179: [lib] Refactor useLogOut to auto-detect logout flow for review.

Dec 20 2024, 4:59 AM

bartek published D14178: [terraform] Bump staging Identity to 0.48 for review.

Dec 20 2024, 12:12 AM

bartek published D14177: [terraform] Bump prod Identity to 0.47 for review.

Dec 20 2024, 12:12 AM

Dec 19 2024

bartek closed D14174: [identity] Optimize Tunnelbroker device data removal.

Dec 19 2024, 11:55 PM

bartek committed rCOMMc44920a6ca59: [identity] Optimize Tunnelbroker device data removal (authored by bartek).

[identity] Optimize Tunnelbroker device data removal

Dec 19 2024, 11:55 PM

bartek closed D14173: [identity] Force v1 primary logout for authoritative keyserver owner.

Dec 19 2024, 11:55 PM

bartek committed rCOMM6fd253e5bc1d: [identity] Force v1 primary logout for authoritative keyserver owner (authored by bartek).

[identity] Force v1 primary logout for authoritative keyserver owner

Dec 19 2024, 11:55 PM

bartek closed D14172: [identity] Allow v1 login for authoritative keyserver.

Dec 19 2024, 11:55 PM

bartek committed rCOMM58bf345631bc: [identity] Allow v1 login for authoritative keyserver (authored by bartek).

[identity] Allow v1 login for authoritative keyserver

Dec 19 2024, 11:55 PM

bartek added inline comments to D14173: [identity] Force v1 primary logout for authoritative keyserver owner.

Dec 19 2024, 11:49 PM

bartek accepted D14171: [native] move `<Auth*` components to a `/auth-components` directory.

Dec 19 2024, 5:20 AM

bartek accepted D14170: [native] rename `<Registration*` components to `<Auth*` components.

Dec 19 2024, 5:19 AM

bartek accepted D14169: [native] rename `QRAuthContext` to `PrimaryDeviceQRAuthContext`.

Dec 19 2024, 5:18 AM

bartek published D14174: [identity] Optimize Tunnelbroker device data removal for review.

Dec 19 2024, 5:18 AM

bartek published D14173: [identity] Force v1 primary logout for authoritative keyserver owner for review.

Dec 19 2024, 5:18 AM

bartek accepted D14166: [lib] rename `QRAuthContext` to `SecondaryDeviceQRAuthContext`.

Dec 19 2024, 5:17 AM

bartek published D14172: [identity] Allow v1 login for authoritative keyserver for review.

Dec 19 2024, 2:05 AM

bartek closed D14088: [identity] Verify new flow migration device list update.

Dec 19 2024, 1:55 AM

bartek committed rCOMMefd40b9457f6: [identity] Verify new flow migration device list update (authored by bartek).

[identity] Verify new flow migration device list update

Dec 19 2024, 1:55 AM

bartek closed D14148: [native] Handler for migrating to signed device lists.

Dec 19 2024, 1:55 AM

bartek committed rCOMM94ed0be6468c: [native] Handler for migrating to signed device lists (authored by bartek).

[native] Handler for migrating to signed device lists

Dec 19 2024, 1:55 AM

bartek updated the diff for D14148: [native] Handler for migrating to signed device lists.

Address comments

Dec 19 2024, 12:59 AM

bartek added inline comments to D14148: [native] Handler for migrating to signed device lists.

Dec 19 2024, 12:58 AM

bartek added inline comments to D14148: [native] Handler for migrating to signed device lists.

Dec 19 2024, 12:43 AM

Dec 17 2024

bartek added inline comments to D14148: [native] Handler for migrating to signed device lists.

Dec 17 2024, 2:49 AM

bartek updated the diff for D14148: [native] Handler for migrating to signed device lists.

Address feedback

Dec 17 2024, 2:45 AM

bartek added inline comments to D14148: [native] Handler for migrating to signed device lists.

Dec 17 2024, 2:06 AM

Dec 16 2024

bartek closed D14147: [native][web] Merge logout buttons for old and new flows.

Dec 16 2024, 6:48 AM

bartek committed rCOMM0f7e12dce745: [native][web] Merge logout buttons for old and new flows (authored by bartek).

[native][web] Merge logout buttons for old and new flows

Dec 16 2024, 6:48 AM

bartek closed D14146: [native] Enable linked devices screen when using restore flow.

Dec 16 2024, 6:48 AM

bartek committed rCOMMd0002b3eff79: [native] Enable linked devices screen when using restore flow (authored by bartek).

[native] Enable linked devices screen when using restore flow

Dec 16 2024, 6:48 AM

bartek added inline comments to D14147: [native][web] Merge logout buttons for old and new flows.

Dec 16 2024, 6:45 AM

bartek published D14148: [native] Handler for migrating to signed device lists for review.

Dec 16 2024, 6:18 AM

bartek updated the test plan for D14088: [identity] Verify new flow migration device list update.

Dec 16 2024, 6:04 AM

bartek published D14088: [identity] Verify new flow migration device list update for review.

Dec 16 2024, 4:24 AM

Dec 12 2024

bartek published D14146: [native] Enable linked devices screen when using restore flow for review.

Dec 12 2024, 11:28 PM

bartek published D14147: [native][web] Merge logout buttons for old and new flows for review.

Dec 12 2024, 11:28 PM

bartek accepted D14097: [CommCoreModule] avoid triggering backup upload on SQLite changes.

Dec 12 2024, 12:34 AM

Dec 11 2024

bartek accepted D14096: [native] make sure `start_backup_handler` is called only once in `BackupHandler`.

Dec 11 2024, 10:43 PM

bartek accepted D14095: [native_rust_library] make `start_backup_handler` thread-safe.

Dec 11 2024, 10:40 PM

Dec 9 2024

bartek added a comment to D14079: [identity] fix `lastPrimarySignature` attribute.

In D14079#392809, @kamil wrote:

In D14079#392786, @ashoat wrote:

How serious is this issue? Wondering what the product impact was, if any

I think there wasn't any product impact, the first time we used this was during restore protocol, and I added it later in this stack (D14083), I don't think any existing logic depends on this, but perhaps @bartek has a better view on this.

Dec 9 2024, 1:42 AM