Page MenuHomePhabricator

bartek (Bartłomiej Klocek)
Animal

Projects

User does not belong to any projects.

User Details

User Since
Sep 30 2022, 5:22 AM (90 w, 2 d)

IMG_6395.JPG (537×680 px, 67 KB)
If it works and/or looks nice, then:
Ship it
- see why

Recent Activity

Today

bartek accepted D12551: [identity] Downgrades search trace error.
Mon, Jun 24, 12:45 AM
bartek accepted D12550: [terraform] Change alarm names to reflect staging or production environment.
Mon, Jun 24, 12:44 AM

Sat, Jun 22

bartek accepted D12537: [lib] introduce setting Tunnelbroker device token action.
Sat, Jun 22, 7:09 AM

Fri, Jun 21

bartek accepted D12529: [terraform] Allow all ip addresses to access self-host internet gateway.
Fri, Jun 21, 11:21 PM
bartek accepted D12528: [terraform] run mariadb in public db group.
Fri, Jun 21, 11:20 PM
bartek added inline comments to D12524: [lib] implement sending message to Tunnelbroker.
Fri, Jun 21, 11:19 PM
bartek accepted D12523: [Tunnelbroker] handle `SetDeviceToken` message.
Fri, Jun 21, 11:11 PM
bartek accepted D12526: [Identity] remove Tunnelbroker data on device removal.
Fri, Jun 21, 11:04 PM
bartek added a comment to D12525: [proto][Tunnelbroker] add RPC to delete device data from Tunnelbroker.

What about undelivered_messages? Are they considered a "device data" too?

Fri, Jun 21, 11:02 PM
bartek accepted D12519: [Tunnelbroker] implement getting device token.
Fri, Jun 21, 10:55 PM
bartek accepted D12518: [Tunnelbroker] implement removing device token.
Fri, Jun 21, 10:55 PM
bartek accepted D12547: remove reserved wallet registration RPC.

Why did we introduce it initially? 🤨

Fri, Jun 21, 10:54 PM
bartek accepted D12544: [identity] fix reserved username workflow for wallet users.

Looks good. Left some nits

Fri, Jun 21, 10:51 PM
bartek accepted D12515: [identity] fix wallet account deletion bug.
Fri, Jun 21, 10:41 PM
bartek added inline comments to D12520: [Tunnelbroker] implement setting device token.
Fri, Jun 21, 10:36 PM
bartek added inline comments to D12520: [Tunnelbroker] implement setting device token.
Fri, Jun 21, 10:32 PM
bartek accepted D12517: [Tunnelbroker] define device tokens table in rust.

Simple change to imports and adding undelivered_messages:: made it look much better

Fri, Jun 21, 10:15 PM
bartek accepted D12516: [terraform] create DDB table for device tokens.
Fri, Jun 21, 10:13 PM

Thu, Jun 20

bartek published D12511: [backup][backup-client] Add auth to logs websocket for review.
Thu, Jun 20, 7:19 AM
bartek closed D12505: [terraform] Add IAM policies for services-to-services token.
Thu, Jun 20, 4:52 AM
bartek committed rCOMMd6daa18521bf: [terraform] Add IAM policies for services-to-services token (authored by bartek).
[terraform] Add IAM policies for services-to-services token
Thu, Jun 20, 4:52 AM
bartek closed D12504: [backup] Hotfix Blob service client auth.
Thu, Jun 20, 4:52 AM
bartek committed rCOMM44ecf8804a94: [backup] Hotfix Blob service client auth (authored by bartek).
[backup] Hotfix Blob service client auth
Thu, Jun 20, 4:52 AM
bartek published D12508: [backup] Use authenticated service trait for review.
Thu, Jun 20, 4:51 AM
bartek published D12507: [comm-lib][reports] Extract 'authenticated' service trait for review.
Thu, Jun 20, 2:51 AM
bartek published D12506: [comm-lib] Implement FromRequest for AuthService for review.
Thu, Jun 20, 2:43 AM
bartek published D12504: [backup] Hotfix Blob service client auth for review.
Thu, Jun 20, 1:39 AM
bartek accepted D12478: [lib][web][native] improve naming in `QRAuthProvider`.
Thu, Jun 20, 1:38 AM
bartek published D12505: [terraform] Add IAM policies for services-to-services token for review.
Thu, Jun 20, 1:30 AM

Wed, Jun 19

bartek accepted D12465: [identity] update change password RPCs to match whitepaper.

You're doing OPAQUE login for old password and OPAQUE registration for new password in the same RPC. Smart!

Wed, Jun 19, 6:15 AM
bartek closed D12447: [identity][websocket] Call DB client directly to verify CSAT.
Wed, Jun 19, 2:23 AM
bartek committed rCOMMe62070d59fdf: [identity][websocket] Call DB client directly to verify CSAT (authored by bartek).
[identity][websocket] Call DB client directly to verify CSAT
Wed, Jun 19, 2:23 AM
bartek closed D12462: [terraform] Refactor search lambda IAM role policy attachments.
Wed, Jun 19, 2:20 AM
bartek closed D12461: [terraform] Remove unused outputs.
Wed, Jun 19, 2:20 AM
bartek committed rCOMMb39d988022b7: [terraform] Refactor search lambda IAM role policy attachments (authored by bartek).
[terraform] Refactor search lambda IAM role policy attachments
Wed, Jun 19, 2:20 AM
bartek committed rCOMMfa97b4e5efb5: [terraform] Remove unused outputs (authored by bartek).
[terraform] Remove unused outputs
Wed, Jun 19, 2:20 AM
bartek closed D12460: [terraform] Add DNS records for load balancers.
Wed, Jun 19, 2:20 AM
bartek committed rCOMM0c357965fdf0: [terraform] Add DNS records for load balancers (authored by bartek).
[terraform] Add DNS records for load balancers
Wed, Jun 19, 2:20 AM

Tue, Jun 18

bartek updated the summary of D12462: [terraform] Refactor search lambda IAM role policy attachments.
Tue, Jun 18, 5:06 AM
bartek published D12462: [terraform] Refactor search lambda IAM role policy attachments for review.
Tue, Jun 18, 5:05 AM
bartek closed D12417: [terraform] Disable CSAT verification on prod.
Tue, Jun 18, 4:59 AM
bartek committed rCOMM7c14a71b9904: [terraform] Disable CSAT verification on prod (authored by bartek).
[terraform] Disable CSAT verification on prod
Tue, Jun 18, 4:59 AM
bartek added inline comments to D12446: [native] Send CSAT when fetching blob service media.
Tue, Jun 18, 4:28 AM
bartek published D12461: [terraform] Remove unused outputs for review.
Tue, Jun 18, 3:43 AM
bartek published D12460: [terraform] Add DNS records for load balancers for review.
Tue, Jun 18, 3:03 AM
bartek closed D12451: [reports] Move HTTP-specific service code.
Tue, Jun 18, 2:19 AM
bartek closed D12416: [reports] Require auth for viewing reports.
Tue, Jun 18, 2:19 AM
bartek closed D12448: [reports] Verify CSAT if present.
Tue, Jun 18, 2:19 AM
bartek committed rCOMM7e28ae476048: [reports] Move HTTP-specific service code (authored by bartek).
[reports] Move HTTP-specific service code
Tue, Jun 18, 2:19 AM
bartek committed rCOMM38138df4b9c6: [reports] Verify CSAT if present (authored by bartek).
[reports] Verify CSAT if present
Tue, Jun 18, 2:19 AM
bartek committed rCOMMc459cea60ff1: [reports] Require auth for viewing reports (authored by bartek).
[reports] Require auth for viewing reports
Tue, Jun 18, 2:19 AM
bartek closed D12415: [blob] Hide endpoints behind auth middleware.
Tue, Jun 18, 2:19 AM
bartek committed rCOMM496f450b731f: [blob] Hide endpoints behind auth middleware (authored by bartek).
[blob] Hide endpoints behind auth middleware
Tue, Jun 18, 2:19 AM
bartek closed D12414: [comm-lib] Verify CSAT in HTTP middleware.
Tue, Jun 18, 2:19 AM
bartek committed rCOMM17e30f45d3b8: [comm-lib] Verify CSAT in HTTP middleware (authored by bartek).
[comm-lib] Verify CSAT in HTTP middleware
Tue, Jun 18, 2:19 AM
bartek closed D12413: [backup] Add AuthService to HTTP server.
Tue, Jun 18, 2:19 AM
bartek committed rCOMM2888481aa9b7: [backup] Add AuthService to HTTP server (authored by bartek).
[backup] Add AuthService to HTTP server
Tue, Jun 18, 2:19 AM
bartek closed D12412: [comm-lib] Add env var to disable CSAT verification.
Tue, Jun 18, 2:19 AM
bartek closed D12411: [comm-lib] Use futures_util::Ready to simplify code.
Tue, Jun 18, 2:19 AM
bartek committed rCOMMb19587c8124d: [comm-lib] Add env var to disable CSAT verification (authored by bartek).
[comm-lib] Add env var to disable CSAT verification
Tue, Jun 18, 2:19 AM
bartek committed rCOMM6ee7d17d7527: [comm-lib] Use futures_util::Ready to simplify code (authored by bartek).
[comm-lib] Use futures_util::Ready to simplify code
Tue, Jun 18, 2:18 AM
bartek closed D12437: [lib][web][native] Send CSAT in getKeyserverOverrideForAnInviteLink.
Tue, Jun 18, 2:18 AM
bartek closed D12446: [native] Send CSAT when fetching blob service media.
Tue, Jun 18, 2:18 AM
bartek committed rCOMMae31755aee5d: [native] Send CSAT when fetching blob service media (authored by bartek).
[native] Send CSAT when fetching blob service media
Tue, Jun 18, 2:18 AM
bartek committed rCOMM52de63b4fcc5: [lib][web][native] Send CSAT in getKeyserverOverrideForAnInviteLink (authored by bartek).
[lib][web][native] Send CSAT in getKeyserverOverrideForAnInviteLink
Tue, Jun 18, 2:18 AM
bartek closed D12350: [identity] Forbid registering multiple devices with the same ID.
Tue, Jun 18, 2:18 AM
bartek committed rCOMM19818e9af187: [identity] Forbid registering multiple devices with the same ID (authored by bartek).
[identity] Forbid registering multiple devices with the same ID
Tue, Jun 18, 2:18 AM
bartek published D12417: [terraform] Disable CSAT verification on prod for review.
Tue, Jun 18, 12:41 AM
bartek published D12446: [native] Send CSAT when fetching blob service media for review.
Tue, Jun 18, 12:34 AM
bartek accepted D12458: [terraform] initial Redis terraform config.
Tue, Jun 18, 12:08 AM

Mon, Jun 17

bartek added inline comments to D12415: [blob] Hide endpoints behind auth middleware.
Mon, Jun 17, 11:58 PM
bartek updated the diff for D12350: [identity] Forbid registering multiple devices with the same ID.

Add constant for Tonic status code

Mon, Jun 17, 11:56 PM
bartek accepted D12457: [terraform] Upgrade AWS Terraform provider to 5.32.0.
Mon, Jun 17, 11:47 PM
bartek accepted D12065: [native] introduce AutoJoinCommunityHandler.
Mon, Jun 17, 11:46 PM
bartek accepted D12453: [native] remove `useQRAuth` hook.
Mon, Jun 17, 11:44 PM
bartek accepted D12449: [lib] implement `QRAuthContext`.
Mon, Jun 17, 11:44 PM
bartek added inline comments to D12350: [identity] Forbid registering multiple devices with the same ID.
Mon, Jun 17, 7:48 AM
bartek closed D12327: [lib][native] Send backup keys in QR auth only if requested.
Mon, Jun 17, 7:32 AM
bartek committed rCOMMe9e330a65dd1: [lib][native] Send backup keys in QR auth only if requested (authored by bartek).
[lib][native] Send backup keys in QR auth only if requested
Mon, Jun 17, 7:32 AM
bartek updated the diff for D12327: [lib][native] Send backup keys in QR auth only if requested.

Add missing return statement

Mon, Jun 17, 6:39 AM
bartek reopened D12327: [lib][native] Send backup keys in QR auth only if requested.
Mon, Jun 17, 6:38 AM
bartek added a reverting change for D12327: [lib][native] Send backup keys in QR auth only if requested: rCOMM7327c4e2e31a: Revert "[lib][native] Send backup keys in QR auth only if requested".
Mon, Jun 17, 6:34 AM
bartek committed rCOMM7327c4e2e31a: Revert "[lib][native] Send backup keys in QR auth only if requested" (authored by bartek).
Revert "[lib][native] Send backup keys in QR auth only if requested"
Mon, Jun 17, 6:34 AM
bartek added a reverting change for rCOMMc25b3d672f2a: [lib][native] Send backup keys in QR auth only if requested: rCOMM7327c4e2e31a: Revert "[lib][native] Send backup keys in QR auth only if requested".
Mon, Jun 17, 6:34 AM
bartek accepted D12455: [lib] broadcast device list updates after Tunnelbroker socket connection is established.
Mon, Jun 17, 4:53 AM
bartek accepted D12452: [native] update QR login flow to use `QRAuthContext`.
Mon, Jun 17, 4:50 AM
bartek accepted D12450: [web] update QR login flow to use `QRAuthContext`.
Mon, Jun 17, 4:46 AM
bartek accepted D12445: [web][native] extract QR code login functions to separate files.
Mon, Jun 17, 4:41 AM
bartek published D12447: [identity][websocket] Call DB client directly to verify CSAT for review.
Mon, Jun 17, 4:22 AM
bartek published D12448: [reports] Verify CSAT if present for review.
Mon, Jun 17, 4:20 AM
bartek published D12451: [reports] Move HTTP-specific service code for review.
Mon, Jun 17, 4:20 AM
bartek closed D12305: [identity][terraform] Add error type for HTTP logs.
Mon, Jun 17, 2:54 AM
bartek committed rCOMM70507f858b2e: [identity][terraform] Add error type for HTTP logs (authored by bartek).
[identity][terraform] Add error type for HTTP logs
Mon, Jun 17, 2:54 AM
bartek closed D12304: [identity] Add /inbound_keys HTTP handler.
Mon, Jun 17, 2:54 AM
bartek committed rCOMMbe362d661778: [identity] Add /inbound_keys HTTP handler (authored by bartek).
[identity] Add /inbound_keys HTTP handler
Mon, Jun 17, 2:54 AM
bartek closed D12349: [identity] Add function to query device by ID.
Mon, Jun 17, 2:54 AM
bartek committed rCOMMe70a7793d320: [identity] Add function to query device by ID (authored by bartek).
[identity] Add function to query device by ID
Mon, Jun 17, 2:54 AM
bartek closed D12348: [identity][terraform] Create DDB index for deviceID.
Mon, Jun 17, 2:54 AM
bartek committed rCOMM3b7dbcdd52f2: [identity][terraform] Create DDB index for deviceID (authored by bartek).
[identity][terraform] Create DDB index for deviceID
Mon, Jun 17, 2:54 AM
bartek closed D12303: [identity] Add HTTP function to verify CSAT.
Mon, Jun 17, 2:54 AM