Page MenuHomePhabricator

bartek (Bartłomiej Klocek)
Animal

Projects

User does not belong to any projects.

User Details

User Since
Sep 30 2022, 5:22 AM (51 w, 1 d)

IMG_6395.JPG (537×680 px, 67 KB)
If it works and/or looks nice, then:
Ship it
- see why

Recent Activity

Wed, Sep 20

bartek accepted D9224: [native] commCoreModule methods for getting, setting, and clearing the commServicesAccessToken.

@kamil for changes related to data clearance. I didn't add him as a blocking reviewer since he might be absent for a longer time. But if he is back quickly I would appreciate his review on the data clearance.

Wed, Sep 20, 3:23 AM
bartek accepted D9157: [lib] Add blobServiceUpload upload action.
Wed, Sep 20, 3:15 AM
bartek published D9243: [services-lib] Support auth token in HTTP middleware for review.
Wed, Sep 20, 3:02 AM
bartek published D9242: [services-lib] Use constant-time-eq for token verification for review.
Wed, Sep 20, 3:02 AM
bartek published D9241: [services-lib] Add enum for authorization tokens for review.
Wed, Sep 20, 3:01 AM

Tue, Sep 19

bartek added inline comments to D9224: [native] commCoreModule methods for getting, setting, and clearing the commServicesAccessToken.
Tue, Sep 19, 9:09 AM

Mon, Sep 18

bartek requested changes to D9157: [lib] Add blobServiceUpload upload action.

Requesting changes to fix failing CI - most likely wrong uuid version is being resolved, try the yarn why uuid command to confirm.

Mon, Sep 18, 5:11 AM
bartek accepted D9163: [native] Use blobServiceUpload upload action.
Mon, Sep 18, 4:55 AM

Fri, Sep 15

bartek closed D9216: [terraform] Deploy Tunnelbroker DynamoDB table.
Fri, Sep 15, 3:45 AM
bartek committed rCOMM7e0a7cce56ff: [terraform] Deploy Tunnelbroker DynamoDB table (authored by bartek).
[terraform] Deploy Tunnelbroker DynamoDB table
Fri, Sep 15, 3:45 AM
bartek published D9216: [terraform] Deploy Tunnelbroker DynamoDB table for review.
Fri, Sep 15, 2:37 AM

Thu, Sep 14

bartek closed D9165: [terraform] Add Tunnelbroker.
Thu, Sep 14, 6:30 AM
bartek committed rCOMM32c6aa104750: [terraform] Add Tunnelbroker (authored by bartek).
[terraform] Add Tunnelbroker
Thu, Sep 14, 6:30 AM
bartek accepted D9197: [CommCoreModule] capture primitive parameter by value.
Thu, Sep 14, 3:41 AM
bartek accepted D9200: [Tunnelbroker] add authentication tests.
Thu, Sep 14, 3:39 AM
bartek added inline comments to D8918: [Tunnelbroker] Authenticate connecting devices.
Thu, Sep 14, 3:24 AM
bartek closed D9162: [secrets] Generate RabbitMQ passwords.
Thu, Sep 14, 12:46 AM
bartek committed rCOMM03ab8acb6366: [secrets] Generate RabbitMQ passwords (authored by bartek).
[secrets] Generate RabbitMQ passwords
Thu, Sep 14, 12:46 AM
bartek closed D9160: [tunnelbroker] Use Hyper service instead of tokio_tungstenite.
Thu, Sep 14, 12:46 AM
bartek closed D9158: [tunnelbroker] Hyper service for WebSocket connections.
Thu, Sep 14, 12:46 AM
bartek committed rCOMM2ec7b28c4b41: [tunnelbroker] Use Hyper service instead of tokio_tungstenite (authored by bartek).
[tunnelbroker] Use Hyper service instead of tokio_tungstenite
Thu, Sep 14, 12:46 AM
bartek committed rCOMM62172ad0caf8: [tunnelbroker] Hyper service for WebSocket connections (authored by bartek).
[tunnelbroker] Hyper service for WebSocket connections
Thu, Sep 14, 12:46 AM
bartek closed D9156: [tunnelbroker] Make WebSocketSession generic.
Thu, Sep 14, 12:46 AM
bartek closed D9155: [tunnelbroker] Don't listen on localhost only.
Thu, Sep 14, 12:46 AM
bartek committed rCOMM09141efe3bc4: [tunnelbroker] Don't listen on localhost only (authored by bartek).
[tunnelbroker] Don't listen on localhost only
Thu, Sep 14, 12:46 AM
bartek committed rCOMMc6850660a189: [tunnelbroker] Make WebSocketSession generic (authored by bartek).
[tunnelbroker] Make WebSocketSession generic
Thu, Sep 14, 12:46 AM
bartek closed D9153: [tunnelbroker] Allow configuring AMQP credentials.
Thu, Sep 14, 12:46 AM
bartek committed rCOMMdd596a2b60c5: [tunnelbroker] Allow configuring AMQP credentials (authored by bartek).
[tunnelbroker] Allow configuring AMQP credentials
Thu, Sep 14, 12:46 AM
bartek updated the diff for D9165: [terraform] Add Tunnelbroker.

Apply review feedback

Thu, Sep 14, 12:42 AM
bartek closed D9177: [terraform] Remove references to legacy services.
Thu, Sep 14, 12:28 AM
bartek committed rCOMMb7e59f331fb0: [terraform] Remove references to legacy services (authored by bartek).
[terraform] Remove references to legacy services
Thu, Sep 14, 12:28 AM
bartek closed D9176: [docker-compose] Match version tags with terraform.
Thu, Sep 14, 12:28 AM
bartek committed rCOMM5a81d89311d1: [docker-compose] Match version tags with terraform (authored by bartek).
[docker-compose] Match version tags with terraform
Thu, Sep 14, 12:28 AM
bartek accepted D9182: [Tunnelbroker] update integration tests to handle auth device.
Thu, Sep 14, 12:27 AM

Wed, Sep 13

bartek added a comment to D9165: [terraform] Add Tunnelbroker.

Would it make sense to add apply_immediately (at least for staging)? If I understand the documentation correctly, currently if we make changes to the user (or add broker configuration) we would have to reboot rabbitmq manually?

Wed, Sep 13, 7:23 AM
bartek added inline comments to D9160: [tunnelbroker] Use Hyper service instead of tokio_tungstenite.
Wed, Sep 13, 7:19 AM
bartek added a comment to D9158: [tunnelbroker] Hyper service for WebSocket connections.

This health check is only needed by AWS to check if the instance endpoint is healthy. It's more related to ENG-4470.

Wed, Sep 13, 5:04 AM
bartek closed D9139: [feature-flags] Use default HTTP port for deployments.
Wed, Sep 13, 4:26 AM
bartek committed rCOMM993b9cbd3d02: [feature-flags] Use default HTTP port for deployments (authored by bartek).
[feature-flags] Use default HTTP port for deployments
Wed, Sep 13, 4:26 AM
bartek closed D9137: [services] Delete base-image and sandbox mode.
Wed, Sep 13, 4:26 AM
bartek committed rCOMM5a92dcf09991: [services] Delete base-image and sandbox mode (authored by bartek).
[services] Delete base-image and sandbox mode
Wed, Sep 13, 4:26 AM
bartek added a comment to D9156: [tunnelbroker] Make WebSocketSession generic.

Is generic-ness of this is going to be helpful in the future? Or is it going to be always HyperWebsocket under the hood? Because in that case we should just remove the generics and use HyperWebsocket directly

Wed, Sep 13, 4:05 AM
bartek added inline comments to D9155: [tunnelbroker] Don't listen on localhost only.
Wed, Sep 13, 4:00 AM
bartek updated the diff for D9139: [feature-flags] Use default HTTP port for deployments.

Update port in docker-compose

Wed, Sep 13, 3:52 AM
bartek added inline comments to D9153: [tunnelbroker] Allow configuring AMQP credentials.
Wed, Sep 13, 3:51 AM
bartek added a comment to D9139: [feature-flags] Use default HTTP port for deployments.

Should we also update the docker-compose.yml to use the new port?

Wed, Sep 13, 12:46 AM
bartek added a comment to D9144: Enable encrypted notification coalescing in NSE on iOS.

Nice! The UI change looks good to me, but letting others review as well.

Wed, Sep 13, 12:14 AM
bartek requested review of D9177: [terraform] Remove references to legacy services.
Wed, Sep 13, 12:09 AM

Tue, Sep 12

bartek requested review of D9176: [docker-compose] Match version tags with terraform.
Tue, Sep 12, 11:52 PM
bartek updated the diff for D9139: [feature-flags] Use default HTTP port for deployments.

Use separate tag for staging, bump prod version

Tue, Sep 12, 11:09 PM
bartek updated the test plan for D9139: [feature-flags] Use default HTTP port for deployments.
Tue, Sep 12, 11:09 PM
bartek published D9137: [services] Delete base-image and sandbox mode for review.
Tue, Sep 12, 11:01 PM
bartek closed D9138: [feature-flags] Standardize localstack and http config.
Tue, Sep 12, 11:00 PM
bartek committed rCOMMaf6356fc54c3: [feature-flags] Standardize localstack and http config (authored by bartek).
[feature-flags] Standardize localstack and http config
Tue, Sep 12, 10:59 PM
bartek added a comment to D9158: [tunnelbroker] Hyper service for WebSocket connections.

Awesome that we get the health check for free! I assume we'll need to implement something on the client for that to work, yes? The Tunnelbroker client in keyserver currently uses the ws library for Node.js

Tue, Sep 12, 9:15 PM
bartek added a comment to D9142: [Tunnelbroker] Fix integration tests.
In D9142#269446, @atul wrote:

What's the command to run tests? Can they be run without any additional configuration?

Tue, Sep 12, 2:53 PM
bartek published D9165: [terraform] Add Tunnelbroker for review.
Tue, Sep 12, 2:37 PM
bartek published D9162: [secrets] Generate RabbitMQ passwords for review.
Tue, Sep 12, 2:29 PM
bartek published D9160: [tunnelbroker] Use Hyper service instead of tokio_tungstenite for review.
Tue, Sep 12, 2:13 PM
bartek published D9158: [tunnelbroker] Hyper service for WebSocket connections for review.
Tue, Sep 12, 2:12 PM
bartek published D9156: [tunnelbroker] Make WebSocketSession generic for review.
Tue, Sep 12, 2:05 PM
bartek published D9155: [tunnelbroker] Don't listen on localhost only for review.
Tue, Sep 12, 2:03 PM
bartek published D9153: [tunnelbroker] Allow configuring AMQP credentials for review.
Tue, Sep 12, 2:02 PM
bartek planned changes to D9139: [feature-flags] Use default HTTP port for deployments.
Tue, Sep 12, 9:22 AM
bartek accepted D9142: [Tunnelbroker] Fix integration tests.
Tue, Sep 12, 4:19 AM
bartek published D9139: [feature-flags] Use default HTTP port for deployments for review.
Tue, Sep 12, 12:24 AM
bartek published D9138: [feature-flags] Standardize localstack and http config for review.
Tue, Sep 12, 12:22 AM
bartek accepted D9093: [lib/web/native] Generate and encode an ephemeral AES-256 key in the QR code.
Tue, Sep 12, 12:18 AM
bartek accepted D9127: [native] rename fields in JSON serialized string to camelCase from snake_case.
Tue, Sep 12, 12:16 AM
bartek accepted D8820: [Keyserver/rust] Used shared identity client.
Tue, Sep 12, 12:14 AM

Mon, Sep 11

bartek accepted D9128: [Tunnelbroker] match JS naming convention.
Mon, Sep 11, 11:43 PM
bartek closed D9117: [feature-flags] Update Dockerfile.
Mon, Sep 11, 11:34 PM
bartek committed rCOMM7ce666defa48: [feature-flags] Update Dockerfile (authored by bartek).
[feature-flags] Update Dockerfile
Mon, Sep 11, 11:34 PM
bartek closed D9116: [blob-service] Update Dockerfile.
Mon, Sep 11, 11:34 PM
bartek committed rCOMMeb8518e1d3ed: [blob-service] Update Dockerfile (authored by bartek).
[blob-service] Update Dockerfile
Mon, Sep 11, 11:34 PM

Sat, Sep 9

bartek added inline comments to D8665: Implement native iOS code to fetch data from blob service.
Sat, Sep 9, 1:16 PM
bartek requested review of D9117: [feature-flags] Update Dockerfile.
Sat, Sep 9, 1:09 PM
bartek requested review of D9116: [blob-service] Update Dockerfile.
Sat, Sep 9, 1:08 PM
bartek planned changes to D9058: [Identity] Use clap for argument parsing.
Sat, Sep 9, 12:58 PM
bartek commandeered D9058: [Identity] Use clap for argument parsing.

Taking this one, I'll play with this a bit

Sat, Sep 9, 12:57 PM
bartek accepted D8918: [Tunnelbroker] Authenticate connecting devices.
Sat, Sep 9, 12:55 PM
bartek closed D9073: [lib] Add fetch timeout to reports service calls.
Sat, Sep 9, 11:54 AM
bartek committed rCOMM20d64119a849: [lib] Add fetch timeout to reports service calls (authored by bartek).
[lib] Add fetch timeout to reports service calls
Sat, Sep 9, 11:54 AM
bartek closed D9044: [lib][native] Unwrap sendReport from callServerEndpoint.
Sat, Sep 9, 11:54 AM
bartek closed D9045: [native] Fix long ID display on crash screen.
Sat, Sep 9, 11:54 AM
bartek committed rCOMMb89023efbb41: [lib][native] Unwrap sendReport from callServerEndpoint (authored by bartek).
[lib][native] Unwrap sendReport from callServerEndpoint
Sat, Sep 9, 11:54 AM
bartek committed rCOMMebfc840ce3ad: [native] Fix long ID display on crash screen (authored by bartek).
[native] Fix long ID display on crash screen
Sat, Sep 9, 11:54 AM
bartek closed D9042: [lib] Add function to send reports.
Sat, Sep 9, 11:53 AM
bartek closed D9043: [lib] Replace sendReports keyserver call with Reports service.
Sat, Sep 9, 11:53 AM
bartek committed rCOMM13fca327654f: [lib] Replace sendReports keyserver call with Reports service (authored by bartek).
[lib] Replace sendReports keyserver call with Reports service
Sat, Sep 9, 11:53 AM
bartek committed rCOMM56e629f020f4: [lib] Add function to send reports (authored by bartek).
[lib] Add function to send reports
Sat, Sep 9, 11:53 AM
bartek closed D9041: [lib] Add reports service facts.
Sat, Sep 9, 11:53 AM
bartek committed rCOMMcc25100ea231: [lib] Add reports service facts (authored by bartek).
[lib] Add reports service facts
Sat, Sep 9, 11:53 AM
bartek closed D9035: [reports-service] Encrypt reports.
Sat, Sep 9, 11:00 AM
bartek closed D9034: [services-lib] Introduce crypto module.
Sat, Sep 9, 11:00 AM
bartek closed D9040: [terraform] Add reports service.
Sat, Sep 9, 11:00 AM
bartek committed rCOMM0bb3cda63aab: [reports-service] Encrypt reports (authored by bartek).
[reports-service] Encrypt reports
Sat, Sep 9, 11:00 AM
bartek committed rCOMMb9a31a6a79a5: [services-lib] Introduce crypto module (authored by bartek).
[services-lib] Introduce crypto module
Sat, Sep 9, 11:00 AM
bartek closed D9039: [secrets] Add e-mail config for reports.
Sat, Sep 9, 11:00 AM
bartek committed rCOMMb2ba1b9e8777: [terraform] Add reports service (authored by bartek).
[terraform] Add reports service
Sat, Sep 9, 11:00 AM