Page MenuHomePhabricator

bartek (Bartłomiej Klocek)
Animal

Projects

User does not belong to any projects.

User Details

User Since
Sep 30 2022, 5:22 AM (95 w, 19 h)

IMG_6395.JPG (537×680 px, 67 KB)
If it works and/or looks nice, then:
Ship it
- see why

Recent Activity

Yesterday

bartek closed D12898: [identity] Fix saving majorDesktopVersion metadata.
Fri, Jul 26, 7:19 AM
bartek committed rCOMMdbd6643c2d91: [identity] Fix saving majorDesktopVersion metadata (authored by bartek).
[identity] Fix saving majorDesktopVersion metadata
Fri, Jul 26, 7:19 AM
bartek published D12898: [identity] Fix saving majorDesktopVersion metadata for review.
Fri, Jul 26, 7:16 AM
bartek published D12897: [lib] Implement sending WebPush notifs using Tunnelbroker for review.
Fri, Jul 26, 6:42 AM
bartek published D12896: [tunnelbroker] Implement sending WebPush notifs by clients for review.
Fri, Jul 26, 6:41 AM
bartek published D12895: [tunnelbroker][lib] Add WebPush notif message type for review.
Fri, Jul 26, 6:40 AM
bartek published D12894: [tunnelbroker] Implement sending WebPush notifs for review.
Fri, Jul 26, 6:40 AM
bartek published D12893: [tunnelbroker] Implement WebPush client adapter for review.
Fri, Jul 26, 6:39 AM
bartek published D12890: [identity] Rewrite GetDeviceLists RPC to use batch functions for review.
Fri, Jul 26, 3:46 AM
bartek published D12889: [identity] Add function to batch-get platform details for review.
Fri, Jul 26, 3:46 AM
bartek published D12888: [identity] Add function to batch-get device lists for review.
Fri, Jul 26, 3:45 AM
bartek accepted D12891: [Tunnelbroker] rename `WebPushConfig` to `camelCase`.
Fri, Jul 26, 3:44 AM
bartek closed D12879: [services] Update AWS Rust SDK.
Fri, Jul 26, 2:48 AM
bartek closed D12880: [services] Replace deprecated aws_config::from_env().
Fri, Jul 26, 2:48 AM
bartek committed rCOMMaa2d0a93a94b: [services] Update AWS Rust SDK (authored by bartek).
[services] Update AWS Rust SDK
Fri, Jul 26, 2:48 AM
bartek committed rCOMMb421e69c314d: [services] Replace deprecated aws_config::from_env() (authored by bartek).
[services] Replace deprecated aws_config::from_env()
Fri, Jul 26, 2:48 AM
bartek closed D12878: Update Rust to 1.76.
Fri, Jul 26, 2:48 AM
bartek committed rCOMMdf4b4911bcff: Update Rust to 1.76 (authored by bartek).
Update Rust to 1.76
Fri, Jul 26, 2:48 AM
bartek updated the diff for D12879: [services] Update AWS Rust SDK.

Address feedback

Fri, Jul 26, 2:10 AM
bartek added inline comments to D12879: [services] Update AWS Rust SDK.
Fri, Jul 26, 2:10 AM
bartek accepted D12805: [lib] introduce new device list function to replace keyserver device.
Fri, Jul 26, 1:56 AM
bartek accepted D12884: [native] replace keyserver using qr code auth.
Fri, Jul 26, 1:55 AM

Thu, Jul 25

bartek published D12886: [identity] Forbid duplicated devices in device lists for review.
Thu, Jul 25, 10:27 PM
bartek accepted D12703: Transfer CSAT to IndexedDB from service worker and implement call to identity to query for inbound keys.
Thu, Jul 25, 7:19 AM
bartek accepted D12877: [terraform] Update terraform.tfvars.example and use json format.

I totally forgot that tfvars can be in JSON format 😅

Thu, Jul 25, 6:53 AM
bartek accepted D12876: [terraform] Making user created vpc false by default.
Thu, Jul 25, 6:52 AM
bartek accepted D12875: [terraform] create separate lb security groups for landing and web.
Thu, Jul 25, 6:51 AM
bartek published D12880: [services] Replace deprecated aws_config::from_env() for review.
Thu, Jul 25, 12:58 AM
bartek published D12878: Update Rust to 1.76 for review.
Thu, Jul 25, 12:47 AM
bartek published D12879: [services] Update AWS Rust SDK for review.
Thu, Jul 25, 12:46 AM
bartek accepted D12874: [terraform] up maximum deployment and minimum deployment percents.
Thu, Jul 25, 12:04 AM

Tue, Jul 23

bartek accepted D12840: [terraform] add Web Push secrets config.
Tue, Jul 23, 4:51 AM
bartek accepted D12841: [Tunnelbroker] implement Web Push config.
Tue, Jul 23, 4:51 AM
bartek accepted D12842: [Tunnelbroker] implement creating Web Push client.
Tue, Jul 23, 4:51 AM

Mon, Jul 22

bartek accepted D12832: [identity] modify get_all_user_details to return wallet addresses too.
Mon, Jul 22, 1:58 AM
bartek accepted D12831: [identity] get all usernames and wallet addresses in get_all_usernames.

Accepting, but I noticed one more thing that needs to be considered.
Scan operation doesn't always return all items. It has response limit of 1MB. If it's exceeded, the response contains LastEvaluatedKey property, from which we should start a subsequent scan.

Mon, Jul 22, 1:57 AM
bartek accepted D12830: [identity] check users table before reserved usernames table for user ID during wallet login.
Mon, Jul 22, 1:50 AM
bartek accepted D12823: [terraform] Avoid including Terraform state and secrets in keyserver Docker images.
Mon, Jul 22, 1:42 AM
bartek requested changes to D12805: [lib] introduce new device list function to replace keyserver device.
Mon, Jul 22, 1:37 AM
bartek accepted D12803: [Tunnelbroker] reduce logging spam.
Mon, Jul 22, 1:34 AM
bartek accepted D12820: [identity] use redact_sensitive_data config to redact sensitive data in logs.

Good luck debugging

Mon, Jul 22, 1:10 AM
bartek accepted D12819: [identity] redact_sensitive_data config.
Mon, Jul 22, 1:09 AM

Fri, Jul 19

bartek accepted D12772: [lib] implement sending FCM notifs using Tunnelbroker.
Fri, Jul 19, 5:38 AM
bartek accepted D12770: [Tunnelbroker][lib] add FCM notif message type.
Fri, Jul 19, 5:38 AM

Thu, Jul 18

bartek added inline comments to D12770: [Tunnelbroker][lib] add FCM notif message type.
Thu, Jul 18, 7:25 AM
bartek accepted D12771: [Tunnelbroker] implement sending FCM notifs by client.
Thu, Jul 18, 7:21 AM
bartek accepted D12773: [Tunnelbroker] simplify retrieving device token.
Thu, Jul 18, 7:21 AM
bartek accepted D12766: [Tunnelbroker] implement FCM Access Token lifetime.
Thu, Jul 18, 7:19 AM
bartek accepted D12765: [Tunnelbroker] implement requesting FCM access token using OAuth 2.0.
Thu, Jul 18, 7:16 AM
bartek accepted D12754: [Tunnelbroker] implement OAuth 2.0 JWT token encoding.
Thu, Jul 18, 7:15 AM
bartek added a comment to D12792: [terraform] Increase Identity memory to 2048.

Assuming this draft is ready for review since @bartek linked in on Linear

Thu, Jul 18, 7:11 AM
bartek added inline comments to D12638: [lib] Send primary device logout message to secondary devices.
Thu, Jul 18, 2:28 AM

Wed, Jul 17

bartek accepted D12769: [Tunnelbroker] implement sending FCM message.

Proposed an optional alternative to error handling

Wed, Jul 17, 9:18 AM
bartek accepted D12768: [Tunnelbroker] implement errors from FCM service.
Wed, Jul 17, 9:05 AM
bartek accepted D12767: [Tunnelbroker] implement messages types to FCM service.
Wed, Jul 17, 9:04 AM
bartek accepted D12753: [Tunnelbroker] implement creating FCM client.
Wed, Jul 17, 8:54 AM
bartek accepted D12752: [Tunnelbroker] implement FCM config.
Wed, Jul 17, 8:53 AM
bartek accepted D12751: [terraform] add FCM secrets config.
Wed, Jul 17, 8:51 AM
bartek accepted D12711: [terraform] Introduce secondary keyserver service.
Wed, Jul 17, 8:48 AM
bartek accepted D12728: Implement Android HTTP call to identity to get notifs inbound keys.
Wed, Jul 17, 8:47 AM
bartek added inline comments to D12731: [terraform] Migration script for for self-hosted keyserver.
Wed, Jul 17, 1:14 AM
bartek accepted D12730: [terraform] Ensure that the primary service is running before deploying secondary service.

@will mentioned a concern I had raised in a 1:1 here. Not sure if we want to address that here, but broadly I'm worried that the health check might not work if we're doing it after bringing the load balancer publicly online with only a single node (the primary) accessible

Wed, Jul 17, 1:04 AM
bartek accepted D12729: [terraform] Make number of secondary nodes configured by the user.
Wed, Jul 17, 12:52 AM
bartek accepted D12725: [terraform] add Tunnelbroker configuration variable to self-host.

Adding @varun as blocking to answer the inline comment

Wed, Jul 17, 12:50 AM
bartek requested changes to D12711: [terraform] Introduce secondary keyserver service.
Wed, Jul 17, 12:49 AM
bartek accepted D12710: [terraform] add authoritative keyserver id as a user-specified variable.
Wed, Jul 17, 12:45 AM

Tue, Jul 16

bartek added inline comments to D12703: Transfer CSAT to IndexedDB from service worker and implement call to identity to query for inbound keys.
Tue, Jul 16, 11:59 PM
bartek accepted D12677: Implement method to query identity service from the NSE.

The HTTP request-response logic looks good; it's analogous to the existing Blob GET request logic.

Tue, Jul 16, 4:41 AM
bartek accepted D12774: [terraform] bump staging identity to 0.30-staging.
Tue, Jul 16, 3:35 AM

Thu, Jul 4

bartek closed D12649: [identity] Delete Tunnelbroker data on primary device logout.
Thu, Jul 4, 1:37 AM
bartek closed D12638: [lib] Send primary device logout message to secondary devices.
Thu, Jul 4, 1:37 AM
bartek committed rCOMM5be17d8cefbc: [identity] Delete Tunnelbroker data on primary device logout (authored by bartek).
[identity] Delete Tunnelbroker data on primary device logout
Thu, Jul 4, 1:37 AM
bartek closed D12639: [lib] Log out secondary devices upon receiving primary logout message.
Thu, Jul 4, 1:37 AM
bartek committed rCOMM2e14a6ae2beb: [lib] Send primary device logout message to secondary devices (authored by bartek).
[lib] Send primary device logout message to secondary devices
Thu, Jul 4, 1:37 AM
bartek committed rCOMM76e319858310: [lib] Log out secondary devices upon receiving primary logout message (authored by bartek).
[lib] Log out secondary devices upon receiving primary logout message
Thu, Jul 4, 1:37 AM
bartek closed D12636: [lib] Add Primary Device Logout P2P message type.
Thu, Jul 4, 1:37 AM
bartek closed D12637: [lib] Extract handling Olm P2P messages to a separate function.
Thu, Jul 4, 1:37 AM
bartek committed rCOMM7b122b94885a: [lib] Extract handling Olm P2P messages to a separate function (authored by bartek).
[lib] Extract handling Olm P2P messages to a separate function
Thu, Jul 4, 1:37 AM
bartek committed rCOMMd30205e170b3: [lib] Add Primary Device Logout P2P message type (authored by bartek).
[lib] Add Primary Device Logout P2P message type
Thu, Jul 4, 1:37 AM
bartek closed D12605: [lib] Broadcast device list update during primary logout.
Thu, Jul 4, 1:37 AM
bartek committed rCOMM4e321a00594d: [lib] Broadcast device list update during primary logout (authored by bartek).
[lib] Broadcast device list update during primary logout
Thu, Jul 4, 1:37 AM
bartek accepted D12650: Update extractKeyserverIDFromID so that it returns null for DMs.

Okay, this makes sense 😉

Thu, Jul 4, 1:25 AM

Wed, Jul 3

bartek added inline comments to D12605: [lib] Broadcast device list update during primary logout.
Wed, Jul 3, 8:09 AM
bartek published D12649: [identity] Delete Tunnelbroker data on primary device logout for review.
Wed, Jul 3, 3:23 AM
bartek added inline comments to D12638: [lib] Send primary device logout message to secondary devices.
Wed, Jul 3, 3:14 AM
bartek closed D12604: [native] Add dev-only button for primary device logout.
Wed, Jul 3, 3:08 AM
bartek committed rCOMM077673982e9c: [native] Add dev-only button for primary device logout (authored by bartek).
[native] Add dev-only button for primary device logout
Wed, Jul 3, 3:08 AM
bartek closed D12586: [lib][native] Add logOutPrimaryDevice to Identity Client.
Wed, Jul 3, 3:08 AM
bartek closed D12603: [lib] Add usePrimaryDeviceLogOut hook.
Wed, Jul 3, 3:08 AM
bartek committed rCOMMdf174019f71a: [lib][native] Add logOutPrimaryDevice to Identity Client (authored by bartek).
[lib][native] Add logOutPrimaryDevice to Identity Client
Wed, Jul 3, 3:08 AM
bartek committed rCOMM399567e31112: [lib] Add usePrimaryDeviceLogOut hook (authored by bartek).
[lib] Add usePrimaryDeviceLogOut hook
Wed, Jul 3, 3:08 AM
bartek closed D12585: [native] Add logOutPrimaryDevice to JSI.
Wed, Jul 3, 3:08 AM
bartek committed rCOMM63f039901610: [native] Add logOutPrimaryDevice to JSI (authored by bartek).
[native] Add logOutPrimaryDevice to JSI
Wed, Jul 3, 3:08 AM
bartek closed D12590: [identity] Implement LogOutPrimaryDevice RPC.
Wed, Jul 3, 3:08 AM
bartek closed D12584: [native_rust_library] Add primary device logout RPC.
Wed, Jul 3, 3:08 AM
bartek committed rCOMM33f97a51114a: [identity] Implement LogOutPrimaryDevice RPC (authored by bartek).
[identity] Implement LogOutPrimaryDevice RPC
Wed, Jul 3, 3:08 AM
bartek committed rCOMMec46687af16c: [native_rust_library] Add primary device logout RPC (authored by bartek).
[native_rust_library] Add primary device logout RPC
Wed, Jul 3, 3:08 AM
bartek closed D12589: [identity] Make apply_devicelist_update more generic.
Wed, Jul 3, 3:08 AM
bartek closed D12588: [identity] Add function to remove user devices' data.
Wed, Jul 3, 3:08 AM
bartek committed rCOMMfdd22dcce572: [identity] Make apply_devicelist_update more generic (authored by bartek).
[identity] Make apply_devicelist_update more generic
Wed, Jul 3, 3:08 AM