User Details
- User Since
- Sep 30 2022, 5:22 AM (25 w, 2 d)
Yesterday
Fri, Mar 24
Added a short description for the holder field
- Updated validateAndConvert to accept a single object argument
- Used serverCanHandleTypes to validate MIME type
Fix encryption_key -> encryptionKey
First of all, I'm sorry that my previous message sounds personal to you, I didn't mean it in any case.
Thu, Mar 23
Wed, Mar 22
It seems to work with all data URIs too!
How do you obtain the SHA-256 fingerprint? From what I understood from the diff description, it is copy-pasted from Play Console, right?
The new ID looks correct
Use compareAndSet sicne it is safer and cleaner
Tue, Mar 21
Besides nits, some considerations about promise handling.
Rebase, fix exports
Rebase, fix exports
Rebase, fix exports
pageSize is 1001 because I used the idea from https://mariadb.com/kb/en/pagination-optimization/ that is to fetch one more row than we intend to process.
Mon, Mar 20
Rebase before landing
Rebase before landing
Rebase before landing
Rebase before landing
Rebase before landing
Rebase before landing
Rebase before landing
Rebase before landing
Thu, Mar 16
Wed, Mar 15
Generally, the code itself looks good to me. But I have a general note regarding naming conventions.
I haven't seen all call sites yet (only the key generation diff is up) so I can't really tell but maybe it's worth revisiting the types and function arguments to have this as clean and consistent as possible.
In my diffs regarding AES encryption, I defined a few naming rules which I stick to (you can find them in this Notion doc). You can take inspiration from them.
Tue, Mar 14
I'm going to leave both for now.
Mon, Mar 13
Revert accidental changes
- Rebase
- Added new tests
- Rebase on new types
- Address review feedback
- Used consistent naming for ciphertext, sealed data etc.
Address code review feedback
Address code review feedback
Address code review feedback
Address code review feedback
Address code review feedback
Regarding all naming issues (applies to the whole stack), I've created a Notion doc that clarifies the names
Sun, Mar 12
Replaced by D6994
LGTM, Works with my changes. Thank you for taking care of this!
Fri, Mar 10
I'll add a test for the correct key, but the malformed ciphertext