Page MenuHomePhabricator

bartek (Bartłomiej Klocek)
Animal

Projects

User does not belong to any projects.

User Details

User Since
Sep 30 2022, 5:22 AM (80 w, 6 d)

IMG_6395.JPG (537×680 px, 67 KB)
If it works and/or looks nice, then:
Ship it
- see why

Recent Activity

Today

bartek published D11685: [identity] Add device list timestamp verification for review.
Fri, Apr 19, 3:30 AM

Yesterday

bartek accepted D11678: [identity] make sure otk exists when we delete it.

Theoretically, we should check if partition and sort key exist (because the otk attribute is present for all rows) but technically, this way also works - the "otk" attribute won't exist for non-existing row (implies non-existing primary key)

Thu, Apr 18, 12:15 AM
bartek accepted D11677: [identity] make sure we don't call refresh keys task twice when fetching content and notif keys.
Thu, Apr 18, 12:08 AM
bartek accepted D11679: [identity] rename otk db method.
Thu, Apr 18, 12:06 AM
bartek accepted D11674: [identity] move otk db stuff to new sub module.
Thu, Apr 18, 12:05 AM
bartek accepted D11658: [identity] check that prekeys are formatted correctly.

Awesome, thanks!

Thu, Apr 18, 12:00 AM

Mon, Apr 15

bartek accepted D11664: [native] Remove socialProof from outbound keyserver keys blobs.
Mon, Apr 15, 6:32 AM
bartek closed D11570: [protos][identity] Add RPC for fetching multiple device lists.
Mon, Apr 15, 1:44 AM
bartek closed D11551: [protos] Replace challengeResponse with nonce and signature pair.
Mon, Apr 15, 1:44 AM
bartek committed rCOMMa8ad5e68ca0f: [protos][identity] Add RPC for fetching multiple device lists (authored by bartek).
[protos][identity] Add RPC for fetching multiple device lists
Mon, Apr 15, 1:44 AM
bartek committed rCOMMecd0073aef88: [protos] Replace challengeResponse with nonce and signature pair (authored by bartek).
[protos] Replace challengeResponse with nonce and signature pair
Mon, Apr 15, 1:44 AM
bartek closed D11548: [identity] Store social proof as a Map in DDB.
Mon, Apr 15, 1:44 AM
bartek closed D11549: [protos] Remove social_proof from IdentityKeyInfo.
Mon, Apr 15, 1:44 AM
bartek committed rCOMM5aed2ee33018: [identity] Store social proof as a Map in DDB (authored by bartek).
[identity] Store social proof as a Map in DDB
Mon, Apr 15, 1:44 AM
bartek committed rCOMMe7f9f1ef90fb: [protos] Remove social_proof from IdentityKeyInfo (authored by bartek).
[protos] Remove social_proof from IdentityKeyInfo
Mon, Apr 15, 1:44 AM
bartek closed D11547: [protos] Refactor user Identity message type.
Mon, Apr 15, 1:44 AM
bartek committed rCOMM883fffc6adc1: [protos] Refactor user Identity message type (authored by bartek).
[protos] Refactor user Identity message type
Mon, Apr 15, 1:44 AM
bartek accepted D11661: Handle key permanently invalidated error to fix Android app crash.
Mon, Apr 15, 1:41 AM
bartek requested changes to D11658: [identity] check that prekeys are formatted correctly.
Mon, Apr 15, 1:36 AM
bartek accepted D11608: [identity] otk db changes.
Mon, Apr 15, 1:31 AM
bartek accepted D11657: check one-time key format.
Mon, Apr 15, 1:27 AM

Fri, Apr 12

bartek updated the diff for D11570: [protos][identity] Add RPC for fetching multiple device lists.

Rebase before landing, fix comment in proto

Fri, Apr 12, 3:27 AM
bartek updated the diff for D11548: [identity] Store social proof as a Map in DDB.

Rebase, Rename variable

Fri, Apr 12, 3:27 AM
bartek added inline comments to D11551: [protos] Replace challengeResponse with nonce and signature pair.
Fri, Apr 12, 3:25 AM
bartek updated subscribers of D11549: [protos] Remove social_proof from IdentityKeyInfo.
Fri, Apr 12, 3:12 AM

Tue, Apr 9

bartek accepted D11574: [web/native] improve rendering Tunnelbroker messages.
Tue, Apr 9, 6:25 AM
bartek accepted D11590: add deletePasswordUser to IdentityServiceClient.
Tue, Apr 9, 4:10 AM

Mon, Apr 8

bartek added inline comments to D11570: [protos][identity] Add RPC for fetching multiple device lists.
Mon, Apr 8, 11:24 PM
bartek accepted D11589: [commRustModule] expose deletePasswordUser to JS.
Mon, Apr 8, 11:16 PM
bartek accepted D11587: replace single deleteUser RPC with deleteWalletUser, deletePasswordUserStart, and deletePasswordUserFinish.
Mon, Apr 8, 11:16 PM
bartek accepted D11588: [native_rust_library] implement delete_password_user method and move delete methods to a separate file.
Mon, Apr 8, 11:12 PM
bartek closed D11546: [protos][identity] Make keyserver_info response non-optional.
Mon, Apr 8, 3:54 AM
bartek closed D11468: [commtest] Add test for LogInExistingDevice RPC.
Mon, Apr 8, 3:54 AM
bartek committed rCOMMd8727804c52e: [protos][identity] Make keyserver_info response non-optional (authored by bartek).
[protos][identity] Make keyserver_info response non-optional
Mon, Apr 8, 3:54 AM
bartek committed rCOMMa975e16c018e: [commtest] Add test for LogInExistingDevice RPC (authored by bartek).
[commtest] Add test for LogInExistingDevice RPC
Mon, Apr 8, 3:54 AM
bartek closed D11467: [commtest] Add helpers for ED25519 signing messages.
Mon, Apr 8, 3:54 AM
bartek committed rCOMMbf3170431861: [commtest] Add helpers for ED25519 signing messages (authored by bartek).
[commtest] Add helpers for ED25519 signing messages
Mon, Apr 8, 3:54 AM
bartek removed 1 blocking reviewer(s) for D11468: [commtest] Add test for LogInExistingDevice RPC: varun.
Mon, Apr 8, 2:53 AM
bartek published D11570: [protos][identity] Add RPC for fetching multiple device lists for review.
Mon, Apr 8, 2:50 AM
bartek updated the diff for D11547: [protos] Refactor user Identity message type.

Address feedback

Mon, Apr 8, 12:24 AM

Sun, Apr 7

bartek added inline comments to D11547: [protos] Refactor user Identity message type.
Sun, Apr 7, 11:53 PM

Thu, Apr 4

bartek published D11551: [protos] Replace challengeResponse with nonce and signature pair for review.
Thu, Apr 4, 7:16 AM
bartek published D11549: [protos] Remove social_proof from IdentityKeyInfo for review.
Thu, Apr 4, 6:30 AM
bartek accepted D11550: [nix][scripts] Rename localstack_main to localstack-main.
Thu, Apr 4, 6:30 AM
bartek closed D11471: [protos][identity] Add primary device keys to GetKeyserverKeys response.
Thu, Apr 4, 5:16 AM
bartek committed rCOMM173f8128076f: [protos][identity] Add primary device keys to GetKeyserverKeys response (authored by bartek).
[protos][identity] Add primary device keys to GetKeyserverKeys response
Thu, Apr 4, 5:16 AM
bartek published D11548: [identity] Store social proof as a Map in DDB for review.
Thu, Apr 4, 5:11 AM
bartek published D11547: [protos] Refactor user Identity message type for review.
Thu, Apr 4, 5:07 AM
bartek closed D11524: [native_rust_library] Cleanup remaining APIs.
Thu, Apr 4, 3:12 AM
bartek closed D11523: [native_rust_library] Move device list APIs to submodule.
Thu, Apr 4, 3:12 AM
bartek committed rCOMM0b089eaf031e: [native_rust_library] Cleanup remaining APIs (authored by bartek).
[native_rust_library] Cleanup remaining APIs
Thu, Apr 4, 3:12 AM
bartek closed D11522: [native_rust_library] Move account actions to submodule.
Thu, Apr 4, 3:12 AM
bartek committed rCOMMcb1f87b40755: [native_rust_library] Move device list APIs to submodule (authored by bartek).
[native_rust_library] Move device list APIs to submodule
Thu, Apr 4, 3:12 AM
bartek committed rCOMM931fedbabf67: [native_rust_library] Move account actions to submodule (authored by bartek).
[native_rust_library] Move account actions to submodule
Thu, Apr 4, 3:12 AM
bartek closed D11521: [native_rust_library] Move X3DH APIs to submodule.
Thu, Apr 4, 3:12 AM
bartek closed D11520: [native_rust_library] Move login APIs to submodule.
Thu, Apr 4, 3:12 AM
bartek closed D11519: [native_rust_library] Move password registration to submodule.
Thu, Apr 4, 3:12 AM
bartek committed rCOMMb14ea1a6766b: [native_rust_library] Move X3DH APIs to submodule (authored by bartek).
[native_rust_library] Move X3DH APIs to submodule
Thu, Apr 4, 3:12 AM
bartek committed rCOMM6e5fec83981f: [native_rust_library] Move login APIs to submodule (authored by bartek).
[native_rust_library] Move login APIs to submodule
Thu, Apr 4, 3:12 AM
bartek committed rCOMM8424533212fb: [native_rust_library] Move password registration to submodule (authored by bartek).
[native_rust_library] Move password registration to submodule
Thu, Apr 4, 3:12 AM
bartek closed D11518: [native_rust_library] Create ffi submodules for identity API.
Thu, Apr 4, 3:12 AM
bartek closed D11517: [native_rust_library] Create identity submodule.
Thu, Apr 4, 3:12 AM
bartek committed rCOMM8e5f464cc6ac: [native_rust_library] Create ffi submodules for identity API (authored by bartek).
[native_rust_library] Create ffi submodules for identity API
Thu, Apr 4, 3:12 AM
bartek committed rCOMMbe9a4f0c6862: [native_rust_library] Create identity submodule (authored by bartek).
[native_rust_library] Create identity submodule
Thu, Apr 4, 3:12 AM
bartek closed D11516: [native_rust_library] Extract utils module.
Thu, Apr 4, 3:12 AM
bartek committed rCOMMd1b8579ff9e8: [native_rust_library] Extract utils module (authored by bartek).
[native_rust_library] Extract utils module
Thu, Apr 4, 3:12 AM
bartek added a comment to D11524: [native_rust_library] Cleanup remaining APIs.

in your testing were you able to see Rust logs in Xcode or your terminal? noticed we have #[instrument] for some functions in this library but i don't think we configure tracing anywhere...

Thu, Apr 4, 2:40 AM
bartek updated the diff for D11524: [native_rust_library] Cleanup remaining APIs.

Rebase before landing

Thu, Apr 4, 2:39 AM
bartek closed D11543: [CI] Use Docker Compose v2 in GH Actions.
Thu, Apr 4, 1:50 AM
bartek committed rCOMM998ee1c199f9: [CI] Use Docker Compose v2 in GH Actions (authored by bartek).
[CI] Use Docker Compose v2 in GH Actions
Thu, Apr 4, 1:50 AM
bartek added a reviewer for D11468: [commtest] Add test for LogInExistingDevice RPC: kamil. bartek added 1 blocking reviewer(s) for D11468: [commtest] Add test for LogInExistingDevice RPC: varun.
Thu, Apr 4, 1:40 AM

Wed, Apr 3

bartek published D11546: [protos][identity] Make keyserver_info response non-optional for review.
Wed, Apr 3, 8:54 AM
bartek requested review of D11543: [CI] Use Docker Compose v2 in GH Actions.
Wed, Apr 3, 7:41 AM
bartek closed D11470: [native] Add JSI bindings for LogInExistingDevice RPC.
Wed, Apr 3, 3:17 AM
bartek committed rCOMM70ffc9f4131d: [native] Add JSI bindings for LogInExistingDevice RPC (authored by bartek).
[native] Add JSI bindings for LogInExistingDevice RPC
Wed, Apr 3, 3:17 AM
bartek closed D11469: [native] Add LogInExistingDevice to native_rust_library.
Wed, Apr 3, 3:17 AM
bartek closed D11466: [identity] Implement LogInExistingDevice RPC.
Wed, Apr 3, 3:17 AM
bartek closed D11465: [protos] Add RPC to log in existing device.
Wed, Apr 3, 3:17 AM
bartek committed rCOMM505eaa6064c4: [native] Add LogInExistingDevice to native_rust_library (authored by bartek).
[native] Add LogInExistingDevice to native_rust_library
Wed, Apr 3, 3:17 AM
bartek committed rCOMM0aacce933929: [identity] Implement LogInExistingDevice RPC (authored by bartek).
[identity] Implement LogInExistingDevice RPC
Wed, Apr 3, 3:17 AM
bartek committed rCOMMeee910d34fc8: [protos] Add RPC to log in existing device (authored by bartek).
[protos] Add RPC to log in existing device
Wed, Apr 3, 3:17 AM
bartek closed D11464: [commtest] Add test for FindUserIdentity RPC.
Wed, Apr 3, 3:17 AM
bartek closed D11435: [protos] Reorder some RPCs.
Wed, Apr 3, 3:17 AM
bartek committed rCOMM79bc9fc59ee3: [commtest] Add test for FindUserIdentity RPC (authored by bartek).
[commtest] Add test for FindUserIdentity RPC
Wed, Apr 3, 3:17 AM
bartek committed rCOMMe4ead704d6b4: [protos] Reorder some RPCs (authored by bartek).
[protos] Reorder some RPCs
Wed, Apr 3, 3:17 AM
bartek closed D11379: [protos][identity] Add RPC to find username by user ID.
Wed, Apr 3, 3:17 AM
bartek committed rCOMM4f47ad45ec56: [protos][identity] Add RPC to find username by user ID (authored by bartek).
[protos][identity] Add RPC to find username by user ID
Wed, Apr 3, 3:17 AM
bartek updated the diff for D11471: [protos][identity] Add primary device keys to GetKeyserverKeys response.

Find user identifier before getting keys

Wed, Apr 3, 3:10 AM
bartek updated the diff for D11471: [protos][identity] Add primary device keys to GetKeyserverKeys response.

Rebase

Wed, Apr 3, 2:54 AM
bartek updated the diff for D11470: [native] Add JSI bindings for LogInExistingDevice RPC.

Rebase before landing

Wed, Apr 3, 2:53 AM
bartek updated the diff for D11465: [protos] Add RPC to log in existing device.

Rebase, add comments explaining challenge response

Wed, Apr 3, 2:53 AM
bartek added inline comments to D11465: [protos] Add RPC to log in existing device.
Wed, Apr 3, 2:53 AM
bartek updated the diff for D11435: [protos] Reorder some RPCs.

Use 'authoritative' where applicable

Wed, Apr 3, 2:51 AM
bartek updated the diff for D11379: [protos][identity] Add RPC to find username by user ID.

Rebase

Wed, Apr 3, 2:50 AM
bartek added a comment to D11379: [protos][identity] Add RPC to find username by user ID.

do we need to change any client code now that some of these RPCs are returning "not found" ?

Wed, Apr 3, 2:36 AM

Tue, Apr 2

bartek published D11524: [native_rust_library] Cleanup remaining APIs for review.
Tue, Apr 2, 10:54 PM
bartek published D11523: [native_rust_library] Move device list APIs to submodule for review.
Tue, Apr 2, 10:54 PM
bartek published D11522: [native_rust_library] Move account actions to submodule for review.
Tue, Apr 2, 10:54 PM
bartek published D11521: [native_rust_library] Move X3DH APIs to submodule for review.
Tue, Apr 2, 10:53 PM
bartek published D11520: [native_rust_library] Move login APIs to submodule for review.
Tue, Apr 2, 10:53 PM