Page MenuHomePhabricator

bartek (Bartłomiej Klocek)
Animal

Projects

User does not belong to any projects.

User Details

User Since
Sep 30 2022, 5:22 AM (25 w, 2 d)

IMG_6395.JPG (537×680 px, 67 KB)
If it works and/or looks nice, then:
Ship it
- see why

Recent Activity

Yesterday

bartek published D7170: [lib] Store encrypted messages in Client DB for review.
Sat, Mar 25, 5:03 AM

Fri, Mar 24

bartek updated the diff for D7168: [lib] Introduce encrypted media types.

Added a short description for the holder field

Fri, Mar 24, 11:21 PM
bartek updated the diff for D7167: [keyserver] Process and store encrypted media.
  • Updated validateAndConvert to accept a single object argument
  • Used serverCanHandleTypes to validate MIME type
Fri, Mar 24, 11:12 PM
bartek updated the diff for D7166: [lib][keyserver] Attach MIME and encryption key to uploads.

Fix encryption_key -> encryptionKey

Fri, Mar 24, 10:51 PM
bartek added inline comments to D7168: [lib] Introduce encrypted media types.
Fri, Mar 24, 10:46 PM
bartek added inline comments to D7167: [keyserver] Process and store encrypted media.
Fri, Mar 24, 10:42 PM
bartek added inline comments to D7166: [lib][keyserver] Attach MIME and encryption key to uploads.
Fri, Mar 24, 10:41 PM
bartek added a comment to D7106: Native Java code to request notifications permissions from JS on Android 13.

First of all, I'm sorry that my previous message sounds personal to you, I didn't mean it in any case.

Fri, Mar 24, 10:38 PM
bartek added inline comments to D7106: Native Java code to request notifications permissions from JS on Android 13.
Fri, Mar 24, 6:12 AM
bartek added inline comments to D7105: Build files set-up for Android 13.
Fri, Mar 24, 6:07 AM
bartek published D7169: [lib] Shim encrypted multimedia for review.
Fri, Mar 24, 5:33 AM
bartek published D7168: [lib] Introduce encrypted media types for review.
Fri, Mar 24, 5:31 AM
bartek published D7167: [keyserver] Process and store encrypted media for review.
Fri, Mar 24, 4:19 AM
bartek published D7166: [lib][keyserver] Attach MIME and encryption key to uploads for review.
Fri, Mar 24, 4:13 AM

Thu, Mar 23

bartek added inline comments to D7106: Native Java code to request notifications permissions from JS on Android 13.
Thu, Mar 23, 10:45 PM
bartek added inline comments to D7105: Build files set-up for Android 13.
Thu, Mar 23, 10:24 PM

Wed, Mar 22

bartek attached a referenced file: F441275: Screenshot 2023-03-23 at 06.34.25.png.
Wed, Mar 22, 11:10 PM
bartek accepted D7151: [native] Migrate from react-native-fast-image to expo-image.

It seems to work with all data URIs too!

Wed, Mar 22, 11:10 PM
bartek added a comment to D7151: [native] Migrate from react-native-fast-image to expo-image.

Just tested and it looks like this solves rendering SVG data URIs for us!! I haven't tested other types, but PNG, JPEG, and SVG are all listed as supported in the docs. Thanks @bartek for the tip! This is way better than what I had planned to do on Android.

Wed, Mar 22, 9:49 PM
bartek added inline comments to D7106: Native Java code to request notifications permissions from JS on Android 13.
Wed, Mar 22, 11:41 AM
bartek added inline comments to D7148: [keyserver/lib] Introduce a new message type and spec for toggling pins.
Wed, Mar 22, 10:45 AM
bartek accepted D7130: [Identity] Add client device service to identity service.
Wed, Mar 22, 10:16 AM
bartek accepted D7147: [server] Update assetlinks file.

How do you obtain the SHA-256 fingerprint? From what I understood from the diff description, it is copy-pasted from Play Console, right?

Wed, Mar 22, 9:51 AM
bartek accepted D7146: [server] Update AASA file so that we prove to iOS that the domain belongs to us.

The new ID looks correct

Wed, Mar 22, 9:49 AM
bartek accepted D7116: [Comm-opaque2] Change project name to avoid name clash.
Wed, Mar 22, 9:35 AM
bartek accepted D7106: Native Java code to request notifications permissions from JS on Android 13.

Use compareAndSet sicne it is safer and cleaner

Wed, Mar 22, 2:10 AM

Tue, Mar 21

bartek closed D7061: [lib] Introduce combined padding interface.
Tue, Mar 21, 10:21 AM
bartek closed D7060: [lib] Introduce superblock padding.
Tue, Mar 21, 10:21 AM
bartek committed rCOMMa37f8d4289a4: [lib] Introduce combined padding interface (authored by bartek).
[lib] Introduce combined padding interface
Tue, Mar 21, 10:21 AM
bartek committed rCOMMe44805bae320: [lib] Introduce superblock padding (authored by bartek).
[lib] Introduce superblock padding
Tue, Mar 21, 10:21 AM
bartek closed D7059: [lib] Introduce PKCS#7 padding.
Tue, Mar 21, 10:21 AM
bartek committed rCOMMb8bc1c09f374: [lib] Introduce PKCS#7 padding (authored by bartek).
[lib] Introduce PKCS#7 padding
Tue, Mar 21, 10:21 AM
bartek accepted D7120: Use notifications permission request API on Android 13 while keeping old behavior on older Androids..
Tue, Mar 21, 10:08 AM
bartek requested changes to D7106: Native Java code to request notifications permissions from JS on Android 13.

Besides nits, some considerations about promise handling.

Tue, Mar 21, 10:05 AM
bartek accepted D7105: Build files set-up for Android 13.
Tue, Mar 21, 9:39 AM
bartek updated the diff for D7061: [lib] Introduce combined padding interface.

Rebase, fix exports

Tue, Mar 21, 9:28 AM
bartek updated the diff for D7060: [lib] Introduce superblock padding.

Rebase, fix exports

Tue, Mar 21, 9:27 AM
bartek updated the diff for D7059: [lib] Introduce PKCS#7 padding.

Rebase, fix exports

Tue, Mar 21, 9:27 AM
bartek added inline comments to D7059: [lib] Introduce PKCS#7 padding.
Tue, Mar 21, 5:36 AM
bartek accepted D7117: [keyserver] Add migration - process messages in our db for search.

pageSize is 1001 because I used the idea from https://mariadb.com/kb/en/pagination-optimization/ that is to fetch one more row than we intend to process.

Tue, Mar 21, 4:56 AM
bartek accepted D7090: Unit tests for Olm's new X3DH methods.
Tue, Mar 21, 4:37 AM
bartek accepted D7104: [web-db] add unit tests for worker crypto utils.
Tue, Mar 21, 4:33 AM
bartek accepted D6995: [web-db] implement crypto functions.
Tue, Mar 21, 4:32 AM

Mon, Mar 20

bartek closed D7025: [web] Add unit tests for AES functions.
Mon, Mar 20, 7:30 AM
bartek committed rCOMM5a9b3ee3b8c3: [web] Add unit tests for AES functions (authored by bartek).
[web] Add unit tests for AES functions
Mon, Mar 20, 7:30 AM
bartek closed D7024: [web] Implement AES encryption functions.
Mon, Mar 20, 7:30 AM
bartek committed rCOMM0a9f3ff4fc9d: [web] Implement AES encryption functions (authored by bartek).
[web] Implement AES encryption functions
Mon, Mar 20, 7:30 AM
bartek closed D7008: [native][AES] Implement decrypt function on Android.
Mon, Mar 20, 7:15 AM
bartek closed D7007: [native][AES] Implement encrypt function on Android.
Mon, Mar 20, 7:15 AM
bartek committed rCOMMfc7383f60b2e: [native][AES] Implement encrypt function on Android (authored by bartek).
[native][AES] Implement encrypt function on Android
Mon, Mar 20, 7:15 AM
bartek closed D7006: [native][AES] Implement decrypt function on iOS.
Mon, Mar 20, 7:15 AM
bartek committed rCOMM868e5fda92f6: [native][AES] Implement decrypt function on iOS (authored by bartek).
[native][AES] Implement decrypt function on iOS
Mon, Mar 20, 7:15 AM
bartek committed rCOMMa0951b122781: [native][AES] Implement decrypt function on Android (authored by bartek).
[native][AES] Implement decrypt function on Android
Mon, Mar 20, 7:15 AM
bartek closed D7005: [native][AES] Implement encrypt function on iOS.
Mon, Mar 20, 7:15 AM
bartek closed D7004: [native][AES] Implement generateKey function.
Mon, Mar 20, 7:15 AM
bartek closed D7002: [native] Create AESCrypto Expo module.
Mon, Mar 20, 7:15 AM
bartek committed rCOMM46037bfe9b83: [native][AES] Implement generateKey function (authored by bartek).
[native][AES] Implement generateKey function
Mon, Mar 20, 7:15 AM
bartek committed rCOMM5789ca85981d: [native][AES] Implement encrypt function on iOS (authored by bartek).
[native][AES] Implement encrypt function on iOS
Mon, Mar 20, 7:15 AM
bartek committed rCOMM8735eb5f5924: [native] Create AESCrypto Expo module (authored by bartek).
[native] Create AESCrypto Expo module
Mon, Mar 20, 7:15 AM
bartek updated the diff for D7025: [web] Add unit tests for AES functions.

Rebase before landing

Mon, Mar 20, 6:57 AM
bartek updated the diff for D7024: [web] Implement AES encryption functions.

Rebase before landing

Mon, Mar 20, 6:57 AM
bartek updated the diff for D7008: [native][AES] Implement decrypt function on Android.

Rebase before landing

Mon, Mar 20, 6:56 AM
bartek updated the diff for D7007: [native][AES] Implement encrypt function on Android.

Rebase before landing

Mon, Mar 20, 6:56 AM
bartek updated the diff for D7006: [native][AES] Implement decrypt function on iOS.

Rebase before landing

Mon, Mar 20, 6:55 AM
bartek updated the diff for D7005: [native][AES] Implement encrypt function on iOS.

Rebase before landing

Mon, Mar 20, 6:55 AM
bartek updated the diff for D7004: [native][AES] Implement generateKey function.

Rebase before landing

Mon, Mar 20, 6:55 AM
bartek updated the diff for D7002: [native] Create AESCrypto Expo module.

Rebase before landing

Mon, Mar 20, 6:55 AM

Thu, Mar 16

bartek accepted D7075: [keyserver] Add natural library for stemming and removing stopwords.
Thu, Mar 16, 1:05 AM

Wed, Mar 15

bartek accepted D6999: [web] Fix compose subchannels modal for long names.
Wed, Mar 15, 3:36 AM
bartek added a comment to D6995: [web-db] implement crypto functions.

Generally, the code itself looks good to me. But I have a general note regarding naming conventions.
I haven't seen all call sites yet (only the key generation diff is up) so I can't really tell but maybe it's worth revisiting the types and function arguments to have this as clean and consistent as possible.
In my diffs regarding AES encryption, I defined a few naming rules which I stick to (you can find them in this Notion doc). You can take inspiration from them.

Wed, Mar 15, 3:34 AM

Tue, Mar 14

bartek closed D7056: [native] Remove network.json fallbacks.
Tue, Mar 14, 4:41 AM
bartek committed rCOMM8962253e8bd9: [native] Remove network.json fallbacks (authored by bartek).
[native] Remove network.json fallbacks
Tue, Mar 14, 4:41 AM
bartek added a comment to D7056: [native] Remove network.json fallbacks.

I'm going to leave both for now.

Tue, Mar 14, 4:35 AM

Mon, Mar 13

bartek added inline comments to D7056: [native] Remove network.json fallbacks.
Mon, Mar 13, 9:48 AM
bartek published D7061: [lib] Introduce combined padding interface for review.
Mon, Mar 13, 8:11 AM
bartek published D7060: [lib] Introduce superblock padding for review.
Mon, Mar 13, 8:10 AM
bartek published D7059: [lib] Introduce PKCS#7 padding for review.
Mon, Mar 13, 8:09 AM
bartek updated the diff for D7024: [web] Implement AES encryption functions.

Revert accidental changes

Mon, Mar 13, 5:21 AM
bartek planned changes to D7024: [web] Implement AES encryption functions.
Mon, Mar 13, 5:19 AM
bartek updated the diff for D7025: [web] Add unit tests for AES functions.
  • Rebase
  • Added new tests
Mon, Mar 13, 5:19 AM
bartek updated the diff for D7024: [web] Implement AES encryption functions.
  • Rebase on new types
  • Address review feedback
    • Used consistent naming for ciphertext, sealed data etc.
Mon, Mar 13, 5:18 AM
bartek updated the diff for D7008: [native][AES] Implement decrypt function on Android.

Address code review feedback

Mon, Mar 13, 4:55 AM
bartek updated the diff for D7007: [native][AES] Implement encrypt function on Android.

Address code review feedback

Mon, Mar 13, 4:55 AM
bartek updated the diff for D7006: [native][AES] Implement decrypt function on iOS.

Address code review feedback

Mon, Mar 13, 4:55 AM
bartek updated the diff for D7005: [native][AES] Implement encrypt function on iOS.

Address code review feedback

Mon, Mar 13, 4:54 AM
bartek updated the diff for D7004: [native][AES] Implement generateKey function.

Address code review feedback

Mon, Mar 13, 4:54 AM
bartek added a comment to D7005: [native][AES] Implement encrypt function on iOS.

Regarding all naming issues (applies to the whole stack), I've created a Notion doc that clarifies the names

Mon, Mar 13, 4:14 AM
bartek added inline comments to D7006: [native][AES] Implement decrypt function on iOS.
Mon, Mar 13, 4:12 AM
bartek updated the summary of D7024: [web] Implement AES encryption functions.
Mon, Mar 13, 3:22 AM
bartek published D7056: [native] Remove network.json fallbacks for review.
Mon, Mar 13, 12:12 AM

Sun, Mar 12

bartek abandoned D7023: [web] Add Flow types for WebCrypto / SubtleCrypto.

Replaced by D6994

Sun, Mar 12, 11:50 PM
bartek accepted D6994: [web-db] implement types for `SubtleCrypto` module.

LGTM, Works with my changes. Thank you for taking care of this!

Sun, Mar 12, 11:48 PM

Fri, Mar 10

bartek planned changes to D7025: [web] Add unit tests for AES functions.

I'll add a test for the correct key, but the malformed ciphertext

Fri, Mar 10, 1:05 AM
bartek added inline comments to D7005: [native][AES] Implement encrypt function on iOS.
Fri, Mar 10, 1:00 AM
bartek added inline comments to D7004: [native][AES] Implement generateKey function.
Fri, Mar 10, 12:51 AM

Thu, Mar 9

bartek published D7025: [web] Add unit tests for AES functions for review.
Thu, Mar 9, 11:11 PM
bartek closed D6558: Added web tests to .lintstagedrc and CI.
Thu, Mar 9, 11:08 PM
bartek committed rCOMM96800eb9c03f: Added web tests to .lintstagedrc and CI (authored by bartek).
Added web tests to .lintstagedrc and CI
Thu, Mar 9, 11:08 PM
bartek closed D7019: [web] Fix missing WebCrypto mock in tests.
Thu, Mar 9, 11:08 PM
bartek committed rCOMM961052269b9f: [web] Fix missing WebCrypto mock in tests (authored by bartek).
[web] Fix missing WebCrypto mock in tests
Thu, Mar 9, 11:07 PM