Page MenuHomePhabricator

bartek (Bartłomiej Klocek)
Animal

Projects

User does not belong to any projects.

User Details

User Since
Sep 30 2022, 5:22 AM (141 w, 1 d)

IMG_6395.JPG (537×680 px, 67 KB)
If it works and/or looks nice, then:
Ship it
- see why

Recent Activity

Today

bartek accepted D14839: [keyserver] Don't crash in socket on responseTo = 0.
Sat, Jun 14, 2:31 AM

Thu, Jun 12

bartek published D14837: [native] Rename C++ functions for logs for review.
Thu, Jun 12, 7:51 AM
bartek published D14834: [native] Add primary device check to DatabaseManager for review.
Thu, Jun 12, 7:51 AM
bartek published D14833: [native] Add SQLiteQueryExecutor method to query for single AuxUserInfo for review.
Thu, Jun 12, 6:12 AM
bartek updated the diff for D14832: [native_rust_lib] Remove compaction file after restoring.

Canceled file removal on success

Thu, Jun 12, 3:21 AM
bartek published D14830: [lib] Stop confirming P2P messages when logout is started for review.
Thu, Jun 12, 12:28 AM
bartek published D14832: [native_rust_lib] Remove compaction file after restoring for review.
Thu, Jun 12, 12:28 AM
bartek published D14831: [native_rust_lib] Add wrapper macro for async c++ calls for review.
Thu, Jun 12, 12:27 AM

Wed, Jun 11

bartek closed D14819: [native] Rekey main db after creating compaction.
Wed, Jun 11, 8:28 AM
bartek committed rCOMM1c31568b9f3e: [native] Rekey main db after creating compaction (authored by bartek).
[native] Rekey main db after creating compaction
Wed, Jun 11, 8:28 AM
bartek closed D14828: [lib] Fix usersSupportingThickThreads for reserved users.
Wed, Jun 11, 8:28 AM
bartek committed rCOMM65b36f446902: [lib] Fix usersSupportingThickThreads for reserved users (authored by bartek).
[lib] Fix usersSupportingThickThreads for reserved users
Wed, Jun 11, 8:28 AM
bartek closed D14829: [terraform] Deploy Blob and Backup to prod.
Wed, Jun 11, 2:53 AM
bartek committed rCOMM35996bd4a89b: [terraform] Deploy Blob and Backup to prod (authored by bartek).
[terraform] Deploy Blob and Backup to prod
Wed, Jun 11, 2:53 AM
bartek published D14829: [terraform] Deploy Blob and Backup to prod for review.
Wed, Jun 11, 2:18 AM
bartek published D14828: [lib] Fix usersSupportingThickThreads for reserved users for review.
Wed, Jun 11, 1:26 AM

Mon, Jun 9

bartek closed D14821: [terraform] Deploy Blob and Backup to staging.
Mon, Jun 9, 7:28 AM
bartek committed rCOMM4a7e7cafc1c7: [terraform] Deploy Blob and Backup to staging (authored by bartek).
[terraform] Deploy Blob and Backup to staging
Mon, Jun 9, 7:28 AM
bartek published D14821: [terraform] Deploy Blob and Backup to staging for review.
Mon, Jun 9, 7:20 AM
bartek published D14819: [native] Rekey main db after creating compaction for review.
Mon, Jun 9, 5:40 AM
bartek closed D14813: [blob] Improve regex for offensive words.
Mon, Jun 9, 5:01 AM
bartek closed D14814: [blob][lib][keyserver] Handle offensive invite link error.
Mon, Jun 9, 5:01 AM
bartek committed rCOMMa6ff8dbc8133: [blob][lib][keyserver] Handle offensive invite link error (authored by bartek).
[blob][lib][keyserver] Handle offensive invite link error
Mon, Jun 9, 5:01 AM
bartek committed rCOMM8650a80e4fb1: [blob] Improve regex for offensive words (authored by bartek).
[blob] Improve regex for offensive words
Mon, Jun 9, 5:01 AM
bartek closed D14818: [backup] Fix finding userID for reserved users.
Mon, Jun 9, 5:01 AM
bartek committed rCOMM0bfd997b1e1d: [backup] Fix finding userID for reserved users (authored by bartek).
[backup] Fix finding userID for reserved users
Mon, Jun 9, 5:01 AM

Sun, Jun 8

bartek published D14818: [backup] Fix finding userID for reserved users for review.
Sun, Jun 8, 1:19 AM
bartek accepted D14817: [lib] Disable sending svg and tiff images on web.

Also curious if we’re using sharp on the keyserver for transcoding at all anymore, given that media is now uploaded to the blob service in all cases (as far as I understand).

Sun, Jun 8, 1:00 AM

Fri, Jun 6

bartek closed D14815: [terraform] Bump Identity 0.53.0 to prod.
Fri, Jun 6, 3:39 AM
bartek committed rCOMM3c0e06bb5587: [terraform] Bump Identity 0.53.0 to prod (authored by bartek).
[terraform] Bump Identity 0.53.0 to prod
Fri, Jun 6, 3:39 AM
bartek published D14815: [terraform] Bump Identity 0.53.0 to prod for review.
Fri, Jun 6, 3:37 AM
bartek published D14814: [blob][lib][keyserver] Handle offensive invite link error for review.
Fri, Jun 6, 1:52 AM
bartek published D14813: [blob] Improve regex for offensive words for review.
Fri, Jun 6, 1:11 AM

Wed, Jun 4

bartek accepted D14811: [lib][web][native] display badge only for errors.
Wed, Jun 4, 3:18 AM
bartek accepted D14809: [lib][web][native] implement debug log types to be able to distinguish logs.
Wed, Jun 4, 3:17 AM
bartek accepted D14810: [lib][web][native] implement log filtering.
Wed, Jun 4, 3:14 AM
bartek closed D14800: [native] Upload DB version with backup info.
Wed, Jun 4, 3:11 AM
bartek closed D14799: [native] Add backup version info path to PlatformSpecificTools.
Wed, Jun 4, 3:11 AM
bartek closed D14795: [native] Use AsyncMutex for logs.
Wed, Jun 4, 3:11 AM
bartek committed rCOMM0280fc6bacdf: [native] Upload DB version with backup info (authored by bartek).
[native] Upload DB version with backup info
Wed, Jun 4, 3:11 AM
bartek committed rCOMM81087fc2d418: [native] Use AsyncMutex for logs (authored by bartek).
[native] Use AsyncMutex for logs
Wed, Jun 4, 3:11 AM
bartek committed rCOMM3a14cd77be14: [native] Add backup version info path to PlatformSpecificTools (authored by bartek).
[native] Add backup version info path to PlatformSpecificTools
Wed, Jun 4, 3:11 AM
bartek updated the diff for D14800: [native] Upload DB version with backup info.

Formatting

Wed, Jun 4, 3:09 AM
bartek accepted D14806: [web][native] clear restored database after copying content.

👍

Wed, Jun 4, 3:06 AM
bartek accepted D14805: [web] implement encryption of restored database.
Wed, Jun 4, 3:04 AM

Tue, Jun 3

bartek accepted D14804: [native] store restored key and path in `CommSecureStore`.
Tue, Jun 3, 8:00 AM
bartek accepted D14807: [lib] deprecate `changesSchema` param.
Tue, Jun 3, 7:56 AM
bartek accepted D14808: [lib] gate `SyncStoreVersionHandler` on rehydration.
Tue, Jun 3, 7:56 AM
bartek accepted D14803: [SQLite] update `copyContentFromDatabase` to handle encrypted database.
Tue, Jun 3, 7:52 AM
bartek accepted D14802: [SQLite] update `restoredConnectionManager` to be `NativeSQLiteConnectionManager`.
Tue, Jun 3, 7:51 AM
bartek accepted D14801: [SQLite] extract code to validate main compaction.
Tue, Jun 3, 3:05 AM

Mon, Jun 2

bartek published D14800: [native] Upload DB version with backup info for review.
Mon, Jun 2, 8:32 AM
bartek published D14799: [native] Add backup version info path to PlatformSpecificTools for review.
Mon, Jun 2, 8:32 AM
bartek closed D14798: [native] Update createMainCompaction to use random backup keys.
Mon, Jun 2, 7:04 AM
bartek closed D14797: [native] Update Rust functions to use random backup keys.
Mon, Jun 2, 7:04 AM
bartek committed rCOMM6cdcc516e96d: [native] Update createMainCompaction to use random backup keys (authored by bartek).
[native] Update createMainCompaction to use random backup keys
Mon, Jun 2, 7:04 AM
bartek closed D14796: [native] Pass generateBackupDataKey to Rust.
Mon, Jun 2, 7:04 AM
bartek committed rCOMMeaab174a6946: [native] Update Rust functions to use random backup keys (authored by bartek).
[native] Update Rust functions to use random backup keys
Mon, Jun 2, 7:04 AM
bartek committed rCOMMd853ccb7d92e: [native] Pass generateBackupDataKey to Rust (authored by bartek).
[native] Pass generateBackupDataKey to Rust
Mon, Jun 2, 7:04 AM
bartek updated the diff for D14798: [native] Update createMainCompaction to use random backup keys.

Apply refactor suggestion

Mon, Jun 2, 6:32 AM
bartek updated the diff for D14796: [native] Pass generateBackupDataKey to Rust.

Refactor

Mon, Jun 2, 6:20 AM
bartek published D14798: [native] Update createMainCompaction to use random backup keys for review.
Mon, Jun 2, 4:31 AM
bartek published D14797: [native] Update Rust functions to use random backup keys for review.
Mon, Jun 2, 4:31 AM
bartek published D14796: [native] Pass generateBackupDataKey to Rust for review.
Mon, Jun 2, 4:31 AM
bartek closed D14786: [native_rust_lib] Make backup upload handler thread safe.
Mon, Jun 2, 2:54 AM
bartek committed rCOMM4023ea9efdbc: [native_rust_lib] Make backup upload handler thread safe (authored by bartek).
[native_rust_lib] Make backup upload handler thread safe
Mon, Jun 2, 2:54 AM
bartek closed D14794: [native] Fix restore API call order.
Mon, Jun 2, 2:54 AM
bartek closed D14785: [native] Display appropriate alerts when restore fails.
Mon, Jun 2, 2:54 AM
bartek committed rCOMMd71667e6e8c7: [native] Display appropriate alerts when restore fails (authored by bartek).
[native] Display appropriate alerts when restore fails
Mon, Jun 2, 2:54 AM
bartek committed rCOMMd272f07869bc: [native] Fix restore API call order (authored by bartek).
[native] Fix restore API call order
Mon, Jun 2, 2:54 AM
bartek closed D14784: [native] Define alert messages for restoration errors.
Mon, Jun 2, 2:54 AM
bartek committed rCOMM7c30ca48536c: [native] Define alert messages for restoration errors (authored by bartek).
[native] Define alert messages for restoration errors
Mon, Jun 2, 2:54 AM
bartek published D14795: [native] Use AsyncMutex for logs for review.
Mon, Jun 2, 2:34 AM
bartek updated the diff for D14786: [native_rust_lib] Make backup upload handler thread safe.

Rebase, add suggested improvement

Mon, Jun 2, 2:27 AM
bartek accepted D14780: [lib] implement restored SQLite data migrations using JS.

Looks good to me, and given examples look reasonable too, but I'm not an expert in migrations

Mon, Jun 2, 2:23 AM
bartek accepted D14793: [native][web] deprecate `getSyncedDatabaseVersion`.
Mon, Jun 2, 2:18 AM
bartek accepted D14791: [lib] checking database and store version before restoring.
Mon, Jun 2, 2:12 AM
bartek accepted D14790: [lib][web] extract restoring user data to hook.
Mon, Jun 2, 2:10 AM
bartek accepted D14789: [lib][native][web] implement handler to sync store version.
Mon, Jun 2, 2:03 AM
bartek accepted D14788: [web] refactor code to get query executor.
Mon, Jun 2, 2:02 AM
bartek accepted D14787: [lib][native][web] implement getting `synced_metadata` entry.
Mon, Jun 2, 2:01 AM

Sat, May 31

bartek published D14794: [native] Fix restore API call order for review.
Sat, May 31, 1:15 AM

Fri, May 30

bartek accepted D14774: [native] set `latestDatabaseVersion` after uploading User Data.
Fri, May 30, 12:10 AM
bartek accepted D14772: [native] add `latestDatabaseVersion` to `BackupStore`.
Fri, May 30, 12:09 AM

Thu, May 29

bartek published D14786: [native_rust_lib] Make backup upload handler thread safe for review.
Thu, May 29, 7:33 AM
bartek added inline comments to D14773: [native] trigger User Data upload after schema change.
Thu, May 29, 2:55 AM
bartek accepted D14773: [native] trigger User Data upload after schema change.
Thu, May 29, 2:49 AM
bartek accepted D14770: [web][native] expose method to get database version.
Thu, May 29, 2:43 AM
bartek accepted D14768: [SQLite] implement `DatabaseQueryExecutor` method to get database version.
Thu, May 29, 2:41 AM
bartek published D14785: [native] Display appropriate alerts when restore fails for review.
Thu, May 29, 2:40 AM
bartek updated the diff for D14784: [native] Define alert messages for restoration errors.

Rebase

Thu, May 29, 2:02 AM
bartek updated the diff for D14784: [native] Define alert messages for restoration errors.

Fix typos

Thu, May 29, 1:44 AM
bartek closed D14779: [web][native] Display network error alert in QR flow.
Thu, May 29, 1:41 AM
bartek committed rCOMM4ea79a50c0b3: [web][native] Display network error alert in QR flow (authored by bartek).
[web][native] Display network error alert in QR flow
Thu, May 29, 1:41 AM
bartek closed D14778: [native] Display network error alert during restore flow.
Thu, May 29, 1:41 AM
bartek committed rCOMM182a40e017a7: [native] Display network error alert during restore flow (authored by bartek).
[native] Display network error alert during restore flow
Thu, May 29, 1:41 AM
bartek closed D14777: [web] Handle grpc-web network errors.
Thu, May 29, 1:41 AM
bartek committed rCOMMcc1ecabf91be: [web] Handle grpc-web network errors (authored by bartek).
[web] Handle grpc-web network errors
Thu, May 29, 1:41 AM
bartek closed D14776: [backup-client] Handle reqwest network errors.
Thu, May 29, 1:41 AM
bartek committed rCOMM7501e47fe51a: [backup-client] Handle reqwest network errors (authored by bartek).
[backup-client] Handle reqwest network errors
Thu, May 29, 1:41 AM