♟ bartek

If it works and/or looks nice, then:

- see why

Added a short description for the holder field

Updated validateAndConvert to accept a single object argument
Used serverCanHandleTypes to validate MIME type

Fix encryption_key -> encryptionKey

First of all, I'm sorry that my previous message sounds personal to you, I didn't mean it in any case.

It seems to work with all data URIs too!

In D7151#212209, @ashoat wrote:

Just tested and it looks like this solves rendering SVG data URIs for us!! I haven't tested other types, but PNG, JPEG, and SVG are all listed as supported in the docs. Thanks @bartek for the tip! This is way better than what I had planned to do on Android.

How do you obtain the SHA-256 fingerprint? From what I understood from the diff description, it is copy-pasted from Play Console, right?

The new ID looks correct

Use compareAndSet sicne it is safer and cleaner

[lib] Introduce combined padding interface

[lib] Introduce superblock padding

[lib] Introduce PKCS#7 padding

Besides nits, some considerations about promise handling.

pageSize is 1001 because I used the idea from https://mariadb.com/kb/en/pagination-optimization/ that is to fetch one more row than we intend to process.

[web] Add unit tests for AES functions

[web] Implement AES encryption functions

[native][AES] Implement encrypt function on Android

[native][AES] Implement decrypt function on iOS

[native][AES] Implement decrypt function on Android

[native][AES] Implement generateKey function

[native][AES] Implement encrypt function on iOS

[native] Create AESCrypto Expo module

Rebase before landing

Generally, the code itself looks good to me. But I have a general note regarding naming conventions.
I haven't seen all call sites yet (only the key generation diff is up) so I can't really tell but maybe it's worth revisiting the types and function arguments to have this as clean and consistent as possible.
In my diffs regarding AES encryption, I defined a few naming rules which I stick to (you can find them in this Notion doc). You can take inspiration from them.

[native] Remove network.json fallbacks

I'm going to leave both for now.

Revert accidental changes

Rebase
Added new tests

Rebase on new types
Address review feedback
- Used consistent naming for ciphertext, sealed data etc.

Address code review feedback

Regarding all naming issues (applies to the whole stack), I've created a Notion doc that clarifies the names

LGTM, Works with my changes. Thank you for taking care of this!

I'll add a test for the correct key, but the malformed ciphertext

Added web tests to .lintstagedrc and CI

[web] Fix missing WebCrypto mock in tests

bartek (Bartłomiej Klocek)
Animal

Projects

User Details

Recent Activity
View All

Yesterday

Fri, Mar 24

Thu, Mar 23

Wed, Mar 22

Tue, Mar 21

Mon, Mar 20

Thu, Mar 16

Wed, Mar 15

Tue, Mar 14

Mon, Mar 13

Sun, Mar 12

Fri, Mar 10

Thu, Mar 9

bartek (Bartłomiej Klocek)Animal