Page MenuHomePhabricator

bartek (Bartłomiej Klocek)
Animal

Projects

User does not belong to any projects.

User Details

User Since
Sep 30 2022, 5:22 AM (74 w, 3 d)

IMG_6395.JPG (537×680 px, 67 KB)
If it works and/or looks nice, then:
Ship it
- see why

Recent Activity

Fri, Feb 16

bartek closed D10862: [identity] Implement RPC for secondary device registration.
Fri, Feb 16, 6:26 AM
bartek closed D10865: [native] Expose LogInSecondaryDevice RPC to JS.
Fri, Feb 16, 6:26 AM
bartek closed D11073: [identity] Add types for Ed25519-signed nonce challenge.
Fri, Feb 16, 6:26 AM
bartek committed rCOMMc89026bc3b6d: [native] Expose LogInSecondaryDevice RPC to JS (authored by bartek).
[native] Expose LogInSecondaryDevice RPC to JS
Fri, Feb 16, 6:26 AM
bartek committed rCOMM12f4e8af8165: [identity] Implement RPC for secondary device registration (authored by bartek).
[identity] Implement RPC for secondary device registration
Fri, Feb 16, 6:26 AM
bartek committed rCOMM56be0a1c5e98: [identity] Add types for Ed25519-signed nonce challenge (authored by bartek).
[identity] Add types for Ed25519-signed nonce challenge
Fri, Feb 16, 6:26 AM
bartek closed D11072: [identity] Extract function to verify nonce.
Fri, Feb 16, 6:26 AM
bartek committed rCOMM71e367ae06b1: [identity] Extract function to verify nonce (authored by bartek).
[identity] Extract function to verify nonce
Fri, Feb 16, 6:26 AM
bartek closed D10861: [identity] Add RPC for secondary device login.
Fri, Feb 16, 6:26 AM
bartek committed rCOMMecaaf648a29c: [identity] Add RPC for secondary device login (authored by bartek).
[identity] Add RPC for secondary device login
Fri, Feb 16, 6:26 AM
bartek closed D11037: [native] Add Olm account sign function to commCoreModule.
Fri, Feb 16, 6:26 AM
bartek committed rCOMM7c81d7e5dcda: [native] Add Olm account sign function to commCoreModule (authored by bartek).
[native] Add Olm account sign function to commCoreModule
Fri, Feb 16, 6:26 AM
bartek added inline comments to D11073: [identity] Add types for Ed25519-signed nonce challenge.
Fri, Feb 16, 6:23 AM
bartek updated the diff for D10865: [native] Expose LogInSecondaryDevice RPC to JS.

Rebase on AuthResponse

Fri, Feb 16, 2:11 AM
bartek updated the diff for D10862: [identity] Implement RPC for secondary device registration.

Rebase. Remove unnecessary comments

Fri, Feb 16, 2:11 AM
bartek updated the diff for D10861: [identity] Add RPC for secondary device login.

Rebase on AuthResponse

Fri, Feb 16, 2:11 AM

Thu, Feb 15

bartek updated the diff for D11037: [native] Add Olm account sign function to commCoreModule.

Address feedback

Thu, Feb 15, 11:19 PM
bartek accepted D11101: [services] tidy up our identity service code.
Thu, Feb 15, 10:31 PM
bartek accepted D11079: [lib][native] rename registerUser -> registerPasswordUser.
Thu, Feb 15, 10:27 PM
bartek accepted D11078: [identity] introduce RegisterWalletUser RPC.
Thu, Feb 15, 10:26 PM
bartek accepted D11098: [native] add findUserIDForWalletAddress to CommRustModule.

Makes sense to me. We can easily refactor this in the future when we find a better way of passing enums JS -> C++ -> Rust

Thu, Feb 15, 10:23 PM
bartek accepted D11081: [native] add CommRustModule bindings for registerWalletUser.
Thu, Feb 15, 10:11 PM
bartek accepted D11080: [native_rust_library] add register_wallet_user function.
Thu, Feb 15, 10:10 PM
bartek added inline comments to D11073: [identity] Add types for Ed25519-signed nonce challenge.
Thu, Feb 15, 10:08 PM
bartek requested review of D11073: [identity] Add types for Ed25519-signed nonce challenge.
Thu, Feb 15, 9:53 PM

Wed, Feb 14

bartek published D11073: [identity] Add types for Ed25519-signed nonce challenge for review.
Wed, Feb 14, 4:56 AM
bartek published D11072: [identity] Extract function to verify nonce for review.
Wed, Feb 14, 4:52 AM
bartek updated the diff for D10862: [identity] Implement RPC for secondary device registration.

Update on parent feedback, introduce nonce challenge

Wed, Feb 14, 4:47 AM
bartek retitled D10862: [identity] Implement RPC for secondary device registration from [identity] Implement RPC for secondary device login to [identity] Implement RPC for secondary device registration.
Wed, Feb 14, 4:44 AM
bartek added inline comments to D11037: [native] Add Olm account sign function to commCoreModule.
Wed, Feb 14, 3:21 AM
bartek accepted D11062: [identity] rename LogInReservedWalletUser -> RegisterReservedWalletUser.
Wed, Feb 14, 2:19 AM
bartek accepted D11061: [identity] Merge Identity auth response messages.

Thanks for doing this!

Wed, Feb 14, 2:19 AM
bartek accepted D11052: [identity] move findUserID to unauth proto.
Wed, Feb 14, 2:16 AM

Tue, Feb 13

bartek accepted D11051: [services] Move reserved_usernames to `shared`.
Tue, Feb 13, 8:42 AM
bartek accepted D10973: [lib] Check for previous auth message and websocket connection state in identity search context provider.
Tue, Feb 13, 6:01 AM
bartek added inline comments to D11046: Introduce MMKV to Android app.
Tue, Feb 13, 5:50 AM
bartek accepted D11015: [blob] Block reserved and offensive links from being created.
Tue, Feb 13, 5:14 AM
bartek accepted D11039: [backup] Move authentication inside of the websocket.
Tue, Feb 13, 5:14 AM

Mon, Feb 12

bartek closed D11028: [terraform] Remove is-dev conditionals for DDB tables.
Mon, Feb 12, 8:20 AM
bartek committed rCOMMe4c8ec1585a4: [terraform] Remove is-dev conditionals for DDB tables (authored by bartek).
[terraform] Remove is-dev conditionals for DDB tables
Mon, Feb 12, 8:20 AM
bartek published D11037: [native] Add Olm account sign function to commCoreModule for review.
Mon, Feb 12, 6:48 AM
bartek closed D10864: [native] Expose UpdateDeviceList RPC to JS.
Mon, Feb 12, 1:26 AM
bartek closed D10863: [native] Expose GetDeviceListForUser RPC to JS.
Mon, Feb 12, 1:26 AM
bartek committed rCOMM82adcac2f329: [native] Expose UpdateDeviceList RPC to JS (authored by bartek).
[native] Expose UpdateDeviceList RPC to JS
Mon, Feb 12, 1:26 AM
bartek closed D10800: [commtest] Add test for UpdateDeviceList RPC.
Mon, Feb 12, 1:26 AM
bartek committed rCOMMcf34b3be50be: [native] Expose GetDeviceListForUser RPC to JS (authored by bartek).
[native] Expose GetDeviceListForUser RPC to JS
Mon, Feb 12, 1:26 AM
bartek committed rCOMMee22cca2ef6c: [commtest] Add test for UpdateDeviceList RPC (authored by bartek).
[commtest] Add test for UpdateDeviceList RPC
Mon, Feb 12, 1:26 AM
bartek closed D10799: [identity] Basic implementation of UpdateDeviceList RPC.
Mon, Feb 12, 1:26 AM
bartek committed rCOMMa25f5283e44f: [identity] Basic implementation of UpdateDeviceList RPC (authored by bartek).
[identity] Basic implementation of UpdateDeviceList RPC
Mon, Feb 12, 1:26 AM
bartek closed D10798: [identity] Make device list transactions more flexible.
Mon, Feb 12, 1:26 AM
bartek committed rCOMM0c4a9659cd41: [identity] Make device list transactions more flexible (authored by bartek).
[identity] Make device list transactions more flexible
Mon, Feb 12, 1:26 AM
bartek closed D10797: [identity] Scaffold RPC for device list updates.
Mon, Feb 12, 1:26 AM
bartek committed rCOMMcd0064f44b2c: [identity] Scaffold RPC for device list updates (authored by bartek).
[identity] Scaffold RPC for device list updates
Mon, Feb 12, 1:26 AM
bartek updated the diff for D10864: [native] Expose UpdateDeviceList RPC to JS.

Rebase before landing

Mon, Feb 12, 1:00 AM
bartek added inline comments to D11015: [blob] Block reserved and offensive links from being created.
Mon, Feb 12, 12:54 AM
bartek published D11028: [terraform] Remove is-dev conditionals for DDB tables for review.
Mon, Feb 12, 12:28 AM

Fri, Feb 9

bartek accepted D10986: [backup client] Downloading logs.

The download_logs() and log_download_stream() logic is unobvious at first glance but after offline discussions, I think they work as expected.

Fri, Feb 9, 7:52 AM
bartek accepted D10985: [backup client] Refactor ws creation.
Fri, Feb 9, 7:27 AM
bartek accepted D10984: [backup client] Merge errors.
Fri, Feb 9, 7:25 AM
bartek accepted D11004: [dev env] add toolchain file.
Fri, Feb 9, 2:27 AM

Thu, Feb 8

bartek closed D10931: [lib][native] Pass CSAT to Reports endpoint.
Thu, Feb 8, 7:57 AM
bartek committed rCOMM231413600c8d: [lib][native] Pass CSAT to Reports endpoint (authored by bartek).
[lib][native] Pass CSAT to Reports endpoint
Thu, Feb 8, 7:57 AM
bartek closed D10930: [lib] Add optional Authorization header to reports endpoint.
Thu, Feb 8, 7:57 AM
bartek committed rCOMMe9f3781d057f: [lib] Add optional Authorization header to reports endpoint (authored by bartek).
[lib] Add optional Authorization header to reports endpoint
Thu, Feb 8, 7:57 AM
bartek closed D10913: [native][web] Add AuthMetadata to Blob service upload actions.
Thu, Feb 8, 7:57 AM
bartek closed D10912: [web] Pass CSAT to Blob service when fetching multimedia.
Thu, Feb 8, 7:57 AM
bartek committed rCOMM41e4177c4707: [native][web] Add AuthMetadata to Blob service upload actions (authored by bartek).
[native][web] Add AuthMetadata to Blob service upload actions
Thu, Feb 8, 7:57 AM
bartek committed rCOMMb30526643bde: [web] Pass CSAT to Blob service when fetching multimedia (authored by bartek).
[web] Pass CSAT to Blob service when fetching multimedia
Thu, Feb 8, 7:57 AM
bartek closed D10910: [native] Pass CSAT to Blob service when fetching multimedia.
Thu, Feb 8, 7:57 AM
bartek committed rCOMMbda5c6e24f8e: [native] Pass CSAT to Blob service when fetching multimedia (authored by bartek).
[native] Pass CSAT to Blob service when fetching multimedia
Thu, Feb 8, 7:57 AM
bartek updated the diff for D10931: [lib][native] Pass CSAT to Reports endpoint.
  • Used hook abstraction as proposed
  • Used direct commCoreModule call in crash component
Thu, Feb 8, 5:54 AM
bartek added inline comments to D10931: [lib][native] Pass CSAT to Reports endpoint.
Thu, Feb 8, 5:51 AM
bartek updated the diff for D10913: [native][web] Add AuthMetadata to Blob service upload actions.

Simplified approach - moved identity context into useBlobServiceUpload hook

Thu, Feb 8, 5:09 AM
bartek accepted D10858: [native] Notify backup uploader after compaction creation.
Thu, Feb 8, 4:47 AM

Wed, Feb 7

bartek updated the diff for D10912: [web] Pass CSAT to Blob service when fetching multimedia.

Add hook for fetchAndDecryptMedia

Wed, Feb 7, 4:37 AM
bartek updated the diff for D10910: [native] Pass CSAT to Blob service when fetching multimedia.

Add hook for fetchAndDecryptMedia

Wed, Feb 7, 4:05 AM
bartek added inline comments to D10910: [native] Pass CSAT to Blob service when fetching multimedia.
Wed, Feb 7, 4:05 AM
bartek added inline comments to D10861: [identity] Add RPC for secondary device login.
Wed, Feb 7, 2:39 AM
bartek accepted D9966: [keyserver] Add a function that deletes a blob.
Wed, Feb 7, 2:05 AM
bartek closed D10908: [keyserver] Authorize blob service requests.
Wed, Feb 7, 2:00 AM
bartek committed rCOMMc98884624359: [keyserver] Authorize blob service requests (authored by bartek).
[keyserver] Authorize blob service requests
Wed, Feb 7, 2:00 AM
bartek closed D10929: [lib] Add function to create HTTP Authorization header.
Wed, Feb 7, 1:59 AM
bartek committed rCOMM73ff928c9e0a: [lib] Add function to create HTTP Authorization header (authored by bartek).
[lib] Add function to create HTTP Authorization header
Wed, Feb 7, 1:59 AM
bartek added a comment to D10929: [lib] Add function to create HTTP Authorization header.

Makes sense. I suppose we could use native implementations in some places (eg. Node.js), but not sure it matters too much for performance.

Wed, Feb 7, 1:54 AM
bartek closed D10907: [web][native] Rename decryptMedia to fetchAndDecryptMedia.
Wed, Feb 7, 1:35 AM
bartek committed rCOMM887894201f17: [web][native] Rename decryptMedia to fetchAndDecryptMedia (authored by bartek).
[web][native] Rename decryptMedia to fetchAndDecryptMedia
Wed, Feb 7, 1:35 AM
bartek closed D10932: [reports] Always create AuthorizationCredential directly.
Wed, Feb 7, 1:35 AM
bartek committed rCOMM38451e4cef66: [reports] Always create AuthorizationCredential directly (authored by bartek).
[reports] Always create AuthorizationCredential directly
Wed, Feb 7, 1:35 AM
bartek updated the diff for D10932: [reports] Always create AuthorizationCredential directly.

Update comment

Wed, Feb 7, 1:32 AM
bartek accepted D10980: [identity] [shared] Change search query enum to struct and introduce search method enum.
Wed, Feb 7, 1:15 AM
bartek accepted D10338: [web][native] Download invite link blob and use it as an override.
Wed, Feb 7, 1:14 AM

Tue, Feb 6

bartek accepted D10205: [keyserver] Add a function that synchronizes keyserver's invite links with blobs.
Tue, Feb 6, 2:42 AM
bartek updated the diff for D10913: [native][web] Add AuthMetadata to Blob service upload actions.

Address feedback

Tue, Feb 6, 2:40 AM
bartek added inline comments to D10913: [native][web] Add AuthMetadata to Blob service upload actions.
Tue, Feb 6, 2:40 AM

Mon, Feb 5

bartek added a comment to D10837: Implement attachments capture.

I'm asking if the uri field might contain something for old-style uploads, that we want to skip.

Mon, Feb 5, 7:03 AM
bartek updated the diff for D10864: [native] Expose UpdateDeviceList RPC to JS.

Rebase on fix

Mon, Feb 5, 5:19 AM
bartek updated the diff for D10861: [identity] Add RPC for secondary device login.

Fix flow

Mon, Feb 5, 5:19 AM
bartek planned changes to D10861: [identity] Add RPC for secondary device login.
Mon, Feb 5, 5:13 AM
bartek added inline comments to D10861: [identity] Add RPC for secondary device login.
Mon, Feb 5, 5:08 AM
bartek updated the diff for D10864: [native] Expose UpdateDeviceList RPC to JS.

Rebase on fix

Mon, Feb 5, 4:59 AM