- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Today
Today
bartek committed rCOMMe69f415a5bd8: [identity] Allow UpdateDeviceList RPC to remove devices (authored by bartek).
[identity] Allow UpdateDeviceList RPC to remove devices
bartek committed rCOMM1c6533aa4886: [identity] Extract device list verification to separate func (authored by bartek).
[identity] Extract device list verification to separate func
bartek committed rCOMM34d9d1efac30: [identity] Add device list timestamp verification (authored by bartek).
[identity] Add device list timestamp verification
Address feedback
Yesterday
Yesterday
As a follow-up, we probably want to extract this logic to comm-lib because finally I'd love to see all services using JSON logs in AWS
bartek requested changes to D11735: Introduce new JSI call to retrieve backup message for latest siwe backup.
bartek accepted D11734: Introduce 'msgBackup' field to 'OrderedBackupItem' and 'LatestBackupIDResponse'.
Logic looks good, just some code-style comments
Looks good, let me know when you'll be landing this, so we can do terraform apply together
The limit logic inside get_one_time_keys could be a bit simplified but it's not worth spending time on it
Mon, Apr 22
Mon, Apr 22
Mostly looks good. Left a few suggestions
[terraform] Update staging identity
bartek committed rCOMM329bec06ca9a: [identity] Temporarily revert wallet user check (authored by bartek).
[identity] Temporarily revert wallet user check
Fri, Apr 19
Fri, Apr 19
bartek accepted D11695: [identity] remove OTKs in chronological order to make sure there are never more than 100 keys per olm account.
Nice!
Thu, Apr 18
Thu, Apr 18
Theoretically, we should check if partition and sort key exist (because the otk attribute is present for all rows) but technically, this way also works - the "otk" attribute won't exist for non-existing row (implies non-existing primary key)
Awesome, thanks!
Mon, Apr 15
Mon, Apr 15
bartek committed rCOMMa8ad5e68ca0f: [protos][identity] Add RPC for fetching multiple device lists (authored by bartek).
[protos][identity] Add RPC for fetching multiple device lists
bartek committed rCOMMecd0073aef88: [protos] Replace challengeResponse with nonce and signature pair (authored by bartek).
[protos] Replace challengeResponse with nonce and signature pair
bartek committed rCOMM5aed2ee33018: [identity] Store social proof as a Map in DDB (authored by bartek).
[identity] Store social proof as a Map in DDB
bartek committed rCOMMe7f9f1ef90fb: [protos] Remove social_proof from IdentityKeyInfo (authored by bartek).
[protos] Remove social_proof from IdentityKeyInfo
bartek committed rCOMM883fffc6adc1: [protos] Refactor user Identity message type (authored by bartek).
[protos] Refactor user Identity message type
Fri, Apr 12
Fri, Apr 12
Rebase before landing, fix comment in proto
Rebase, Rename variable
bartek added inline comments to D11551: [protos] Replace challengeResponse with nonce and signature pair.
Tue, Apr 9
Tue, Apr 9
Mon, Apr 8
Mon, Apr 8
bartek added inline comments to D11570: [protos][identity] Add RPC for fetching multiple device lists.
bartek committed rCOMMd8727804c52e: [protos][identity] Make keyserver_info response non-optional (authored by bartek).
[protos][identity] Make keyserver_info response non-optional
bartek committed rCOMMa975e16c018e: [commtest] Add test for LogInExistingDevice RPC (authored by bartek).
[commtest] Add test for LogInExistingDevice RPC
bartek committed rCOMMbf3170431861: [commtest] Add helpers for ED25519 signing messages (authored by bartek).
[commtest] Add helpers for ED25519 signing messages
bartek removed 1 blocking reviewer(s) for D11468: [commtest] Add test for LogInExistingDevice RPC: varun.
Address feedback
Sun, Apr 7
Sun, Apr 7
Thu, Apr 4
Thu, Apr 4
bartek published D11551: [protos] Replace challengeResponse with nonce and signature pair for review.
bartek committed rCOMM173f8128076f: [protos][identity] Add primary device keys to GetKeyserverKeys response (authored by bartek).
[protos][identity] Add primary device keys to GetKeyserverKeys response
bartek committed rCOMM0b089eaf031e: [native_rust_library] Cleanup remaining APIs (authored by bartek).
[native_rust_library] Cleanup remaining APIs
bartek committed rCOMMcb1f87b40755: [native_rust_library] Move device list APIs to submodule (authored by bartek).
[native_rust_library] Move device list APIs to submodule
bartek committed rCOMM931fedbabf67: [native_rust_library] Move account actions to submodule (authored by bartek).
[native_rust_library] Move account actions to submodule
bartek committed rCOMMb14ea1a6766b: [native_rust_library] Move X3DH APIs to submodule (authored by bartek).
[native_rust_library] Move X3DH APIs to submodule
bartek committed rCOMM6e5fec83981f: [native_rust_library] Move login APIs to submodule (authored by bartek).
[native_rust_library] Move login APIs to submodule
bartek committed rCOMM8424533212fb: [native_rust_library] Move password registration to submodule (authored by bartek).
[native_rust_library] Move password registration to submodule
bartek committed rCOMM8e5f464cc6ac: [native_rust_library] Create ffi submodules for identity API (authored by bartek).
[native_rust_library] Create ffi submodules for identity API
bartek committed rCOMMbe9a4f0c6862: [native_rust_library] Create identity submodule (authored by bartek).
[native_rust_library] Create identity submodule
bartek committed rCOMMd1b8579ff9e8: [native_rust_library] Extract utils module (authored by bartek).
[native_rust_library] Extract utils module
In D11524#331968, @varun wrote:in your testing were you able to see Rust logs in Xcode or your terminal? noticed we have #[instrument] for some functions in this library but i don't think we configure tracing anywhere...
Rebase before landing
[CI] Use Docker Compose v2 in GH Actions
bartek added a reviewer for D11468: [commtest] Add test for LogInExistingDevice RPC: kamil. bartek added 1 blocking reviewer(s) for D11468: [commtest] Add test for LogInExistingDevice RPC: varun.