Paths

Table of Contentst

[backup-client] refactor `SIWEBackupData` type
Needs ReviewPublic
Actions

Authored by kamil on Thu, Oct 31, 4:44 AM.

Details

Reviewers

varun
bartek

Summary

ENG-6145.

Move retrieving SIWEBackupData to a util funtion - it will be needed later in the stack
Move types to proper places on JS side
Add comment keep types in sync
Add validation on JS side
Remove siwe_backup_msg - it's not needed

Test Plan

Test backup restore for Wallet user

Diff Detail

Repository

rCOMM Comm

Branch

backup-work-4

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Thu, Oct 31, 4:44 AM

kamil held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptThu, Oct 31, 4:44 AM

kamil mentioned this in D13837: [native_rust_library] implement method to retrieve latest backup info.Thu, Oct 31, 5:00 AM

Harbormaster completed remote builds in B32465: Diff 45498.Thu, Oct 31, 5:02 AM

kamil added a child revision: D13837: [native_rust_library] implement method to retrieve latest backup info.Thu, Oct 31, 5:08 AM

kamil published this revision for review.Thu, Oct 31, 8:46 AM

kamil added inline comments.

lib/types/backup-types.js
24	This is not needed, it's removed in D13850 to make CI pass

Revision Contents
Changeset List

Path

Size

lib/

types/

backup-types.js

16 lines

native/

backup/

use-client-backup.js

21 lines

native_rust_library/

src/

backup.rs

74 lines

Diff 45498

View Options

lib/types/backup-types.js

View Options

native/backup/use-client-backup.js

View Options

native/native_rust_library/src/backup.rs

[backup-client] refactor `SIWEBackupData` typeNeeds ReviewPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 45498

lib/types/backup-types.js

native/backup/use-client-backup.js

native/native_rust_library/src/backup.rs

[backup-client] refactor `SIWEBackupData` type
Needs ReviewPublic
Actions

Revision Contents
Changeset List