Paths

Table of Contentst

Differential D13836

[backup-client] refactor `SIWEBackupData` type
ClosedPublic
Actions

Authored by kamil on Oct 31 2024, 4:44 AM.

Tags

None

Referenced Files

	F3513335: D13836.id45667.diff
	Sat, Dec 21, 11:34 PM

	F3513334: D13836.id45651.diff
	Sat, Dec 21, 11:34 PM

	F3513333: D13836.id45498.diff
	Sat, Dec 21, 11:34 PM

	F3513301: D13836.id.diff
	Sat, Dec 21, 11:34 PM

	F3513282: D13836.diff
	Sat, Dec 21, 11:33 PM

	Unknown Object (File)
	Mon, Dec 2, 1:17 PM

	Unknown Object (File)
	Mon, Dec 2, 1:57 AM

	Unknown Object (File)
	Sun, Dec 1, 12:03 PM

View All 34 Files

Subscribers

Details

Reviewers

varun
bartek

Commits

rCOMM3aff4e035708: [backup-client] refactor `SIWEBackupData` type

Summary

Move retrieving SIWEBackupData to a util funtion - it will be needed later in the stack
Move types to proper places on JS side
Add comment keep types in sync
Add validation on JS side
Remove siwe_backup_msg - it's not needed

Test Plan

Test backup restore for Wallet user

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Oct 31 2024, 4:44 AM

kamil held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptOct 31 2024, 4:44 AM

kamil mentioned this in D13837: [native_rust_library] implement method to retrieve latest backup info.Oct 31 2024, 5:00 AM

Harbormaster completed remote builds in B32465: Diff 45498.Oct 31 2024, 5:02 AM

kamil added a child revision: D13837: [native_rust_library] implement method to retrieve latest backup info.Oct 31 2024, 5:08 AM

kamil published this revision for review.Oct 31 2024, 8:46 AM

kamil added inline comments.

lib/types/backup-types.js
24 ↗	(On Diff #45498)	This is not needed, it's removed in D13850 to make CI pass

bartek accepted this revision.Nov 4 2024, 11:20 PM

bartek added inline comments.

native/native_rust_library/src/backup.rs
253–272 ↗	(On Diff #45498)	Nit: to avoid nested `match` you could use `let-else` to unwrap `Some(siwe_backup_msg_value)` and then the inner `match get_siwe_backup_data_from_msg()` would not be nested

This revision is now accepted and ready to land.Nov 4 2024, 11:20 PM

address nit

Harbormaster failed remote builds in B32565: Diff 45651!Nov 7 2024, 2:03 AM

Harbormaster completed remote builds in B32565: Diff 45651.Nov 7 2024, 2:31 AM

Closed by commit rCOMM3aff4e035708: [backup-client] refactor `SIWEBackupData` type (authored by kamil). · Explain WhyNov 7 2024, 4:07 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM3aff4e035708: [backup-client] refactor `SIWEBackupData` type.

kamil mentioned this in rCOMM532c51fae374: [native_rust_library] implement method to retrieve latest backup info.

Revision Contents
Changeset List

Path

Size

lib/

types/

backup-types.js

16 lines

native/

backup/

use-client-backup.js

21 lines

native_rust_library/

src/

86 lines

Diff 45667

lib/types/backup-types.js

Loading...

native/backup/use-client-backup.js

Loading...

native/native_rust_library/src/backup.rs

Loading...