Paths

Table of Contentst

Differential D13879

[backup-service][commtest] implement integration tests for uploading User Keys and User Data separately
Needs ReviewPublic
Actions

Authored by kamil on Tue, Nov 5, 9:12 AM.

Tags

None

Referenced Files

	F3163715: D13879.id45638.diff
	Wed, Nov 6, 3:24 PM

	F3163714: D13879.id45636.diff
	Wed, Nov 6, 3:24 PM

	F3163713: D13879.id45614.diff
	Wed, Nov 6, 3:24 PM

	F3163712: D13879.id45635.diff
	Wed, Nov 6, 3:24 PM

	F3163702: D13879.id.diff
	Wed, Nov 6, 3:24 PM

	F3163682: D13879.diff
	Wed, Nov 6, 3:23 PM

Subscribers

Details

Reviewers

varun
bartek
tomek
angelika

Summary

Part of ENG-9673.

Tracked in ENG-9650.

I think I covered most of the cases, this is described in the code comments.

The endpoint to upload both User Keys and User Data at once is tested in backup_integration_test.

If anyone has any ideas about what test case can be added, I would be happy to do it.

Depends on D13878

Test Plan

Run tests

Diff Detail

Repository

Branch

backup-work-6

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Tue, Nov 5, 9:12 AM

kamil held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptTue, Nov 5, 9:12 AM

kamil mentioned this in D13876: [backup-service] implement endpoint to upload User Keys.Tue, Nov 5, 9:16 AM

kamil mentioned this in D13877: [backup-service] implement endpoint to upload User Data.

kamil mentioned this in D13878: [backup-service] make `user_data` and `user_keys` optional in `BackupData`.

Harbormaster failed remote builds in B32546: Diff 45614!Tue, Nov 5, 9:36 AM

rebase

kamil mentioned this in D13875: [backup-service] make `user_data` optional in `BackupItem`.Wed, Nov 6, 3:34 AM

kamil edited the summary of this revision. (Show Details)Wed, Nov 6, 3:47 AM

kamil added reviewers: tomek, angelika.

Harbormaster failed remote builds in B32558: Diff 45635!Wed, Nov 6, 4:00 AM

fix running tests at once

fix conversion

Harbormaster failed remote builds in B32559: Diff 45636!Wed, Nov 6, 4:31 AM

Harbormaster completed remote builds in B32560: Diff 45638.Wed, Nov 6, 4:48 AM

Adding more reviewers here - maybe there is more edge-cases that worth testing too

services/commtest/tests/backup_upload_test.rs
69–79 ↗	(On Diff #45635)	we can additionally check here if `new_backup_data` could be downloaded but probably not worth it, as it's covered in the test below too
83–116 ↗	(On Diff #45635)	Here, I additionally checked if holders on the Blob service are managed correctly

Revision Contents
Changeset List

Path

Size

services/

commtest/

src/

backup/

backup_utils.rs

7 lines

tests/

backup_performance_test.rs

2 lines

backup_upload_test.rs

278 lines

Diff 45638

services/commtest/src/backup/backup_utils.rs

Loading...

services/commtest/tests/backup_performance_test.rs

Loading...

services/commtest/tests/backup_upload_test.rs

Loading...