Page MenuHomePhabricator
Differential D13809

[backup-service][backup-client] update `/latest` endpoint to return both `backupID` and `userID`
ClosedPublic
Actions

Authored by kamil on Oct 29 2024, 9:28 AM.
Tags
None
Referenced Files
F3513332: D13809.id45666.diff
Sat, Dec 21, 11:34 PM
F3513331: D13809.id45605.diff
Sat, Dec 21, 11:34 PM
F3513330: D13809.id45458.diff
Sat, Dec 21, 11:34 PM
F3513329: D13809.id45431.diff
Sat, Dec 21, 11:34 PM
F3513298: D13809.id.diff
Sat, Dec 21, 11:34 PM
F3513283: D13809.diff
Sat, Dec 21, 11:33 PM
Unknown Object (File)
Thu, Nov 28, 5:54 AM
Unknown Object (File)
Wed, Nov 27, 4:09 AM
View All 42 Files
Subscribers
ashoat
tomek

Details

Reviewers
varun
bartek
Commits
rCOMM8f72e02e2b90: [backup-service][backup-client] update `/latest` endpoint to return both…
Summary

ENG-6145.

We need this to return userID too.
Renaming path and following types to make it more readable.

Depends on D13808

Test Plan

run commtest

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Oct 29 2024, 9:28 AM
kamil held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptOct 29 2024, 9:28 AM
Harbormaster failed remote builds in B32408: Diff 45431!Oct 29 2024, 9:55 AM
kamil added inline comments.Oct 30 2024, 3:35 AM
native/native_rust_library/src/backup.rs
329 ↗(On Diff #45431)

this is going to be updated later as part of Native changes for minimal version of backup

kamil updated this revision to Diff 45458.Oct 30 2024, 3:50 AM

rebase

Harbormaster completed remote builds in B32431: Diff 45458.Oct 30 2024, 4:08 AM
kamil published this revision for review.Oct 30 2024, 9:29 AM
kamil added a child revision: D13839: [native] make it possible to test retrieving latest backup info.Oct 31 2024, 5:24 AM
bartek accepted this revision.Nov 4 2024, 5:01 AM

Neat idea with this rename to backup info

This revision is now accepted and ready to land.Nov 4 2024, 5:01 AM
kamil updated this revision to Diff 45605.Nov 5 2024, 4:21 AM

rebase

Harbormaster completed remote builds in B32537: Diff 45605.Nov 5 2024, 4:51 AM
kamil added a child revision: D13872: [commtest] refactor backup service integration tests.Nov 5 2024, 6:06 AM
Closed by commit rCOMM8f72e02e2b90: [backup-service][backup-client] update `/latest` endpoint to return both… (authored by kamil). · Explain WhyNov 7 2024, 4:07 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM8f72e02e2b90: [backup-service][backup-client] update `/latest` endpoint to return both….

Revision Contents
Changeset List

PathSize
native/
native_rust_library/
src/
19 lines
services/
backup/
src/
http/
handlers/
7 lines
4 lines
commtest/
tests/
13 lines
6 lines
shared/
backup_client/
src/
6 lines
comm-lib/
src/
backup/
5 lines

Diff 45666

View Options

native/native_rust_library/src/backup.rs

Loading...
View Options

services/backup/src/http/handlers/backup.rs

Loading...
View Options

services/backup/src/http/mod.rs

Loading...
View Options

services/commtest/tests/backup_integration_test.rs

Loading...
View Options

services/commtest/tests/backup_performance_test.rs

Loading...
View Options

shared/backup_client/src/lib.rs

Loading...
View Options

shared/comm-lib/src/backup/mod.rs

Loading...