Page MenuHomePhabricator
Differential D13846

[CommCoreModule][native_rust_library] deprecate SIWE related backup code
ClosedPublic
Actions

Authored by kamil on Oct 31 2024, 8:10 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 19, 2:11 AM
Unknown Object (File)
Fri, Apr 18, 9:46 PM
Unknown Object (File)
Fri, Apr 18, 8:38 PM
Unknown Object (File)
Fri, Apr 18, 10:26 AM
Unknown Object (File)
Fri, Apr 11, 12:02 PM
Unknown Object (File)
Wed, Apr 9, 3:49 AM
Unknown Object (File)
Wed, Apr 2, 4:42 AM
Unknown Object (File)
Mar 19 2025, 9:32 PM
View All 48 Files
Subscribers
ashoat
tomek

Details

Reviewers
varun
bartek
Commits
rCOMM0504d518f7f1: [CommCoreModule][native_rust_library] deprecate SIWE related backup code
Summary

ENG-6145.

In the past logic was diverged, it shouldn't be - for C++/Rust we should just use backup with secret (no matter if this is a secret from password or wallet signature)

Depends on D13844

Test Plan

N/A, removing dead code

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
NativeModules/
11 lines
48 lines
_generated/
native_rust_library/
src/
43 lines
3 lines
schema/
6 lines

Diff 45673

View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.h

Show First 20 Lines • Show All 217 Lines • ▼ Show 20 Lines return createPromiseAsJSIValue(
jsiStringToRustString(accessToken, innerRt), jsiStringToRustString(accessToken, innerRt),
currentID); currentID);
} catch (const std::exception &e) { } catch (const std::exception &e) {
error = e.what(); error = e.what();
}; };
}); });
} }
jsi::Value CommRustModule::getOutboundKeysForUserDevice( jsi::Value CommRustModule::getOutboundKeysForUser(
jsi::Runtime &rt, jsi::Runtime &rt,
jsi::String authUserID, jsi::String authUserID,
jsi::String authDeviceID, jsi::String authDeviceID,
jsi::String authAccessToken, jsi::String authAccessToken,
jsi::String userID, jsi::String userID) {
jsi::String deviceID) {
return createPromiseAsJSIValue( return createPromiseAsJSIValue(
rt, [&, this](jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) { rt, [&, this](jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) {
std::string error; std::string error;
try { try {
auto currentID = RustPromiseManager::instance.addPromise( auto currentID = RustPromiseManager::instance.addPromise(
promise, this->jsInvoker_, innerRt); promise, this->jsInvoker_, innerRt);
identityGetOutboundKeysForUserDevice( identityGetOutboundKeysForUser(
jsiStringToRustString(authUserID, innerRt), jsiStringToRustString(authUserID, innerRt),
jsiStringToRustString(authDeviceID, innerRt), jsiStringToRustString(authDeviceID, innerRt),
jsiStringToRustString(authAccessToken, innerRt), jsiStringToRustString(authAccessToken, innerRt),
jsiStringToRustString(userID, innerRt), jsiStringToRustString(userID, innerRt),
jsiStringToRustString(deviceID, innerRt),
currentID); currentID);
} catch (const std::exception &e) { } catch (const std::exception &e) {
error = e.what(); error = e.what();
}; };
}); });
} }
jsi::Value CommRustModule::versionSupported(jsi::Runtime &rt) { jsi::Value CommRustModule::versionSupported(jsi::Runtime &rt) {
Show All 14 Lines
View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

Show First 20 Lines • Show All 217 Lines • ▼ Show 20 Lines return createPromiseAsJSIValue(
jsiStringToRustString(accessToken, innerRt), jsiStringToRustString(accessToken, innerRt),
currentID); currentID);
} catch (const std::exception &e) { } catch (const std::exception &e) {
error = e.what(); error = e.what();
}; };
}); });
} }
jsi::Value CommRustModule::getOutboundKeysForUserDevice( jsi::Value CommRustModule::getOutboundKeysForUser(
jsi::Runtime &rt, jsi::Runtime &rt,
jsi::String authUserID, jsi::String authUserID,
jsi::String authDeviceID, jsi::String authDeviceID,
jsi::String authAccessToken, jsi::String authAccessToken,
jsi::String userID, jsi::String userID) {
jsi::String deviceID) {
return createPromiseAsJSIValue( return createPromiseAsJSIValue(
rt, [&, this](jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) { rt, [&, this](jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) {
std::string error; std::string error;
try { try {
auto currentID = RustPromiseManager::instance.addPromise( auto currentID = RustPromiseManager::instance.addPromise(
promise, this->jsInvoker_, innerRt); promise, this->jsInvoker_, innerRt);
identityGetOutboundKeysForUserDevice( identityGetOutboundKeysForUser(
jsiStringToRustString(authUserID, innerRt), jsiStringToRustString(authUserID, innerRt),
jsiStringToRustString(authDeviceID, innerRt), jsiStringToRustString(authDeviceID, innerRt),
jsiStringToRustString(authAccessToken, innerRt), jsiStringToRustString(authAccessToken, innerRt),
jsiStringToRustString(userID, innerRt), jsiStringToRustString(userID, innerRt),
jsiStringToRustString(deviceID, innerRt),
currentID); currentID);
} catch (const std::exception &e) { } catch (const std::exception &e) {
error = e.what(); error = e.what();
}; };
}); });
} }
jsi::Value CommRustModule::versionSupported(jsi::Runtime &rt) { jsi::Value CommRustModule::versionSupported(jsi::Runtime &rt) {
Show All 14 Lines
View Options

native/cpp/CommonCpp/_generated/commJSI-generated.cpp

Show First 20 Lines • Show All 217 Lines • ▼ Show 20 Lines return createPromiseAsJSIValue(
jsiStringToRustString(accessToken, innerRt), jsiStringToRustString(accessToken, innerRt),
currentID); currentID);
} catch (const std::exception &e) { } catch (const std::exception &e) {
error = e.what(); error = e.what();
}; };
}); });
} }
jsi::Value CommRustModule::getOutboundKeysForUserDevice( jsi::Value CommRustModule::getOutboundKeysForUser(
jsi::Runtime &rt, jsi::Runtime &rt,
jsi::String authUserID, jsi::String authUserID,
jsi::String authDeviceID, jsi::String authDeviceID,
jsi::String authAccessToken, jsi::String authAccessToken,
jsi::String userID, jsi::String userID) {
jsi::String deviceID) {
return createPromiseAsJSIValue( return createPromiseAsJSIValue(
rt, [&, this](jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) { rt, [&, this](jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) {
std::string error; std::string error;
try { try {
auto currentID = RustPromiseManager::instance.addPromise( auto currentID = RustPromiseManager::instance.addPromise(
promise, this->jsInvoker_, innerRt); promise, this->jsInvoker_, innerRt);
identityGetOutboundKeysForUserDevice( identityGetOutboundKeysForUser(
jsiStringToRustString(authUserID, innerRt), jsiStringToRustString(authUserID, innerRt),
jsiStringToRustString(authDeviceID, innerRt), jsiStringToRustString(authDeviceID, innerRt),
jsiStringToRustString(authAccessToken, innerRt), jsiStringToRustString(authAccessToken, innerRt),
jsiStringToRustString(userID, innerRt), jsiStringToRustString(userID, innerRt),
jsiStringToRustString(deviceID, innerRt),
currentID); currentID);
} catch (const std::exception &e) { } catch (const std::exception &e) {
error = e.what(); error = e.what();
}; };
}); });
} }
jsi::Value CommRustModule::versionSupported(jsi::Runtime &rt) { jsi::Value CommRustModule::versionSupported(jsi::Runtime &rt) {
Show All 14 Lines
View Options

native/cpp/CommonCpp/_generated/commJSI.h

Show First 20 Lines • Show All 217 Lines • ▼ Show 20 Lines return createPromiseAsJSIValue(
jsiStringToRustString(accessToken, innerRt), jsiStringToRustString(accessToken, innerRt),
currentID); currentID);
} catch (const std::exception &e) { } catch (const std::exception &e) {
error = e.what(); error = e.what();
}; };
}); });
} }
jsi::Value CommRustModule::getOutboundKeysForUserDevice( jsi::Value CommRustModule::getOutboundKeysForUser(
jsi::Runtime &rt, jsi::Runtime &rt,
jsi::String authUserID, jsi::String authUserID,
jsi::String authDeviceID, jsi::String authDeviceID,
jsi::String authAccessToken, jsi::String authAccessToken,
jsi::String userID, jsi::String userID) {
jsi::String deviceID) {
return createPromiseAsJSIValue( return createPromiseAsJSIValue(
rt, [&, this](jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) { rt, [&, this](jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) {
std::string error; std::string error;
try { try {
auto currentID = RustPromiseManager::instance.addPromise( auto currentID = RustPromiseManager::instance.addPromise(
promise, this->jsInvoker_, innerRt); promise, this->jsInvoker_, innerRt);
identityGetOutboundKeysForUserDevice( identityGetOutboundKeysForUser(
jsiStringToRustString(authUserID, innerRt), jsiStringToRustString(authUserID, innerRt),
jsiStringToRustString(authDeviceID, innerRt), jsiStringToRustString(authDeviceID, innerRt),
jsiStringToRustString(authAccessToken, innerRt), jsiStringToRustString(authAccessToken, innerRt),
jsiStringToRustString(userID, innerRt), jsiStringToRustString(userID, innerRt),
jsiStringToRustString(deviceID, innerRt),
currentID); currentID);
} catch (const std::exception &e) { } catch (const std::exception &e) {
error = e.what(); error = e.what();
}; };
}); });
} }
jsi::Value CommRustModule::versionSupported(jsi::Runtime &rt) { jsi::Value CommRustModule::versionSupported(jsi::Runtime &rt) {
Show All 14 Lines
View Options

native/native_rust_library/src/backup.rs

Loading...
View Options

native/native_rust_library/src/lib.rs

Loading...
View Options

native/schema/CommCoreModuleSchema.js

Loading...