[native] unify username and wallet backup restore
ClosedPublic
Actions

Authored by kamil on Oct 31 2024, 8:05 AM.

Details

Reviewers

varun
bartek

Commits

rCOMM5a8e0d6d32c6: [native] unify username and wallet backup restore

Summary

ENG-6145.

This allows us to decrease code duplication (next diff) and use the same interface for wallet/username users.

Additionally, moving restore methods to BackupMenu as this is for now only for testing purposes and we'll need something different for actual backup.

Depends on D13840

Test Plan

Tested in D13849

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Oct 31 2024, 8:05 AM

kamil held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptOct 31 2024, 8:05 AM

kamil retitled this revision from [native] unify SIWE and password user restore to [native] unify username and wallet backup restore.Oct 31 2024, 8:08 AM

kamil edited the summary of this revision. (Show Details)

kamil added a child revision: D13846: [CommCoreModule][native_rust_library] deprecate SIWE related backup code.Oct 31 2024, 8:10 AM

Harbormaster completed remote builds in B32478: Diff 45511.Oct 31 2024, 8:24 AM

kamil published this revision for review.Oct 31 2024, 8:51 AM

kamil mentioned this in D13840: [backup-client] make `backupID` mandatory when restoring backup.

kamil edited the test plan for this revision. (Show Details)

varun accepted this revision.Nov 5 2024, 7:15 AM

This revision is now accepted and ready to land.Nov 5 2024, 7:15 AM

bartek accepted this revision.Nov 6 2024, 12:38 AM

Closed by commit rCOMM5a8e0d6d32c6: [native] unify username and wallet backup restore (authored by kamil). · Explain WhyNov 7 2024, 4:07 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM5a8e0d6d32c6: [native] unify username and wallet backup restore.