Page MenuHomePhabricator
Differential D13873

[backup-service] refactor uploading function in `/backups` endpoint
ClosedPublic
Actions

Authored by kamil on Nov 5 2024, 6:33 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 23, 1:01 PM
Unknown Object (File)
Mon, Mar 17, 8:38 PM
Unknown Object (File)
Mon, Mar 17, 7:08 PM
Unknown Object (File)
Mon, Mar 17, 9:18 AM
Unknown Object (File)
Sat, Mar 15, 7:25 AM
Unknown Object (File)
Tue, Mar 11, 6:56 AM
Unknown Object (File)
Tue, Mar 11, 6:39 AM
Unknown Object (File)
Mon, Mar 10, 9:41 AM
View All 69 Files
Subscribers
ashoat
tomek

Details

Reviewers
varun
bartek
Commits
rCOMMb8c417d81cec: [backup-service] refactor uploading function in `/backups` endpoint
Summary

Part of ENG-6145.

Tracked in ENG-9645.

  1. Extract code that will be needed in endpoints introduced later in the stack
  2. Added comment explaining the purpose of this endpoint
  3. Fixed typo in previous comment

Depends on D13872

Test Plan

run commtest

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
services/
backup/
src/
2 lines
http/
handlers/
98 lines
9 lines

Diff 45678

View Options

services/backup/src/error.rs

Show First 20 Lines • Show All 55 Lines • ▼ Show 20 Lines +getInboundKeysForUserDevice: (
authDeviceId: string, authDeviceId: string,
authAccessToken: string, authAccessToken: string,
userId: string, userId: string,
deviceId: string, deviceId: string,
) => Promise<InboundKeyInfoResponse>, ) => Promise<InboundKeyInfoResponse>,
+getFarcasterUsers: ( +getFarcasterUsers: (
farcasterIds: $ReadOnlyArray<string>, farcasterIds: $ReadOnlyArray<string>,
) => Promise<$ReadOnlyArray<FarcasterUser>>, ) => Promise<$ReadOnlyArray<FarcasterUser>>,
+generateNonce: () => Promise<string>,
}; };
export type { RustNativeBindingAPI }; export type { RustNativeBindingAPI };
View Options

services/backup/src/http/handlers/backup.rs

Show First 20 Lines • Show All 55 Lines • ▼ Show 20 Lines +getInboundKeysForUserDevice: (
authDeviceId: string, authDeviceId: string,
authAccessToken: string, authAccessToken: string,
userId: string, userId: string,
deviceId: string, deviceId: string,
) => Promise<InboundKeyInfoResponse>, ) => Promise<InboundKeyInfoResponse>,
+getFarcasterUsers: ( +getFarcasterUsers: (
farcasterIds: $ReadOnlyArray<string>, farcasterIds: $ReadOnlyArray<string>,
) => Promise<$ReadOnlyArray<FarcasterUser>>, ) => Promise<$ReadOnlyArray<FarcasterUser>>,
+generateNonce: () => Promise<string>,
}; };
export type { RustNativeBindingAPI }; export type { RustNativeBindingAPI };
View Options

services/backup/src/http/mod.rs

Show First 20 Lines • Show All 55 Lines • ▼ Show 20 Lines +getInboundKeysForUserDevice: (
authDeviceId: string, authDeviceId: string,
authAccessToken: string, authAccessToken: string,
userId: string, userId: string,
deviceId: string, deviceId: string,
) => Promise<InboundKeyInfoResponse>, ) => Promise<InboundKeyInfoResponse>,
+getFarcasterUsers: ( +getFarcasterUsers: (
farcasterIds: $ReadOnlyArray<string>, farcasterIds: $ReadOnlyArray<string>,
) => Promise<$ReadOnlyArray<FarcasterUser>>, ) => Promise<$ReadOnlyArray<FarcasterUser>>,
+generateNonce: () => Promise<string>,
}; };
export type { RustNativeBindingAPI }; export type { RustNativeBindingAPI };