[backup-service] refactor uploading function in `/backups` endpoint
ClosedPublic
Actions

Authored by kamil on Nov 5 2024, 2:33 PM.

Details

Reviewers

varun
bartek

Commits

rCOMMb8c417d81cec: [backup-service] refactor uploading function in `/backups` endpoint

Summary

Part of ENG-6145.

Tracked in ENG-9645.

Extract code that will be needed in endpoints introduced later in the stack
Added comment explaining the purpose of this endpoint
Fixed typo in previous comment

Depends on D13872

Test Plan

run commtest

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Nov 5 2024, 2:33 PM

kamil held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptNov 5 2024, 2:33 PM

kamil edited the summary of this revision. (Show Details)Nov 5 2024, 2:33 PM

minor update

kamil added a child revision: D13875: [backup-service] make `user_data` optional in `BackupItem`.Nov 5 2024, 2:44 PM

Harbormaster completed remote builds in B32539: Diff 45607.Nov 5 2024, 2:51 PM

Harbormaster completed remote builds in B32540: Diff 45608.Nov 5 2024, 2:53 PM

kamil published this revision for review.Nov 5 2024, 3:42 PM

bartek accepted this revision.Nov 6 2024, 9:05 AM

This revision is now accepted and ready to land.Nov 6 2024, 9:05 AM

Closed by commit rCOMMb8c417d81cec: [backup-service] refactor uploading function in `/backups` endpoint. · Explain WhyNov 7 2024, 12:07 PM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMb8c417d81cec: [backup-service] refactor uploading function in `/backups` endpoint.

Revision Contents
Changeset List

Path

Size

services/

backup/

src/

error.rs

2 lines

http/

handlers/

backup.rs

98 lines

mod.rs

9 lines

Diff 45678

View Options

services/backup/src/error.rs

View Options

services/backup/src/http/handlers/backup.rs

View Options

services/backup/src/http/mod.rs

[backup-service] refactor uploading function in `/backups` endpointClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 45678

services/backup/src/error.rs

services/backup/src/http/handlers/backup.rs

services/backup/src/http/mod.rs

[backup-service] refactor uploading function in `/backups` endpoint
ClosedPublic
Actions

Revision Contents
Changeset List