Paths

Table of Contentst

[backup-client] make `backupID` mandatory when restoring backup
ClosedPublic
Actions

Authored by kamil on Oct 31 2024, 12:33 PM.

Details

Reviewers

varun
bartek

Commits

rCOMM955ec0a26dea: [backup-client] make `backupID` mandatory when restoring backup

Summary

ENG-6145.

Alternative, was to pass username/wallet to restoreBackup - but each time using this we should already have latestBackupInfo as it's needed during restore, so this better matches out protocol.

Depends on D13839

Test Plan

Tested in D13849

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Oct 31 2024, 12:33 PM

kamil held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptOct 31 2024, 12:33 PM

Harbormaster completed remote builds in B32470: Diff 45503.Oct 31 2024, 12:51 PM

update

Harbormaster completed remote builds in B32475: Diff 45508.Oct 31 2024, 2:39 PM

kamil added a child revision: D13844: [native] unify username and wallet backup restore.Oct 31 2024, 3:05 PM

kamil published this revision for review.Oct 31 2024, 3:50 PM

kamil edited the test plan for this revision. (Show Details)

kamil added inline comments.

native/backup/use-client-backup.js
104–123 ↗	(On Diff #45508)	This is refactored in D13844

bartek accepted this revision.Nov 5 2024, 11:14 AM

This revision is now accepted and ready to land.Nov 5 2024, 11:14 AM

Closed by commit rCOMM955ec0a26dea: [backup-client] make `backupID` mandatory when restoring backup. · Explain WhyNov 7 2024, 12:07 PM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM955ec0a26dea: [backup-client] make `backupID` mandatory when restoring backup.

Revision Contents
Changeset List

Path

Size

native/

backup/

use-client-backup.js

43 lines

cpp/

CommonCpp/

NativeModules/

CommCoreModule.h

3 lines

CommCoreModule.cpp

7 lines

_generated/

commJSI-generated.cpp

commJSI.h

native_rust_library/

src/

backup.rs

11 lines

schema/

CommCoreModuleSchema.js

6 lines

Diff 45671

View Options

native/backup/use-client-backup.js

View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.h

View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

View Options

native/cpp/CommonCpp/_generated/commJSI-generated.cpp

View Options

native/cpp/CommonCpp/_generated/commJSI.h

View Options

native/native_rust_library/src/backup.rs

View Options

native/schema/CommCoreModuleSchema.js

[backup-client] make `backupID` mandatory when restoring backupClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 45671

native/backup/use-client-backup.js

native/cpp/CommonCpp/NativeModules/CommCoreModule.h

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

native/cpp/CommonCpp/_generated/commJSI-generated.cpp

native/cpp/CommonCpp/_generated/commJSI.h

native/native_rust_library/src/backup.rs

native/schema/CommCoreModuleSchema.js

[backup-client] make `backupID` mandatory when restoring backup
ClosedPublic
Actions

Revision Contents
Changeset List