Page MenuHomePhabricator
Differential D13840

[backup-client] make `backupID` mandatory when restoring backup
ClosedPublic
Actions

Authored by kamil on Oct 31 2024, 5:33 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 20, 3:42 PM
Unknown Object (File)
Sun, Apr 20, 11:46 AM
Unknown Object (File)
Sat, Apr 19, 2:22 PM
Unknown Object (File)
Sat, Apr 19, 1:50 PM
Unknown Object (File)
Thu, Apr 17, 7:33 PM
Unknown Object (File)
Mon, Apr 7, 10:55 PM
Unknown Object (File)
Mar 23 2025, 12:56 PM
Unknown Object (File)
Mar 22 2025, 9:36 AM
View All 87 Files
Subscribers
ashoat
tomek

Details

Reviewers
varun
bartek
Commits
rCOMM955ec0a26dea: [backup-client] make `backupID` mandatory when restoring backup
Summary

ENG-6145.

Alternative, was to pass username/wallet to restoreBackup - but each time using this we should already have latestBackupInfo as it's needed during restore, so this better matches out protocol.

Depends on D13839

Test Plan

Tested in D13849

Diff Detail

Repository
rCOMM Comm
Branch
backup-work-4
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
native/
backup/
43 lines
cpp/
CommonCpp/
NativeModules/
3 lines
7 lines
_generated/
schema/
6 lines

Diff 45503

View Options

native/backup/use-client-backup.js

Loading...
View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.h

Loading...
View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

Loading...
View Options

native/cpp/CommonCpp/_generated/commJSI-generated.cpp

Loading...
View Options

native/cpp/CommonCpp/_generated/commJSI.h

Loading...
View Options

native/schema/CommCoreModuleSchema.js

Loading...