Add a colon

In D14248#396595, @kamil wrote:

Might be worth creating another task to explicitly add a loading indicator here, as this is not perfect but the reasoning makes sense to only disable it

Reuse the types

Haven't reviewed too closely, but it looks reasonable, and the summary's tradeoffs make sense.

I tried to split this diff into parts somehow, but it doesn’t look like it’s possible: if one part is migrated then any parts that use or are used by this parts must be migrated as well.

High level, while creating the diffs, we should prioritize how easy it is to review them. Sometimes it makes sense to create diffs that don't work just to make them easier to review (e.g. we're doing that as a part of RN upgrades). It sounds like it could be the case here, but I'm not sure.

Update the layout

One things that feels pretty "broken" (unrelated to your changes) is that we have no loading state when the "Sign in using this wallet" button on landing/siwe is pressed. Would you mind creating a separate task/diff to add a loading state to the button after it's clicked? This will probably reduce buggy behavior by avoiding sending multiple events to a user's wallet, and it will feel more like a responsive UI. I think it should probably be prioritized – curious for your take.

Rebase

Fix imports

Rebase

The changes look good, but I have some more questions, that probably should've been asked in the first iteration - sorry for that!

Ah, ok, I get it. So the ref is actually an optimization and we could as well just avoid the early return when setSaveButtonDisabled === undefined.

Could you explain a bit more why this solves the issue? I have a couple of questions:

1. setOptions() wasn't called when onPressAdd changed - The effect depends on onPressAdd and calls setOptions. Are you sure that setOptions isn't called when a new user is added?
2. onPressAdd doesn't seem to depend on the selected users and it isn't obvious why it should always updated when new tag was added - why it has to be updated?
3. Why saving onPressAdd in a ref solves the issue?