Page MenuHomePhabricator

tomek (Tomasz Palys)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 24 2020, 6:20 AM (195 w, 6 d)

Recent Activity

Wed, May 22

tomek accepted D12145: [lib] Pull `useCommunityRootMembersToRole` out of `useThreadSearchIndex`.
Wed, May 22, 6:27 AM
tomek requested review of D12177: [lib] Stop checking for entry store inconsistencies.
Wed, May 22, 6:11 AM
tomek updated the test plan for D12170: [web][keyserver] Use entries from the initial state only if they are missing from the store.
Wed, May 22, 5:01 AM
tomek updated the diff for D12170: [web][keyserver] Use entries from the initial state only if they are missing from the store.

Use entries from the DB

Wed, May 22, 4:58 AM
tomek requested review of D12170: [web][keyserver] Use entries from the initial state only if they are missing from the store.
Wed, May 22, 4:58 AM
tomek requested review of D12169: [web] Replace persisted entries with the ones from initial redux state.
Wed, May 22, 4:50 AM
tomek updated the summary of D12153: [native] Persist only lastUserInteractionCalendar from the entry store.
Wed, May 22, 4:35 AM
tomek updated the summary of D12153: [native] Persist only lastUserInteractionCalendar from the entry store.
Wed, May 22, 4:34 AM
tomek added inline comments to D12156: [lib] Update delete keyserver, delete thread, leave thread and set new session actions with the ops approach.
Wed, May 22, 4:18 AM
tomek updated the test plan for D12157: [native] Add a migration that moves entries to SQLite.
Wed, May 22, 4:16 AM
tomek added inline comments to D12157: [native] Add a migration that moves entries to SQLite.
Wed, May 22, 4:12 AM
tomek updated the test plan for D12152: [lib] Schedule entry store ops processing.
Wed, May 22, 4:11 AM
tomek updated the test plan for D12147: [lib] Handle setClientDBStoreActionType for entries.
Wed, May 22, 4:10 AM
tomek updated the diff for D12147: [lib] Handle setClientDBStoreActionType for entries.

Return state from the store

Wed, May 22, 4:06 AM
tomek added inline comments to D12147: [lib] Handle setClientDBStoreActionType for entries.
Wed, May 22, 3:55 AM
tomek updated the summary of D12143: [lib] Refactor the entries reducer to return an object.
Wed, May 22, 3:54 AM
tomek updated the test plan for D12143: [lib] Refactor the entries reducer to return an object.
Wed, May 22, 3:54 AM
tomek updated the summary of D12156: [lib] Update delete keyserver, delete thread, leave thread and set new session actions with the ops approach.
Wed, May 22, 3:49 AM
tomek updated the summary of D12153: [native] Persist only lastUserInteractionCalendar from the entry store.
Wed, May 22, 3:48 AM
tomek updated the diff for D12163: [lib] Migrate creating local entries, concurrent modification and delete entries actions to ops.

Delete local entry after successful creation

Wed, May 22, 3:45 AM
tomek accepted D12148: Connect pipes between C++ and JS for entry store.
Wed, May 22, 2:42 AM

Tue, May 21

tomek requested review of D12164: [lib] Migrate remaining actions.
Tue, May 21, 1:21 PM
tomek requested review of D12163: [lib] Migrate creating local entries, concurrent modification and delete entries actions to ops.
Tue, May 21, 1:17 PM
tomek requested review of D12157: [native] Add a migration that moves entries to SQLite.
Tue, May 21, 1:15 PM
tomek requested review of D12162: [lib] Replace merging entries with an ops approach.
Tue, May 21, 1:12 PM
tomek requested review of D12156: [lib] Update delete keyserver, delete thread, leave thread and set new session actions with the ops approach.
Tue, May 21, 1:07 PM
tomek requested review of D12153: [native] Persist only lastUserInteractionCalendar from the entry store.
Tue, May 21, 1:02 PM
tomek requested review of D12152: [lib] Schedule entry store ops processing.
Tue, May 21, 12:53 PM
tomek requested review of D12147: [lib] Handle setClientDBStoreActionType for entries.
Tue, May 21, 12:51 PM
tomek updated the diff for D12143: [lib] Refactor the entries reducer to return an object.

Rebase

Tue, May 21, 12:34 PM
tomek closed D12094: [native] Stop persisting invite links.
Tue, May 21, 7:46 AM
tomek committed rCOMMe41813e3ab54: [native] Stop persisting invite links (authored by tomek).
[native] Stop persisting invite links
Tue, May 21, 7:46 AM
tomek accepted D12142: Implement JSI for EntryStore.
Tue, May 21, 7:33 AM
tomek requested review of D12143: [lib] Refactor the entries reducer to return an object.
Tue, May 21, 7:03 AM
tomek closed D12141: [lib] Create entry store handler.
Tue, May 21, 6:55 AM
tomek closed D12137: [lib] Create entry store operations.
Tue, May 21, 6:55 AM
tomek committed rCOMMce296fe96891: [lib] Create entry store handler (authored by tomek).
[lib] Create entry store handler
Tue, May 21, 6:55 AM
tomek committed rCOMM1db8124d0443: [lib] Create entry store operations (authored by tomek).
[lib] Create entry store operations
Tue, May 21, 6:55 AM
tomek updated the diff for D12141: [lib] Create entry store handler.

Delete a console log

Tue, May 21, 6:35 AM
tomek requested review of D12141: [lib] Create entry store handler.
Tue, May 21, 6:28 AM
tomek accepted D12138: Implement SQLite API to handle entry store.
Tue, May 21, 6:17 AM
tomek requested review of D12137: [lib] Create entry store operations.
Tue, May 21, 2:26 AM

Mon, May 20

tomek added a comment to D11942: [native] Set the DB version after registration.

Can you test both SIWE and password?

Mon, May 20, 8:43 AM
tomek added a comment to D11942: [native] Set the DB version after registration.
In D11942#341891, @inka wrote:

Can you test a scenario where the migration is run on a logged out screen, and then the user logs in? Can you verify that the db has the correct version set in this case?

Mon, May 20, 5:59 AM
tomek updated the diff for D12048: [web] Run backup migrations.

Rebase

Mon, May 20, 3:14 AM
tomek updated the summary of D11947: [web] Check backup version when restoring.
Mon, May 20, 3:10 AM
tomek updated the diff for D11947: [web] Check backup version when restoring.

Check the version

Mon, May 20, 3:09 AM
tomek added a comment to D11947: [web] Check backup version when restoring.

In the future, handling this exception should be a part of the login flow.

I wonder if there is a way to document this on Linear

Mon, May 20, 1:04 AM
tomek updated the diff for D12013: [native] Verify if the backup version is correct.

Update wasm

Mon, May 20, 12:44 AM

Fri, May 17

tomek updated the summary of D12013: [native] Verify if the backup version is correct.
Fri, May 17, 2:12 PM
tomek requested review of D12013: [native] Verify if the backup version is correct.
Fri, May 17, 2:09 PM
tomek updated the diff for D12013: [native] Verify if the backup version is correct.

Check the version before restoring

Fri, May 17, 2:07 PM
tomek requested review of D12094: [native] Stop persisting invite links.
Fri, May 17, 6:54 AM
tomek accepted D12072: [lib] Add httpMessageUserInfosHandler.
Fri, May 17, 6:08 AM
tomek added inline comments to D12062: [keyserver/lib] introduce MANAGE_FARCASTER_CHANNEL_TAGS permission.
Fri, May 17, 3:56 AM

Thu, May 16

tomek updated the diff for D12050: [lib] Create a compaction after schema-changing migration.

Rebase

Thu, May 16, 7:30 AM
tomek updated the diff for D12049: [lib] Add a way of marking migrations as schema-changing.

Rebase

Thu, May 16, 7:26 AM
tomek updated the diff for D12048: [web] Run backup migrations.

Rebase

Thu, May 16, 7:11 AM
tomek updated the diff for D12016: [native] Run backup migrations.

Rebase

Thu, May 16, 7:04 AM
tomek added a comment to D12033: Introduce new header to siwe endpoint.

I think decomposing is the best bet. Curious for @tomek's perspective

Thu, May 16, 4:36 AM
tomek added inline comments to D12013: [native] Verify if the backup version is correct.
Thu, May 16, 1:21 AM
tomek accepted D12052: [lib] Extract user ids from server socket messages.
Thu, May 16, 1:20 AM
tomek added inline comments to D12050: [lib] Create a compaction after schema-changing migration.
Thu, May 16, 1:02 AM
tomek added inline comments to D12048: [web] Run backup migrations.
Thu, May 16, 12:57 AM

Wed, May 15

tomek updated the diff for D12015: [lib] Extract a function that runs the migrations.

Rebase

Wed, May 15, 8:27 AM
tomek updated the diff for D12014: [lib] Move createAsyncMigrate to utils.

Rebase

Wed, May 15, 8:16 AM
tomek updated the diff for D12013: [native] Verify if the backup version is correct.

Rebase

Wed, May 15, 8:06 AM
tomek updated the diff for D12012: [native] Create a function returning the DB version.

Rename

Wed, May 15, 8:02 AM
tomek added a comment to D11947: [web] Check backup version when restoring.
In D11947#341896, @inka wrote:

Should we display some kind of a message to the user?

Wed, May 15, 7:55 AM
tomek added inline comments to D11937: [lib] Update DB version while running a migration.
Wed, May 15, 7:43 AM
tomek updated the diff for D11937: [lib] Update DB version while running a migration.

Handle migration errors. This required a lot of changes in types.

Wed, May 15, 7:40 AM
tomek requested review of D12050: [lib] Create a compaction after schema-changing migration.
Wed, May 15, 6:05 AM
tomek requested review of D12049: [lib] Add a way of marking migrations as schema-changing.
Wed, May 15, 5:28 AM
tomek requested review of D12048: [web] Run backup migrations.
Wed, May 15, 5:19 AM

Tue, May 14

tomek accepted D12031: [keyserver] Use endpointValidators in keyserve code.
Tue, May 14, 8:28 AM
tomek accepted D12030: [lib] Bind output validators to endpoints on lib.
Tue, May 14, 8:14 AM
tomek accepted D12029: [lib][keyserver] Move upload output validators to lib.
Tue, May 14, 8:01 AM
tomek accepted D12028: [lib] Remove request_access.

This is a leftover from a feature that we had https://github.com/CommE2E/comm/commit/d967a4423104140388fb8227787f676abf319dd0

Tue, May 14, 7:59 AM
tomek closed D11936: [lib][web][native] Make all the props of StoreOperations optional.
Tue, May 14, 4:49 AM
tomek closed D11933: [lib] Create a synced metadata key for DB version.
Tue, May 14, 4:49 AM
tomek committed rCOMMe3f2aff62c8f: [lib][web][native] Make all the props of StoreOperations optional (authored by tomek).
[lib][web][native] Make all the props of StoreOperations optional
Tue, May 14, 4:49 AM
tomek committed rCOMM446a2b523d91: [lib] Create a synced metadata key for DB version (authored by tomek).
[lib] Create a synced metadata key for DB version
Tue, May 14, 4:49 AM
tomek closed D11931: [lib] Expose function that processes operations as a part of SQLite API.
Tue, May 14, 4:49 AM
tomek committed rCOMM0897e32be4a5: [lib] Expose function that processes operations as a part of SQLite API (authored by tomek).
[lib] Expose function that processes operations as a part of SQLite API
Tue, May 14, 4:49 AM
tomek updated the diff for D11936: [lib][web][native] Make all the props of StoreOperations optional.

Modify convertOpsToClientDBOps

Tue, May 14, 4:29 AM
tomek added a comment to D11936: [lib][web][native] Make all the props of StoreOperations optional.

Wondering if updating convertOpsToClientDBOps to handle nullable param wouldn't be even more readable but up to you

Tue, May 14, 4:14 AM
tomek added a comment to D11931: [lib] Expose function that processes operations as a part of SQLite API.

Are you planning to update callsites of processDBStoreOperations to use SQLiteAPI?

Tue, May 14, 4:13 AM
tomek accepted D12027: [lib] update community reducer to handle new community action types.
Tue, May 14, 3:36 AM
tomek accepted D12025: [native] display loading spinner in TagChannelButton during loading state.
Tue, May 14, 3:29 AM
tomek accepted D12024: [native] introduce TagChannelButton.
Tue, May 14, 3:27 AM
tomek accepted D12023: [native] call fetchCommunityInfos from the community drawer.
Tue, May 14, 3:22 AM
tomek accepted D11984: [lib] Add extractUserIDsFromPayload.
Tue, May 14, 12:50 AM

Mon, May 13

tomek requested review of D12016: [native] Run backup migrations.
Mon, May 13, 6:36 AM
tomek requested review of D12015: [lib] Extract a function that runs the migrations.
Mon, May 13, 6:33 AM
tomek requested review of D12014: [lib] Move createAsyncMigrate to utils.
Mon, May 13, 5:26 AM
tomek requested review of D12013: [native] Verify if the backup version is correct.
Mon, May 13, 3:45 AM
tomek requested review of D12012: [native] Create a function returning the DB version.
Mon, May 13, 3:43 AM
tomek accepted D11997: [web] introduce CommunitiesRefresher.
Mon, May 13, 3:17 AM
tomek accepted D11996: [lib] introduce fetch community infos redux action.
Mon, May 13, 3:15 AM
tomek accepted D11995: [keyserver/lib] introduce fetch_community_infos endpoint.
Mon, May 13, 3:13 AM