Page MenuHomePhabricator

tomek (Tomasz Palys)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 24 2020, 6:20 AM (204 w, 4 d)

Recent Activity

Today

tomek closed D12786: [lib] Track progress of message processing.
Fri, Jul 26, 8:42 AM
tomek committed rCOMMd0b9971793b3: [lib] Track progress of message processing (authored by tomek).
[lib] Track progress of message processing
Fri, Jul 26, 8:42 AM
tomek closed D12776: [lib] Generate P2P messages based on actions.
Fri, Jul 26, 8:42 AM
tomek committed rCOMMda886a2548bb: [lib] Generate P2P messages based on actions (authored by tomek).
[lib] Generate P2P messages based on actions
Fri, Jul 26, 8:42 AM
tomek updated the diff for D12786: [lib] Track progress of message processing.

Use UUID v4

Fri, Jul 26, 6:50 AM
tomek updated the diff for D12786: [lib] Track progress of message processing.

Rebase and improve naming

Fri, Jul 26, 6:48 AM
tomek added a comment to D12786: [lib] Track progress of message processing.

I think the usage of if and dmOpID can be improved and more descriptive, this might look confusing as we have plenty IDs all over the codebase - but I don't have idea about better ones

Fri, Jul 26, 6:48 AM
tomek updated the diff for D12776: [lib] Generate P2P messages based on actions.

Fix device ID filtering

Fri, Jul 26, 6:33 AM
tomek added inline comments to D12776: [lib] Generate P2P messages based on actions.
Fri, Jul 26, 6:31 AM
tomek updated the diff for D12776: [lib] Generate P2P messages based on actions.

Filter out this device ID

Fri, Jul 26, 6:31 AM
tomek foisted D12749: [lib] Stop requiring sequential messages upon kamil.
Fri, Jul 26, 6:12 AM
tomek closed D12807: [lib] DMOperationSpec for edit operation.
Fri, Jul 26, 5:22 AM
tomek committed rCOMMf95e8973dae8: [lib] DMOperationSpec for edit operation (authored by tomek).
[lib] DMOperationSpec for edit operation
Fri, Jul 26, 5:22 AM
tomek closed D12806: [lib] DMOperationSpec for reaction operation.
Fri, Jul 26, 5:22 AM
tomek committed rCOMM20323899bb24: [lib] DMOperationSpec for reaction operation (authored by tomek).
[lib] DMOperationSpec for reaction operation
Fri, Jul 26, 5:22 AM
tomek updated the diff for D12881: [lib] DMOperationSpec for change thread settings operation.

Rename

Fri, Jul 26, 4:38 AM
tomek updated the diff for D12872: [lib] DMOperationSpec for remove members operation.

Rename

Fri, Jul 26, 4:36 AM
tomek updated the diff for D12871: [lib] DMOperationSpec for leave thread operation.

Rename

Fri, Jul 26, 4:35 AM
tomek updated the diff for D12870: [lib] DMOperationSpec for join thread operation.

Rename

Fri, Jul 26, 4:33 AM
tomek updated the diff for D12835: [lib] DMOperationSpec for add members operation.

Rename

Fri, Jul 26, 4:31 AM
tomek updated the diff for D12807: [lib] DMOperationSpec for edit operation.

Rename

Fri, Jul 26, 4:29 AM
tomek updated the diff for D12806: [lib] DMOperationSpec for reaction operation.

Rename

Fri, Jul 26, 4:25 AM
tomek updated the diff for D12807: [lib] DMOperationSpec for edit operation.

Rename

Fri, Jul 26, 3:48 AM
tomek accepted D12869: [native][web] Fill target_message column for sidebar source.
Fri, Jul 26, 3:39 AM
tomek requested review of D12881: [lib] DMOperationSpec for change thread settings operation.
Fri, Jul 26, 3:30 AM
tomek requested review of D12872: [lib] DMOperationSpec for remove members operation.
Fri, Jul 26, 3:26 AM
tomek requested review of D12871: [lib] DMOperationSpec for leave thread operation.
Fri, Jul 26, 3:20 AM
tomek accepted D12884: [native] replace keyserver using qr code auth.
Fri, Jul 26, 2:55 AM
tomek added a reviewer for D12884: [native] replace keyserver using qr code auth: ashoat.

Looks reasonable, but the copy should be reviewed by @ashoat

Fri, Jul 26, 2:54 AM

Yesterday

tomek accepted D12859: [Tunnelbroker][lib] rename `MessageToDeviceRequestStatus` -> `DeviceToTunnelbrokerRequestStatus`.
Thu, Jul 25, 6:28 AM
tomek accepted D12869: [native][web] Fill target_message column for sidebar source.
Thu, Jul 25, 6:23 AM
tomek accepted D12867: [native][web] Fetch related messages for search.
Thu, Jul 25, 6:08 AM
tomek accepted D12860: [CommCoreModule] remove `T[]` syntax.
Thu, Jul 25, 2:58 AM

Wed, Jul 24

tomek added inline comments to D12835: [lib] DMOperationSpec for add members operation.
Wed, Jul 24, 9:32 AM
tomek updated the diff for D12870: [lib] DMOperationSpec for join thread operation.

Rebase

Wed, Jul 24, 9:29 AM
tomek added inline comments to D12835: [lib] DMOperationSpec for add members operation.
Wed, Jul 24, 9:29 AM
tomek updated the diff for D12835: [lib] DMOperationSpec for add members operation.

Improve the logic

Wed, Jul 24, 9:25 AM
tomek requested review of D12870: [lib] DMOperationSpec for join thread operation.
Wed, Jul 24, 9:23 AM
tomek accepted D12858: [lib] improve naming in Tunnelbroker socket.
Wed, Jul 24, 6:24 AM
tomek accepted D12857: [lib] remove unused Tunnelbroker message validators.

I'd prefer to also validate on the JS side, but it isn't a strong opinion.

Wed, Jul 24, 6:04 AM
tomek accepted D12856: [Tunnelbroker][lib] cleanup Device <-> Tunnelbroker message types.
Wed, Jul 24, 6:03 AM
tomek accepted D12866: [native][web] Fix timestamp type in cpp.

Have you tested it on both platforms?

Wed, Jul 24, 5:46 AM
tomek accepted D12865: [keyserver][lib][web][native] use local search for thick threads.
Wed, Jul 24, 5:44 AM

Tue, Jul 23

tomek planned changes to D12835: [lib] DMOperationSpec for add members operation.

Still have to figure out a distinction between this and JOIN_THREAD

Tue, Jul 23, 7:59 AM
tomek added inline comments to D12835: [lib] DMOperationSpec for add members operation.
Tue, Jul 23, 7:45 AM
tomek added inline comments to D12835: [lib] DMOperationSpec for add members operation.
Tue, Jul 23, 7:44 AM
tomek updated the diff for D12835: [lib] DMOperationSpec for add members operation.

Add the util

Tue, Jul 23, 7:41 AM
tomek updated the diff for D12807: [lib] DMOperationSpec for edit operation.

Add to specs

Tue, Jul 23, 7:30 AM
tomek updated the diff for D12806: [lib] DMOperationSpec for reaction operation.

Add to specs

Tue, Jul 23, 7:28 AM
tomek added a comment to D12806: [lib] DMOperationSpec for reaction operation.

I wonder if we should have a separate task for updating the replies count. I don't think I contemplated it in sendTextMessageSpec

Tue, Jul 23, 7:00 AM
tomek closed D12804: [native][web] Rename P2P messages methods.
Tue, Jul 23, 6:46 AM
tomek committed rCOMMed98e4a6ebd2: [native][web] Rename P2P messages methods (authored by tomek).
[native][web] Rename P2P messages methods
Tue, Jul 23, 6:46 AM
tomek added a comment to D12855: [SQLite] rename all QueryExecutor params to `camelCase`.

We can also build and run the native app as a part of the test plan.

Tue, Jul 23, 6:39 AM
tomek accepted D12855: [SQLite] rename all QueryExecutor params to `camelCase`.
Tue, Jul 23, 6:38 AM
tomek accepted D12854: [lib] introduce message searching to `SQLiteAPI`.
Tue, Jul 23, 6:36 AM
tomek accepted D12853: [native] introduce message searching to `CommCoreModule`.
Tue, Jul 23, 6:35 AM
tomek accepted D12852: [web] introduce message searching to shared worker.
Tue, Jul 23, 6:28 AM
tomek accepted D12851: [SQLite] implement tests for messages search.

We can consider one more thing: sorting the returned messages.

Tue, Jul 23, 6:25 AM
tomek accepted D12850: [SQLite] add Emscripten bindings for message search.
Tue, Jul 23, 6:16 AM
tomek accepted D12844: [SQLite] implement query for searching messages.
Tue, Jul 23, 6:15 AM
tomek accepted D12843: [SQLite] add method for message search to SQLiteQueryExecutor for both web and native.
Tue, Jul 23, 6:10 AM
tomek closed D12170: [web][keyserver] Use entries from the initial state only if they are missing from the store.
Tue, Jul 23, 5:57 AM
tomek closed D12177: [lib] Stop checking for entry store inconsistencies.
Tue, Jul 23, 5:57 AM
tomek committed rCOMMfed680b1193d: [lib] Stop checking for entry store inconsistencies (authored by tomek).
[lib] Stop checking for entry store inconsistencies
Tue, Jul 23, 5:57 AM
tomek committed rCOMM3248d0b99c58: [web][keyserver] Use entries from the initial state only if they are missing… (authored by tomek).
[web][keyserver] Use entries from the initial state only if they are missing…
Tue, Jul 23, 5:57 AM
tomek closed D12153: [native] Persist only lastUserInteractionCalendar from the entry store.
Tue, Jul 23, 5:57 AM
tomek committed rCOMMbb0f4743a386: [native] Persist only lastUserInteractionCalendar from the entry store (authored by tomek).
[native] Persist only lastUserInteractionCalendar from the entry store
Tue, Jul 23, 5:57 AM
tomek updated the diff for D12177: [lib] Stop checking for entry store inconsistencies.

Fix eslint

Tue, Jul 23, 5:30 AM
tomek updated the test plan for D12153: [native] Persist only lastUserInteractionCalendar from the entry store.
Tue, Jul 23, 3:59 AM
tomek updated the diff for D12177: [lib] Stop checking for entry store inconsistencies.

Rebase

Tue, Jul 23, 3:53 AM
tomek updated the diff for D12170: [web][keyserver] Use entries from the initial state only if they are missing from the store.

Rebase

Tue, Jul 23, 3:52 AM
tomek updated the diff for D12153: [native] Persist only lastUserInteractionCalendar from the entry store.

Rebase

Tue, Jul 23, 3:52 AM
tomek closed D12834: [web][native] Increase number of actions kept in Redux debugger.
Tue, Jul 23, 3:49 AM
tomek committed rCOMM25deb730c421: [web][native] Increase number of actions kept in Redux debugger (authored by tomek).
[web][native] Increase number of actions kept in Redux debugger
Tue, Jul 23, 3:49 AM
tomek added inline comments to D12170: [web][keyserver] Use entries from the initial state only if they are missing from the store.
Tue, Jul 23, 3:41 AM
tomek accepted D12833: [lib][web][native] Create message search store ops.
Tue, Jul 23, 3:17 AM
tomek accepted D12839: [lib][native][web] Introduce threadTypeIsSidebar.
Tue, Jul 23, 1:12 AM

Mon, Jul 22

tomek requested review of D12835: [lib] DMOperationSpec for add members operation.
Mon, Jul 22, 7:07 AM
tomek accepted D12833: [lib][web][native] Create message search store ops.
Mon, Jul 22, 5:01 AM
tomek requested review of D12834: [web][native] Increase number of actions kept in Redux debugger.
Mon, Jul 22, 3:36 AM
tomek accepted D12829: [lib] Specify messageID in sendTextMessageSpec.

Makes sense! I asked about it in https://phab.comm.dev/D12655#362785.

Mon, Jul 22, 3:33 AM
tomek accepted D12828: [lib] Make sure thick threads starts out with startReached.
Mon, Jul 22, 3:31 AM
tomek accepted D12827: [lib] Reduce duplication in message-types.js.
Mon, Jul 22, 3:30 AM
tomek accepted D12826: [native][web] Allow sending custom encrypted message via Tunnelbroker test interface.
Mon, Jul 22, 3:29 AM
tomek accepted D12825: [lib] Turn on notifs by default for thick threads.
Mon, Jul 22, 3:27 AM
tomek accepted D12824: [keyserver][lib] Factor out joinThreadSubscription.
Mon, Jul 22, 3:26 AM
tomek accepted D12781: [lib] Reduce new PROCESS_DM_OPS action.
Mon, Jul 22, 1:57 AM
tomek accepted D12780: [lib] Introduce new PROCESS_DM_OPS action and dispatch from useProcessDMOperation.
Mon, Jul 22, 1:39 AM
tomek accepted D12741: [lib] Process DMOperations when received from peers via Tunnelbroker.
Mon, Jul 22, 1:27 AM
tomek accepted D12764: [lib] Introduce useGetLatestMessageEdit.
Mon, Jul 22, 1:24 AM

Fri, Jul 19

tomek updated the diff for D12807: [lib] DMOperationSpec for edit operation.

Rename a file

Fri, Jul 19, 1:34 PM
tomek updated the diff for D12806: [lib] DMOperationSpec for reaction operation.

Rename file

Fri, Jul 19, 1:33 PM
tomek updated the diff for D12807: [lib] DMOperationSpec for edit operation.

Fix the types

Fri, Jul 19, 1:21 PM
tomek requested review of D12806: [lib] DMOperationSpec for reaction operation.
Fri, Jul 19, 1:19 PM
tomek requested review of D12807: [lib] DMOperationSpec for edit operation.
Fri, Jul 19, 1:16 PM
tomek added inline comments to D12655: [lib] DMOperationSpec for SEND_TEXT_MESSAGE operation.
Fri, Jul 19, 12:50 PM
tomek requested review of D12804: [native][web] Rename P2P messages methods.
Fri, Jul 19, 8:55 AM
tomek added inline comments to D12745: [native][web] Introduce a method fetching messages by ID to SQLiteAPI.
Fri, Jul 19, 8:38 AM
tomek closed D12650: Update extractKeyserverIDFromID so that it returns null for DMs.
Fri, Jul 19, 8:08 AM
tomek committed rCOMMf016986ee2cf: Update extractKeyserverIDFromID so that it returns null for DMs (authored by tomek).
Update extractKeyserverIDFromID so that it returns null for DMs
Fri, Jul 19, 8:08 AM