Page MenuHomePhabricator

tomek (Tomasz Palys)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 24 2020, 6:20 AM (250 w, 5 d)

Recent Activity

Yesterday

tomek accepted D14836: [SQLite] convert `target_message` column in `messages` table to standard column.
Fri, Jun 13, 1:44 AM
tomek accepted D14835: [SQLite][web] implement tests for `getRelatedMessages()`.
Fri, Jun 13, 1:38 AM

Wed, Jun 11

tomek accepted D14827: [lib][web][native] update `ReplaceMessageStoreLocalMessageInfoOperation` to decide if data should be included backup.
Wed, Jun 11, 6:00 AM
tomek accepted D14826: [lib][web][native] update `ReplaceMessageStoreThreadsOperation` to decide if data should be included backup.
Wed, Jun 11, 5:57 AM
tomek accepted D14825: [lib][web][native] update `ReplaceThreadActivityEntryOperation` to decide if data should be included backup.
Wed, Jun 11, 5:52 AM
tomek accepted D14824: [lib][web][native] update `ReplaceThreadOperation` to decide if data should be included backup.
Wed, Jun 11, 5:46 AM
tomek accepted D14823: [lib][web][native] update `ReplaceEntryOperation` to decide if data should be included backup.
Wed, Jun 11, 5:42 AM
tomek accepted D14822: [lib][web][native] update `ReplaceMessageOperation` to decide if data should be included backup.
Wed, Jun 11, 5:34 AM

Tue, Jun 10

tomek accepted D14820: [lib] add `dataIsBackedUp` flag to `ThreadProtocol`.
Tue, Jun 10, 2:30 AM

Mon, Jun 9

tomek accepted D14809: [lib][web][native] implement debug log types to be able to distinguish logs.
Mon, Jun 9, 3:06 AM
tomek accepted D14814: [blob][lib][keyserver] Handle offensive invite link error.
Mon, Jun 9, 1:25 AM
tomek accepted D14813: [blob] Improve regex for offensive words.
Mon, Jun 9, 1:23 AM

Fri, Jun 6

tomek closed D14816: [lib] Fetch keys only when a session is missing.
Fri, Jun 6, 6:42 AM
tomek committed rCOMMfbd1ea0c3497: [lib] Fetch keys only when a session is missing (authored by tomek).
[lib] Fetch keys only when a session is missing
Fri, Jun 6, 6:42 AM
tomek accepted D14815: [terraform] Bump Identity 0.53.0 to prod.
Fri, Jun 6, 3:37 AM

Thu, Jun 5

tomek accepted D14811: [lib][web][native] display badge only for errors.
Thu, Jun 5, 7:07 AM
tomek accepted D14810: [lib][web][native] implement log filtering.
Thu, Jun 5, 7:05 AM
tomek accepted D14809: [lib][web][native] implement debug log types to be able to distinguish logs.
Thu, Jun 5, 6:57 AM
tomek accepted D14812: [native] fix simultaneous promises in `SQLiteDataHandler`.
Thu, Jun 5, 6:40 AM

Wed, May 28

tomek closed D14771: [lib] Introduce additional logging.
Wed, May 28, 3:28 AM
tomek committed rCOMM1e222a9afa2a: [lib] Introduce additional logging (authored by tomek).
[lib] Introduce additional logging
Wed, May 28, 3:28 AM
tomek closed D14769: [lib] Confirm a message after processing it unconditionally.
Wed, May 28, 3:28 AM
tomek committed rCOMMb6d48fd158c4: [lib] Confirm a message after processing it unconditionally (authored by tomek).
[lib] Confirm a message after processing it unconditionally
Wed, May 28, 3:28 AM
tomek closed D14756: [lib] Broadcast account deletion message after verifying the password.
Wed, May 28, 3:28 AM
tomek committed rCOMM3337169d2a69: [lib] Broadcast account deletion message after verifying the password (authored by tomek).
[lib] Broadcast account deletion message after verifying the password
Wed, May 28, 3:28 AM
tomek updated the diff for D14771: [lib] Introduce additional logging.

Rebase

Wed, May 28, 2:05 AM
tomek updated the diff for D14769: [lib] Confirm a message after processing it unconditionally.

Keep checking if the socket exists

Wed, May 28, 2:04 AM
tomek closed D14763: [lib] Remove shouldPerformSideEffectsBeforeSendingMessage flag.
Wed, May 28, 1:58 AM
tomek committed rCOMMc75b3a0f7950: [lib] Remove shouldPerformSideEffectsBeforeSendingMessage flag (authored by tomek).
[lib] Remove shouldPerformSideEffectsBeforeSendingMessage flag
Wed, May 28, 1:58 AM

Tue, May 27

tomek requested review of D14771: [lib] Introduce additional logging.
Tue, May 27, 4:35 AM
tomek accepted D14760: [web][native] Add selectedDeviceIDs to Inbound/Outbound keys APIs.
Tue, May 27, 4:20 AM
tomek requested review of D14769: [lib] Confirm a message after processing it unconditionally.
Tue, May 27, 4:14 AM
tomek accepted D14759: [identity] Implement devices filter for X3DH RPCs.
Tue, May 27, 4:13 AM
tomek accepted D14758: [proto] Add devices filter param to X3DH RPC requests.
Tue, May 27, 4:10 AM

Mon, May 26

tomek requested review of D14763: [lib] Remove shouldPerformSideEffectsBeforeSendingMessage flag.
Mon, May 26, 6:12 AM

Fri, May 23

tomek requested review of D14756: [lib] Broadcast account deletion message after verifying the password.
Fri, May 23, 11:24 AM
tomek closed D14712: [lib] Choose thread ID behavior in the initial state gate based on the specs.
Fri, May 23, 8:51 AM
tomek closed D14711: [lib] Choose a protocol based on thread ID.
Fri, May 23, 8:51 AM
tomek committed rCOMMc1549f6d130f: [lib] Choose a protocol based on thread ID (authored by tomek).
[lib] Choose a protocol based on thread ID
Fri, May 23, 8:51 AM
tomek committed rCOMMc71b113ea957: [lib] Choose thread ID behavior in the initial state gate based on the specs (authored by tomek).
[lib] Choose thread ID behavior in the initial state gate based on the specs
Fri, May 23, 8:51 AM
tomek closed D14710: [lib] Replace some usages of `thick` property.
Fri, May 23, 8:51 AM
tomek closed D14707: [lib] Move joining threads to a spec.
Fri, May 23, 8:51 AM
tomek committed rCOMM4eda19d72d00: [lib] Replace some usages of `thick` property (authored by tomek).
[lib] Replace some usages of `thick` property
Fri, May 23, 8:51 AM
tomek closed D14703: [lib] Move deleting messages to a spec.
Fri, May 23, 8:51 AM
tomek committed rCOMMd53cafa87ecc: [lib] Move joining threads to a spec (authored by tomek).
[lib] Move joining threads to a spec
Fri, May 23, 8:51 AM
tomek committed rCOMM151f110fad00: [lib] Move deleting messages to a spec (authored by tomek).
[lib] Move deleting messages to a spec
Fri, May 23, 8:51 AM
tomek closed D14702: [lib] Delete threadTypeIsThick function.
Fri, May 23, 8:51 AM
tomek closed D14701: [lib] Move creating permission blobs to a spec.
Fri, May 23, 8:51 AM
tomek closed D14700: [lib] Split thread permissions.
Fri, May 23, 8:51 AM
tomek committed rCOMM02b5700072d0: [lib] Delete threadTypeIsThick function (authored by tomek).
[lib] Delete threadTypeIsThick function
Fri, May 23, 8:51 AM
tomek committed rCOMM97921cf493f4: [lib] Move creating permission blobs to a spec (authored by tomek).
[lib] Move creating permission blobs to a spec
Fri, May 23, 8:51 AM
tomek closed D14697: [lib] Create a flag determining a thread search header.
Fri, May 23, 8:51 AM
tomek committed rCOMM46bbb1cb8a4b: [lib] Split thread permissions (authored by tomek).
[lib] Split thread permissions
Fri, May 23, 8:51 AM
tomek closed D14696: [lib] Move thread creation to a spec.
Fri, May 23, 8:51 AM
tomek committed rCOMMa0a123853ec8: [lib] Create a flag determining a thread search header (authored by tomek).
[lib] Create a flag determining a thread search header
Fri, May 23, 8:51 AM
tomek closed D14694: [lib] Move determining pending thread types to a spec.
Fri, May 23, 8:51 AM
tomek committed rCOMM729b491848cd: [lib] Move thread creation to a spec (authored by tomek).
[lib] Move thread creation to a spec
Fri, May 23, 8:51 AM
tomek closed D14693: [lib] Use a protocol flag when determining unread status updates.
Fri, May 23, 8:51 AM
tomek committed rCOMMc7b766d2c8a3: [lib] Move determining pending thread types to a spec (authored by tomek).
[lib] Move determining pending thread types to a spec
Fri, May 23, 8:51 AM
tomek closed D14692: [lib] Move freezing behavior to a spec.
Fri, May 23, 8:51 AM
tomek committed rCOMM1ffb36701e4c: [lib] Move freezing behavior to a spec (authored by tomek).
[lib] Move freezing behavior to a spec
Fri, May 23, 8:51 AM
tomek closed D14691: [lib] Refactor pending to realized thread selector to use the protocol.
Fri, May 23, 8:51 AM
tomek committed rCOMMc7f58a8f8eda: [lib] Use a protocol flag when determining unread status updates (authored by tomek).
[lib] Use a protocol flag when determining unread status updates
Fri, May 23, 8:51 AM
tomek closed D14664: [lib] Rename thread-actions.
Fri, May 23, 8:50 AM
tomek closed D14677: [lib] Rename metadata upload parameter.
Fri, May 23, 8:50 AM
tomek committed rCOMMc0774d006f27: [lib] Refactor pending to realized thread selector to use the protocol (authored by tomek).
[lib] Refactor pending to realized thread selector to use the protocol
Fri, May 23, 8:50 AM
tomek committed rCOMM2b184c882f91: [lib] Rename thread-actions (authored by tomek).
[lib] Rename thread-actions
Fri, May 23, 8:50 AM
tomek closed D14654: [lib] Move creating pending threads to a spec.
Fri, May 23, 8:50 AM
tomek committed rCOMM044d2a6a4f17: [lib] Rename metadata upload parameter (authored by tomek).
[lib] Rename metadata upload parameter
Fri, May 23, 8:50 AM
tomek committed rCOMMb78922fd83a4: [lib] Move creating pending threads to a spec (authored by tomek).
[lib] Move creating pending threads to a spec
Fri, May 23, 8:50 AM
tomek closed D14642: [lib] Move fetching messages to a spec.
Fri, May 23, 8:50 AM
tomek closed D14652: [lib] Replace the protocol array with a function.
Fri, May 23, 8:50 AM
tomek committed rCOMM8a0173e4be89: [lib] Move fetching messages to a spec (authored by tomek).
[lib] Move fetching messages to a spec
Fri, May 23, 8:50 AM
tomek closed D14641: [lib] Move converting DB threads to a spec.
Fri, May 23, 8:50 AM
tomek committed rCOMM13965f7b0842: [lib] Replace the protocol array with a function (authored by tomek).
[lib] Replace the protocol array with a function
Fri, May 23, 8:50 AM
tomek closed D14640: [lib] Create a flag telling if we should use DM activity handler.
Fri, May 23, 8:50 AM
tomek committed rCOMM0fe939413a18: [lib] Move converting DB threads to a spec (authored by tomek).
[lib] Move converting DB threads to a spec
Fri, May 23, 8:50 AM
tomek closed D14639: [lib] Create a flag telling if pending threads are descendants of genesis.
Fri, May 23, 8:50 AM
tomek committed rCOMMef7aa569a6df: [lib] Create a flag telling if we should use DM activity handler (authored by tomek).
[lib] Create a flag telling if we should use DM activity handler
Fri, May 23, 8:50 AM
tomek closed D14634: [web] Display thread icon based on the specs.
Fri, May 23, 8:50 AM
tomek committed rCOMMf02834644290: [web] Display thread icon based on the specs (authored by tomek).
[web] Display thread icon based on the specs
Fri, May 23, 8:50 AM
tomek committed rCOMMb82071f46ecd: [lib] Create a flag telling if pending threads are descendants of genesis (authored by tomek).
[lib] Create a flag telling if pending threads are descendants of genesis
Fri, May 23, 8:50 AM
tomek closed D14633: [native] Display thread ancestry based on the spec.
Fri, May 23, 8:50 AM
tomek closed D14632: [lib] Add a flag telling if messages are stored on a server.
Fri, May 23, 8:50 AM
tomek committed rCOMMda44e71b8b4e: [native] Display thread ancestry based on the spec (authored by tomek).
[native] Display thread ancestry based on the spec
Fri, May 23, 8:50 AM
tomek committed rCOMMfec293ca568d: [lib] Add a flag telling if messages are stored on a server (authored by tomek).
[lib] Add a flag telling if messages are stored on a server
Fri, May 23, 8:50 AM
tomek closed D14631: [lib] Create a flag determining message side effects behavior.
Fri, May 23, 8:50 AM
tomek committed rCOMMbab25524666e: [lib] Create a flag determining message side effects behavior (authored by tomek).
[lib] Create a flag determining message side effects behavior
Fri, May 23, 8:50 AM
tomek closed D14747: [lib] Fix sharing initial state.
Fri, May 23, 3:51 AM
tomek committed rCOMM4f31f695b740: [lib] Fix sharing initial state (authored by tomek).
[lib] Fix sharing initial state
Fri, May 23, 3:51 AM
tomek added inline comments to D14634: [web] Display thread icon based on the specs.
Fri, May 23, 3:31 AM

Thu, May 22

tomek added inline comments to D14712: [lib] Choose thread ID behavior in the initial state gate based on the specs.
Thu, May 22, 6:20 AM
tomek updated the diff for D14712: [lib] Choose thread ID behavior in the initial state gate based on the specs.

Simplify

Thu, May 22, 6:20 AM
tomek updated the diff for D14641: [lib] Move converting DB threads to a spec.

Rebase

Thu, May 22, 6:06 AM
tomek updated the summary of D14634: [web] Display thread icon based on the specs.
Thu, May 22, 6:04 AM
tomek updated the diff for D14634: [web] Display thread icon based on the specs.

Simplify

Thu, May 22, 6:03 AM
tomek added a comment to D14634: [web] Display thread icon based on the specs.

I don't understand why iconCreationFunction is introduced. Can't we just have chatThreadListIcon in specs that is lock, server or something else in the future (depends on the protocol)?

  • lib doesn't know and doesn't care about actual icons and components as it should
  • native does <Icon name={iconName} size={12} style={iconStyle} /> where iconName comes from specs (as it does now)
  • web does
const icon = iconName === 'lock' ? lock : server;
...
<FontAwesomeIcon size="xs" className={iconClass} icon={icon} />

where iconName comes from specs

Thu, May 22, 6:02 AM
tomek added inline comments to D14632: [lib] Add a flag telling if messages are stored on a server.
Thu, May 22, 5:48 AM
tomek added a comment to D14631: [lib] Create a flag determining message side effects behavior.

LGTM but I wonder if those side effects and deciding when to call them should be included in the protocol and handled in sendTextMessage(...) method. Then every protocol (dm/keyserver/other) has just "sendTextMessage" method and protocol decides when side effects should be performed. Also in useCreationSideEffectsFunc there are also conditionals threadTypeIsThick so the side effects can be different for different protocols.
Or in other words: Imagine a user of the protocol who wants to send a text message. I think it's way easier to use if a protocol is just "sendTextMessage and I'll take care of the side effects and when to call them" instead of "call this sendTextMessage but before that use this boolean to check whether you should apply those side effects first or last".

Thu, May 22, 5:28 AM
tomek closed D14740: [lib] Debounce new OTKs response.
Thu, May 22, 5:18 AM