Paths

Table of Contentst

[web] introduce message searching to shared worker
ClosedPublic
Actions

Authored by kamil on Jul 23 2024, 10:05 AM.

Details

Reviewers

tomek
inka

Commits

rCOMM81fc7466f203: [web] introduce message searching to shared worker

Summary

The code on the web to interface with the search API exposed via WASM.

Depends on D12851

Test Plan

Tested later in the stack by @inka.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Jul 23 2024, 10:05 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptJul 23 2024, 10:05 AM

kamil added a child revision: D12853: [native] introduce message searching to `CommCoreModule`.Jul 23 2024, 10:09 AM

kamil edited the summary of this revision. (Show Details)Jul 23 2024, 10:27 AM

Harbormaster completed remote builds in B30597: Diff 42671.Jul 23 2024, 10:37 AM

kamil published this revision for review.Jul 23 2024, 12:03 PM

kamil added inline comments.

web/types/worker-types.js
298–306 ↗	(On Diff #42671)	we can merge those two and name something like `MessagesResponse` but not sure if worth

tomek accepted this revision.Jul 23 2024, 1:28 PM

tomek added inline comments.

web/types/worker-types.js
298–306 ↗	(On Diff #42671)	Sounds quite cheap, we can have e.g. `GetMessagesResponse`.

This revision is now accepted and ready to land.Jul 23 2024, 1:28 PM

merge types

Harbormaster completed remote builds in B30616: Diff 42703.Jul 23 2024, 3:14 PM

Closed by commit rCOMM81fc7466f203: [web] introduce message searching to shared worker. · Explain WhyJul 23 2024, 3:18 PM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM81fc7466f203: [web] introduce message searching to shared worker.

Revision Contents
Changeset List

Path

Size

web/

shared-worker/

worker/

shared-worker.js

13 lines

types/

worker-types.js

18 lines

Diff 42708

View Options

web/shared-worker/worker/shared-worker.js