Paths

Table of Contentst

Differential D12843

[SQLite] add method for message search to SQLiteQueryExecutor for both web and native
ClosedPublic
Actions

Authored by kamil on Jul 22 2024, 5:13 PM.

Tags

None

Referenced Files

None

Subscribers

Details

Reviewers

tomek
inka

Commits

rCOMMb290620829de: [SQLite] add method for message search to SQLiteQueryExecutor for both web and…

Summary

Defining API, logic will be implemented in searchMessages in the next diff.

Depends on D12833

Test Plan

N/A, just defining method arguments and returned type

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Jul 22 2024, 5:13 PM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptJul 22 2024, 5:13 PM

kamil added a child revision: D12844: [SQLite] implement query for searching messages.Jul 22 2024, 5:15 PM

Harbormaster failed remote builds in B30572: Diff 42636!Jul 22 2024, 5:35 PM

rebase

kamil edited parent revisions, added: D12794: [native] Add MessageSearchStoreOperations; removed: D12833: [lib][web][native] Create message search store ops.Jul 23 2024, 9:51 AM

Harbormaster completed remote builds in B30591: Diff 42665.Jul 23 2024, 10:07 AM

kamil edited the summary of this revision. (Show Details)Jul 23 2024, 10:24 AM

kamil added a parent revision: D12833: [lib][web][native] Create message search store ops.

kamil removed a parent revision: D12833: [lib][web][native] Create message search store ops.

kamil published this revision for review.Jul 23 2024, 12:03 PM

kamil added inline comments.

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp
2559 ↗	(On Diff #42665)	implemented in D12844
native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.h
206 ↗	(On Diff #42665)	for the web we need `MessageWithMedias`, and for native `MessageEntity` - this can be avoided after ENG-5719

tomek accepted this revision.Jul 23 2024, 1:10 PM

tomek added inline comments.

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp
2625 ↗	(On Diff #42665)
2628 ↗	(On Diff #42665)	Why do we move only the first item?

This revision is now accepted and ready to land.Jul 23 2024, 1:10 PM

inka accepted this revision.Jul 23 2024, 1:14 PM

marcin subscribed.Jul 23 2024, 2:15 PM

marcin added inline comments.

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp
2628 ↗	(On Diff #42665)	The type of `messageWithMedia.first` is `Message`. The `Message` type has `unique_ptr` fields. Therefore it doesn't have copy constructor so it must be moved when passing to function.

rename

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp
2628 ↗	(On Diff #42665)	Thanks!

kamil removed a parent revision: D12833: [lib][web][native] Create message search store ops.Jul 23 2024, 2:16 PM

Harbormaster completed remote builds in B30611: Diff 42698.Jul 23 2024, 2:32 PM

Closed by commit rCOMMb290620829de: [SQLite] add method for message search to SQLiteQueryExecutor for both web and…. · Explain WhyJul 23 2024, 3:18 PM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMb290620829de: [SQLite] add method for message search to SQLiteQueryExecutor for both web and….

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

DatabaseManagers/

DatabaseQueryExecutor.h

10 lines

SQLiteQueryExecutor.h

10 lines

SQLiteQueryExecutor.cpp

26 lines

web/

shared-worker/

_generated/

comm_query_executor.wasm

Diff 42704

native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h

Loading...

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.h

Loading...

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

Loading...

web/shared-worker/_generated/comm_query_executor.wasm

Loading...