Page MenuHomePhabricator

[native][web] Handle deleted messages when searching
ClosedPublic

Authored by tomek on Tue, Apr 8, 4:01 AM.
Tags
None
Referenced Files
F6079279: D14557.id47801.diff
Sun, Apr 20, 5:45 PM
Unknown Object (File)
Sat, Apr 19, 11:32 AM
Unknown Object (File)
Sat, Apr 19, 5:30 AM
Unknown Object (File)
Sat, Apr 19, 1:36 AM
Unknown Object (File)
Sat, Apr 19, 12:59 AM
Unknown Object (File)
Fri, Apr 18, 12:00 PM
Unknown Object (File)
Fri, Apr 18, 5:43 AM
Unknown Object (File)
Tue, Apr 15, 5:05 PM
Subscribers
None

Details

Summary

Delete from a search index when deleting a message.

https://linear.app/comm/issue/ENG-10517/consider-deleted-message-in-message-search

Depends on D14556

Test Plan

In a thick thread: created a message, deleted it, sent 20 more messages, changed active thread, refreshed the app, opened the previous active thread, and searched for the message. After this diff - mo messages are shown. Before this diff - the original message content was shown (if less than 20 messages were sent, the deleted message was shown in the results).

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tomek requested review of this revision.Tue, Apr 8, 4:19 AM
This revision is now accepted and ready to land.Tue, Apr 8, 6:37 AM