Delete from a search index when deleting a message.
https://linear.app/comm/issue/ENG-10517/consider-deleted-message-in-message-search
Depends on D14556
Paths
| Differential D14557 Authored by tomek on Tue, Apr 8, 4:01 AM.
Tags None Referenced Files
Subscribers None
Details Summary Delete from a search index when deleting a message. https://linear.app/comm/issue/ENG-10517/consider-deleted-message-in-message-search Depends on D14556 Test Plan In a thick thread: created a message, deleted it, sent 20 more messages, changed active thread, refreshed the app, opened the previous active thread, and searched for the message. After this diff - mo messages are shown. Before this diff - the original message content was shown (if less than 20 messages were sent, the deleted message was shown in the results).
Diff Detail
Event TimelineHarbormaster completed remote builds in B33927: Diff 47706.Tue, Apr 8, 4:19 AM2025-04-08 04:19:08 (UTC-7) This revision is now accepted and ready to land.Tue, Apr 8, 6:37 AM2025-04-08 06:37:04 (UTC-7) Harbormaster completed remote builds in B33934: Diff 47716.Wed, Apr 9, 8:43 AM2025-04-09 08:43:10 (UTC-7) Harbormaster completed remote builds in B33960: Diff 47744.Thu, Apr 10, 8:21 AM2025-04-10 08:21:12 (UTC-7) Harbormaster completed remote builds in B33980: Diff 47771.Mon, Apr 14, 5:47 AM2025-04-14 05:47:33 (UTC-7) Closed by commit rCOMMfa997d9f1afd: [native][web] Handle deleted messages when searching (authored by tomek). · Explain WhyTue, Apr 15, 2:11 AM2025-04-15 02:11:47 (UTC-7) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 47800 lib/message-search-types.js
lib/reducers/db-ops-reducer.js
native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h
native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.h
native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp
native/cpp/CommonCpp/NativeModules/MessageSearchStoreOperations.h
native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/DataStores/MessageSearchStore.h
native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/DataStores/MessageSearchStore.cpp
|