This spec is mostly inspired by the one for EDIT_MESSAGE
https://linear.app/comm/issue/ENG-10326/add-a-spec-for-the-delete-message-message
Depends on D14510
Details
Details
- Reviewers
kamil ashoat - Commits
- rCOMM1de1b945b503: [lib] Introduce delete message spec
Flow. Tested later in the stack.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| lib/shared/messages/delete-message-spec.js | ||
|---|---|---|
| 108–109 ↗ | (On Diff #47610) | Interesting that you use FUTURE_CODE_VERSION here but you used NEXT_CODE_VERSION earlier in the stack. I guess we want to introduce the migrations earlier than we want the messages unshimmed? Is there a downside to introducing the unshimming at the same time? |
| lib/shared/messages/delete-message-spec.js | ||
|---|---|---|
| 108–109 ↗ | (On Diff #47610) | I think the safest approach is to use FUTURE_CODE_VERSION initially and then replace it with NEXT_CODE_VERSION in a diff that e.g. performs a migration. By taking this approach we're making sure that there's no chance to introduce an issue by landing only a part of the stack. Update the earlier diff with FUTURE_CODE_VERSION. |