Page MenuHomePhabricator
Differential D14510

[lib] Introduce a new message type
AcceptedPublic
Actions

Authored by tomek on Fri, Mar 28, 4:10 AM.
Tags
None
Referenced Files
F5099905: D14510.id.diff
Mon, Mar 31, 9:20 AM
F5098475: D14510.id47609.diff
Mon, Mar 31, 3:19 AM
F5093967: D14510.diff
Sun, Mar 30, 2:04 PM
Subscribers
None

Details

Reviewers
kamil
ashoat
Summary

Introduce a new message type for deleting a message

https://linear.app/comm/issue/ENG-10325/create-a-new-message-type

Depends on D14505

Test Plan

Flow

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

tomek created this revision.Fri, Mar 28, 4:10 AM
Harbormaster completed remote builds in B33861: Diff 47608.Fri, Mar 28, 4:29 AM
tomek requested review of this revision.Fri, Mar 28, 4:29 AM
tomek updated this revision to Diff 47609.Fri, Mar 28, 4:44 AM

Modify some more types, test the validator

tomek added inline comments.Fri, Mar 28, 4:46 AM
lib/selectors/chat-selectors.js
461 ↗(On Diff #47609)

This is temporary just to make sure Flow doesn't complain. Implementing the proper solution is a part of the client side work.

lib/shared/messages/delete-message-spec.js
65 ↗(On Diff #47609)

We're introducing this whole spec just to have this line - to make sure the tests work. The functions that were introduced here are mandatory. More functions will be implemented later.

Harbormaster completed remote builds in B33862: Diff 47609.Fri, Mar 28, 5:03 AM
tomek added a child revision: D14511: [lib] Introduce a message spec.Fri, Mar 28, 5:45 AM
ashoat accepted this revision.Fri, Mar 28, 6:42 AM

Can you retitle all of the diffs in this stack to explicitly reference message deletion? Just realized that they're just generically titled.

This revision is now accepted and ready to land.Fri, Mar 28, 6:42 AM
tomek updated this revision to Diff 47611.Fri, Mar 28, 6:46 AM

Expand MessageData

Harbormaster failed remote builds in B33864: Diff 47611!Fri, Mar 28, 6:55 AM

Revision Contents
Changeset List

PathSize
lib/
selectors/
3 lines
shared/
10 lines
messages/
66 lines
2 lines
types/
4 lines
16 lines
messages/
39 lines
9 lines
8 lines

Diff 47611

View Options

lib/selectors/chat-selectors.js

Show First 20 Lines • Show All 68 Lines • ▼ Show 20 Lines runtime_platform {
cpu_architecture = "ARM64" cpu_architecture = "ARM64"
operating_system_family = "LINUX" operating_system_family = "LINUX"
} }
# Wait indefinitely for primary service to become healthy before deploying secondary service # Wait indefinitely for primary service to become healthy before deploying secondary service
provisioner "local-exec" { provisioner "local-exec" {
command = <<EOT command = <<EOT
while true; do while true; do
if curl --silent --output /dev/null --fail "https://${var.domain_name}/health"; then if curl --silent --output /dev/null --fail "https://${var.keyserver_domain_name}/health"; then
echo "Primary service is healthy. Proceeding with deployment of secondary service." echo "Primary service is healthy. Proceeding with deployment of secondary service."
exit 0 exit 0
else else
echo "Primary service is not healthy yet. Waiting 10 seconds before checking again..." echo "Primary service is not healthy yet. Waiting 10 seconds before checking again..."
sleep 10 sleep 10
fi fi
done done
EOT EOT
Show All 35 Lines
View Options

lib/shared/message-utils.js

Show First 20 Lines • Show All 68 Lines • ▼ Show 20 Lines runtime_platform {
cpu_architecture = "ARM64" cpu_architecture = "ARM64"
operating_system_family = "LINUX" operating_system_family = "LINUX"
} }
# Wait indefinitely for primary service to become healthy before deploying secondary service # Wait indefinitely for primary service to become healthy before deploying secondary service
provisioner "local-exec" { provisioner "local-exec" {
command = <<EOT command = <<EOT
while true; do while true; do
if curl --silent --output /dev/null --fail "https://${var.domain_name}/health"; then if curl --silent --output /dev/null --fail "https://${var.keyserver_domain_name}/health"; then
echo "Primary service is healthy. Proceeding with deployment of secondary service." echo "Primary service is healthy. Proceeding with deployment of secondary service."
exit 0 exit 0
else else
echo "Primary service is not healthy yet. Waiting 10 seconds before checking again..." echo "Primary service is not healthy yet. Waiting 10 seconds before checking again..."
sleep 10 sleep 10
fi fi
done done
EOT EOT
Show All 35 Lines
View Options

lib/shared/messages/delete-message-spec.js

Show First 20 Lines • Show All 68 Lines • ▼ Show 20 Lines runtime_platform {
cpu_architecture = "ARM64" cpu_architecture = "ARM64"
operating_system_family = "LINUX" operating_system_family = "LINUX"
} }
# Wait indefinitely for primary service to become healthy before deploying secondary service # Wait indefinitely for primary service to become healthy before deploying secondary service
provisioner "local-exec" { provisioner "local-exec" {
command = <<EOT command = <<EOT
while true; do while true; do
if curl --silent --output /dev/null --fail "https://${var.domain_name}/health"; then if curl --silent --output /dev/null --fail "https://${var.keyserver_domain_name}/health"; then
echo "Primary service is healthy. Proceeding with deployment of secondary service." echo "Primary service is healthy. Proceeding with deployment of secondary service."
exit 0 exit 0
else else
echo "Primary service is not healthy yet. Waiting 10 seconds before checking again..." echo "Primary service is not healthy yet. Waiting 10 seconds before checking again..."
sleep 10 sleep 10
fi fi
done done
EOT EOT
Show All 35 Lines
View Options

lib/shared/messages/message-specs.js

Show First 20 Lines • Show All 68 Lines • ▼ Show 20 Lines runtime_platform {
cpu_architecture = "ARM64" cpu_architecture = "ARM64"
operating_system_family = "LINUX" operating_system_family = "LINUX"
} }
# Wait indefinitely for primary service to become healthy before deploying secondary service # Wait indefinitely for primary service to become healthy before deploying secondary service
provisioner "local-exec" { provisioner "local-exec" {
command = <<EOT command = <<EOT
while true; do while true; do
if curl --silent --output /dev/null --fail "https://${var.domain_name}/health"; then if curl --silent --output /dev/null --fail "https://${var.keyserver_domain_name}/health"; then
echo "Primary service is healthy. Proceeding with deployment of secondary service." echo "Primary service is healthy. Proceeding with deployment of secondary service."
exit 0 exit 0
else else
echo "Primary service is not healthy yet. Waiting 10 seconds before checking again..." echo "Primary service is not healthy yet. Waiting 10 seconds before checking again..."
sleep 10 sleep 10
fi fi
done done
EOT EOT
Show All 35 Lines
View Options

lib/types/message-types-enum.js

Show First 20 Lines • Show All 68 Lines • ▼ Show 20 Lines runtime_platform {
cpu_architecture = "ARM64" cpu_architecture = "ARM64"
operating_system_family = "LINUX" operating_system_family = "LINUX"
} }
# Wait indefinitely for primary service to become healthy before deploying secondary service # Wait indefinitely for primary service to become healthy before deploying secondary service
provisioner "local-exec" { provisioner "local-exec" {
command = <<EOT command = <<EOT
while true; do while true; do
if curl --silent --output /dev/null --fail "https://${var.domain_name}/health"; then if curl --silent --output /dev/null --fail "https://${var.keyserver_domain_name}/health"; then
echo "Primary service is healthy. Proceeding with deployment of secondary service." echo "Primary service is healthy. Proceeding with deployment of secondary service."
exit 0 exit 0
else else
echo "Primary service is not healthy yet. Waiting 10 seconds before checking again..." echo "Primary service is not healthy yet. Waiting 10 seconds before checking again..."
sleep 10 sleep 10
fi fi
done done
EOT EOT
Show All 35 Lines
View Options

lib/types/message-types.js

Show First 20 Lines • Show All 68 Lines • ▼ Show 20 Lines runtime_platform {
cpu_architecture = "ARM64" cpu_architecture = "ARM64"
operating_system_family = "LINUX" operating_system_family = "LINUX"
} }
# Wait indefinitely for primary service to become healthy before deploying secondary service # Wait indefinitely for primary service to become healthy before deploying secondary service
provisioner "local-exec" { provisioner "local-exec" {
command = <<EOT command = <<EOT
while true; do while true; do
if curl --silent --output /dev/null --fail "https://${var.domain_name}/health"; then if curl --silent --output /dev/null --fail "https://${var.keyserver_domain_name}/health"; then
echo "Primary service is healthy. Proceeding with deployment of secondary service." echo "Primary service is healthy. Proceeding with deployment of secondary service."
exit 0 exit 0
else else
echo "Primary service is not healthy yet. Waiting 10 seconds before checking again..." echo "Primary service is not healthy yet. Waiting 10 seconds before checking again..."
sleep 10 sleep 10
fi fi
done done
EOT EOT
Show All 35 Lines
View Options

lib/types/messages/delete.js

Show First 20 Lines • Show All 68 Lines • ▼ Show 20 Lines runtime_platform {
cpu_architecture = "ARM64" cpu_architecture = "ARM64"
operating_system_family = "LINUX" operating_system_family = "LINUX"
} }
# Wait indefinitely for primary service to become healthy before deploying secondary service # Wait indefinitely for primary service to become healthy before deploying secondary service
provisioner "local-exec" { provisioner "local-exec" {
command = <<EOT command = <<EOT
while true; do while true; do
if curl --silent --output /dev/null --fail "https://${var.domain_name}/health"; then if curl --silent --output /dev/null --fail "https://${var.keyserver_domain_name}/health"; then
echo "Primary service is healthy. Proceeding with deployment of secondary service." echo "Primary service is healthy. Proceeding with deployment of secondary service."
exit 0 exit 0
else else
echo "Primary service is not healthy yet. Waiting 10 seconds before checking again..." echo "Primary service is not healthy yet. Waiting 10 seconds before checking again..."
sleep 10 sleep 10
fi fi
done done
EOT EOT
Show All 35 Lines
View Options

lib/types/messages/unsupported.js

Loading...
View Options

lib/types/validation.test.js

Loading...