Page MenuHomePhabricator
Differential D14511

[lib] Introduce delete message spec
ClosedPublic
Actions

Authored by tomek on Fri, Mar 28, 5:45 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 12, 10:59 AM
Unknown Object (File)
Tue, Apr 8, 12:13 PM
Unknown Object (File)
Tue, Apr 8, 11:21 AM
Unknown Object (File)
Mon, Apr 7, 3:21 PM
Unknown Object (File)
Sun, Apr 6, 3:36 PM
Unknown Object (File)
Sun, Apr 6, 8:30 AM
Unknown Object (File)
Fri, Apr 4, 11:42 PM
Unknown Object (File)
Thu, Apr 3, 11:56 PM
View All 18 Files
Subscribers
None

Details

Reviewers
kamil
ashoat
Commits
rCOMM1de1b945b503: [lib] Introduce delete message spec
Summary

This spec is mostly inspired by the one for EDIT_MESSAGE

https://linear.app/comm/issue/ENG-10326/add-a-spec-for-the-delete-message-message

Depends on D14510

Test Plan

Flow. Tested later in the stack.

Diff Detail

Repository
rCOMM Comm
Branch
delete-messages
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

tomek created this revision.Fri, Mar 28, 5:45 AM
Harbormaster completed remote builds in B33863: Diff 47610.Fri, Mar 28, 6:04 AM
tomek requested review of this revision.Fri, Mar 28, 6:04 AM
ashoat accepted this revision.Fri, Mar 28, 6:45 AM
ashoat added inline comments.
lib/shared/messages/delete-message-spec.js
108–109

Interesting that you use FUTURE_CODE_VERSION here but you used NEXT_CODE_VERSION earlier in the stack. I guess we want to introduce the migrations earlier than we want the messages unshimmed? Is there a downside to introducing the unshimming at the same time?

This revision is now accepted and ready to land.Fri, Mar 28, 6:45 AM
tomek retitled this revision from [lib] Introduce a message spec to [lib] Introduce delete message spec.Thu, Apr 3, 8:16 AM
tomek added inline comments.Thu, Apr 3, 8:19 AM
lib/shared/messages/delete-message-spec.js
108–109

I think the safest approach is to use FUTURE_CODE_VERSION initially and then replace it with NEXT_CODE_VERSION in a diff that e.g. performs a migration. By taking this approach we're making sure that there's no chance to introduce an issue by landing only a part of the stack. Update the earlier diff with FUTURE_CODE_VERSION.

tomek added a child revision: D14534: [lib] Add a new endpoint for deleting messages.Thu, Apr 3, 8:21 AM
Closed by commit rCOMM1de1b945b503: [lib] Introduce delete message spec (authored by tomek). · Explain WhyTue, Apr 15, 2:11 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMM1de1b945b503: [lib] Introduce delete message spec.

Revision Contents
Changeset List

PathSize
lib/
shared/
messages/
75 lines

Diff 47610

View Options

lib/shared/messages/delete-message-spec.js

Show All 13 Lines
} }
jsi::Value CommRustModule::generateNonce(jsi::Runtime &rt) { jsi::Value CommRustModule::generateNonce(jsi::Runtime &rt) {
return createPromiseAsJSIValue( return createPromiseAsJSIValue(
rt, [this](jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) { rt, [this](jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) {
std::string error; std::string error;
try { try {
auto currentID = RustPromiseManager::instance.addPromise( auto currentID = RustPromiseManager::instance.addPromise(
promise, this->jsInvoker_, innerRt); {promise, this->jsInvoker_, innerRt});
identityGenerateNonce(currentID); identityGenerateNonce(currentID);
} catch (const std::exception &e) { } catch (const std::exception &e) {
error = e.what(); error = e.what();
}; };
if (!error.empty()) { if (!error.empty()) {
this->jsInvoker_->invokeAsync( this->jsInvoker_->invokeAsync(
[error, promise]() { promise->reject(error); }); [error, promise]() { promise->reject(error); });
} }
Show All 25 Linesjsi::Value CommRustModule::registerUser(
auto contentOneTimeKeysRust = jsiStringArrayToRustVec(contentOneTimeKeys, rt); auto contentOneTimeKeysRust = jsiStringArrayToRustVec(contentOneTimeKeys, rt);
auto notifOneTimeKeysRust = jsiStringArrayToRustVec(notifOneTimeKeys, rt); auto notifOneTimeKeysRust = jsiStringArrayToRustVec(notifOneTimeKeys, rt);
return createPromiseAsJSIValue( return createPromiseAsJSIValue(
rt, [=, this](jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) { rt, [=, this](jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) {
std::string error; std::string error;
try { try {
auto currentID = RustPromiseManager::instance.addPromise( auto currentID = RustPromiseManager::instance.addPromise(
promise, this->jsInvoker_, innerRt); {promise, this->jsInvoker_, innerRt});
identityRegisterUser( identityRegisterUser(
usernameRust, usernameRust,
passwordRust, passwordRust,
keyPayloadRust, keyPayloadRust,
keyPayloadSignatureRust, keyPayloadSignatureRust,
contentPrekeyRust, contentPrekeyRust,
contentPrekeySignatureRust, contentPrekeySignatureRust,
notifPrekeyRust, notifPrekeyRust,
Show All 36 Linesjsi::Value CommRustModule::loginPasswordUser(
auto contentOneTimeKeysRust = jsiStringArrayToRustVec(contentOneTimeKeys, rt); auto contentOneTimeKeysRust = jsiStringArrayToRustVec(contentOneTimeKeys, rt);
auto notifOneTimeKeysRust = jsiStringArrayToRustVec(notifOneTimeKeys, rt); auto notifOneTimeKeysRust = jsiStringArrayToRustVec(notifOneTimeKeys, rt);
return createPromiseAsJSIValue( return createPromiseAsJSIValue(
rt, [=, this](jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) { rt, [=, this](jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) {
std::string error; std::string error;
try { try {
auto currentID = RustPromiseManager::instance.addPromise( auto currentID = RustPromiseManager::instance.addPromise(
promise, this->jsInvoker_, innerRt); {promise, this->jsInvoker_, innerRt});
identityLoginPasswordUser( identityLoginPasswordUser(
usernameRust, usernameRust,
passwordRust, passwordRust,
keyPayloadRust, keyPayloadRust,
keyPayloadSignatureRust, keyPayloadSignatureRust,
contentPrekeyRust, contentPrekeyRust,
contentPrekeySignatureRust, contentPrekeySignatureRust,
notifPrekeyRust, notifPrekeyRust,
Show All 38 Linesjsi::Value CommRustModule::loginWalletUser(
auto notifOneTimeKeysRust = jsiStringArrayToRustVec(notifOneTimeKeys, rt); auto notifOneTimeKeysRust = jsiStringArrayToRustVec(notifOneTimeKeys, rt);
auto socialProofRust = jsiStringToRustString(socialProof, rt); auto socialProofRust = jsiStringToRustString(socialProof, rt);
return createPromiseAsJSIValue( return createPromiseAsJSIValue(
rt, [=, this](jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) { rt, [=, this](jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) {
std::string error; std::string error;
try { try {
auto currentID = RustPromiseManager::instance.addPromise( auto currentID = RustPromiseManager::instance.addPromise(
promise, this->jsInvoker_, innerRt); {promise, this->jsInvoker_, innerRt});
identityLoginWalletUser( identityLoginWalletUser(
siweMessageRust, siweMessageRust,
siweSignatureRust, siweSignatureRust,
keyPayloadRust, keyPayloadRust,
keyPayloadSignatureRust, keyPayloadSignatureRust,
contentPrekeyRust, contentPrekeyRust,
contentPrekeySignatureRust, contentPrekeySignatureRust,
notifPrekeyRust, notifPrekeyRust,
Show All 23 Linesjsi::Value CommRustModule::updatePassword(
auto accessTokenRust = jsiStringToRustString(accessToken, rt); auto accessTokenRust = jsiStringToRustString(accessToken, rt);
auto passwordRust = jsiStringToRustString(password, rt); auto passwordRust = jsiStringToRustString(password, rt);
return createPromiseAsJSIValue( return createPromiseAsJSIValue(
rt, [=, this](jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) { rt, [=, this](jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) {
std::string error; std::string error;
try { try {
auto currentID = RustPromiseManager::instance.addPromise( auto currentID = RustPromiseManager::instance.addPromise(
promise, this->jsInvoker_, innerRt); {promise, this->jsInvoker_, innerRt});
identityUpdateUserPassword( identityUpdateUserPassword(
userIDRust, userIDRust,
deviceIDRust, deviceIDRust,
accessTokenRust, accessTokenRust,
passwordRust, passwordRust,
currentID); currentID);
} catch (const std::exception &e) { } catch (const std::exception &e) {
error = e.what(); error = e.what();
Show All 14 Linesjsi::Value CommRustModule::deleteUser(
auto deviceIDRust = jsiStringToRustString(deviceID, rt); auto deviceIDRust = jsiStringToRustString(deviceID, rt);
auto accessTokenRust = jsiStringToRustString(accessToken, rt); auto accessTokenRust = jsiStringToRustString(accessToken, rt);
return createPromiseAsJSIValue( return createPromiseAsJSIValue(
rt, [=, this](jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) { rt, [=, this](jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) {
std::string error; std::string error;
try { try {
auto currentID = RustPromiseManager::instance.addPromise( auto currentID = RustPromiseManager::instance.addPromise(
promise, this->jsInvoker_, innerRt); {promise, this->jsInvoker_, innerRt});
identityDeleteUser( identityDeleteUser(
userIDRust, deviceIDRust, accessTokenRust, currentID); userIDRust, deviceIDRust, accessTokenRust, currentID);
} catch (const std::exception &e) { } catch (const std::exception &e) {
error = e.what(); error = e.what();
}; };
if (!error.empty()) { if (!error.empty()) {
this->jsInvoker_->invokeAsync( this->jsInvoker_->invokeAsync(
[error, promise]() { promise->reject(error); }); [error, promise]() { promise->reject(error); });
Show All 12 Linesjsi::Value CommRustModule::getOutboundKeysForUser(
auto authAccessTokenRust = jsiStringToRustString(authAccessToken, rt); auto authAccessTokenRust = jsiStringToRustString(authAccessToken, rt);
auto userIDRust = jsiStringToRustString(userID, rt); auto userIDRust = jsiStringToRustString(userID, rt);
return createPromiseAsJSIValue( return createPromiseAsJSIValue(
rt, [=, this](jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) { rt, [=, this](jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) {
std::string error; std::string error;
try { try {
auto currentID = RustPromiseManager::instance.addPromise( auto currentID = RustPromiseManager::instance.addPromise(
promise, this->jsInvoker_, innerRt); {promise, this->jsInvoker_, innerRt});
identityGetOutboundKeysForUser( identityGetOutboundKeysForUser(
authUserIDRust, authUserIDRust,
authDeviceIDRust, authDeviceIDRust,
authAccessTokenRust, authAccessTokenRust,
userIDRust, userIDRust,
currentID); currentID);
} catch (const std::exception &e) { } catch (const std::exception &e) {
error = e.what(); error = e.what();
Show All 16 Linesjsi::Value CommRustModule::getInboundKeysForUser(
auto authAccessTokenRust = jsiStringToRustString(authAccessToken, rt); auto authAccessTokenRust = jsiStringToRustString(authAccessToken, rt);
auto userIDRust = jsiStringToRustString(userID, rt); auto userIDRust = jsiStringToRustString(userID, rt);
return createPromiseAsJSIValue( return createPromiseAsJSIValue(
rt, [=, this](jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) { rt, [=, this](jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) {
std::string error; std::string error;
try { try {
auto currentID = RustPromiseManager::instance.addPromise( auto currentID = RustPromiseManager::instance.addPromise(
promise, this->jsInvoker_, innerRt); {promise, this->jsInvoker_, innerRt});
identityGetInboundKeysForUser( identityGetInboundKeysForUser(
authUserIDRust, authUserIDRust,
authDeviceIDRust, authDeviceIDRust,
authAccessTokenRust, authAccessTokenRust,
userIDRust, userIDRust,
currentID); currentID);
} catch (const std::exception &e) { } catch (const std::exception &e) {
error = e.what(); error = e.what();
}; };
if (!error.empty()) { if (!error.empty()) {
this->jsInvoker_->invokeAsync( this->jsInvoker_->invokeAsync(
[error, promise]() { promise->reject(error); }); [error, promise]() { promise->reject(error); });
} }
}); });
} }
jsi::Value CommRustModule::versionSupported(jsi::Runtime &rt) { jsi::Value CommRustModule::versionSupported(jsi::Runtime &rt) {
return createPromiseAsJSIValue( return createPromiseAsJSIValue(
rt, [=, this](jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) { rt, [=, this](jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) {
std::string error; std::string error;
try { try {
auto currentID = RustPromiseManager::instance.addPromise( auto currentID = RustPromiseManager::instance.addPromise(
promise, this->jsInvoker_, innerRt); {promise, this->jsInvoker_, innerRt});
identityVersionSupported(currentID); identityVersionSupported(currentID);
} catch (const std::exception &e) { } catch (const std::exception &e) {
error = e.what(); error = e.what();
}; };
if (!error.empty()) { if (!error.empty()) {
this->jsInvoker_->invokeAsync( this->jsInvoker_->invokeAsync(
[error, promise]() { promise->reject(error); }); [error, promise]() { promise->reject(error); });
} }
Show All 15 Linesjsi::Value CommRustModule::uploadOneTimeKeys(
auto notifOneTimePreKeysRust = auto notifOneTimePreKeysRust =
jsiStringArrayToRustVec(notifOneTimePreKeys, rt); jsiStringArrayToRustVec(notifOneTimePreKeys, rt);
return createPromiseAsJSIValue( return createPromiseAsJSIValue(
rt, [=, this](jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) { rt, [=, this](jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) {
std::string error; std::string error;
try { try {
auto currentID = RustPromiseManager::instance.addPromise( auto currentID = RustPromiseManager::instance.addPromise(
promise, this->jsInvoker_, innerRt); {promise, this->jsInvoker_, innerRt});
identityUploadOneTimeKeys( identityUploadOneTimeKeys(
authUserIDRust, authUserIDRust,
authDeviceIDRust, authDeviceIDRust,
authAccessTokenRust, authAccessTokenRust,
contentOneTimePreKeysRust, contentOneTimePreKeysRust,
notifOneTimePreKeysRust, notifOneTimePreKeysRust,
currentID); currentID);
} catch (const std::exception &e) { } catch (const std::exception &e) {
Show All 17 Linesjsi::Value CommRustModule::getKeyserverKeys(
auto authAccessTokenRust = jsiStringToRustString(authAccessToken, rt); auto authAccessTokenRust = jsiStringToRustString(authAccessToken, rt);
auto keyserverIDRust = jsiStringToRustString(keyserverID, rt); auto keyserverIDRust = jsiStringToRustString(keyserverID, rt);
return createPromiseAsJSIValue( return createPromiseAsJSIValue(
rt, [=, this](jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) { rt, [=, this](jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) {
std::string error; std::string error;
try { try {
auto currentID = RustPromiseManager::instance.addPromise( auto currentID = RustPromiseManager::instance.addPromise(
promise, this->jsInvoker_, innerRt); {promise, this->jsInvoker_, innerRt});
identityGetKeyserverKeys( identityGetKeyserverKeys(
authUserIDRust, authUserIDRust,
authDeviceIDRust, authDeviceIDRust,
authAccessTokenRust, authAccessTokenRust,
keyserverIDRust, keyserverIDRust,
currentID); currentID);
} catch (const std::exception &e) { } catch (const std::exception &e) {
error = e.what(); error = e.what();
Show All 9 Lines