[web] Disable all the actions for a deleted message
ClosedPublic
Actions

Authored by tomek on Fri, Apr 4, 6:46 AM.

Details

Reviewers

kamil
ashoat

Commits

rCOMM71fb511b2e08: [web] Disable all the actions for a deleted message

Summary

When a message is deleted, we shouldn't be able to perform any action to it, e.g. edit, react, pin, etc. On native, it is handled automatically because DeletedMessage doesn't handle a click action. On web, we have to set the tooltip actions to an empty array.

https://linear.app/comm/issue/ENG-10494/update-reaction-logic

web-deleted-tooltip.png (462×706 px, 32 KB)

Depends on D14546

Test Plan

Checked on both native and web that it isn't possible to e.g. react to a deleted message.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Fri, Apr 4, 6:46 AM

Harbormaster completed remote builds in B33907: Diff 47659.Fri, Apr 4, 7:05 AM

tomek requested review of this revision.Fri, Apr 4, 7:05 AM

tomek added a child revision: D14548: [native][web] Hide edit label and reactions of deleted messages.Fri, Apr 4, 7:11 AM

Can you share a screenshot of what a mouseover looks like in this case? Wondering if the timestamp still appears, and where it appears

This revision is now accepted and ready to land.Fri, Apr 4, 8:50 AM

In D14547#403433, @ashoat wrote:

Can you share a screenshot of what a mouseover looks like in this case? Wondering if the timestamp still appears, and where it appears

Sure! It appears but is displayed slightly off.