[lib] Don't show a message deleting other message in a preview
ClosedPublic
Actions

Authored by tomek on Apr 4 2025, 6:45 PM.

Details

Reviewers

kamil
ashoat

Commits

rCOMMca315ab5b492: [lib] Don't show a message deleting other message in a preview

Summary

When the most recent message is of delete message type, it shouldn't be shown in the preview.

https://linear.app/comm/issue/ENG-10462/make-sure-that-deleted-messages-are-displayed-correctly-in-the-preview

Depends on D14549

Test Plan

Deleted a message and made sure it isn't shown in the preview.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Apr 4 2025, 6:45 PM

tomek added a child revision: D14551: [lib] Don't show a deleted message in a preview.

Harbormaster completed remote builds in B33911: Diff 47663.Apr 4 2025, 7:04 PM

tomek requested review of this revision.Apr 4 2025, 7:04 PM

ashoat accepted this revision.Apr 4 2025, 9:24 PM

This revision is now accepted and ready to land.Apr 4 2025, 9:24 PM

Closed by commit rCOMMca315ab5b492: [lib] Don't show a message deleting other message in a preview. · Explain WhyApr 15 2025, 9:11 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMMca315ab5b492: [lib] Don't show a message deleting other message in a preview.

Revision Contents
Changeset List

Path

Size

lib/

shared/

messages/

delete-message-spec.js

2 lines

Diff 47796

View Options

lib/shared/messages/delete-message-spec.js

[lib] Don't show a message deleting other message in a previewClosedPublicActions