Page MenuHomePhabricator
Differential D14542

[native][web] Show an option to delete a message
ClosedPublic
Actions

Authored by tomek on Fri, Apr 4, 3:24 AM.
Tags
None
Referenced Files
F5754751: D14542.id47714.diff
Mon, Apr 14, 11:53 AM
Unknown Object (File)
Mon, Apr 14, 2:01 AM
Unknown Object (File)
Sat, Apr 12, 7:56 PM
Unknown Object (File)
Thu, Apr 10, 11:10 AM
Unknown Object (File)
Wed, Apr 9, 3:44 PM
F5353067: web-delete-icon.png
Wed, Apr 9, 9:46 AM
F5353064: web-delete-icon.png
Wed, Apr 9, 9:45 AM
Unknown Object (File)
Wed, Apr 9, 6:37 AM
View All 25 Files
Subscribers
None

Details

Reviewers
kamil
ashoat
Commits
rCOMMad759e247eee: [native][web] Show an option to delete a message
Summary

Add a new option to our tooltips. Its presence is based on permissions, so it's better to land this diff together with the rest of this stack.

https://linear.app/comm/issue/ENG-10344/show-an-option-in-the-ui-to-delete-a-message

Web:

web-delete-icon.png (160×624 px, 12 KB)

Native:

delete-button-native-2.png (270×448 px, 27 KB)

delete-button-native-1.png (439×451 px, 50 KB)

Depends on D14541

Test Plan

Checked on both native and web if it is possible to delete a message.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tomek created this revision.Fri, Apr 4, 3:24 AM
tomek edited the summary of this revision. (Show Details)Fri, Apr 4, 3:42 AM
Harbormaster completed remote builds in B33901: Diff 47653.Fri, Apr 4, 3:42 AM
tomek requested review of this revision.Fri, Apr 4, 3:42 AM
tomek edited the summary of this revision. (Show Details)Fri, Apr 4, 3:42 AM
tomek added a child revision: D14543: [lib] Update chat selector to return an info telling if a message was deleted.Fri, Apr 4, 3:53 AM
ashoat added a comment.Fri, Apr 4, 7:21 AM

For web I agree the style of the icon should be more similar (outline vs fill). For native, does the action sheet only pop up if there are too many actions, and the user clicks more to see the extra actions?

tomek added a comment.Fri, Apr 4, 7:25 AM

For web I agree the style of the icon should be more similar (outline vs fill).

Ok, I'll search for something else

For native, does the action sheet only pop up if there are too many actions, and the user clicks more to see the extra actions?

Yes, exactly

ashoat requested changes to this revision.Fri, Apr 4, 8:54 AM

I want to review the icon before landing, but this generally looks good

lib/utils/delete-message-utils.js
107–108 ↗(On Diff #47653)

Should we use a utility that checks if the type is composable?

This revision now requires changes to proceed.Fri, Apr 4, 8:54 AM
tomek updated this revision to Diff 47714.Wed, Apr 9, 8:15 AM

Close the tooltip after deleting a message

tomek planned changes to this revision.Wed, Apr 9, 8:15 AM
Harbormaster completed remote builds in B33932: Diff 47714.Wed, Apr 9, 8:33 AM
tomek updated this revision to Diff 47721.Wed, Apr 9, 9:44 AM

Use the util and replace the web icon

tomek edited the summary of this revision. (Show Details)Wed, Apr 9, 9:45 AM
In D14542#403439, @ashoat wrote:

I want to review the icon before landing, but this generally looks good

Replaced the icon with something from FontAwesome

web-delete-icon.png (160×624 px, 12 KB)

Harbormaster completed remote builds in B33939: Diff 47721.Wed, Apr 9, 10:03 AM
ashoat accepted this revision.Wed, Apr 9, 8:02 PM
This revision is now accepted and ready to land.Wed, Apr 9, 8:02 PM
tomek updated this revision to Diff 47741.Thu, Apr 10, 7:22 AM

Fix deleting messages in a sidebar

Harbormaster completed remote builds in B33957: Diff 47741.Thu, Apr 10, 7:40 AM
Closed by commit rCOMMad759e247eee: [native][web] Show an option to delete a message (authored by tomek). · Explain WhyTue, Apr 15, 2:11 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMMad759e247eee: [native][web] Show an option to delete a message.

Revision Contents
Changeset List

Diff 47788

View Options

lib/utils/delete-message-utils.js

Loading...
View Options

native/chat/multimedia-message-tooltip-modal.react.js

Loading...
View Options

native/chat/multimedia-message.react.js

Loading...
View Options

native/chat/text-message-tooltip-modal.react.js

Loading...
View Options

native/chat/text-message.react.js

Loading...
View Options

web/tooltips/tooltip-action-utils.js

Loading...