[lib] Add a new endpoint for deleting messages
Needs RevisionPublic
Actions

Authored by tomek on Thu, Apr 3, 8:21 AM.

Details

Reviewers

kamil
ashoat

Summary

This more or less follows what we're doing for message editing. The only significant change is the permissions check.

Depends on D14511

Test Plan

Tested later in the stack by deleting a message and noticing that it gets deleted on two clients.

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

tomek requested review of this revision.Thu, Apr 3, 8:40 AM

ashoat requested changes to this revision.Thu, Apr 3, 8:38 PM

ashoat added inline comments.

keyserver/src/responders/message-responders.js
451–460	We are issuing the exact same query here twice at the same time. Can this be avoided?
470	This comment is a bit confusing... you suggest that the client should send the ID of the `sourceMessage` instead, but the check seems to indicate that is exactly what the client did (it sent `targetMessageThreadInfo.sourceMessageID`, right?)
482	Should we add another check here to prevent the client from deleting a `sidebarCreation` message? Context here
497–503	What is the effect of deleting the `SIDEBAR_SOURCE` message like this? Should it be allowed?