Page MenuHomePhabricator
Differential D14546

[native] Update message height measurement logic to handle deleted messages
ClosedPublic
Actions

Authored by tomek on Fri, Apr 4, 4:52 AM.
Tags
None
Referenced Files
F6084507: D14546.id47727.diff
Sun, Apr 20, 11:17 PM
F6068353: D14546.id47792.diff
Sun, Apr 20, 12:30 PM
Unknown Object (File)
Fri, Apr 18, 2:36 AM
Unknown Object (File)
Thu, Apr 17, 8:31 PM
Unknown Object (File)
Thu, Apr 17, 4:17 PM
Unknown Object (File)
Thu, Apr 17, 6:00 AM
Unknown Object (File)
Tue, Apr 15, 4:40 PM
Unknown Object (File)
Tue, Apr 15, 3:01 PM
View All 32 Files
Subscribers
None

Details

Reviewers
kamil
ashoat
Commits
rCOMM974d1dda7492: [native] Update message height measurement logic to handle deleted messages
Summary

Make sure the deleted message height is computed correctly.

https://linear.app/comm/issue/ENG-10347/make-sure-height-calculation-is-correct

Depends on D14545

Test Plan

Checked if there are no warnings in the console about an invalid height.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tomek created this revision.Fri, Apr 4, 4:52 AM
Harbormaster completed remote builds in B33906: Diff 47658.Fri, Apr 4, 5:11 AM
tomek requested review of this revision.Fri, Apr 4, 5:11 AM
tomek added a child revision: D14547: [web] Disable all the actions for a deleted message.Fri, Apr 4, 6:46 AM
tomek planned changes to this revision.Fri, Apr 4, 7:01 AM
tomek added inline comments.
native/chat/chat-item-height-measurer.react.js
47–51 ↗(On Diff #47658)

This is probably wrong because a deleted message can be a sidebar source

tomek updated this revision to Diff 47661.Fri, Apr 4, 7:14 AM

Consider that a deleted message can be a sidebar source

Harbormaster completed remote builds in B33909: Diff 47661.Fri, Apr 4, 7:32 AM
ashoat accepted this revision.Fri, Apr 4, 8:52 AM
ashoat added inline comments.
native/chat/chat-item-height-measurer.react.js
95–100 ↗(On Diff #47661)

Is it difficult to do this without rendering <Markdown>? I can see the argument for it if so, but would be helpful to explain

This revision is now accepted and ready to land.Fri, Apr 4, 8:52 AM
tomek updated this revision to Diff 47726.Wed, Apr 9, 10:32 AM

Don't use markdown when measuring deleted messages

native/chat/chat-item-height-measurer.react.js
95–100 ↗(On Diff #47661)

It isn't that difficult, and after the recent changes from the parent diffs it is more correct.

tomek updated this revision to Diff 47727.Wed, Apr 9, 10:33 AM

Delete outdated comment

Harbormaster completed remote builds in B33945: Diff 47727.Wed, Apr 9, 10:52 AM
Harbormaster completed remote builds in B33944: Diff 47726.Wed, Apr 9, 11:00 AM
ashoat accepted this revision.Wed, Apr 9, 8:06 PM

I suppose the italics don't change the height

Closed by commit rCOMM974d1dda7492: [native] Update message height measurement logic to handle deleted messages (authored by tomek). · Explain WhyTue, Apr 15, 2:11 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMM974d1dda7492: [native] Update message height measurement logic to handle deleted messages.

Revision Contents
Changeset List

Diff 47792

View Options

lib/utils/delete-message-utils.js

Loading...
View Options

native/chat/chat-item-height-measurer.react.js

Loading...
View Options

native/chat/deleted-message.react.js

Loading...
View Options

native/chat/inner-text-message.react.js

Loading...
View Options

web/chat/deleted-message.react.js

Loading...