Page MenuHomePhabricator
Differential D14564

[lib] Handle deleted messages when generating notifs
ClosedPublic
Actions

Authored by tomek on Thu, Apr 10, 6:04 AM.
Tags
None
Referenced Files
F6064752: D14564.id.diff
Sun, Apr 20, 11:20 AM
Unknown Object (File)
Sat, Apr 19, 7:34 PM
Unknown Object (File)
Sat, Apr 19, 3:36 PM
Unknown Object (File)
Fri, Apr 18, 4:06 AM
Unknown Object (File)
Fri, Apr 18, 4:06 AM
Unknown Object (File)
Fri, Apr 18, 4:06 AM
Unknown Object (File)
Thu, Apr 17, 10:55 AM
Unknown Object (File)
Wed, Apr 16, 5:52 AM
View All 21 Files
Subscribers
None

Details

Reviewers
kamil
ashoat
Commits
rCOMMfbaf3d741161: [lib] Handle deleted messages when generating notifs
Summary

When a user deletes a message, we should rescind all the notifs about the original message. There are two issues:

  1. Multimedia messages are collapsed when they come from the same author - this diff disables this behavior
  2. We issue a special collapse key when a message creates a sidebar - this diff keeps this behavior, but as a result sidebar source notifications can't be rescinded

https://linear.app/comm/issue/ENG-10510/rescind-notifications-regarding-deleted-messages

Depends on D14561

Test Plan

Haven't tested it yet

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
lib/
shared/
messages/
12 lines
12 lines
9 lines
types/
2 lines

Diff 47803

View Options

lib/shared/messages/delete-message-spec.js

Show First 20 Lines • Show All 2,327 Lines • ▼ Show 20 Lines OlmPersistSession persistSession = {
it->first, it->first,
std::string(it->second.buffer.begin(), it->second.buffer.end()), std::string(it->second.buffer.begin(), it->second.buffer.end()),
it->second.version}; it->second.version};
this->storeOlmPersistSession(persistSession); this->storeOlmPersistSession(persistSession);
} }
} }
void SQLiteQueryExecutor::setNotifyToken(std::string token) const {
this->setMetadata("notify_token", token);
}
void SQLiteQueryExecutor::clearNotifyToken() const {
this->clearMetadata("notify_token");
}
void SQLiteQueryExecutor::stampSQLiteDBUserID(std::string userID) const { void SQLiteQueryExecutor::stampSQLiteDBUserID(std::string userID) const {
this->setMetadata("current_user_id", userID); this->setMetadata("current_user_id", userID);
} }
std::string SQLiteQueryExecutor::getSQLiteStampedUserID() const { std::string SQLiteQueryExecutor::getSQLiteStampedUserID() const {
return this->getMetadata("current_user_id"); return this->getMetadata("current_user_id");
} }
▲ Show 20 Lines • Show All 919 Lines • Show Last 20 Lines
View Options

lib/shared/messages/multimedia-message-spec.js

Show First 20 Lines • Show All 2,327 Lines • ▼ Show 20 Lines OlmPersistSession persistSession = {
it->first, it->first,
std::string(it->second.buffer.begin(), it->second.buffer.end()), std::string(it->second.buffer.begin(), it->second.buffer.end()),
it->second.version}; it->second.version};
this->storeOlmPersistSession(persistSession); this->storeOlmPersistSession(persistSession);
} }
} }
void SQLiteQueryExecutor::setNotifyToken(std::string token) const {
this->setMetadata("notify_token", token);
}
void SQLiteQueryExecutor::clearNotifyToken() const {
this->clearMetadata("notify_token");
}
void SQLiteQueryExecutor::stampSQLiteDBUserID(std::string userID) const { void SQLiteQueryExecutor::stampSQLiteDBUserID(std::string userID) const {
this->setMetadata("current_user_id", userID); this->setMetadata("current_user_id", userID);
} }
std::string SQLiteQueryExecutor::getSQLiteStampedUserID() const { std::string SQLiteQueryExecutor::getSQLiteStampedUserID() const {
return this->getMetadata("current_user_id"); return this->getMetadata("current_user_id");
} }
▲ Show 20 Lines • Show All 919 Lines • Show Last 20 Lines
View Options

lib/shared/messages/text-message-spec.js

Show First 20 Lines • Show All 2,327 Lines • ▼ Show 20 Lines OlmPersistSession persistSession = {
it->first, it->first,
std::string(it->second.buffer.begin(), it->second.buffer.end()), std::string(it->second.buffer.begin(), it->second.buffer.end()),
it->second.version}; it->second.version};
this->storeOlmPersistSession(persistSession); this->storeOlmPersistSession(persistSession);
} }
} }
void SQLiteQueryExecutor::setNotifyToken(std::string token) const {
this->setMetadata("notify_token", token);
}
void SQLiteQueryExecutor::clearNotifyToken() const {
this->clearMetadata("notify_token");
}
void SQLiteQueryExecutor::stampSQLiteDBUserID(std::string userID) const { void SQLiteQueryExecutor::stampSQLiteDBUserID(std::string userID) const {
this->setMetadata("current_user_id", userID); this->setMetadata("current_user_id", userID);
} }
std::string SQLiteQueryExecutor::getSQLiteStampedUserID() const { std::string SQLiteQueryExecutor::getSQLiteStampedUserID() const {
return this->getMetadata("current_user_id"); return this->getMetadata("current_user_id");
} }
▲ Show 20 Lines • Show All 919 Lines • Show Last 20 Lines
View Options

lib/types/message-types.js

Show First 20 Lines • Show All 2,327 Lines • ▼ Show 20 Lines OlmPersistSession persistSession = {
it->first, it->first,
std::string(it->second.buffer.begin(), it->second.buffer.end()), std::string(it->second.buffer.begin(), it->second.buffer.end()),
it->second.version}; it->second.version};
this->storeOlmPersistSession(persistSession); this->storeOlmPersistSession(persistSession);
} }
} }
void SQLiteQueryExecutor::setNotifyToken(std::string token) const {
this->setMetadata("notify_token", token);
}
void SQLiteQueryExecutor::clearNotifyToken() const {
this->clearMetadata("notify_token");
}
void SQLiteQueryExecutor::stampSQLiteDBUserID(std::string userID) const { void SQLiteQueryExecutor::stampSQLiteDBUserID(std::string userID) const {
this->setMetadata("current_user_id", userID); this->setMetadata("current_user_id", userID);
} }
std::string SQLiteQueryExecutor::getSQLiteStampedUserID() const { std::string SQLiteQueryExecutor::getSQLiteStampedUserID() const {
return this->getMetadata("current_user_id"); return this->getMetadata("current_user_id");
} }
▲ Show 20 Lines • Show All 919 Lines • Show Last 20 Lines