[lib] Create a hook that can delete thin and thick messages
ClosedPublic
Actions

Authored by tomek on Apr 4 2025, 10:15 AM.

Details

Reviewers

kamil
ashoat

Commits

rCOMM86010512c313: [lib] Create a hook that can delete thin and thick messages

Summary

Depending on the protocol, create a DM or send a request to a keyserver.

https://linear.app/comm/issue/ENG-10342/add-client-code-to-call-the-keyserver-endpoint

Depends on D14540

Test Plan

Tested later in the stack by checking if it is possible to delete a message both in thin and thick threads.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Apr 4 2025, 10:15 AM

tomek added a child revision: D14542: [native][web] Show an option to delete a message.Apr 4 2025, 10:24 AM

Harbormaster completed remote builds in B33900: Diff 47652.Apr 4 2025, 10:33 AM

tomek requested review of this revision.Apr 4 2025, 10:33 AM

ashoat accepted this revision.Apr 4 2025, 3:45 PM

ashoat added inline comments.

lib/utils/delete-message-utils.js
65–67 ↗	(On Diff #47652)	Curious why this wrapping is needed

This revision is now accepted and ready to land.Apr 4 2025, 3:45 PM

Simplify the code

lib/utils/delete-message-utils.js
65–67 ↗	(On Diff #47652)	Good question! It isn't needed - simplified the code.

Await the promise to make this symmetric with the thick thread's code

Harbormaster completed remote builds in B33937: Diff 47719.Apr 9 2025, 4:47 PM

Harbormaster completed remote builds in B33938: Diff 47720.

Closed by commit rCOMM86010512c313: [lib] Create a hook that can delete thin and thick messages. · Explain WhyApr 15 2025, 9:11 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM86010512c313: [lib] Create a hook that can delete thin and thick messages.

Revision Contents
Changeset List

Path

Size

lib/

utils/

delete-message-utils.js

77 lines

Diff 47787

View Options

lib/utils/delete-message-utils.js

[lib] Create a hook that can delete thin and thick messagesClosedPublicActions