Page MenuHomePhabricator
Differential D14541

[lib] Create a hook that can delete thin and thick messages
ClosedPublic
Actions

Authored by tomek on Fri, Apr 4, 3:15 AM.
Tags
None
Referenced Files
F5775782: D14541.id47719.diff
Tue, Apr 15, 1:21 AM
F5771278: D14541.id47652.diff
Mon, Apr 14, 9:05 PM
F5766457: D14541.id47720.diff
Mon, Apr 14, 4:47 PM
F5751804: D14541.id.diff
Mon, Apr 14, 11:42 AM
Unknown Object (File)
Sun, Apr 13, 8:48 AM
Unknown Object (File)
Thu, Apr 10, 2:57 PM
Unknown Object (File)
Thu, Apr 10, 10:46 AM
Unknown Object (File)
Wed, Apr 9, 3:48 PM
View All 18 Files
Subscribers
None

Details

Reviewers
kamil
ashoat
Commits
rCOMM86010512c313: [lib] Create a hook that can delete thin and thick messages
Summary

Depending on the protocol, create a DM or send a request to a keyserver.

https://linear.app/comm/issue/ENG-10342/add-client-code-to-call-the-keyserver-endpoint

Depends on D14540

Test Plan

Tested later in the stack by checking if it is possible to delete a message both in thin and thick threads.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tomek created this revision.Fri, Apr 4, 3:15 AM
tomek added a child revision: D14542: [native][web] Show an option to delete a message.Fri, Apr 4, 3:24 AM
Harbormaster completed remote builds in B33900: Diff 47652.Fri, Apr 4, 3:33 AM
tomek requested review of this revision.Fri, Apr 4, 3:33 AM
ashoat accepted this revision.Fri, Apr 4, 8:45 AM
ashoat added inline comments.
lib/utils/delete-message-utils.js
65–67 ↗(On Diff #47652)

Curious why this wrapping is needed

This revision is now accepted and ready to land.Fri, Apr 4, 8:45 AM
tomek updated this revision to Diff 47719.Wed, Apr 9, 9:29 AM

Simplify the code

lib/utils/delete-message-utils.js
65–67 ↗(On Diff #47652)

Good question! It isn't needed - simplified the code.

tomek updated this revision to Diff 47720.Wed, Apr 9, 9:31 AM

Await the promise to make this symmetric with the thick thread's code

Harbormaster completed remote builds in B33937: Diff 47719.Wed, Apr 9, 9:47 AM
Harbormaster completed remote builds in B33938: Diff 47720.
Closed by commit rCOMM86010512c313: [lib] Create a hook that can delete thin and thick messages (authored by tomek). · Explain WhyTue, Apr 15, 2:11 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMM86010512c313: [lib] Create a hook that can delete thin and thick messages.

Revision Contents
Changeset List

PathSize
lib/
utils/
77 lines

Diff 47787

View Options

lib/utils/delete-message-utils.js

Loading...