Page MenuHomePhabricator
Differential D14543

[lib] Update chat selector to return an info telling if a message was deleted
ClosedPublic
Actions

Authored by tomek on Fri, Apr 4, 3:53 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 19, 8:51 PM
Unknown Object (File)
Fri, Apr 18, 9:39 PM
Unknown Object (File)
Fri, Apr 18, 2:45 AM
Unknown Object (File)
Thu, Apr 17, 10:39 AM
Unknown Object (File)
Tue, Apr 15, 8:58 PM
Unknown Object (File)
Tue, Apr 15, 12:18 AM
Unknown Object (File)
Mon, Apr 14, 1:54 PM
Unknown Object (File)
Sat, Apr 12, 12:28 PM
View All 26 Files
Subscribers
None

Details

Reviewers
kamil
ashoat
Commits
rCOMM98a55a09e68d: [lib] Update chat selector to return an info telling if a message was deleted
Summary

Add a new property to the item telling if a message was deleted.

https://linear.app/comm/issue/ENG-10319/update-the-ui-so-that-delete-operation-is-correctly-presented

Depends on D14542

Test Plan

Tested with the rest of the stack by checking if a deleted message is shown as deleted.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tomek created this revision.Fri, Apr 4, 3:53 AM
Harbormaster completed remote builds in B33902: Diff 47654.Fri, Apr 4, 4:12 AM
tomek requested review of this revision.Fri, Apr 4, 4:12 AM
tomek added a child revision: D14544: [web] Display a deleted message on web.Fri, Apr 4, 4:15 AM
ashoat accepted this revision.Fri, Apr 4, 8:47 AM
ashoat added inline comments.
lib/selectors/chat-selectors.js
500–506 ↗(On Diff #47654)

This can be simplified:

const deleted = !!(
  originalMessageInfo.id &&
  targetMessageDeleteStatusMap.get(originalMessageInfo.id)
);
This revision is now accepted and ready to land.Fri, Apr 4, 8:47 AM
tomek updated this revision to Diff 47723.Wed, Apr 9, 9:51 AM

Simplify

Harbormaster completed remote builds in B33941: Diff 47723.Wed, Apr 9, 10:09 AM
Closed by commit rCOMM98a55a09e68d: [lib] Update chat selector to return an info telling if a message was deleted (authored by tomek). · Explain WhyTue, Apr 15, 2:11 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMM98a55a09e68d: [lib] Update chat selector to return an info telling if a message was deleted.

Revision Contents
Changeset List

PathSize
lib/
selectors/
16 lines
native/
chat/
2 lines
types/
2 lines

Diff 47789

View Options

lib/selectors/chat-selectors.js

Loading...
View Options

native/chat/chat-item-height-measurer.react.js

Loading...
View Options

native/types/chat-types.js

Loading...