Paths

Table of Contentst

-
lib/shared/
-
shared/
-
chat-message-item-utils.js
-
native/chat/
-
chat/
-
chat-item-height-measurer.react.js
-
composed-message.react.js
-
inline-engagement.react.js
-
inner-robotext-message.react.js
-
inner-text-message.react.js
-
robotext-message.react.js
-
web/chat/
-
chat/
-
composed-message.react.js
-
inline-engagement.react.js
-
robotext-message.react.js

[native][web] Hide edit label and reactions of deleted messages
AcceptedPublic
Actions

Authored by tomek on Fri, Apr 4, 7:11 AM.

Details

Reviewers

kamil
ashoat

Summary

When a message is deleted, we should hide all the inline engagement components but a sidebars - because it is possible that a sidebar was created before the message was deleted.

https://linear.app/comm/issue/ENG-10494/update-reaction-logic
https://linear.app/comm/issue/ENG-10493/update-sidebar-creation-logic

Depends on D14547

Test Plan

Checked on both native and web that reactions and edit label aren't shown for a deleted message.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

tomek created this revision.Fri, Apr 4, 7:11 AM

Harbormaster completed remote builds in B33908: Diff 47660.Fri, Apr 4, 7:30 AM

tomek requested review of this revision.Fri, Apr 4, 7:30 AM

tomek added a child revision: D14549: [keyserver] Handle unpinning deleted messages.Fri, Apr 4, 8:06 AM

ashoat accepted this revision.Fri, Apr 4, 8:57 AM

ashoat added inline comments.

lib/shared/chat-message-item-utils.js
101	The implication is that it's impossible to delete a message from which a sidebar has been created, right? Do we make sure to prevent this on both sender/recipient sides for both keyserver-hosted and DM messages?
native/chat/chat-item-height-measurer.react.js
126	This can be `false`, since there is no way to get to this code branch if `item.deleted` is `true`