Page MenuHomePhabricator
Differential D12844

[SQLite] implement query for searching messages
ClosedPublic
Actions

Authored by kamil on Jul 22 2024, 10:15 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Sep 4, 1:58 AM
Unknown Object (File)
Wed, Sep 4, 1:58 AM
Unknown Object (File)
Wed, Sep 4, 1:58 AM
Unknown Object (File)
Wed, Sep 4, 1:58 AM
Unknown Object (File)
Thu, Aug 29, 8:53 PM
Unknown Object (File)
Wed, Aug 28, 3:36 PM
Unknown Object (File)
Wed, Aug 28, 7:17 AM
Unknown Object (File)
Wed, Aug 28, 3:37 AM
View All 43 Files
Subscribers
ashoat

Details

Reviewers
tomek
inka
Commits
rCOMM3b9546b1e346: [SQLite] implement query for searching messages
Summary

Query similar to keyserver version.

Depends on D12843

Test Plan

Tested in D12851

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Jul 22 2024, 10:15 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptJul 22 2024, 10:15 AM
Harbormaster failed remote builds in B30573: Diff 42637!Jul 22 2024, 10:35 AM
kamil updated this revision to Diff 42666.Jul 23 2024, 2:53 AM

rebase

kamil added a child revision: D12850: [SQLite] add Emscripten bindings for message search.Jul 23 2024, 2:53 AM
kamil edited the test plan for this revision. (Show Details)Jul 23 2024, 2:55 AM
Harbormaster completed remote builds in B30592: Diff 42666.Jul 23 2024, 3:12 AM
kamil published this revision for review.Jul 23 2024, 5:03 AM
kamil mentioned this in D12843: [SQLite] add method for message search to SQLiteQueryExecutor for both web and native.
kamil added inline comments.
native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp
2574 ↗(On Diff #42666)

there is no ; on purpose

2589 ↗(On Diff #42666)

we can't use this becuase this will require adding folly dependency to .wasm

tomek accepted this revision.Jul 23 2024, 6:15 AM
inka accepted this revision.Jul 23 2024, 6:22 AM
This revision is now accepted and ready to land.Jul 23 2024, 6:22 AM
Closed by commit rCOMM3b9546b1e346: [SQLite] implement query for searching messages (authored by kamil). · Explain WhyJul 23 2024, 8:18 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM3b9546b1e346: [SQLite] implement query for searching messages.
ashoat added inline comments.Jul 31 2024, 6:52 PM
native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp
2589 ↗(On Diff #42666)

Maybe I shouldn't have abandoned D12761

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
DatabaseManagers/
45 lines
web/
shared-worker/
_generated/

Diff 42705

View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

Loading...
View Options

web/shared-worker/_generated/comm_query_executor.wasm

Loading...