web/shared-worker/queries/message-search.test.js
139–146 ↗	(On Diff #42670)	Shouldn't this contain `targetMessageID`?
143 ↗	(On Diff #42670)	Can we use constants from `messageTypes`?
152 ↗	(On Diff #42670)	Can we validate more than just the ID? Like we do in other tests.
210 ↗	(On Diff #42670)
232 ↗	(On Diff #42670)

inka accepted this revision.Jul 23 2024, 6:44 AM

inka added inline comments.

web/shared-worker/queries/message-search.test.js
155 ↗	(On Diff #42670)	Can we change the text to reflect that the timestamp can be equal? For example "should return only messages with time equal or smaller than timestampCursor"
168 ↗	(On Diff #42670)	Why is this a leave thread message?
277 ↗	(On Diff #42670)	This is the same test as `should prioritizes timestampCursor over messageIDCursor`, we can remove one of them

This revision is now accepted and ready to land.Jul 23 2024, 6:44 AM

address review

Harbormaster completed remote builds in B30615: Diff 42702.Jul 23 2024, 8:12 AM

Closed by commit rCOMM7085908cc6d2: [SQLite] implement tests for messages search (authored by kamil). · Explain WhyJul 23 2024, 8:18 AM

This revision was automatically updated to reflect the committed changes.

kamil mentioned this in rCOMM3b9546b1e346: [SQLite] implement query for searching messages.

kamil mentioned this in rCOMMffb88c4a6c6d: [SQLite] add Emscripten bindings for message search.

kamil added a commit: rCOMM7085908cc6d2: [SQLite] implement tests for messages search.

Revision Contents
Changeset List

Path

Size

web/

shared-worker/

queries/

message-search.test.js

323 lines

Diff 42707

View Options

web/shared-worker/queries/message-search.test.js

	// @flow			// @flow

	import uuid from 'uuid';			import uuid from 'uuid';

				import { DISABLE_TAGGING_FARCASTER_CHANNEL } from 'lib/shared/community-utils.js';
	import type {			import type {
	CreateOrUpdateFarcasterChannelTagRequest,			CreateOrUpdateFarcasterChannelTagRequest,
	CreateOrUpdateFarcasterChannelTagResponse,			CreateOrUpdateFarcasterChannelTagResponse,
	} from 'lib/types/community-types.js';			} from 'lib/types/community-types.js';
	import { ServerError } from 'lib/utils/errors.js';			import { ServerError } from 'lib/utils/errors.js';

	import {			import {
	uploadBlob,			uploadBlob,
	assignHolder,			assignHolder,
	download,			download,
	type BlobOperationResult,			type BlobOperationResult,
	type BlobDownloadResult,			type BlobDownloadResult,
	} from '../services/blob.js';			} from '../services/blob.js';
	import { Viewer } from '../session/viewer.js';			import { Viewer } from '../session/viewer.js';

	async function createOrUpdateFarcasterChannelTag(			async function createOrUpdateFarcasterChannelTag(
	viewer: Viewer,			viewer: Viewer,
	request: CreateOrUpdateFarcasterChannelTagRequest,			request: CreateOrUpdateFarcasterChannelTagRequest,
	): Promise<CreateOrUpdateFarcasterChannelTagResponse> {			): Promise<CreateOrUpdateFarcasterChannelTagResponse> {
	const { commCommunityID, farcasterChannelID } = request;			const { commCommunityID, farcasterChannelID } = request;

				if (DISABLE_TAGGING_FARCASTER_CHANNEL) {
				throw new ServerError('internal_error');
				}

	const blobDownload = await getFarcasterChannelTagBlob(farcasterChannelID);			const blobDownload = await getFarcasterChannelTagBlob(farcasterChannelID);

	if (blobDownload.found) {			if (blobDownload.found) {
	throw new ServerError('already_in_use');			throw new ServerError('already_in_use');
	}			}

	const blobHolder = uuid.v4();			const blobHolder = uuid.v4();

	▲ Show 20 Lines • Show All 56 Lines • Show Last 20 Lines

[SQLite] implement tests for messages searchClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 42707

web/shared-worker/queries/message-search.test.js

[SQLite] implement tests for messages search
ClosedPublic
Actions

Revision Contents
Changeset List