Paths

Table of Contentst

Differential D12851

[SQLite] implement tests for messages search
ClosedPublic
Actions

Authored by kamil on Jul 23 2024, 2:54 AM.

Tags

None

Referenced Files

	F2999521: D12851.diff
	Thu, Oct 17, 11:17 PM

	F2991770: D12851.id42703.diff
	Thu, Oct 17, 1:24 AM

	Unknown Object (File)
	Wed, Oct 16, 9:32 AM

	Unknown Object (File)
	Tue, Oct 15, 6:23 PM

	Unknown Object (File)
	Mon, Oct 14, 3:16 PM

	Unknown Object (File)
	Mon, Oct 14, 3:16 PM

	Unknown Object (File)
	Mon, Oct 14, 3:16 PM

	Unknown Object (File)
	Mon, Oct 14, 3:16 PM

Subscribers

Details

Reviewers

tomek
inka

Commits

rCOMM7085908cc6d2: [SQLite] implement tests for messages search

Summary

Testing searching logic - tests implemented by @inka.

Depends on D12850

Test Plan

Run tests

Diff Detail

Repository

Branch

cpp-search-2

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Jul 23 2024, 2:54 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptJul 23 2024, 2:54 AM

kamil mentioned this in D12844: [SQLite] implement query for searching messages.Jul 23 2024, 2:55 AM

kamil mentioned this in D12850: [SQLite] add Emscripten bindings for message search.

rebase

kamil added a child revision: D12852: [web] introduce message searching to shared worker.Jul 23 2024, 3:05 AM

Harbormaster failed remote builds in B30594: Diff 42668!Jul 23 2024, 3:22 AM

Harbormaster completed remote builds in B30596: Diff 42670.Jul 23 2024, 3:34 AM

kamil published this revision for review.Jul 23 2024, 5:03 AM

We can consider one more thing: sorting the returned messages.

web/shared-worker/queries/message-search.test.js
139–146 ↗	(On Diff #42670)	Shouldn't this contain `targetMessageID`?
143 ↗	(On Diff #42670)	Can we use constants from `messageTypes`?
152 ↗	(On Diff #42670)	Can we validate more than just the ID? Like we do in other tests.
210 ↗	(On Diff #42670)
232 ↗	(On Diff #42670)

inka accepted this revision.Jul 23 2024, 6:44 AM

inka added inline comments.

web/shared-worker/queries/message-search.test.js
155 ↗	(On Diff #42670)	Can we change the text to reflect that the timestamp can be equal? For example "should return only messages with time equal or smaller than timestampCursor"
168 ↗	(On Diff #42670)	Why is this a leave thread message?
277 ↗	(On Diff #42670)	This is the same test as `should prioritizes timestampCursor over messageIDCursor`, we can remove one of them

This revision is now accepted and ready to land.Jul 23 2024, 6:44 AM

address review

Harbormaster completed remote builds in B30615: Diff 42702.Jul 23 2024, 8:12 AM

Closed by commit rCOMM7085908cc6d2: [SQLite] implement tests for messages search (authored by kamil). · Explain WhyJul 23 2024, 8:18 AM

This revision was automatically updated to reflect the committed changes.

kamil mentioned this in rCOMM3b9546b1e346: [SQLite] implement query for searching messages.

kamil mentioned this in rCOMMffb88c4a6c6d: [SQLite] add Emscripten bindings for message search.

kamil added a commit: rCOMM7085908cc6d2: [SQLite] implement tests for messages search.

Revision Contents
Changeset List

Path

Size

web/

shared-worker/

queries/

message-search.test.js

311 lines

Diff 42668

web/shared-worker/queries/message-search.test.js

Loading...