Page MenuHomePhabricator
Differential D12855

[SQLite] rename all QueryExecutor params to `camelCase`
ClosedPublic
Actions

Authored by kamil on Jul 23 2024, 3:18 AM.
Tags
None
Referenced Files
F2622438: D12855.id42711.diff
Fri, Sep 6, 7:17 PM
Unknown Object (File)
Thu, Sep 5, 10:13 AM
Unknown Object (File)
Wed, Sep 4, 12:42 AM
Unknown Object (File)
Wed, Sep 4, 12:42 AM
Unknown Object (File)
Wed, Sep 4, 12:42 AM
Unknown Object (File)
Wed, Sep 4, 12:42 AM
Unknown Object (File)
Fri, Aug 30, 12:51 PM
Unknown Object (File)
Fri, Aug 30, 7:27 AM
View All 42 Files
Subscribers
ashoat

Details

Reviewers
tomek
inka
Commits
rCOMMdd5c4d502382: [SQLite] rename all QueryExecutor params to `camelCase`
Summary

There was a huge inconsistency in naming - using the same style for all.

Depends on D12854

Test Plan

yarn jest, build and run the native app

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Jul 23 2024, 3:18 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptJul 23 2024, 3:18 AM
Harbormaster completed remote builds in B30601: Diff 42675.Jul 23 2024, 4:00 AM
kamil published this revision for review.Jul 23 2024, 5:04 AM
tomek accepted this revision.Jul 23 2024, 6:38 AM
This revision is now accepted and ready to land.Jul 23 2024, 6:38 AM
tomek added a comment.Jul 23 2024, 6:39 AM

We can also build and run the native app as a part of the test plan.

kamil edited the test plan for this revision. (Show Details)Jul 23 2024, 8:06 AM
Closed by commit rCOMMdd5c4d502382: [SQLite] rename all QueryExecutor params to `camelCase` (authored by kamil). · Explain WhyJul 23 2024, 8:18 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMMdd5c4d502382: [SQLite] rename all QueryExecutor params to `camelCase`.

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
DatabaseManagers/
36 lines
38 lines
92 lines

Diff 42711

View Options

native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h

Loading...
View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.h

Loading...
View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

Loading...