Tags

None

Referenced Files

	F2622805: D12796.id42473.diff
	Fri, Sep 6, 8:34 PM

	Unknown Object (File)
	Wed, Sep 4, 1:28 AM

	Unknown Object (File)
	Wed, Sep 4, 1:27 AM

	Unknown Object (File)
	Wed, Sep 4, 1:27 AM

	Unknown Object (File)
	Wed, Sep 4, 1:27 AM

	Unknown Object (File)
	Mon, Aug 26, 11:17 AM

	Unknown Object (File)
	Mon, Aug 26, 6:02 AM

	Unknown Object (File)
	Fri, Aug 23, 12:25 PM

View All 33 Files

Subscribers

ashoat

Details

Reviewers

tomek
kamil
marcin

Commits

rCOMM42a24e328e36: [native] Add CommCoreModule code for inserting into the search table

Summary

issue: [[https://linear.app/comm/issue/ENG-8830/[native]-update-processdbstoreoperations-to-handle-insert-into-search | ENG-8830]]

Test Plan

Added an "add search message" operation on the js side and tested that updateMessageSearchIndex was run and no errors showed up in Metro nor in XCode console

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

inka created this revision.Jul 18 2024, 8:10 AM

Herald added a subscriber: ashoat. · View Herald TranscriptJul 18 2024, 8:10 AM

inka added a parent revision: D12795: [native] Add message search store.Jul 18 2024, 8:10 AM

Harbormaster completed remote builds in B30474: Diff 42473.Jul 18 2024, 8:30 AM

inka requested review of this revision.Jul 18 2024, 8:30 AM

inka added a child revision: D12801: [lib][web] Add worker logic for adding search messages.Jul 19 2024, 3:17 AM

marcin accepted this revision.Jul 19 2024, 3:29 AM

This revision is now accepted and ready to land.Jul 19 2024, 3:29 AM

kamil accepted this revision.Jul 19 2024, 5:16 AM

Closed by commit rCOMM42a24e328e36: [native] Add CommCoreModule code for inserting into the search table (authored by inka). · Explain WhyJul 23 2024, 6:12 AM

This revision was automatically updated to reflect the committed changes.

inka added a commit: rCOMM42a24e328e36: [native] Add CommCoreModule code for inserting into the search table.

[native] Add CommCoreModule code for inserting into the search table
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 42692

native/cpp/CommonCpp/NativeModules/CommCoreModule.h

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

[native] Add CommCoreModule code for inserting into the search tableClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 42692

native/cpp/CommonCpp/NativeModules/CommCoreModule.h

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

[native] Add CommCoreModule code for inserting into the search table
ClosedPublic
Actions

Revision Contents
Changeset List