Details

Reviewers

tomek
kamil
marcin

Commits

rCOMM4d163ea41aef: [lib][web][native] Create message search store ops

Summary

issue: ENG-8647

Test Plan

Tested by removnig the extractKeyserverIDFromIDOptional(messageInfo.threadID) condition from getMessageSearchStoreOps. Tested that on web and native if replace message ops are present, update ops are created for the search table, and updateMessageSearchIndex is called

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

inka created this revision.Jul 22 2024, 2:02 AM

Herald added a subscriber: ashoat. · View Herald TranscriptJul 22 2024, 2:02 AM

inka added a parent revision: D12801: [lib][web] Add worker logic for adding search messages.Jul 22 2024, 2:02 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 22 2024, 2:12 AM

Harbormaster failed remote builds in B30557: Diff 42604!

Harbormaster completed remote builds in B30557: Diff 42604.Jul 22 2024, 3:12 AM

inka requested review of this revision.Jul 22 2024, 3:12 AM

tomek accepted this revision.Jul 22 2024, 5:01 AM

tomek added inline comments.

lib/handlers/db-ops-handler.react.js
89–96 ↗	(On Diff #42604)	I'm not sure where's the best place to put this logic. `DBOpsHandler` wasn't supposed to understand the content of the ops. `db-ops-reducer.js` could be a better place, because reducers handle business logic. What do you think?