Page MenuHomePhabricator

marcin (Marcin)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 29 2021, 2:54 AM (121 w, 1 d)

Recent Activity

Today

marcin requested review of D11782: Let the user skip backup message generation and record it in alert store.
Thu, Apr 25, 10:34 AM
marcin closed D11779: Add missing privacy API declarations and upgrade MMKV.
Thu, Apr 25, 9:45 AM
marcin committed rCOMMd1adda5d6bd8: Add missing privacy API declarations and upgrade MMKV (authored by marcin).
Add missing privacy API declarations and upgrade MMKV
Thu, Apr 25, 9:45 AM
marcin updated the diff for D11779: Add missing privacy API declarations and upgrade MMKV.

rebase before landing

Thu, Apr 25, 9:06 AM
marcin requested review of D11781: Move MissingRegistrationDataHandler to NavigationHandler.
Thu, Apr 25, 8:37 AM
marcin requested review of D11779: Add missing privacy API declarations and upgrade MMKV.
Thu, Apr 25, 6:24 AM

Yesterday

marcin requested review of D11757: [SIWE] Differentiate content for social proof and backup message..
Wed, Apr 24, 5:26 AM
marcin accepted D11727: [CommCoreModule] decrypt and persist plaintext in SQL transaction.
Wed, Apr 24, 4:21 AM
marcin accepted D11725: [SQLite/native] implement received message to device API.
Wed, Apr 24, 4:14 AM
marcin added inline comments to D11723: [SQLite] add queries to decrypted messages table.
Wed, Apr 24, 4:13 AM
marcin accepted D11724: [SQLite/web] implement received message to device API.
Wed, Apr 24, 3:40 AM
marcin added inline comments to D11723: [SQLite] add queries to decrypted messages table.
Wed, Apr 24, 3:39 AM
marcin added inline comments to D11722: [SQLite] add table to persist decrypted messages.
Wed, Apr 24, 3:33 AM
marcin added inline comments to D11722: [SQLite] add table to persist decrypted messages.
Wed, Apr 24, 3:26 AM
marcin accepted D11721: [native/web] add SQL transaction to persisting crypto module.
Wed, Apr 24, 3:21 AM
marcin added a comment to D11721: [native/web] add SQL transaction to persisting crypto module.

I think it is good to add a transaction here as it will force accounts states in SQLite to be in sync.

Wed, Apr 24, 3:21 AM
marcin accepted D11720: [lib] update P2P message handler to use sequential decrypt.
Wed, Apr 24, 3:12 AM
marcin accepted D11719: [web/lib] add sequential decrypt to `olmAPI`.
Wed, Apr 24, 3:11 AM
marcin accepted D11718: [CommCoreModule] add sequential decrypt to crypto API.
Wed, Apr 24, 3:09 AM
marcin accepted D11717: [CryptoModule] add sequential decrypt to crypto API.
Wed, Apr 24, 3:04 AM
marcin added inline comments to D11717: [CryptoModule] add sequential decrypt to crypto API.
Wed, Apr 24, 3:04 AM

Tue, Apr 23

marcin closed D11645: Force already logged in ETH users to create and sign backup message.
Tue, Apr 23, 6:54 AM
marcin closed D11644: Extract shareable logic from CreateSIWEBackupMessage component.
Tue, Apr 23, 6:54 AM
marcin committed rCOMMc40b7bdb4ba8: Force already logged in ETH users to create and sign backup message (authored by marcin).
Force already logged in ETH users to create and sign backup message
Tue, Apr 23, 6:54 AM
marcin closed D11636: Implement screen to create backup mesage and its signature.
Tue, Apr 23, 6:54 AM
marcin committed rCOMMc1e55f55b290: Extract shareable logic from CreateSIWEBackupMessage component (authored by marcin).
Extract shareable logic from CreateSIWEBackupMessage component
Tue, Apr 23, 6:54 AM
marcin closed D11638: Persist SIWE backup secrets to SQLite after succesfull registration process.
Tue, Apr 23, 6:54 AM
marcin committed rCOMMd3fe1ddfa50c: Implement screen to create backup mesage and its signature (authored by marcin).
Implement screen to create backup mesage and its signature
Tue, Apr 23, 6:54 AM
marcin closed D11637: Implement JSI getter and setter for siwe backup secrets.
Tue, Apr 23, 6:54 AM
marcin committed rCOMM9de8d349dfbd: Persist SIWE backup secrets to SQLite after succesfull registration process (authored by marcin).
Persist SIWE backup secrets to SQLite after succesfull registration process
Tue, Apr 23, 6:54 AM
marcin committed rCOMM311dd775e343: Implement JSI getter and setter for siwe backup secrets (authored by marcin).
Implement JSI getter and setter for siwe backup secrets
Tue, Apr 23, 6:54 AM
marcin closed D11634: Introduce user texts for siwe backup message creation.
Tue, Apr 23, 6:54 AM
marcin closed D11635: Handle backup message type with different user texts in siwe.reac.js.
Tue, Apr 23, 6:54 AM
marcin committed rCOMMd0736e8e1ee0: Handle backup message type with different user texts in siwe.reac.js (authored by marcin).
Handle backup message type with different user texts in siwe.reac.js
Tue, Apr 23, 6:54 AM
marcin committed rCOMM296d435817c6: Introduce user texts for siwe backup message creation (authored by marcin).
Introduce user texts for siwe backup message creation
Tue, Apr 23, 6:54 AM
marcin closed D11633: Introduce SIWE message types.
Tue, Apr 23, 6:54 AM
marcin committed rCOMMeb9c80b4a681: Introduce SIWE message types (authored by marcin).
Introduce SIWE message types
Tue, Apr 23, 6:54 AM
marcin updated the diff for D11637: Implement JSI getter and setter for siwe backup secrets.

rebase before landing

Tue, Apr 23, 6:06 AM
marcin updated the diff for D11645: Force already logged in ETH users to create and sign backup message.

Rebase before landing

Tue, Apr 23, 5:48 AM
marcin updated the diff for D11644: Extract shareable logic from CreateSIWEBackupMessage component.

Rebase before landing

Tue, Apr 23, 5:47 AM
marcin updated the diff for D11638: Persist SIWE backup secrets to SQLite after succesfull registration process.

Rebase before landing

Tue, Apr 23, 5:47 AM
marcin updated the diff for D11636: Implement screen to create backup mesage and its signature.

Rebase before landing

Tue, Apr 23, 5:46 AM
marcin updated the diff for D11635: Handle backup message type with different user texts in siwe.reac.js.

Rebase before landing

Tue, Apr 23, 5:45 AM
marcin updated the diff for D11634: Introduce user texts for siwe backup message creation.

Rebase before landing

Tue, Apr 23, 5:44 AM
marcin updated the diff for D11633: Introduce SIWE message types.

Rebase before landing

Tue, Apr 23, 5:43 AM
marcin requested review of D11735: Introduce new JSI call to retrieve backup message for latest siwe backup.
Tue, Apr 23, 4:12 AM
marcin requested review of D11734: Introduce 'msgBackup' field to 'OrderedBackupItem' and 'LatestBackupIDResponse'.
Tue, Apr 23, 4:08 AM
marcin requested review of D11716: Enable backup creation and upload for SIWE users from JS.
Tue, Apr 23, 4:05 AM
marcin requested review of D11733: Update latest backup id search index to include 'msgBackup'.
Tue, Apr 23, 4:04 AM
marcin requested review of D11715: Update native backup code to handle siwe backup message.
Tue, Apr 23, 4:02 AM

Mon, Apr 22

marcin requested review of D11714: Introduce function to get path to a file to temporarily save backup message.
Mon, Apr 22, 11:41 AM
marcin updated the diff for D11713: Introduce msg_backup field to BackupItem.

Remove empty line

Mon, Apr 22, 11:36 AM
marcin requested review of D11713: Introduce msg_backup field to BackupItem.
Mon, Apr 22, 11:32 AM
marcin closed D11684: Construct local badge-only notif when notification doesn't have body property.
Mon, Apr 22, 5:34 AM
marcin committed rCOMMee13a15fdb7b: Construct local badge-only notif when notification doesn't have body property (authored by marcin).
Construct local badge-only notif when notification doesn't have body property
Mon, Apr 22, 5:34 AM
marcin closed D11702: Remove unecessary SQLite initialization from CommHybrid.
Mon, Apr 22, 5:33 AM
marcin committed rCOMMfaf8cda7751a: Remove unecessary SQLite initialization from CommHybrid (authored by marcin).
Remove unecessary SQLite initialization from CommHybrid
Mon, Apr 22, 5:33 AM
marcin updated the diff for D11702: Remove unecessary SQLite initialization from CommHybrid.

Rebase before landing

Mon, Apr 22, 5:09 AM
marcin updated the diff for D11684: Construct local badge-only notif when notification doesn't have body property.

Rebase before landing

Mon, Apr 22, 5:07 AM

Fri, Apr 19

marcin added inline comments to D11684: Construct local badge-only notif when notification doesn't have body property.
Fri, Apr 19, 12:15 PM
marcin updated the diff for D11638: Persist SIWE backup secrets to SQLite after succesfull registration process.
  1. Put SIWE backup secrets persistence to step 1.
  2. Put clearing cached selections to step 2.
Fri, Apr 19, 10:30 AM
marcin added inline comments to D11638: Persist SIWE backup secrets to SQLite after succesfull registration process.
Fri, Apr 19, 10:28 AM
marcin requested review of D11702: Remove unecessary SQLite initialization from CommHybrid.
Fri, Apr 19, 10:08 AM
marcin updated the diff for D11684: Construct local badge-only notif when notification doesn't have body property.
  1. Update the comment
  2. Use method to get badge only content for notif.
Fri, Apr 19, 10:03 AM
marcin added inline comments to D11684: Construct local badge-only notif when notification doesn't have body property.
Fri, Apr 19, 9:41 AM
marcin updated the diff for D11638: Persist SIWE backup secrets to SQLite after succesfull registration process.

Add finally statements to set gurd refs to false eventually.

Fri, Apr 19, 8:20 AM
marcin added a comment to D11638: Persist SIWE backup secrets to SQLite after succesfull registration process.

It wasn't easy to introduce new step here. If this solution is not accepted I will just introduce new step that clears cached Selections in the same promise as sqlite persistence and leave avatar upload unchanged.

Fri, Apr 19, 8:15 AM
marcin updated the diff for D11638: Persist SIWE backup secrets to SQLite after succesfull registration process.

Introduce two new steps: SQLite data persistence and clearing cached selections

Fri, Apr 19, 8:11 AM
marcin updated the diff for D11636: Implement screen to create backup mesage and its signature.

Encrypt with Ethereum Wallet -> Encrypt with Ethereum signature

Fri, Apr 19, 8:10 AM
marcin added inline comments to D11684: Construct local badge-only notif when notification doesn't have body property.
Fri, Apr 19, 8:07 AM
marcin added inline comments to D11638: Persist SIWE backup secrets to SQLite after succesfull registration process.
Fri, Apr 19, 4:58 AM
marcin added inline comments to D11638: Persist SIWE backup secrets to SQLite after succesfull registration process.
Fri, Apr 19, 3:43 AM
marcin updated the diff for D11684: Construct local badge-only notif when notification doesn't have body property.
  1. Remove needsSilentBadgeUpdate function and replace it with inline checks.
  2. Bring back useful comment.
Fri, Apr 19, 3:05 AM
marcin added inline comments to D11684: Construct local badge-only notif when notification doesn't have body property.
Fri, Apr 19, 3:05 AM
marcin accepted D11693: [native] Wait for authoritative keyserver login before setting avatar in registration flow.
Fri, Apr 19, 2:46 AM

Thu, Apr 18

marcin requested review of D11684: Construct local badge-only notif when notification doesn't have body property.
Thu, Apr 18, 4:07 AM
marcin added inline comments to D11638: Persist SIWE backup secrets to SQLite after succesfull registration process.
Thu, Apr 18, 1:24 AM
marcin updated the diff for D11645: Force already logged in ETH users to create and sign backup message.

Persist directly to SQLite when forcing user to create backup message signature.

Thu, Apr 18, 1:22 AM
marcin updated the diff for D11644: Extract shareable logic from CreateSIWEBackupMessage component.

REbase to reflect changes from parent diff

Thu, Apr 18, 1:22 AM
marcin updated the diff for D11638: Persist SIWE backup secrets to SQLite after succesfull registration process.

Move siwe secrets persistence and cached selections clearing to registration server call.

Thu, Apr 18, 1:21 AM
marcin attached a referenced file: F1568318: Simulator Screen Shot - iPhone 14 Pro - 2024-04-18 at 09.53.40.png.
Thu, Apr 18, 1:20 AM
marcin added a comment to D11636: Implement screen to create backup mesage and its signature.

If we go back from registration terms screen then siwe backup message creation screen looks like this:

Simulator Screen Shot - iPhone 14 Pro - 2024-04-18 at 09.53.40.png (2×1 px, 144 KB)

Thu, Apr 18, 1:20 AM
marcin updated the diff for D11636: Implement screen to create backup mesage and its signature.

Handle existing siwe backup secrets in cached selections.

Thu, Apr 18, 1:18 AM

Wed, Apr 17

marcin added a comment to D11666: [native] Rename get/setCurrentUserID in CommCoreModule.

Should we regenerate a wasm file?

Wed, Apr 17, 4:35 AM

Tue, Apr 16

marcin added inline comments to D11638: Persist SIWE backup secrets to SQLite after succesfull registration process.
Tue, Apr 16, 7:35 AM
marcin added a comment to D11638: Persist SIWE backup secrets to SQLite after succesfull registration process.

Are we able to cache it, such that if the user goes back to before this screen, and then advances to this screen again, the SIWE flow does not need to be re-entered?

Tue, Apr 16, 5:55 AM
marcin updated the diff for D11638: Persist SIWE backup secrets to SQLite after succesfull registration process.
  1. Clear all cached selections at once after user becomes logged in. Persist siweBackupSecrets in SQLite beforehand.
Tue, Apr 16, 5:52 AM
marcin added inline comments to D11636: Implement screen to create backup mesage and its signature.
Tue, Apr 16, 5:51 AM
marcin attached a referenced file: F1552593: Simulator Screen Shot - iPhone 14 Pro - 2024-04-16 at 14.11.09.png.
Tue, Apr 16, 5:45 AM
marcin added a comment to D11636: Implement screen to create backup mesage and its signature.

Screen with backup icon from MaterialIcons

Simulator Screen Shot - iPhone 14 Pro - 2024-04-16 at 14.11.09.png (2×1 px, 128 KB)

Tue, Apr 16, 5:44 AM
marcin updated the diff for D11644: Extract shareable logic from CreateSIWEBackupMessage component.

Use backup icon from MaterialIcons

Tue, Apr 16, 5:06 AM
marcin updated the diff for D11636: Implement screen to create backup mesage and its signature.

Use backup icon from MaterialIcons

Tue, Apr 16, 5:05 AM
marcin added inline comments to D11636: Implement screen to create backup mesage and its signature.
Tue, Apr 16, 5:04 AM
marcin attached a referenced file: F1552438: Simulator Screen Shot - iPhone 14 Pro - 2024-04-16 at 13.39.45.png.
Tue, Apr 16, 4:43 AM
marcin added a comment to D11636: Implement screen to create backup mesage and its signature.

New screen looks like this:

Simulator Screen Shot - iPhone 14 Pro - 2024-04-16 at 13.39.45.png (2×1 px, 135 KB)

Tue, Apr 16, 4:42 AM
marcin added inline comments to D11636: Implement screen to create backup mesage and its signature.
Tue, Apr 16, 4:42 AM
marcin updated the diff for D11636: Implement screen to create backup mesage and its signature.

Add icon to enchance user experience.

Tue, Apr 16, 4:41 AM
marcin added inline comments to D11645: Force already logged in ETH users to create and sign backup message.
Tue, Apr 16, 3:55 AM
marcin added inline comments to D11645: Force already logged in ETH users to create and sign backup message.
Tue, Apr 16, 3:49 AM
marcin added inline comments to D11638: Persist SIWE backup secrets to SQLite after succesfull registration process.
Tue, Apr 16, 3:05 AM