Page MenuHomePhabricator

marcin (Marcin)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 29 2021, 2:54 AM (129 w, 4 d)

Recent Activity

Fri, Jun 21

marcin updated the diff for D12427: Move android rescinds and badge updates to lib.

Address Ashoat requests

Fri, Jun 21, 5:48 AM
marcin added inline comments to D8566: Upload/download large notification payload from the keyserver/Android NSE if its size exceeds FCM limits.
Fri, Jun 21, 4:46 AM
marcin updated the diff for D12539: Utilise subscription from ThickMemberInfo when building a notif.

Fix android bug

Fri, Jun 21, 4:44 AM
marcin added inline comments to D12397: Move notification creaction and encryption to lib except for APNs noifs..
Fri, Jun 21, 4:37 AM
marcin requested review of D12539: Utilise subscription from ThickMemberInfo when building a notif.
Fri, Jun 21, 4:25 AM
marcin added inline comments to D8566: Upload/download large notification payload from the keyserver/Android NSE if its size exceeds FCM limits.
Fri, Jun 21, 4:25 AM

Thu, Jun 20

marcin added inline comments to D12495: [lib] Introduce RawThickThreadInfo type.
Thu, Jun 20, 8:19 AM
marcin accepted D12494: [lib] Factor out defaultSubscription in createPendingThread.
Thu, Jun 20, 8:17 AM
marcin accepted D12479: [web][native] olm api method to mark prekeys as published.
Thu, Jun 20, 7:47 AM
marcin added inline comments to D12464: Implement notification texts generation on the client.
Thu, Jun 20, 5:01 AM
marcin updated the diff for D12477: Implement building encrypted notifications on the client.

Rebase

Thu, Jun 20, 5:00 AM
marcin added a comment to D12476: Move groupping device by platform details and notif info generation promise to utils in lib/push.

This diff is pure copy paste. No additional logic.

Thu, Jun 20, 5:00 AM
marcin updated the diff for D12476: Move groupping device by platform details and notif info generation promise to utils in lib/push.

Rebacr

Thu, Jun 20, 4:59 AM
marcin added inline comments to D12464: Implement notification texts generation on the client.
Thu, Jun 20, 4:59 AM
marcin updated the diff for D12464: Implement notification texts generation on the client.

Refactor

Thu, Jun 20, 4:56 AM
marcin updated the diff for D12463: Implement route from MessageData to MessageInfo on the client.

Fix eslint

Thu, Jun 20, 4:56 AM
marcin updated the diff for D12429: Implement notification types, creation and encryption for APNs notifications.

Fix eslint

Thu, Jun 20, 4:55 AM
marcin updated the diff for D12464: Implement notification texts generation on the client.

Rebase

Thu, Jun 20, 4:51 AM
marcin added inline comments to D12463: Implement route from MessageData to MessageInfo on the client.
Thu, Jun 20, 4:51 AM
marcin updated the diff for D12463: Implement route from MessageData to MessageInfo on the client.

Rebase

Thu, Jun 20, 4:47 AM
marcin added inline comments to D12429: Implement notification types, creation and encryption for APNs notifications.
Thu, Jun 20, 4:42 AM
marcin updated the diff for D12429: Implement notification types, creation and encryption for APNs notifications.

Rebase and move apns logic to separate file

Thu, Jun 20, 4:38 AM
marcin added inline comments to D12427: Move android rescinds and badge updates to lib.
Thu, Jun 20, 4:36 AM
marcin updated the diff for D12427: Move android rescinds and badge updates to lib.

rebase and fix types

Thu, Jun 20, 4:34 AM
marcin updated the diff for D12398: Rename cookieID -> cryptoID and deviceToken -> deliveryID.

Rebase

Thu, Jun 20, 4:33 AM
marcin added inline comments to D12397: Move notification creaction and encryption to lib except for APNs noifs..
Thu, Jun 20, 4:32 AM
marcin added inline comments to D12397: Move notification creaction and encryption to lib except for APNs noifs..
Thu, Jun 20, 4:20 AM
marcin updated the diff for D12397: Move notification creaction and encryption to lib except for APNs noifs..

Split notif creators for each platform to separate files.

Thu, Jun 20, 4:20 AM
marcin updated the diff for D12396: Introduce EncryptedNotifUtilsAPI and implement it on the keyserver.

Rebase

Thu, Jun 20, 4:19 AM
marcin updated the diff for D12395: Enable encrypted notifications to have keyservevrID or senderDeviceID.

Rebase

Thu, Jun 20, 4:17 AM
marcin updated the diff for D12395: Enable encrypted notifications to have keyservevrID or senderDeviceID.
  1. Use invariant instead of new const
  2. Rename to SenderDeviceDescriptor
  3. Make types elegant.
Thu, Jun 20, 4:16 AM
marcin added inline comments to D12395: Enable encrypted notifications to have keyservevrID or senderDeviceID.
Thu, Jun 20, 4:15 AM
marcin added inline comments to D12395: Enable encrypted notifications to have keyservevrID or senderDeviceID.
Thu, Jun 20, 4:12 AM
marcin added a comment to D12398: Rename cookieID -> cryptoID and deviceToken -> deliveryID.

Probably you know it better so up to you but for me recipientID seems better than cryptoID

Thu, Jun 20, 3:24 AM

Wed, Jun 19

marcin requested review of D12477: Implement building encrypted notifications on the client.
Wed, Jun 19, 1:39 PM
marcin requested review of D12476: Move groupping device by platform details and notif info generation promise to utils in lib/push.
Wed, Jun 19, 1:33 PM
marcin accepted D12467: [web] mark otks as published before attempting to upload keys to identity.
Wed, Jun 19, 6:09 AM

Tue, Jun 18

marcin requested review of D12464: Implement notification texts generation on the client.
Tue, Jun 18, 6:12 AM
marcin requested review of D12463: Implement route from MessageData to MessageInfo on the client.
Tue, Jun 18, 6:12 AM

Fri, Jun 14

marcin accepted D12439: [keyserver] Set thread links code version.
Fri, Jun 14, 6:25 AM

Thu, Jun 13

marcin resigned from D12348: [identity][terraform] Create DDB index for deviceID.

@will or @varun will do a better job reviewing this.

Thu, Jun 13, 9:30 AM
marcin requested review of D12429: Implement notification types, creation and encryption for APNs notifications.
Thu, Jun 13, 9:20 AM
marcin requested review of D12428: Bump minimal native code version to 149.
Thu, Jun 13, 9:14 AM
marcin requested review of D12427: Move android rescinds and badge updates to lib.
Thu, Jun 13, 9:07 AM

Tue, Jun 11

marcin requested review of D12398: Rename cookieID -> cryptoID and deviceToken -> deliveryID.
Tue, Jun 11, 11:02 AM
marcin requested review of D12397: Move notification creaction and encryption to lib except for APNs noifs..
Tue, Jun 11, 10:56 AM
marcin requested review of D12396: Introduce EncryptedNotifUtilsAPI and implement it on the keyserver.
Tue, Jun 11, 10:54 AM
marcin requested review of D12395: Enable encrypted notifications to have keyservevrID or senderDeviceID.
Tue, Jun 11, 10:44 AM
marcin requested review of D12394: Move all notif types to lib except for APNs notifs.
Tue, Jun 11, 10:40 AM

Fri, Jun 7

marcin accepted D12304: [identity] Add /inbound_keys HTTP handler.
Fri, Jun 7, 10:09 AM

Thu, Jun 6

marcin closed D12312: Synchronize platform details with identity on app start.
Thu, Jun 6, 8:59 AM
marcin committed rCOMMfcb896100446: Synchronize platform details with identity on app start (authored by marcin).
Synchronize platform details with identity on app start
Thu, Jun 6, 8:59 AM
marcin closed D12311: Expose syncing platform details to identity client context.
Thu, Jun 6, 8:59 AM
marcin committed rCOMMdabebc1ca86f: Expose syncing platform details to identity client context (authored by marcin).
Expose syncing platform details to identity client context
Thu, Jun 6, 8:59 AM
marcin closed D12310: Implement native wrapper for syncPlatformDetails RPC.
Thu, Jun 6, 8:59 AM
marcin committed rCOMM54e4b16d2f01: Implement native wrapper for syncPlatformDetails RPC (authored by marcin).
Implement native wrapper for syncPlatformDetails RPC
Thu, Jun 6, 8:59 AM
marcin closed D12308: Enable the client to fetch users platform details from identity RPC.
Thu, Jun 6, 8:59 AM
marcin committed rCOMM89119a1098b9: Enable the client to fetch users platform details from identity RPC (authored by marcin).
Enable the client to fetch users platform details from identity RPC
Thu, Jun 6, 8:59 AM
marcin closed D12307: Add identity platform details to aux user store.
Thu, Jun 6, 8:59 AM
marcin committed rCOMMca08c62896e9: Add identity platform details to aux user store (authored by marcin).
Add identity platform details to aux user store
Thu, Jun 6, 8:59 AM
marcin updated the diff for D12312: Synchronize platform details with identity on app start.

Rebase before landing

Thu, Jun 6, 8:28 AM
marcin updated the diff for D12311: Expose syncing platform details to identity client context.

Rebase before landing

Thu, Jun 6, 8:27 AM
marcin updated the diff for D12310: Implement native wrapper for syncPlatformDetails RPC.

Rebase befoe landing

Thu, Jun 6, 8:26 AM
marcin updated the diff for D12308: Enable the client to fetch users platform details from identity RPC.

Rerbase before landing

Thu, Jun 6, 8:23 AM
marcin updated the diff for D12307: Add identity platform details to aux user store.

Rebase before landing

Thu, Jun 6, 8:22 AM
marcin closed D12334: Deploy identity 0.22-staging to staging.
Thu, Jun 6, 7:58 AM
marcin committed rCOMM47d699f758b6: Deploy identity 0.22-staging to staging (authored by marcin).
Deploy identity 0.22-staging to staging
Thu, Jun 6, 7:58 AM
marcin added inline comments to D12307: Add identity platform details to aux user store.
Thu, Jun 6, 5:34 AM
marcin accepted D12300: [identity] Add Serialize trait for inbound keys types.
Thu, Jun 6, 2:13 AM
marcin accepted D12282: [identity][grpc_clients] Move PlatformMetadata to grpc_clients crate.
Thu, Jun 6, 2:08 AM
marcin accepted D12279: [grpc_clients] Add platform details metadata.
Thu, Jun 6, 2:08 AM

Wed, Jun 5

marcin updated the diff for D12308: Enable the client to fetch users platform details from identity RPC.

Make inner collection immutable. Use direct assignment in a for loop.

Wed, Jun 5, 6:48 AM
marcin updated the diff for D12307: Add identity platform details to aux user store.

Fix types. Use a map of [deviceID]: IdentityPlatformDetails

Wed, Jun 5, 6:47 AM
marcin planned changes to D12307: Add identity platform details to aux user store.

Those types are totally wrong. We need mapping from device id to platform details. Interestingly reducer worked as expected - it put map into the SQLite.

Wed, Jun 5, 5:36 AM
marcin updated the diff for D12308: Enable the client to fetch users platform details from identity RPC.
  1. Make collection mutable.
  2. Use for loop instead of forEach
Wed, Jun 5, 3:00 AM
marcin updated the diff for D12307: Add identity platform details to aux user store.

Make identity platform details type readonly

Wed, Jun 5, 2:59 AM
marcin added inline comments to D12307: Add identity platform details to aux user store.
Wed, Jun 5, 2:47 AM
marcin accepted D12283: [grpc_clients] Accept PlatformMetadata when creating client.
Wed, Jun 5, 2:24 AM
marcin accepted D12272: [protos] Add PlatformDetails to PeersDeviceListsResponse.
Wed, Jun 5, 2:23 AM
marcin updated the diff for D12312: Synchronize platform details with identity on app start.
  1. Fix typing
  2. Use hasRun ref.
  3. Fix typing of MinVersionHandler
Wed, Jun 5, 2:22 AM
marcin added inline comments to D12312: Synchronize platform details with identity on app start.
Wed, Jun 5, 2:20 AM
marcin added a comment to D12312: Synchronize platform details with identity on app start.

By the way, do you think it makes sense to merge this with VersionSupportedChecker component?

I was thinking about this but I couldn't find any compelling arguments against neither of those solutions. What made me finally decide to use separate component was that we have two different components to check version support on native on web. However this logic is exactly the same for both platforms so putting it inside version support checkers would result in code duplication.

Wed, Jun 5, 2:13 AM

Tue, Jun 4

marcin updated subscribers of D12272: [protos] Add PlatformDetails to PeersDeviceListsResponse.
Tue, Jun 4, 9:35 AM
marcin accepted D12280: [web] Add platform details metadata.
Tue, Jun 4, 9:33 AM
marcin added inline comments to D12283: [grpc_clients] Accept PlatformMetadata when creating client.
Tue, Jun 4, 9:23 AM
marcin added inline comments to D12282: [identity][grpc_clients] Move PlatformMetadata to grpc_clients crate.
Tue, Jun 4, 9:20 AM
marcin added inline comments to D12279: [grpc_clients] Add platform details metadata.
Tue, Jun 4, 9:09 AM
marcin accepted D12275: [native_rust_library] Write state version as build-time constant.
Tue, Jun 4, 9:06 AM
marcin accepted D12274: [identity][protos] Add RPC to update PlatformDetails.
Tue, Jun 4, 9:03 AM
marcin accepted D12273: [identity] Fetch platform details along with device lists.
Tue, Jun 4, 9:01 AM
marcin added inline comments to D12272: [protos] Add PlatformDetails to PeersDeviceListsResponse.
Tue, Jun 4, 9:00 AM
marcin accepted D12270: [identity] Add metadata parser for PlatformDetails.
Tue, Jun 4, 7:57 AM
marcin accepted D12271: [identity] Get device PlatformDetails from metadata.
Tue, Jun 4, 7:52 AM
marcin accepted D12269: [identity] Introduce PlatformDetails DDB attribute.
Tue, Jun 4, 7:48 AM
marcin updated the diff for D12312: Synchronize platform details with identity on app start.

Check against usingCommServicesAccessToken before trying to sync platform details

Tue, Jun 4, 7:45 AM
marcin requested review of D12312: Synchronize platform details with identity on app start.
Tue, Jun 4, 7:26 AM
marcin requested review of D12311: Expose syncing platform details to identity client context.
Tue, Jun 4, 7:02 AM
marcin requested review of D12310: Implement native wrapper for syncPlatformDetails RPC.
Tue, Jun 4, 6:59 AM
marcin requested review of D12308: Enable the client to fetch users platform details from identity RPC.
Tue, Jun 4, 1:46 AM
marcin requested review of D12307: Add identity platform details to aux user store.
Tue, Jun 4, 1:34 AM