Page MenuHomePhabricator

marcin (Marcin)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 29 2021, 2:54 AM (64 w, 4 d)

Recent Activity

Fri, Mar 24

marcin updated the diff for D7125: Use new notifications permission API to modify push notifs settings alerts on Android 13.

Refactor code to make more readable check for ability to request notifications permission

Fri, Mar 24, 10:35 AM
marcin updated the diff for D7120: Use notifications permission request API on Android 13 while keeping old behavior on older Androids..

More robust check as to whether issue notifications permission request.

Fri, Mar 24, 10:33 AM
marcin updated the diff for D7106: Native Java code to request notifications permissions from JS on Android 13.
  1. Replace method overloading with different names.
  2. Simplify check for Android OS version.
  3. Add comment to explain hardcoded request code for notifications permission.
Fri, Mar 24, 10:32 AM
marcin updated the diff for D7105: Build files set-up for Android 13.

Add intent-filter for MainActivity to be started from SplashActivity in debug build

Fri, Mar 24, 10:30 AM
marcin added inline comments to D7125: Use new notifications permission API to modify push notifs settings alerts on Android 13.
Fri, Mar 24, 10:02 AM
marcin added inline comments to D7120: Use notifications permission request API on Android 13 while keeping old behavior on older Androids..
Fri, Mar 24, 9:56 AM
marcin added inline comments to D7106: Native Java code to request notifications permissions from JS on Android 13.
Fri, Mar 24, 6:30 AM
marcin added inline comments to D7106: Native Java code to request notifications permissions from JS on Android 13.
Fri, Mar 24, 6:05 AM
marcin added inline comments to D7106: Native Java code to request notifications permissions from JS on Android 13.
Fri, Mar 24, 6:00 AM
marcin added inline comments to D7105: Build files set-up for Android 13.
Fri, Mar 24, 5:43 AM

Thu, Mar 23

marcin added inline comments to D7120: Use notifications permission request API on Android 13 while keeping old behavior on older Androids..
Thu, Mar 23, 7:57 AM
marcin added inline comments to D7106: Native Java code to request notifications permissions from JS on Android 13.
Thu, Mar 23, 7:24 AM
marcin added inline comments to D7105: Build files set-up for Android 13.
Thu, Mar 23, 7:04 AM
marcin updated the diff for D7105: Build files set-up for Android 13.

Important changes for media files permission and ability to launch MainActivity from SplachActivity

Thu, Mar 23, 6:56 AM

Wed, Mar 22

marcin updated the diff for D7106: Native Java code to request notifications permissions from JS on Android 13.

Use compareAndSet since it is safer and cleaner

Wed, Mar 22, 2:08 AM
marcin updated the diff for D7106: Native Java code to request notifications permissions from JS on Android 13.

Use getAndSet() sicne it is safer and cleaner

Wed, Mar 22, 2:05 AM
marcin updated the diff for D7106: Native Java code to request notifications permissions from JS on Android 13.

Reject promise if there is ongoing one already. Check for null promise to avoid NPE.

Wed, Mar 22, 2:02 AM
marcin added inline comments to D7106: Native Java code to request notifications permissions from JS on Android 13.
Wed, Mar 22, 2:00 AM

Tue, Mar 21

marcin requested review of D7125: Use new notifications permission API to modify push notifs settings alerts on Android 13.
Tue, Mar 21, 8:48 AM
marcin updated the diff for D7105: Build files set-up for Android 13.

Bump buildToolsVersion

Tue, Mar 21, 8:41 AM
marcin requested review of D7120: Use notifications permission request API on Android 13 while keeping old behavior on older Androids..
Tue, Mar 21, 7:35 AM
marcin added inline comments to D7105: Build files set-up for Android 13.
Tue, Mar 21, 7:34 AM
marcin updated the diff for D7106: Native Java code to request notifications permissions from JS on Android 13.

Mirror iOS behavior on Android 13

Tue, Mar 21, 7:08 AM
marcin planned changes to D7106: Native Java code to request notifications permissions from JS on Android 13.

I will change JS-visible interface this methods.

Tue, Mar 21, 1:52 AM

Mon, Mar 20

marcin requested review of D7106: Native Java code to request notifications permissions from JS on Android 13.
Mon, Mar 20, 12:28 PM
marcin requested review of D7105: Build files set-up for Android 13.
Mon, Mar 20, 12:24 PM

Wed, Mar 15

marcin closed D6922: Permanently enable rescind and visible notifications processing via NotificationService.
Wed, Mar 15, 7:45 AM
marcin closed D6920: Modify TemporaryMessageStorage API, so that we can have two storages: one (created by default init) for messages and the other for rescinds..
Wed, Mar 15, 7:45 AM
marcin closed D6921: Persist rescinds payloads in NSE so that AppDelegate can update thread statuses on app start..
Wed, Mar 15, 7:45 AM
marcin committed rCOMM523b192eaa62: Permanently enable rescind and visible notifications processing via… (authored by marcin).
Permanently enable rescind and visible notifications processing via…
Wed, Mar 15, 7:45 AM
marcin committed rCOMMfaf07ac262f5: Persist rescinds payloads in NSE so that AppDelegate can update thread statuses… (authored by marcin).
Persist rescinds payloads in NSE so that AppDelegate can update thread statuses…
Wed, Mar 15, 7:45 AM
marcin committed rCOMM7d230d26f9cb: Modify TemporaryMessageStorage API, so that we can have two storages: one… (authored by marcin).
Modify TemporaryMessageStorage API, so that we can have two storages: one…
Wed, Mar 15, 7:45 AM
marcin closed D6918: Silence rescinds in NSE.
Wed, Mar 15, 7:45 AM
marcin closed D6919: Remove relevant notification from notifications center when receiving rescind in NSE.
Wed, Mar 15, 7:45 AM
marcin committed rCOMMb155617fd0d7: Remove relevant notification from notifications center when receiving rescind… (authored by marcin).
Remove relevant notification from notifications center when receiving rescind…
Wed, Mar 15, 7:45 AM
marcin committed rCOMM70905d6a8d4d: Silence rescinds in NSE (authored by marcin).
Silence rescinds in NSE
Wed, Mar 15, 7:45 AM
marcin closed D6917: Prepare to conditionally process rescinds in NSE..
Wed, Mar 15, 7:45 AM
marcin committed rCOMM4f2022de618b: Prepare to conditionally process rescinds in NSE. (authored by marcin).
Prepare to conditionally process rescinds in NSE.
Wed, Mar 15, 7:45 AM
marcin added a comment to D7058: Use initial notifications from queue rather than from launch options.

Why hasn't this been landed? It's an urgent issue and the diff was accepted on Monday...

Wed, Mar 15, 7:17 AM
marcin added a comment to D6921: Persist rescinds payloads in NSE so that AppDelegate can update thread statuses on app start..

Why hasn't this been landed? As mentioned on Monday, we need to create a release with these changes ASAP so we can test the before the end of the month...

Wed, Mar 15, 7:15 AM
marcin updated the diff for D6922: Permanently enable rescind and visible notifications processing via NotificationService.

Rebase before landing. Add check for code version

Wed, Mar 15, 7:10 AM
marcin updated the diff for D6921: Persist rescinds payloads in NSE so that AppDelegate can update thread statuses on app start..

Rebase before landing. Extract thread ID key to constant

Wed, Mar 15, 7:10 AM
marcin updated the diff for D6920: Modify TemporaryMessageStorage API, so that we can have two storages: one (created by default init) for messages and the other for rescinds..

Rebase before landing

Wed, Mar 15, 7:09 AM
marcin updated the diff for D6919: Remove relevant notification from notifications center when receiving rescind in NSE.

Rebase before landing

Wed, Mar 15, 7:09 AM
marcin updated the diff for D6918: Silence rescinds in NSE.

Rebase before landing

Wed, Mar 15, 7:08 AM
marcin updated the diff for D6917: Prepare to conditionally process rescinds in NSE..

Rebase before landing

Wed, Mar 15, 7:08 AM
marcin closed D7058: Use initial notifications from queue rather than from launch options.
Wed, Mar 15, 6:35 AM
marcin committed rCOMM3b3a0f4f991a: Use initial notifications from queue rather than from launch options (authored by marcin).
Use initial notifications from queue rather than from launch options
Wed, Mar 15, 6:35 AM
marcin updated the diff for D7058: Use initial notifications from queue rather than from launch options.

Rebase before landing

Wed, Mar 15, 6:15 AM

Tue, Mar 14

marcin added inline comments to D6921: Persist rescinds payloads in NSE so that AppDelegate can update thread statuses on app start..
Tue, Mar 14, 7:46 AM
marcin added inline comments to D6921: Persist rescinds payloads in NSE so that AppDelegate can update thread statuses on app start..
Tue, Mar 14, 1:21 AM

Mon, Mar 13

marcin added inline comments to D6920: Modify TemporaryMessageStorage API, so that we can have two storages: one (created by default init) for messages and the other for rescinds..
Mon, Mar 13, 6:50 AM
marcin updated the diff for D6917: Prepare to conditionally process rescinds in NSE..

Add comment explaining even release pattern

Mon, Mar 13, 5:17 AM
marcin added inline comments to D6921: Persist rescinds payloads in NSE so that AppDelegate can update thread statuses on app start..
Mon, Mar 13, 4:52 AM
marcin requested review of D7058: Use initial notifications from queue rather than from launch options.
Mon, Mar 13, 4:02 AM

Wed, Mar 8

marcin closed D6959: Run everuthing regarding NotificationsCryptoModule with native Android Accessible.
Wed, Mar 8, 3:01 AM
marcin committed rCOMM94d3449b1bb0: Run everuthing regarding NotificationsCryptoModule with native Android… (authored by marcin).
Run everuthing regarding NotificationsCryptoModule with native Android…
Wed, Mar 8, 3:01 AM
marcin closed D6980: Revert "[native] Move CommSecureStore::get to main thread to avoid JNI crash".
Wed, Mar 8, 3:01 AM
marcin added a reverting change for D6958: [native] Move CommSecureStore::get to main thread to avoid JNI crash: rCOMM2453e10d5b13: Revert "[native] Move CommSecureStore::get to main thread to avoid JNI crash".
Wed, Mar 8, 3:00 AM
marcin committed rCOMM2453e10d5b13: Revert "[native] Move CommSecureStore::get to main thread to avoid JNI crash" (authored by marcin).
Revert "[native] Move CommSecureStore::get to main thread to avoid JNI crash"
Wed, Mar 8, 3:00 AM
marcin added a reverting change for rCOMM980305ee4c95: [native] Move CommSecureStore::get to main thread to avoid JNI crash: rCOMM2453e10d5b13: Revert "[native] Move CommSecureStore::get to main thread to avoid JNI crash".
Wed, Mar 8, 3:00 AM
marcin added 1 blocking reviewer(s) for D6921: Persist rescinds payloads in NSE so that AppDelegate can update thread statuses on app start.: tomek.
Wed, Mar 8, 2:17 AM
marcin added 1 blocking reviewer(s) for D6920: Modify TemporaryMessageStorage API, so that we can have two storages: one (created by default init) for messages and the other for rescinds.: tomek.
Wed, Mar 8, 2:16 AM
marcin updated the diff for D6959: Run everuthing regarding NotificationsCryptoModule with native Android Accessible.

Rebase before landing

Wed, Mar 8, 2:14 AM
marcin updated the diff for D6980: Revert "[native] Move CommSecureStore::get to main thread to avoid JNI crash".

Rebase before landing

Wed, Mar 8, 2:13 AM

Tue, Mar 7

marcin requested review of D6959: Run everuthing regarding NotificationsCryptoModule with native Android Accessible.
Tue, Mar 7, 8:29 AM
marcin added a comment to D6959: Run everuthing regarding NotificationsCryptoModule with native Android Accessible.

I considered a solution like this, but I was worried that we would need some synchronization. @marcin, can you share some resources that show that NativeAndroidAccessProvider::runTask is "blocking", ie. it guarantees that the lambda passed to it will finish executing before it returns?

(Passing back with question)

Tue, Mar 7, 8:29 AM
marcin updated the diff for D6959: Run everuthing regarding NotificationsCryptoModule with native Android Accessible.

Attach thread to JVM when calling CommSecureStore on Android to avoid JNI crash

Tue, Mar 7, 6:54 AM
marcin updated subscribers of D6959: Run everuthing regarding NotificationsCryptoModule with native Android Accessible.

Okay, based on that it sounds like your solution is probably better than mine.

  1. Let's try to do it without macros if possible (it doesn't seem like we've needed them before, but maybe I'm wrong)

There was a period when we were using macros for this purpose: https://phab.comm.dev/D6416. Now it is refactored not to use macros at the cost of implementing this in Android specific directory. Basically if we want to share a C++, which could potentially cause JNI error, between platforms we have to use macros. If we don't want to use macros we have to make sure that methods called in common C++ that are implemented in Android specific directory are wrapped with NativeAndroidAccessible. In this particular case it is the get method of CommSecureStore that has to be wrapped with NativeAndroidAccessible mirroring what has already been done for set method. I talked to @kamil who wrapped set method with NativeAndroidAccessible. He agreed that similar change should have been done for get.

Tue, Mar 7, 6:37 AM
marcin requested review of D6980: Revert "[native] Move CommSecureStore::get to main thread to avoid JNI crash".
Tue, Mar 7, 5:53 AM
marcin updated the diff for D6959: Run everuthing regarding NotificationsCryptoModule with native Android Accessible.

Rebase

Tue, Mar 7, 5:38 AM
marcin added a reverting change for D6958: [native] Move CommSecureStore::get to main thread to avoid JNI crash: D6980: Revert "[native] Move CommSecureStore::get to main thread to avoid JNI crash".
Tue, Mar 7, 5:37 AM
marcin added a reverting change for rCOMM980305ee4c95: [native] Move CommSecureStore::get to main thread to avoid JNI crash: D6980: Revert "[native] Move CommSecureStore::get to main thread to avoid JNI crash".
Tue, Mar 7, 5:37 AM
marcin added a comment to D6959: Run everuthing regarding NotificationsCryptoModule with native Android Accessible.

Open to it if there is some benefit over approach in D6958, but would like to see a discussion of tradeoffs.

Tue, Mar 7, 4:36 AM

Mon, Mar 6

marcin requested review of D6959: Run everuthing regarding NotificationsCryptoModule with native Android Accessible.
Mon, Mar 6, 1:03 PM

Fri, Mar 3

marcin updated the diff for D6919: Remove relevant notification from notifications center when receiving rescind in NSE.

Post semaphore once and only once. Give lambda a better name

Fri, Mar 3, 7:49 AM
marcin updated the diff for D6917: Prepare to conditionally process rescinds in NSE..

Remove artificial body property

Fri, Mar 3, 7:48 AM

Thu, Mar 2

marcin added inline comments to D6917: Prepare to conditionally process rescinds in NSE..
Thu, Mar 2, 8:18 AM
marcin added inline comments to D6919: Remove relevant notification from notifications center when receiving rescind in NSE.
Thu, Mar 2, 8:05 AM
marcin added inline comments to D6917: Prepare to conditionally process rescinds in NSE..
Thu, Mar 2, 7:54 AM

Wed, Mar 1

marcin updated the diff for D6919: Remove relevant notification from notifications center when receiving rescind in NSE.

Rebase

Wed, Mar 1, 5:37 AM
marcin updated the diff for D6918: Silence rescinds in NSE.

Add constant for rescind type indicator

Wed, Mar 1, 5:37 AM
marcin updated the diff for D6922: Permanently enable rescind and visible notifications processing via NotificationService.

Remove unread constant

Wed, Mar 1, 5:33 AM
marcin updated the diff for D6922: Permanently enable rescind and visible notifications processing via NotificationService.

Remove rescind handling from AppDelegate.

Wed, Mar 1, 5:30 AM
marcin updated the summary of D6917: Prepare to conditionally process rescinds in NSE..
Wed, Mar 1, 5:10 AM
marcin requested review of D6922: Permanently enable rescind and visible notifications processing via NotificationService.
Wed, Mar 1, 5:09 AM
marcin updated the summary of D6917: Prepare to conditionally process rescinds in NSE..
Wed, Mar 1, 5:08 AM
marcin requested review of D6921: Persist rescinds payloads in NSE so that AppDelegate can update thread statuses on app start..
Wed, Mar 1, 4:35 AM
marcin requested review of D6920: Modify TemporaryMessageStorage API, so that we can have two storages: one (created by default init) for messages and the other for rescinds..
Wed, Mar 1, 4:22 AM
marcin requested review of D6919: Remove relevant notification from notifications center when receiving rescind in NSE.
Wed, Mar 1, 4:11 AM
marcin requested review of D6918: Silence rescinds in NSE.
Wed, Mar 1, 4:02 AM
marcin requested review of D6917: Prepare to conditionally process rescinds in NSE..
Wed, Mar 1, 3:55 AM
marcin closed D6821: Implement method to sign message.
Wed, Mar 1, 2:04 AM
marcin closed D6822: Sign concatenation of public and notif keypairs using private key of public identity.
Wed, Mar 1, 2:04 AM
marcin committed rCOMMa91b1a96bd3e: Implement method to sign message (authored by marcin).
Implement method to sign message
Wed, Mar 1, 2:04 AM
marcin committed rCOMM0d5ed08376e9: Sign concatenation of public and notif keypairs using private key of public… (authored by marcin).
Sign concatenation of public and notif keypairs using private key of public…
Wed, Mar 1, 2:04 AM
marcin closed D6780: Refactor CommCoreModule.initializeCryptoAccount not to take userID as an argument..
Wed, Mar 1, 2:04 AM
marcin closed D6781: Initialize notifications olm account in CommCoreModule and expose notifications public keys to JS.
Wed, Mar 1, 2:04 AM
marcin closed D6779: Implement utility method to remove notifications olm account storage.
Wed, Mar 1, 2:04 AM
marcin committed rCOMMb0bf604bc8ef: Refactor CommCoreModule.initializeCryptoAccount not to take userID as an… (authored by marcin).
Refactor CommCoreModule.initializeCryptoAccount not to take userID as an…
Wed, Mar 1, 2:04 AM