User Details
- User Since
- Dec 29 2021, 2:54 AM (64 w, 4 d)
Fri, Mar 24
Refactor code to make more readable check for ability to request notifications permission
More robust check as to whether issue notifications permission request.
- Replace method overloading with different names.
- Simplify check for Android OS version.
- Add comment to explain hardcoded request code for notifications permission.
Add intent-filter for MainActivity to be started from SplashActivity in debug build
Thu, Mar 23
Important changes for media files permission and ability to launch MainActivity from SplachActivity
Wed, Mar 22
Use compareAndSet since it is safer and cleaner
Use getAndSet() sicne it is safer and cleaner
Reject promise if there is ongoing one already. Check for null promise to avoid NPE.
Tue, Mar 21
Bump buildToolsVersion
Mirror iOS behavior on Android 13
I will change JS-visible interface this methods.
Mon, Mar 20
Wed, Mar 15
Rebase before landing. Add check for code version
Rebase before landing. Extract thread ID key to constant
Rebase before landing
Rebase before landing
Rebase before landing
Rebase before landing
Rebase before landing
Tue, Mar 14
Mon, Mar 13
Add comment explaining even release pattern
Wed, Mar 8
Rebase before landing
Rebase before landing
Tue, Mar 7
Attach thread to JVM when calling CommSecureStore on Android to avoid JNI crash
There was a period when we were using macros for this purpose: https://phab.comm.dev/D6416. Now it is refactored not to use macros at the cost of implementing this in Android specific directory. Basically if we want to share a C++, which could potentially cause JNI error, between platforms we have to use macros. If we don't want to use macros we have to make sure that methods called in common C++ that are implemented in Android specific directory are wrapped with NativeAndroidAccessible. In this particular case it is the get method of CommSecureStore that has to be wrapped with NativeAndroidAccessible mirroring what has already been done for set method. I talked to @kamil who wrapped set method with NativeAndroidAccessible. He agreed that similar change should have been done for get.
Rebase
Mon, Mar 6
Fri, Mar 3
Post semaphore once and only once. Give lambda a better name
Remove artificial body property
Thu, Mar 2
Wed, Mar 1
Rebase
Add constant for rescind type indicator
Remove unread constant
Remove rescind handling from AppDelegate.