Page MenuHomePhabricator

marcin (Marcin)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 29 2021, 2:54 AM (134 w, 3 d)

Recent Activity

Yesterday

marcin requested review of D12882: Implement sending E2EE notification from the client.
Fri, Jul 26, 7:44 AM
marcin accepted D12898: [identity] Fix saving majorDesktopVersion metadata.
Fri, Jul 26, 7:18 AM

Thu, Jul 25

marcin updated the diff for D12673: Utilities to idempotently create content and notif sessions.
  1. Use query to check notifications session for multiple devices at once and initilize crypto account in send utils instead of each time before encryption. it is huge performance improvement.
  2. Fix context cycle
Thu, Jul 25, 9:47 AM
marcin updated the diff for D12672: Implement utility functions to check if we have content or notif session with device.

Add additional method to check for presence of notifications session for multiple devices with one db query

Thu, Jul 25, 9:45 AM

Wed, Jul 24

marcin updated the diff for D12748: Expose function to get notifs inbound keys to C++.

Address review

Wed, Jul 24, 5:56 AM
marcin updated the diff for D12703: Transfer CSAT to IndexedDB from service worker and implement call to identity to query for inbound keys.

Address review

Wed, Jul 24, 5:55 AM
marcin updated the diff for D12836: Patch localforage to support transactional multiple items retrieval/persistence.

Addres review

Wed, Jul 24, 5:55 AM
marcin updated the diff for D12677: Implement method to query identity service from the NSE.

Address review

Wed, Jul 24, 5:54 AM
marcin updated the diff for D12676: Migrate notifications crypto account to MMKV on native.

Address review

Wed, Jul 24, 5:54 AM
marcin updated the diff for D12673: Utilities to idempotently create content and notif sessions.

Address review

Wed, Jul 24, 5:52 AM
marcin updated the diff for D12672: Implement utility functions to check if we have content or notif session with device.

Address review

Wed, Jul 24, 5:48 AM
marcin updated the diff for D12670: Implement notification encryption on native.

Address review

Wed, Jul 24, 5:45 AM
marcin updated the diff for D12669: Implement peer notifications session creation as outbound on web and add notifs outbound session creator to OlmAPI.

Address review

Wed, Jul 24, 5:45 AM
marcin updated the diff for D12668: Implement peer notifications session creation as outbound on native.

Address review

Wed, Jul 24, 5:44 AM
marcin added a comment to D12692: Migrate notification account to IndexedDB on web.

Right now two JS threads (shared worker and service worker) can concurrently modify the same key in IndexedDB. I think to make it safe we should use transactions to make sure this is safe.

Unfortunately, looks like locaforage is not supporting this: https://github.com/localForage/localForage/issues/582 and https://github.com/localForage/localForage/issues/17.

Could you do some research about whether it's safe or suggest an alternative solution?

(this could change most of the code so not reviewing details of this diff)

Wed, Jul 24, 4:49 AM
marcin added a comment to D12836: Patch localforage to support transactional multiple items retrieval/persistence.

About to create fork with PR shortly

Wed, Jul 24, 4:47 AM
marcin added a comment to D12677: Implement method to query identity service from the NSE.

The HTTP request-response logic looks good; it's analogous to the existing Blob GET request logic.

Accepting but please remember to fix that semicolon. Otherwise, release builds will fail.

Wed, Jul 24, 4:46 AM
marcin added inline comments to D12670: Implement notification encryption on native.
Wed, Jul 24, 3:54 AM
marcin added inline comments to D12672: Implement utility functions to check if we have content or notif session with device.
Wed, Jul 24, 3:43 AM
marcin added a comment to D12668: Implement peer notifications session creation as outbound on native.

I really don't like the idea (looking at this diff and the entire stack) of passing isKeyserverSession - notification crypto module should treat all devices the same regardless of whether this is a keyserver or client device, and we should only have senderID, because the current design makes it confusing. But given this is implemented and tested I believe we can proceed, you could create a follow-up task to improve it in future but for now LGTM.

Curious for @marcin's perspective on this, and how much time it might take to fix up

Wed, Jul 24, 2:48 AM

Tue, Jul 23

marcin updated the test plan for D12838: Implement web notifs session createion with race condition handling.
Tue, Jul 23, 11:12 AM
marcin updated the diff for D12838: Implement web notifs session createion with race condition handling.

Rebase

Tue, Jul 23, 11:08 AM
marcin updated the diff for D12750: Implement inbound notif session creation from the NSE with race condition handling.

Use common C++ implementation on Android. It was tested the same way as iOS using latest staging Tunnelbroker release

Tue, Jul 23, 11:07 AM
marcin updated the diff for D12692: Migrate notification account to IndexedDB on web.

Rebase

Tue, Jul 23, 11:05 AM
marcin updated the diff for D12673: Utilities to idempotently create content and notif sessions.

Use the API in send-utils

Tue, Jul 23, 11:04 AM
marcin updated the diff for D12671: Implement notification encryption on web.

Make encryptNotification a part of olmAPI. This change is ESSENTIAL on web since it makes encryptNotification run on shared worker. This enables us to deterministically handle race conditions.

Tue, Jul 23, 11:03 AM
marcin added inline comments to D12843: [SQLite] add method for message search to SQLiteQueryExecutor for both web and native.
Tue, Jul 23, 7:15 AM

Mon, Jul 22

marcin updated the diff for D12838: Implement web notifs session createion with race condition handling.

Improvement: use the same functions to fetch and persist olm data regardless of notification type (keyserver/peer device)

Mon, Jul 22, 11:55 AM
marcin updated the diff for D12692: Migrate notification account to IndexedDB on web.

Use transactional write when creating outbound session

Mon, Jul 22, 11:54 AM
marcin updated the diff for D12838: Implement web notifs session createion with race condition handling.

A couple of changes

Mon, Jul 22, 7:49 AM
marcin added a comment to D12836: Patch localforage to support transactional multiple items retrieval/persistence.

If the patch file appears cumbersome to review I will create fork of localforage with PR containing those changes.

Mon, Jul 22, 7:35 AM
marcin requested review of D12838: Implement web notifs session createion with race condition handling.
Mon, Jul 22, 7:34 AM
marcin requested review of D12837: Bump olm version.
Mon, Jul 22, 7:31 AM
marcin requested review of D12836: Patch localforage to support transactional multiple items retrieval/persistence.
Mon, Jul 22, 7:28 AM

Fri, Jul 19

marcin accepted D12802: [terraform] Deploy Tunnelbroker 0.11 to staging.
Fri, Jul 19, 7:22 AM
marcin accepted D12772: [lib] implement sending FCM notifs using Tunnelbroker.
Fri, Jul 19, 5:40 AM
marcin accepted D12770: [Tunnelbroker][lib] add FCM notif message type.
Fri, Jul 19, 5:40 AM
marcin added inline comments to D12795: [native] Add message search store.
Fri, Jul 19, 3:32 AM
marcin accepted D12796: [native] Add CommCoreModule code for inserting into the search table.
Fri, Jul 19, 3:29 AM
marcin accepted D12794: [native] Add MessageSearchStoreOperations.
Fri, Jul 19, 3:27 AM

Thu, Jul 18

marcin closed D12784: Make client notif generation code operate on thick threads only.
Thu, Jul 18, 1:41 AM
marcin committed rCOMMd8e292b74d30: Make client notif generation code operate on thick threads only (authored by marcin).
Make client notif generation code operate on thick threads only
Thu, Jul 18, 1:41 AM
marcin updated the diff for D12784: Make client notif generation code operate on thick threads only.

Rebase before landing

Thu, Jul 18, 1:39 AM

Wed, Jul 17

marcin updated the diff for D12784: Make client notif generation code operate on thick threads only.

Rebase before landing

Wed, Jul 17, 10:57 AM
marcin closed D12785: Add keyserverID to unencrypted notification and display to staff info about notification failure.
Wed, Jul 17, 10:56 AM
marcin committed rCOMM46beed0710f4: Add keyserverID to unencrypted notification and display to staff info about… (authored by marcin).
Add keyserverID to unencrypted notification and display to staff info about…
Wed, Jul 17, 10:56 AM
marcin updated the diff for D12784: Make client notif generation code operate on thick threads only.

Rebase before landing

Wed, Jul 17, 10:33 AM
marcin updated the diff for D12785: Add keyserverID to unencrypted notification and display to staff info about notification failure.

Log information about notification encryption failure regardless of user staff member status.

Wed, Jul 17, 10:30 AM
marcin requested review of D12784: Make client notif generation code operate on thick threads only.
Wed, Jul 17, 6:21 AM

Tue, Jul 16

marcin updated the diff for D12673: Utilities to idempotently create content and notif sessions.

Remove TODO

Tue, Jul 16, 7:19 AM
marcin updated the diff for D12673: Utilities to idempotently create content and notif sessions.

Fix race condition by exposing olm session creation via context

Tue, Jul 16, 7:10 AM
marcin closed D12774: [terraform] bump staging identity to 0.30-staging.
Tue, Jul 16, 3:41 AM
marcin committed rCOMMb13871d5c6a9: [terraform] bump staging identity to 0.30-staging (authored by marcin).
[terraform] bump staging identity to 0.30-staging
Tue, Jul 16, 3:41 AM
marcin published D12774: [terraform] bump staging identity to 0.30-staging for review.
Tue, Jul 16, 3:32 AM

Mon, Jul 15

marcin added inline comments to D12750: Implement inbound notif session creation from the NSE with race condition handling.
Mon, Jul 15, 8:26 AM
marcin removed a reviewer for D12677: Implement method to query identity service from the NSE: tomek. marcin added 1 blocking reviewer(s) for D12677: Implement method to query identity service from the NSE: bartek.
Mon, Jul 15, 8:09 AM
marcin removed a reviewer for D12703: Transfer CSAT to IndexedDB from service worker and implement call to identity to query for inbound keys: tomek.
Mon, Jul 15, 8:08 AM
marcin removed a reviewer for D12728: Implement Android HTTP call to identity to get notifs inbound keys: tomek.
Mon, Jul 15, 8:08 AM
marcin removed a reviewer for D12748: Expose function to get notifs inbound keys to C++: tomek.
Mon, Jul 15, 8:07 AM
marcin added inline comments to D12750: Implement inbound notif session creation from the NSE with race condition handling.
Mon, Jul 15, 7:57 AM
marcin updated the diff for D12672: Implement utility functions to check if we have content or notif session with device.

Add error handling to CommCoreModule::isContentSessionInitialized

Mon, Jul 15, 7:14 AM
marcin updated the diff for D12671: Implement notification encryption on web.

Rename ...DataContent... -> ...Data... to remove confusion around Conent keyword when dealing with notifs sessions

Mon, Jul 15, 7:09 AM
marcin added inline comments to D12672: Implement utility functions to check if we have content or notif session with device.
Mon, Jul 15, 6:13 AM
marcin requested review of D12750: Implement inbound notif session creation from the NSE with race condition handling.
Mon, Jul 15, 6:02 AM
marcin added inline comments to D12670: Implement notification encryption on native.
Mon, Jul 15, 5:40 AM
marcin requested review of D12748: Expose function to get notifs inbound keys to C++.
Mon, Jul 15, 5:09 AM
marcin added inline comments to D12739: [native] Introduce getRelatedMessages to CommCoreModule.
Mon, Jul 15, 4:07 AM
marcin closed D12719: Fix CORS issues with identity HTTP.
Mon, Jul 15, 3:04 AM
marcin committed rCOMM52aa37541e68: Fix CORS issues with identity HTTP (authored by marcin).
Fix CORS issues with identity HTTP
Mon, Jul 15, 3:04 AM
marcin accepted D12740: [lib] Introduce getRelatedMessages to SQLiteAPI.
Mon, Jul 15, 2:58 AM
marcin accepted D12739: [native] Introduce getRelatedMessages to CommCoreModule.
Mon, Jul 15, 2:58 AM
marcin accepted D12738: [web] Introduce getRelatedMessages to shared worker.
Mon, Jul 15, 2:53 AM
marcin accepted D12737: [SQLite] Introduce getRelatedMessages.
Mon, Jul 15, 2:52 AM
marcin updated the diff for D12719: Fix CORS issues with identity HTTP.

Rebase before landing

Mon, Jul 15, 2:43 AM

Fri, Jul 12

marcin updated the diff for D12719: Fix CORS issues with identity HTTP.

rebase before landing

Fri, Jul 12, 5:15 AM
marcin updated the diff for D12719: Fix CORS issues with identity HTTP.

Address Varun's and Will's feedbacks

Fri, Jul 12, 3:13 AM
marcin accepted D12693: [native][web] Add fts5 extension to SQLite.
Fri, Jul 12, 3:12 AM
marcin added inline comments to D12719: Fix CORS issues with identity HTTP.
Fri, Jul 12, 3:08 AM
marcin added inline comments to D12719: Fix CORS issues with identity HTTP.
Fri, Jul 12, 2:42 AM
marcin added inline comments to D12673: Utilities to idempotently create content and notif sessions.
Fri, Jul 12, 2:31 AM
marcin added inline comments to D12668: Implement peer notifications session creation as outbound on native.
Fri, Jul 12, 2:24 AM
marcin added inline comments to D12669: Implement peer notifications session creation as outbound on web and add notifs outbound session creator to OlmAPI.
Fri, Jul 12, 2:22 AM
marcin added inline comments to D12671: Implement notification encryption on web.
Fri, Jul 12, 2:17 AM
marcin accepted D12722: [lib] Add `invariant` to suppress `flow` issue in `getPushUserInfo`.

This function is supposed to be used exclusively with thick threads.

Fri, Jul 12, 2:09 AM

Thu, Jul 11

marcin requested review of D12728: Implement Android HTTP call to identity to get notifs inbound keys.
Thu, Jul 11, 8:54 AM
marcin added inline comments to D12703: Transfer CSAT to IndexedDB from service worker and implement call to identity to query for inbound keys.
Thu, Jul 11, 8:39 AM
marcin added inline comments to D12676: Migrate notifications crypto account to MMKV on native.
Thu, Jul 11, 8:36 AM
marcin updated the diff for D12676: Migrate notifications crypto account to MMKV on native.
  1. Don't pass references to unique pointer between lambdas - a rookie mistake!. Pass shared pointers by copy.
  2. Switch to multi process mode on MMKV on Android
Thu, Jul 11, 8:29 AM
marcin closed D12695: Make client handlers that call authenticated identity RPC's gated on CSAT.
Thu, Jul 11, 6:09 AM
marcin committed rCOMM11e83317cd31: Make client handlers that call authenticated identity RPC's gated on CSAT (authored by marcin).
Make client handlers that call authenticated identity RPC's gated on CSAT
Thu, Jul 11, 6:09 AM
marcin added a comment to D12695: Make client handlers that call authenticated identity RPC's gated on CSAT.

Hey @marcin, any reason this hasn't been landed yet?

Thu, Jul 11, 5:54 AM
marcin updated the diff for D12695: Make client handlers that call authenticated identity RPC's gated on CSAT.

Rebase before landing

Thu, Jul 11, 5:53 AM

Wed, Jul 10

marcin requested review of D12719: Fix CORS issues with identity HTTP.
Wed, Jul 10, 7:32 AM

Tue, Jul 9

marcin requested review of D12703: Transfer CSAT to IndexedDB from service worker and implement call to identity to query for inbound keys.
Tue, Jul 9, 9:45 AM
marcin added inline comments to D12695: Make client handlers that call authenticated identity RPC's gated on CSAT.
Tue, Jul 9, 4:26 AM
marcin added inline comments to D12693: [native][web] Add fts5 extension to SQLite.
Tue, Jul 9, 4:21 AM

Mon, Jul 8

marcin requested review of D12695: Make client handlers that call authenticated identity RPC's gated on CSAT.
Mon, Jul 8, 9:37 AM
marcin requested review of D12692: Migrate notification account to IndexedDB on web.
Mon, Jul 8, 7:07 AM
marcin requested review of D12677: Implement method to query identity service from the NSE.
Mon, Jul 8, 2:31 AM

Fri, Jul 5

marcin requested review of D12676: Migrate notifications crypto account to MMKV on native.
Fri, Jul 5, 11:37 AM