Page MenuHomePhabricator

marcin (Marcin)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 29 2021, 2:54 AM (112 w, 2 d)

Recent Activity

Tue, Feb 20

marcin requested review of D11127: Enable SQLite database to hold two olm accounts: content and notifs.
Tue, Feb 20, 10:50 AM
marcin closed D11009: Remove expendable data during compaction creation.
Tue, Feb 20, 10:38 AM
marcin committed rCOMM63c2dcbc881d: Remove expendable data during compaction creation (authored by marcin).
Remove expendable data during compaction creation
Tue, Feb 20, 10:38 AM
marcin updated the diff for D11009: Remove expendable data during compaction creation.
  1. Rename removeExpendableDataSQL -> removeDeviceSpecificDataSQL
  2. Rebase before landing
Tue, Feb 20, 10:26 AM
marcin closed D11117: Fix broken clang formatting.
Tue, Feb 20, 4:10 AM
marcin committed rCOMM7afc7860379c: Fix broken clang formatting (authored by marcin).
Fix broken clang formatting
Tue, Feb 20, 4:10 AM
marcin requested review of D11117: Fix broken clang formatting.
Tue, Feb 20, 3:45 AM

Mon, Feb 19

marcin accepted D11038: [native] Download and apply logs.
Mon, Feb 19, 8:12 AM
marcin added inline comments to D11043: [web] Restore compaction.
Mon, Feb 19, 4:46 AM
marcin added inline comments to D11044: [web] Restore logs.
Mon, Feb 19, 4:44 AM
marcin accepted D11044: [web] Restore logs.
Mon, Feb 19, 4:40 AM
marcin accepted D11074: [native] Stop backup client in background.
Mon, Feb 19, 4:39 AM
marcin added inline comments to D11043: [web] Restore compaction.
Mon, Feb 19, 4:34 AM

Thu, Feb 15

marcin requested review of D11090: Update unread count storage from JS and NSE.
Thu, Feb 15, 5:28 AM
marcin added a comment to D11077: [web/native] Clear device specific data after restoration.

Is there a codepath that will lead to populating data that we remove here with accurate data?

Thu, Feb 15, 3:18 AM
marcin accepted D11086: [native] persist OLM account on SQLiteQueryExecutor::storeOlmPersistData.

Great job catching this @varun !

Thu, Feb 15, 3:17 AM
marcin added a comment to D11077: [web/native] Clear device specific data after restoration.

Let me know if I'm missing something, but if there's some data we don't need in the backup, shouldn't we prevent it from being included, instead of clearing it after restoration?

Thu, Feb 15, 3:15 AM

Wed, Feb 14

marcin requested review of D11071: Implement JSI to handle unread count from JS.
Wed, Feb 14, 4:40 AM
marcin updated the diff for D11046: Introduce MMKV to Android app.

Fix bug: replace "initializeMMKV" with "initialize" when calling Java method from C++ CommMMKVJavaClass.

Wed, Feb 14, 4:24 AM

Tue, Feb 13

marcin retitled D11047: Add getter and setter for integers, getter for all keys and function to remove subset of keys to MMKV from Add getter and setter for integers and getter for all keys to MMKV to Add getter and setter for integers, getter for all keys and function to remove subset of keys to MMKV.
Tue, Feb 13, 1:45 AM
marcin updated the diff for D11047: Add getter and setter for integers, getter for all keys and function to remove subset of keys to MMKV.

Add method to remove subset of keys

Tue, Feb 13, 1:42 AM
marcin added inline comments to D11009: Remove expendable data during compaction creation.
Tue, Feb 13, 12:07 AM
marcin accepted D11037: [native] Add Olm account sign function to commCoreModule.
Tue, Feb 13, 12:00 AM

Mon, Feb 12

marcin resigned from D11040: [comm lib] Add additional features.
Mon, Feb 12, 11:55 PM
marcin resigned from D11039: [backup] Move authentication inside of the websocket.
Mon, Feb 12, 11:55 PM
marcin accepted D10987: [native] Download and restore compaction.
Mon, Feb 12, 11:53 PM
marcin added inline comments to D11046: Introduce MMKV to Android app.
Mon, Feb 12, 10:21 AM
marcin added inline comments to D11047: Add getter and setter for integers, getter for all keys and function to remove subset of keys to MMKV.
Mon, Feb 12, 9:52 AM
marcin updated the test plan for D11047: Add getter and setter for integers, getter for all keys and function to remove subset of keys to MMKV.
Mon, Feb 12, 9:48 AM
marcin updated the test plan for D11046: Introduce MMKV to Android app.
Mon, Feb 12, 9:44 AM
marcin added inline comments to D11045: Introduce MMKV to iOS app and NSE.
Mon, Feb 12, 9:43 AM
marcin added inline comments to D11045: Introduce MMKV to iOS app and NSE.
Mon, Feb 12, 9:31 AM
marcin requested review of D11046: Introduce MMKV to Android app.
Mon, Feb 12, 9:30 AM
marcin requested review of D11045: Introduce MMKV to iOS app and NSE.
Mon, Feb 12, 9:29 AM
marcin requested review of D11047: Add getter and setter for integers, getter for all keys and function to remove subset of keys to MMKV.
Mon, Feb 12, 9:27 AM
marcin requested changes to D11038: [native] Download and apply logs.
Mon, Feb 12, 7:28 AM

Fri, Feb 9

marcin requested review of D11009: Remove expendable data during compaction creation.
Fri, Feb 9, 8:07 AM
marcin closed D10911: Capture backup logs at the end of each data store transaction..
Fri, Feb 9, 6:25 AM
marcin closed D10905: Implement restore from backup logs.
Fri, Feb 9, 6:25 AM
marcin committed rCOMM6d18590b8b05: Capture backup logs at the end of each data store transaction. (authored by marcin).
Capture backup logs at the end of each data store transaction.
Fri, Feb 9, 6:25 AM
marcin committed rCOMMd0fb20607662: Implement restore from backup logs (authored by marcin).
Implement restore from backup logs
Fri, Feb 9, 6:25 AM
marcin closed D10838: Implement log encryption using native AES utilities.
Fri, Feb 9, 6:25 AM
marcin committed rCOMM948c295368ca: Implement log encryption using native AES utilities (authored by marcin).
Implement log encryption using native AES utilities
Fri, Feb 9, 6:25 AM
marcin closed D10837: Implement attachments capture.
Fri, Feb 9, 6:25 AM
marcin closed D10835: Implement unencrypted log capture without attachments.
Fri, Feb 9, 6:25 AM
marcin committed rCOMMeaeb4f63f0dd: Implement attachments capture (authored by marcin).
Implement attachments capture
Fri, Feb 9, 6:25 AM
marcin committed rCOMM30a703aec0fd: Implement unencrypted log capture without attachments (authored by marcin).
Implement unencrypted log capture without attachments
Fri, Feb 9, 6:25 AM
marcin closed D10833: Bump SQLCipher Amalgamation version to enable sqlite3 session extension.
Fri, Feb 9, 6:25 AM
marcin committed rCOMM68d3b4ee8b60: Bump SQLCipher Amalgamation version to enable sqlite3 session extension (authored by marcin).
Bump SQLCipher Amalgamation version to enable sqlite3 session extension
Fri, Feb 9, 6:25 AM
marcin updated the diff for D10911: Capture backup logs at the end of each data store transaction..

Rebase

Fri, Feb 9, 6:00 AM
marcin updated the diff for D10905: Implement restore from backup logs.

Rebase

Fri, Feb 9, 6:00 AM
marcin updated the diff for D10838: Implement log encryption using native AES utilities.

Rebase

Fri, Feb 9, 5:59 AM
marcin updated the diff for D10837: Implement attachments capture.

Rebase

Fri, Feb 9, 5:59 AM
marcin updated the diff for D10835: Implement unencrypted log capture without attachments.

Rebase

Fri, Feb 9, 5:58 AM
marcin updated the diff for D10833: Bump SQLCipher Amalgamation version to enable sqlite3 session extension.

Rebase

Fri, Feb 9, 5:58 AM
marcin updated the diff for D10835: Implement unencrypted log capture without attachments.

Last minute bug fix: don't create log file if patchset is empty

Fri, Feb 9, 5:56 AM
marcin updated the diff for D10833: Bump SQLCipher Amalgamation version to enable sqlite3 session extension.

Rebase

Fri, Feb 9, 5:55 AM
marcin updated the summary of D10833: Bump SQLCipher Amalgamation version to enable sqlite3 session extension.
Fri, Feb 9, 3:47 AM
marcin retitled D10833: Bump SQLCipher Amalgamation version to enable sqlite3 session extension from Patch SQLCipher Amalgamation to enable sqlite3 session extension to Bump SQLCipher Amalgamation version to enable sqlite3 session extension.
Fri, Feb 9, 3:43 AM
marcin updated the diff for D10911: Capture backup logs at the end of each data store transaction..

Rebase before landinf

Fri, Feb 9, 3:41 AM
marcin updated the diff for D10905: Implement restore from backup logs.

Rebase before landing

Fri, Feb 9, 3:40 AM
marcin updated the diff for D10838: Implement log encryption using native AES utilities.

Rebase before landing

Fri, Feb 9, 3:40 AM
marcin updated the diff for D10837: Implement attachments capture.

Rebase before landing

Fri, Feb 9, 3:39 AM
marcin updated the diff for D10835: Implement unencrypted log capture without attachments.

Rebase before landing

Fri, Feb 9, 3:39 AM
marcin updated the diff for D10833: Bump SQLCipher Amalgamation version to enable sqlite3 session extension.

Rebase before landing

Fri, Feb 9, 3:38 AM

Thu, Feb 8

marcin added a comment to D10987: [native] Download and restore compaction.

Could you please update and re-execute the test plan so that after creating draft you log-out and log-in instead of removing the draft? With you current test plan you test restoring from backup that is encrypted with the same encryption key that we already have on the device. This scenario isn't realistic enough - in practice we will always restore from backup file encrypted with different encryption key that we have on the device.

Thu, Feb 8, 2:16 AM
marcin accepted D10858: [native] Notify backup uploader after compaction creation.
Thu, Feb 8, 2:00 AM

Wed, Feb 7

marcin added inline comments to D10927: [native] validateAndGetPrekeys method.
Wed, Feb 7, 1:35 AM
marcin added a comment to D10905: Implement restore from backup logs.

Can you add a test case when you test backupLogRestoreConflictHandler?

Wed, Feb 7, 1:31 AM
marcin updated the test plan for D10905: Implement restore from backup logs.
Wed, Feb 7, 1:30 AM
marcin accepted D10977: [native] update one time keys logic.
Wed, Feb 7, 1:24 AM
marcin accepted D10964: [crypto] unify one-time keys usage.
Wed, Feb 7, 1:14 AM
marcin accepted D10927: [native] validateAndGetPrekeys method.
Wed, Feb 7, 1:11 AM
marcin added a comment to D10927: [native] validateAndGetPrekeys method.

The code is technically correct but I think it needs some adjustments so that it conforms to our C++ conventions.

Wed, Feb 7, 1:10 AM

Tue, Feb 6

marcin updated the diff for D10911: Capture backup logs at the end of each data store transaction..

Rebase

Tue, Feb 6, 9:43 AM
marcin updated the diff for D10905: Implement restore from backup logs.

Rebase + rust bindings for restoration from logs

Tue, Feb 6, 9:42 AM
marcin updated the diff for D10838: Implement log encryption using native AES utilities.

Rebase

Tue, Feb 6, 9:41 AM
marcin updated the diff for D10837: Implement attachments capture.

Rebase

Tue, Feb 6, 9:41 AM
marcin updated the diff for D10835: Implement unencrypted log capture without attachments.

Rebase

Tue, Feb 6, 9:35 AM
marcin updated the diff for D10833: Bump SQLCipher Amalgamation version to enable sqlite3 session extension.

Rebase

Tue, Feb 6, 9:31 AM
marcin closed D10711: Prepare tests to cover missing SQLiteQueryExecutor queries.
Tue, Feb 6, 6:37 AM
marcin committed rCOMM6d1d91c2c28e: Prepare tests to cover missing SQLiteQueryExecutor queries (authored by marcin).
Prepare tests to cover missing SQLiteQueryExecutor queries
Tue, Feb 6, 6:37 AM
marcin closed D10710: Remove sqlite_orm dependency from the project.
Tue, Feb 6, 6:37 AM
marcin closed D10709: Refactor main compaction creation and restore not to use ORM.
Tue, Feb 6, 6:37 AM
marcin committed rCOMM2029d7cd68a8: Remove sqlite_orm dependency from the project (authored by marcin).
Remove sqlite_orm dependency from the project
Tue, Feb 6, 6:37 AM
marcin committed rCOMM8128c8549bf7: Refactor main compaction creation and restore not to use ORM (authored by marcin).
Refactor main compaction creation and restore not to use ORM
Tue, Feb 6, 6:37 AM
marcin closed D10708: Refactor rekey media containers query not to use ORM.
Tue, Feb 6, 6:37 AM
marcin closed D10707: Refactor all remove queries not to use ORM.
Tue, Feb 6, 6:37 AM
marcin committed rCOMM7335daaf6508: Refactor rekey media containers query not to use ORM (authored by marcin).
Refactor rekey media containers query not to use ORM
Tue, Feb 6, 6:37 AM
marcin closed D10706: Refactor all replace and update queries not to user ORM..
Tue, Feb 6, 6:37 AM
marcin committed rCOMMc3e6f54bffbe: Refactor all remove queries not to use ORM (authored by marcin).
Refactor all remove queries not to use ORM
Tue, Feb 6, 6:37 AM
marcin committed rCOMMa61616d178cb: Refactor all replace and update queries not to user ORM. (authored by marcin).
Refactor all replace and update queries not to user ORM.
Tue, Feb 6, 6:37 AM
marcin closed D10705: Refactor all 'get entity by primary key'-like queries not to use ORM.
Tue, Feb 6, 6:37 AM
marcin closed D10704: Refactor all 'getAll...'-like queries not to use ORM..
Tue, Feb 6, 6:37 AM
marcin committed rCOMM9df56f96b4bf: Refactor all 'get entity by primary key'-like queries not to use ORM (authored by marcin).
Refactor all 'get entity by primary key'-like queries not to use ORM
Tue, Feb 6, 6:37 AM
marcin committed rCOMM7f409ad90d98: Refactor all 'getAll...'-like queries not to use ORM. (authored by marcin).
Refactor all 'getAll...'-like queries not to use ORM.
Tue, Feb 6, 6:37 AM
marcin closed D10703: Prepare for new connection handling.
Tue, Feb 6, 6:37 AM
marcin committed rCOMM9130b5df4182: Prepare for new connection handling (authored by marcin).
Prepare for new connection handling
Tue, Feb 6, 6:37 AM
marcin updated the diff for D10711: Prepare tests to cover missing SQLiteQueryExecutor queries.

Fix olm tests description

Tue, Feb 6, 6:16 AM
marcin updated the diff for D10711: Prepare tests to cover missing SQLiteQueryExecutor queries.

Rebase before landing

Tue, Feb 6, 6:06 AM