Implement method to query identity service from the NSE
Needs ReviewPublic
Actions

Authored by marcin on Fri, Jul 5, 11:24 AM.

Details

Reviewers

tomek
bartek

Summary

This differential enables the NSE to call idenity service to query for device identity keys

Test Plan

Apply patch from D12673 test plan.
Apply this patch: https://gist.github.com/marcinwasowicz/2ff63cc0989b19990cbc8924113891c2
Set NSE debugger to stop at the line that checks for error from identity request
Send notification from web client
Examine content of the response from identity service

Repository

rCOMM Comm

Branch

marcin/eng-8237

Lint

No Lint Coverage

Unit

No Test Coverage

marcin edited the test plan for this revision. (Show Details)Fri, Jul 5, 11:29 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Fri, Jul 5, 11:36 AM

marcin requested review of this revision.Mon, Jul 8, 2:31 AM

native/ios/Comm/CommIOSServices/CommIOSServicesClient.mm
7–15	I don't love that these are configured separately from the rest of the app. We went through a lot of effort to make sure that the Rust code in `native_rust_library` respects the same configs as the rest of the JS app (eg. `native/facts/identity_service_config.json`)