Page MenuHomePhabricator
Differential D12671

Implement notification encryption on web
ClosedPublic
Actions

Authored by marcin on Jul 4 2024, 9:27 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 22, 5:32 PM
Unknown Object (File)
Sun, Dec 22, 5:32 PM
Unknown Object (File)
Sun, Dec 22, 5:32 PM
Unknown Object (File)
Sun, Dec 22, 5:32 PM
Unknown Object (File)
Sun, Dec 22, 5:32 PM
Unknown Object (File)
Sun, Dec 22, 5:32 PM
Unknown Object (File)
Sun, Dec 22, 5:32 PM
Unknown Object (File)
Sun, Dec 22, 5:32 PM
View All Files
Subscribers
ashoat

Details

Reviewers
tomek
inka
kamil
Commits
rCOMM9df96ca6c7f8: Implement notification encryption on web
Summary

This differential implements notification encryption with olm session on web.

Test Plan

Tested in D12673

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

marcin created this revision.Jul 4 2024, 9:27 AM
Herald added a subscriber: ashoat. · View Herald TranscriptJul 4 2024, 9:27 AM
marcin added a parent revision: D12670: Implement notification encryption on native.Jul 4 2024, 9:27 AM
marcin added a child revision: D12672: Implement utility functions to check if we have content or notif session with device.Jul 4 2024, 9:31 AM
marcin edited the test plan for this revision. (Show Details)Jul 4 2024, 9:44 AM
Harbormaster completed remote builds in B30150: Diff 42041.Jul 4 2024, 9:44 AM
marcin requested review of this revision.Jul 4 2024, 9:44 AM
tomek accepted this revision.Jul 10 2024, 4:49 AM
tomek added inline comments.
web/push-notif/notif-crypto-utils.js
318 ↗(On Diff #42041)

Why are we using the content key instead of notif?

This revision is now accepted and ready to land.Jul 10 2024, 4:49 AM
marcin added inline comments.Jul 12 2024, 2:17 AM
web/push-notif/notif-crypto-utils.js
318 ↗(On Diff #42041)

We are using key for notif session here. Content in this variable refers to "the content of notif olm session"

ashoat added inline comments.Jul 12 2024, 7:23 AM
web/push-notif/notif-crypto-utils.js
318 ↗(On Diff #42041)

Can you rename? This seems like very confusing naming

marcin updated this revision to Diff 42291.Jul 15 2024, 7:09 AM

Rename ...DataContent... -> ...Data... to remove confusion around Conent keyword when dealing with notifs sessions

Harbormaster completed remote builds in B30329: Diff 42291.Jul 15 2024, 7:26 AM
kamil accepted this revision.Jul 16 2024, 4:48 AM
marcin updated this revision to Diff 42714.Jul 23 2024, 11:03 AM

Make encryptNotification a part of olmAPI. This change is ESSENTIAL on web since it makes encryptNotification run on shared worker. This enables us to deterministically handle race conditions.

Harbormaster completed remote builds in B30619: Diff 42714.Jul 23 2024, 11:20 AM
marcin updated this revision to Diff 42937.Jul 30 2024, 3:23 AM

Update phab

Harbormaster completed remote builds in B30792: Diff 42937.Jul 30 2024, 3:54 AM
marcin updated this revision to Diff 43074.Aug 5 2024, 4:06 AM

Rebase before landing

Harbormaster completed remote builds in B30894: Diff 43074.Aug 5 2024, 4:48 AM
Closed by commit rCOMM9df96ca6c7f8: Implement notification encryption on web (authored by marcin, committed by Marcin Wąsowicz <marcinwasowicz@MacBook-Pro-Marcin.local>). · Explain WhyAug 5 2024, 6:39 AM
This revision was automatically updated to reflect the committed changes.
Marcin Wąsowicz <marcinwasowicz@MacBook-Pro-Marcin.local> added a commit: rCOMM9df96ca6c7f8: Implement notification encryption on web.

Revision Contents
Changeset List

PathSize
lib/
types/
4 lines
utils/
__mocks__/
1 line
native/
crypto/
1 line
push/
11 lines
web/
crypto/
1 line
push-notif/
17 lines
151 lines
shared-worker/
worker/
24 lines

Diff 43132

View Options

lib/types/crypto-types.js

Loading...
View Options

lib/utils/__mocks__/config.js

Loading...
View Options

native/crypto/olm-api.js

Loading...
View Options

native/push/encrypted-notif-utils-api.js

Loading...
View Options

web/crypto/olm-api.js

Loading...
View Options

web/push-notif/encrypted-notif-utils-api.js

Loading...
View Options

web/push-notif/notif-crypto-utils.js

Loading...
View Options

web/shared-worker/worker/worker-crypto.js

Loading...