Page MenuHomePhabricator

Implement notification encryption on web
AcceptedPublic

Authored by marcin on Thu, Jul 4, 9:27 AM.
Tags
None
Referenced Files
F2320132: D12671.id42291.diff
Mon, Jul 22, 11:52 PM
Unknown Object (File)
Fri, Jul 19, 11:07 PM
Unknown Object (File)
Thu, Jul 18, 8:31 PM
Unknown Object (File)
Tue, Jul 16, 4:28 PM
Unknown Object (File)
Sun, Jul 14, 11:37 PM
Unknown Object (File)
Sat, Jul 13, 8:54 AM
Unknown Object (File)
Fri, Jul 12, 8:34 PM
Unknown Object (File)
Fri, Jul 12, 7:15 PM
Subscribers

Details

Reviewers
tomek
inka
kamil
Summary

This differential implements notification encryption with olm session on web.

Test Plan

Tested in D12673

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

marcin requested review of this revision.Thu, Jul 4, 9:44 AM
tomek added inline comments.
web/push-notif/notif-crypto-utils.js
318 ↗(On Diff #42041)

Why are we using the content key instead of notif?

This revision is now accepted and ready to land.Wed, Jul 10, 4:49 AM
web/push-notif/notif-crypto-utils.js
318 ↗(On Diff #42041)

We are using key for notif session here. Content in this variable refers to "the content of notif olm session"

web/push-notif/notif-crypto-utils.js
318 ↗(On Diff #42041)

Can you rename? This seems like very confusing naming

Rename ...DataContent... -> ...Data... to remove confusion around Conent keyword when dealing with notifs sessions

Make encryptNotification a part of olmAPI. This change is ESSENTIAL on web since it makes encryptNotification run on shared worker. This enables us to deterministically handle race conditions.