This differential implements encryption with notifications session on native
Details
Details
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| native/push/encrypted-notif-utils-api.js | ||
|---|---|---|
| 21 ↗ | (On Diff #42040) | Isn't this conversion equivalent? |
| native/push/encrypted-notif-utils-api.js | ||
|---|---|---|
| 21 ↗ | (On Diff #42040) | Type definition at line 13 expects literal union of 1 | 0 while toString() can yield any string. Flow complains when this change is applied. |
| native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp | ||
|---|---|---|
| 1577–1584 ↗ | (On Diff #42040) | same comment as here: https://phab.comm.dev/D12668#inline-74094 |
| native/cpp/CommonCpp/NativeModules/CommCoreModule.h | ||
| 141 ↗ | (On Diff #42040) | is it change accidental? If not please update .cpp file and Schema in .js file |
| native/cpp/CommonCpp/Notifications/BackgroundDataStorage/NotificationsCryptoModule.h | ||
| 120 ↗ | (On Diff #42040) | in CommCoreModuleSchema it makes sense to keep the suffix but here because it's NotificationsCryptoModule it seems redundant |
| native/push/encrypted-notif-utils-api.js | ||
| 17 ↗ | (On Diff #42040) | I prefer to add encryptNotification to sqliteAPI and use it here (and on web), but up to you |
| native/push/encrypted-notif-utils-api.js | ||
|---|---|---|
| 17 ↗ | (On Diff #42040) | olmAPI* - sorry for confusing |
| native/push/encrypted-notif-utils-api.js | ||
|---|---|---|
| 17 ↗ | (On Diff #42040) | Added in next diff |