Page MenuHomePhabricator

inka (Inka Sokołowska)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 13 2022, 2:18 AM (62 w, 3 d)

Recent Activity

Yesterday

inka accepted D9254: [lib] Add unit tests for mention utils.
Fri, Sep 22, 7:55 AM
inka accepted D9218: [keyserver] Render raw chat mention in the notification text.
Fri, Sep 22, 7:49 AM
inka accepted D9005: [lib] Introduce chat mention utilities for plain text.

Important context in D9007 - we just want to use the alt text for now

Fri, Sep 22, 7:43 AM
inka accepted D8944: [web] Modify mention typeahead regex.
Fri, Sep 22, 7:32 AM
inka added a comment to D9057: [web] Add webMentionTypeaheadRegex tests.

You could remove the text field and just do textPrefix + mentionText

Fri, Sep 22, 7:32 AM
inka accepted D8901: [lib] Add userStoreMentionSearchIndex selector.
Fri, Sep 22, 7:20 AM
inka accepted D9057: [web] Add webMentionTypeaheadRegex tests.
Fri, Sep 22, 6:45 AM
inka accepted D8834: [lib] Introduce chat mention match and parse utilities.
Fri, Sep 22, 6:25 AM

Wed, Sep 20

inka requested review of D9246: [native][web] Fix keyserver store tranform error.
Wed, Sep 20, 9:17 AM
inka added inline comments to D9226: [lib] Update KeyserverCall type.
Wed, Sep 20, 6:15 AM
inka updated the diff for D9240: [lib][web][native] Refactor actions in message-actions.js.

Remove comment

Wed, Sep 20, 6:12 AM
inka added a comment to D9217: [lib] Add logic for handling faonut actions.

@michal my idea is that every action will take care of the merging inside

Wed, Sep 20, 5:21 AM
inka updated the diff for D9095: [native] Block editing messages on search and pinned messages screens, and of the first message in a thread.

Use constant. Move logic to ConnectedTextMessage, where other conditions for whether a message can be edited are checked, and a canEditMessage value used to create visibleEntryIDs which are used by TooltipContext to determine whether the item should be rendered, is created.

Wed, Sep 20, 3:48 AM
inka requested review of D9240: [lib][web][native] Refactor actions in message-actions.js.
Wed, Sep 20, 2:41 AM

Tue, Sep 19

inka requested review of D9226: [lib] Update KeyserverCall type.
Tue, Sep 19, 7:37 AM
inka requested review of D9225: [lib] Create function for extracing keyserver id from object id.
Tue, Sep 19, 2:24 AM
inka updated the diff for D9217: [lib] Add logic for handling faonut actions.

Rebase

Tue, Sep 19, 12:29 AM

Mon, Sep 18

inka updated the diff for D9143: [lib] Add memoization to useKeyserverCall.

Memoize boundCallServerEndpointSelector per keserverID

Mon, Sep 18, 10:04 AM
inka added a comment to D9121: [lib] Create useKeyserverCall.

I created a followup task to update the types: ENG-4968

Mon, Sep 18, 7:18 AM
inka updated the diff for D9121: [lib] Create useKeyserverCall.

Update type

Mon, Sep 18, 7:17 AM
inka added inline comments to D9121: [lib] Create useKeyserverCall.
Mon, Sep 18, 3:43 AM

Fri, Sep 15

inka requested review of D9217: [lib] Add logic for handling faonut actions.
Fri, Sep 15, 7:21 AM
inka added a comment to D8873: [native] Make chat mentions clickable.

Did you test whether the animation still works when user opens tooltip and presses "thread", even if the message has a link?

Fri, Sep 15, 6:57 AM
inka accepted D9109: [web] Enable db for all users.
Fri, Sep 15, 6:30 AM
inka updated the diff for D9143: [lib] Add memoization to useKeyserverCall.

Rebase

Fri, Sep 15, 3:22 AM
inka added inline comments to D9121: [lib] Create useKeyserverCall.
Fri, Sep 15, 3:21 AM
inka updated the diff for D9121: [lib] Create useKeyserverCall.

Address review

Fri, Sep 15, 3:20 AM

Thu, Sep 14

inka closed D9126: [web][native] Fix message search showing toggle pin robotext.
Thu, Sep 14, 8:11 AM
inka committed rCOMMdcbe566de055: [web][native] Fix message search showing toggle pin robotext (authored by inka).
[web][native] Fix message search showing toggle pin robotext
Thu, Sep 14, 8:11 AM
inka closed D9123: [web] Fix warnings on search screen.
Thu, Sep 14, 8:10 AM
inka committed rCOMM72d5a1003660: [web] Fix warnings on search screen (authored by inka).
[web] Fix warnings on search screen
Thu, Sep 14, 8:10 AM

Wed, Sep 13

inka updated the diff for D9143: [lib] Add memoization to useKeyserverCall.

Remove unused veriable

Wed, Sep 13, 7:53 AM
inka added a comment to D9143: [lib] Add memoization to useKeyserverCall.

We already pass all actions to a hook (even in class components, we use useServerCall) so I imagine there is some way to do it. But I won't insist

Wed, Sep 13, 7:49 AM
inka added a comment to D9143: [lib] Add memoization to useKeyserverCall.

Now the memoization works in a slightly different way, but achieves the same effect - memoizes the function.
We create a selector, that returns a _memoized function. This function remembers the last action returned for every KeyserverCall. This selector remembers the _memoized function, so it can be used in all components calling useKeyserverCall. If this selector's dependencies change, all actions would have to be recalculated anyway, so it fine that the memoized function is created anew.
This way, we have to memoize less things, because we memoize one function, and actions for all ActionFuncs, instead of a selector and an action for every ActionFunc

Wed, Sep 13, 6:57 AM
inka updated the diff for D9143: [lib] Add memoization to useKeyserverCall.

Clean up - inline getCallKeyserverEndpoint and invert memoization

Wed, Sep 13, 6:10 AM
inka updated the summary of D9143: [lib] Add memoization to useKeyserverCall.
Wed, Sep 13, 6:03 AM
inka updated the summary of D9143: [lib] Add memoization to useKeyserverCall.
Wed, Sep 13, 6:00 AM
inka added a comment to D9143: [lib] Add memoization to useKeyserverCall.

@ashoat This selector is called inside of actions. I don't think I can use selectors inside of actions, especially that they are called in class components.

Wed, Sep 13, 5:58 AM

Tue, Sep 12

inka added inline comments to D9145: [web] Remove intial redux state from website responders.
Tue, Sep 12, 6:43 AM
inka added a comment to D9140: [web] Add setInitialReduxState action.

What happens if this action fails?

Tue, Sep 12, 6:18 AM
inka added a comment to D9120: [native] update UserProfileBottomSheet to get a userInfo from a userID.

Is it possible that a user with this id will not be in our store?

Tue, Sep 12, 5:45 AM
inka accepted D9119: [native] use stringForUserExplicit function to determine username text for profiles.
Tue, Sep 12, 5:44 AM
inka accepted D9101: [native] introduce user profile bottomsheet component.
Tue, Sep 12, 5:36 AM
inka requested review of D9143: [lib] Add memoization to useKeyserverCall.
Tue, Sep 12, 4:58 AM

Mon, Sep 11

inka closed D9104: [web] Fix nested a tags.
Mon, Sep 11, 8:06 AM
inka committed rCOMM439f1371107c: [web] Fix nested a tags (authored by inka).
[web] Fix nested a tags
Mon, Sep 11, 8:06 AM
inka added a comment to D9126: [web][native] Fix message search showing toggle pin robotext.

ENG-4920

Mon, Sep 11, 8:01 AM
inka added a comment to D9126: [web][native] Fix message search showing toggle pin robotext.

I remove copy paste between search on web and native. I will create a followup task to use this function in pinned messages, because it seems to me that this logic wan be used there as well.

Mon, Sep 11, 7:58 AM
inka updated the diff for D9126: [web][native] Fix message search showing toggle pin robotext.

Use isComposableMessageType

Mon, Sep 11, 7:32 AM
inka added inline comments to D9126: [web][native] Fix message search showing toggle pin robotext.
Mon, Sep 11, 7:28 AM
inka requested review of D9126: [web][native] Fix message search showing toggle pin robotext.

Requesting review, because I ended up extracting a lot of common code to lib. This is code that takes messages returned from messageListData and filters them to just include the messages we initaily fetched from the search endpoint

Mon, Sep 11, 7:27 AM
inka updated the diff for D9126: [web][native] Fix message search showing toggle pin robotext.

Extract common code to lib

Mon, Sep 11, 7:26 AM
inka requested review of D9126: [web][native] Fix message search showing toggle pin robotext.
Mon, Sep 11, 6:43 AM
inka requested review of D9104: [web] Fix nested a tags.
Mon, Sep 11, 6:41 AM
inka updated the diff for D9104: [web] Fix nested a tags.

Found one more plance. Don't know why it wasn't showing errors before...

Mon, Sep 11, 6:40 AM
inka requested review of D9123: [web] Fix warnings on search screen.
Mon, Sep 11, 6:08 AM
inka requested review of D9121: [lib] Create useKeyserverCall.
Mon, Sep 11, 4:13 AM

Fri, Sep 8

inka accepted D9098: [native] introduce onClosed callback prop to BottomSheet component.
Fri, Sep 8, 3:54 AM
inka accepted D9094: [native] move BottomSheetModalProvider to inside NavigationContainer.
Fri, Sep 8, 3:52 AM
inka updated the summary of D9104: [web] Fix nested a tags.
Fri, Sep 8, 3:37 AM
inka requested review of D9104: [web] Fix nested a tags.
Fri, Sep 8, 2:44 AM

Thu, Sep 7

inka abandoned D9092: [lib] Create selectors for fetching data needed to call servers.

You are probably right, there isn't much more data in the keyserverInfos than we are fetching here, so this is probably unnecessary.

Thu, Sep 7, 3:49 AM
inka requested review of D9095: [native] Block editing messages on search and pinned messages screens, and of the first message in a thread.
Thu, Sep 7, 1:54 AM

Wed, Sep 6

inka requested review of D9092: [lib] Create selectors for fetching data needed to call servers.
Wed, Sep 6, 6:01 AM
inka added a comment to D9007: [keyserver] Render chat mention in notification text.

What is the default text?

Wed, Sep 6, 3:29 AM
inka added inline comments to D9005: [lib] Introduce chat mention utilities for plain text.
Wed, Sep 6, 3:04 AM
inka requested changes to D8834: [lib] Introduce chat mention match and parse utilities.
Wed, Sep 6, 2:38 AM
inka added inline comments to D8910: [native] Show chats in mention typeahead tooltip.
Wed, Sep 6, 2:16 AM
inka accepted D8909: [native] Replace chat name with raw chat mention.
Wed, Sep 6, 2:12 AM
inka added inline comments to D8944: [web] Modify mention typeahead regex.
Wed, Sep 6, 1:45 AM
inka added a comment to D8908: [lib] Encode chat name in raw chat mention.

Can you add some tests please?

Wed, Sep 6, 1:27 AM
inka added a comment to D8901: [lib] Add userStoreMentionSearchIndex selector.

D8903 will introduce new regex for detecting when typeahead should be shown (it will catch spaces too). Because of that change, the tooltip would never close.

Wed, Sep 6, 1:25 AM
inka accepted D8900: [lib] Add chat mention SearchIndex selector.
Wed, Sep 6, 1:07 AM
inka accepted D8897: [native] Refactor TypeaheadTooltip component.

This solution is a bit overengineered, but I think there is no point in reverting it

Wed, Sep 6, 12:55 AM

Tue, Sep 5

inka closed D9078: [keyserver][lib][native][web] Remove lastCommunicatedPlatformDetails form redux top level.
Tue, Sep 5, 7:21 AM
inka closed D9079: [lib][web][native] Start using lastCommunicatedPlatformDetailsSelector from keyserverStore.
Tue, Sep 5, 7:20 AM
inka committed rCOMMee0c28bf7e17: [keyserver][lib][native][web] Remove lastCommunicatedPlatformDetails form redux… (authored by inka).
[keyserver][lib][native][web] Remove lastCommunicatedPlatformDetails form redux…
Tue, Sep 5, 7:20 AM
inka committed rCOMMcc80ee8f7606: [lib][web][native] Start using lastCommunicatedPlatformDetailsSelector from… (authored by inka).
[lib][web][native] Start using lastCommunicatedPlatformDetailsSelector from…
Tue, Sep 5, 7:20 AM
inka closed D9077: [keyserver][lib][native] Add lastCommunicatedPlatformDetails to keyserverStore.
Tue, Sep 5, 7:20 AM
inka closed D9060: [lib] Refactor lastCommunicatedPlatformDetails to be PlatformDetails.
Tue, Sep 5, 7:20 AM
inka committed rCOMM7c361bfa78e7: [keyserver][lib][native] Add lastCommunicatedPlatformDetails to keyserverStore (authored by inka).
[keyserver][lib][native] Add lastCommunicatedPlatformDetails to keyserverStore
Tue, Sep 5, 7:20 AM
inka committed rCOMM2eb888a53ee7: [lib] Refactor lastCommunicatedPlatformDetails to be PlatformDetails (authored by inka).
[lib] Refactor lastCommunicatedPlatformDetails to be PlatformDetails
Tue, Sep 5, 7:20 AM
inka closed D9062: [web] Start persisting keyserverStore.
Tue, Sep 5, 7:20 AM
inka committed rCOMM9f39ad91f27c: [web] Start persisting keyserverStore (authored by inka).
[web] Start persisting keyserverStore
Tue, Sep 5, 7:20 AM
inka added a comment to D9078: [keyserver][lib][native][web] Remove lastCommunicatedPlatformDetails form redux top level.

LGTM, could you check that it still works with something like this:

  1. Disable the websocket
  2. Bump the webAndKeyserverCodeVersion version
  3. Send a message or do something else that will call an endpoint
  4. Check that redux has updated
Tue, Sep 5, 7:11 AM
inka updated the test plan for D9078: [keyserver][lib][native][web] Remove lastCommunicatedPlatformDetails form redux top level.
Tue, Sep 5, 3:49 AM
inka updated the diff for D9078: [keyserver][lib][native][web] Remove lastCommunicatedPlatformDetails form redux top level.

Add migrations

Tue, Sep 5, 3:49 AM
inka planned changes to D9078: [keyserver][lib][native][web] Remove lastCommunicatedPlatformDetails form redux top level.

Need to add migrations

Tue, Sep 5, 3:39 AM
inka requested review of D9079: [lib][web][native] Start using lastCommunicatedPlatformDetailsSelector from keyserverStore.
Tue, Sep 5, 3:21 AM
inka requested review of D9078: [keyserver][lib][native][web] Remove lastCommunicatedPlatformDetails form redux top level.
Tue, Sep 5, 3:19 AM
inka requested review of D9077: [keyserver][lib][native] Add lastCommunicatedPlatformDetails to keyserverStore.
Tue, Sep 5, 3:14 AM
inka updated the diff for D9060: [lib] Refactor lastCommunicatedPlatformDetails to be PlatformDetails.

Fix lastCommunicatedPlatformDetails default validator

Tue, Sep 5, 2:47 AM
inka updated the diff for D9062: [web] Start persisting keyserverStore.

Address review

Tue, Sep 5, 1:35 AM

Fri, Sep 1

inka requested review of D9062: [web] Start persisting keyserverStore.
Fri, Sep 1, 5:52 AM
inka requested review of D9060: [lib] Refactor lastCommunicatedPlatformDetails to be PlatformDetails.
Fri, Sep 1, 2:42 AM

Thu, Aug 31

inka accepted D8852: [web] Introduce markdown component for chat mentions.
Thu, Aug 31, 8:16 AM
inka accepted D8847: [native] Change ChatContextProvider position.
Thu, Aug 31, 8:12 AM
inka accepted D8845: [native] Introduce markdown component for chat mentions.
Thu, Aug 31, 7:28 AM
inka accepted D8833: [lib] Introduce chat mention candidates getters.
Thu, Aug 31, 7:15 AM
inka closed D9047: [web] Fix wrong selector used to obtain connection.
Thu, Aug 31, 7:02 AM