Page MenuHomePhabricator

inka (Inka Sokołowska)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 13 2022, 2:18 AM (93 w, 2 d)

Recent Activity

Today

inka accepted D11785: [native] introduce TagFarcasterChannelParams.
Fri, Apr 26, 8:32 AM
inka accepted D11784: [native] update selectedChannel state to be a FarcasterChannel type.
Fri, Apr 26, 8:30 AM
inka accepted D11769: [lib] Don't set dataLoaded on authoritative keyserver auth.
Fri, Apr 26, 7:00 AM
inka accepted D11764: [lib][native][web] Rename useLogIn to useLegacyLogIn.

Should we rename siweAuthActionTypes to legacySiweAuthActionTypes and keyserverRegisterActionTypes to legacyKeyserverRegisterActionTypes?

Fri, Apr 26, 6:57 AM
inka accepted D11768: [lib][native][web] Introduce useWalletLogIn hook.
Fri, Apr 26, 6:53 AM
inka accepted D11767: [native] Use useRegistrationServerCall in FullscreenSIWEPanel for identity registration.
Fri, Apr 26, 6:27 AM
inka accepted D11766: [lib][native] Defer saving user credentials until successful auth.
Fri, Apr 26, 6:04 AM
inka requested review of D11799: [lib] Search for users in thread list search.
Fri, Apr 26, 6:01 AM
inka accepted D11765: [lib][native][web] Introduce usePasswordLogIn hook.
Fri, Apr 26, 5:57 AM
inka accepted D11763: [native] Auth with authoritative keyserver directly from registration flow.
Fri, Apr 26, 5:38 AM
inka updated the diff for D11780: [keyserver] Fix sending a user cookie when olm session creation failed.

Remove unnecessary code

Fri, Apr 26, 3:20 AM
inka added inline comments to D11780: [keyserver] Fix sending a user cookie when olm session creation failed.
Fri, Apr 26, 3:17 AM
inka added inline comments to D11780: [keyserver] Fix sending a user cookie when olm session creation failed.
Fri, Apr 26, 2:58 AM
inka updated the diff for D11780: [keyserver] Fix sending a user cookie when olm session creation failed.

Address review

Fri, Apr 26, 2:58 AM

Yesterday

inka closed D11760: [web] Fix missing relationship buttons.
Thu, Apr 25, 8:46 AM
inka committed rCOMMfa2cd2e93e24: [web] Fix missing relationship buttons (authored by inka).
[web] Fix missing relationship buttons
Thu, Apr 25, 8:46 AM
inka closed D11759: [lib][native] Stop persisting CSAT.
Thu, Apr 25, 8:43 AM
inka committed rCOMM35764971478c: [lib][native] Stop persisting CSAT (authored by inka).
[lib][native] Stop persisting CSAT
Thu, Apr 25, 8:43 AM
inka closed D11738: [lib][native] Move reduceServicesAccessToken and setAccessTokenActionType to native.
Thu, Apr 25, 8:43 AM
inka committed rCOMMa05e97f0976b: [lib][native] Move reduceServicesAccessToken and setAccessTokenActionType to… (authored by inka).
[lib][native] Move reduceServicesAccessToken and setAccessTokenActionType to…
Thu, Apr 25, 8:43 AM
inka closed D11395: [lib][native] Only reduce CSAT on setAccessTokenActionType.
Thu, Apr 25, 8:42 AM
inka committed rCOMM3a63c9460ff0: [lib][native] Only reduce CSAT on setAccessTokenActionType (authored by inka).
[lib][native] Only reduce CSAT on setAccessTokenActionType
Thu, Apr 25, 8:42 AM
inka abandoned D11141: [IGNORE] Client hacks for testing multiple keyservers.
Thu, Apr 25, 8:32 AM
inka added a comment to D11760: [web] Fix missing relationship buttons.

Is native also affected by this bug?

Thu, Apr 25, 8:28 AM
inka requested review of D11780: [keyserver] Fix sending a user cookie when olm session creation failed.
Thu, Apr 25, 8:25 AM
inka updated the diff for D11760: [web] Fix missing relationship buttons.

Make the code safer

Thu, Apr 25, 5:52 AM
inka added inline comments to D11766: [lib][native] Defer saving user credentials until successful auth.
Thu, Apr 25, 3:57 AM
inka added inline comments to D11765: [lib][native][web] Introduce usePasswordLogIn hook.
Thu, Apr 25, 3:47 AM
inka added inline comments to D11763: [native] Auth with authoritative keyserver directly from registration flow.
Thu, Apr 25, 3:21 AM
inka accepted D11762: [lib] Don't try authing to authoritative keyserver from KeyserverConnectionHandler.
Thu, Apr 25, 2:28 AM
inka accepted D11761: [lib] Extract useRawKeyserverAuth.
Thu, Apr 25, 2:22 AM

Wed, Apr 24

inka accepted D11758: [lib] Bump invite link accept timeout.
Wed, Apr 24, 8:28 AM
inka requested review of D11760: [web] Fix missing relationship buttons.
Wed, Apr 24, 7:51 AM
inka requested review of D11759: [lib][native] Stop persisting CSAT.
Wed, Apr 24, 7:23 AM

Tue, Apr 23

inka closed D11736: [lib] Fix error when deleting a keyserver.
Tue, Apr 23, 4:56 AM
inka committed rCOMM69c181651591: [lib] Fix error when deleting a keyserver (authored by inka).
[lib] Fix error when deleting a keyserver
Tue, Apr 23, 4:56 AM
inka requested review of D11738: [lib][native] Move reduceServicesAccessToken and setAccessTokenActionType to native.
Tue, Apr 23, 4:54 AM
inka updated the summary of D11395: [lib][native] Only reduce CSAT on setAccessTokenActionType.
Tue, Apr 23, 4:36 AM
inka updated the test plan for D11395: [lib][native] Only reduce CSAT on setAccessTokenActionType.
Tue, Apr 23, 4:35 AM
inka retitled D11395: [lib][native] Only reduce CSAT on setAccessTokenActionType from [lib][native] Stop deleting CSAT on login actions to [lib][native] Only reduce CSAT on setAccessTokenActionType.
Tue, Apr 23, 4:34 AM
inka updated the diff for D11395: [lib][native] Only reduce CSAT on setAccessTokenActionType.

Remove all actions but setAccessTokenActionType.
In the next diff I will move this reducer to native

Tue, Apr 23, 4:33 AM
inka requested review of D11736: [lib] Fix error when deleting a keyserver.
Tue, Apr 23, 4:17 AM
inka accepted D11692: [lib] Don't reduce KEYSERVER_AUTH_SUCCESS in reduceCurrentUserInfo.
Tue, Apr 23, 1:20 AM

Mon, Apr 22

inka added inline comments to D11692: [lib] Don't reduce KEYSERVER_AUTH_SUCCESS in reduceCurrentUserInfo.
Mon, Apr 22, 7:57 AM
inka accepted D11708: [keyserver] Use keyserverID instead of userID when creating invite link blobs.
Mon, Apr 22, 4:58 AM
inka published D11708: [keyserver] Use keyserverID instead of userID when creating invite link blobs for review.
Mon, Apr 22, 4:57 AM
inka updated the diff for D11141: [IGNORE] Client hacks for testing multiple keyservers.

Rebase

Mon, Apr 22, 4:50 AM
inka closed D11701: [web] Remove authoritativeKeyserverID check from getInitialReduxState.
Mon, Apr 22, 4:36 AM
inka committed rCOMMfaa0659b1a25: [web] Remove authoritativeKeyserverID check from getInitialReduxState (authored by inka).
[web] Remove authoritativeKeyserverID check from getInitialReduxState
Mon, Apr 22, 4:35 AM

Fri, Apr 19

inka requested review of D11701: [web] Remove authoritativeKeyserverID check from getInitialReduxState.
Fri, Apr 19, 9:11 AM

Thu, Apr 18

inka updated the diff for D11141: [IGNORE] Client hacks for testing multiple keyservers.

Remove unnecessary lines

Thu, Apr 18, 4:42 AM
inka added a comment to D11141: [IGNORE] Client hacks for testing multiple keyservers.

I tested this and I was indeed able to login and register without these lines!

Thu, Apr 18, 4:41 AM

Wed, Apr 17

inka added inline comments to D11670: [native][web] Don't stamp SQLite database until authoritative keyserver auth.
Wed, Apr 17, 6:01 AM

Tue, Apr 16

inka closed D11643: [web] Show a popup when client_version_unsupported.
Tue, Apr 16, 5:18 AM
inka committed rCOMMe54b3a74315b: [web] Show a popup when client_version_unsupported (authored by inka).
[web] Show a popup when client_version_unsupported
Tue, Apr 16, 5:18 AM
inka closed D11632: [lib][web][native] Pass preRequestUserState into invalidSessionRecovery.
Tue, Apr 16, 5:18 AM
inka closed D11631: [lib] Stop attempting recovery when client version unsupported.
Tue, Apr 16, 5:18 AM
inka committed rCOMM7b3fd475e97a: [lib][web][native] Pass preRequestUserState into invalidSessionRecovery (authored by inka).
[lib][web][native] Pass preRequestUserState into invalidSessionRecovery
Tue, Apr 16, 5:18 AM
inka committed rCOMMabe65dc59251: [lib] Stop attempting recovery when client version unsupported (authored by inka).
[lib] Stop attempting recovery when client version unsupported
Tue, Apr 16, 5:18 AM
inka closed D11619: [lib] Add client_version_unsupported connectionIssue.
Tue, Apr 16, 5:18 AM
inka committed rCOMMa766dc8d4a21: [lib] Add client_version_unsupported connectionIssue (authored by inka).
[lib] Add client_version_unsupported connectionIssue
Tue, Apr 16, 5:18 AM
inka updated the diff for D11643: [web] Show a popup when client_version_unsupported.

Rename

Tue, Apr 16, 4:50 AM
inka updated the diff for D11643: [web] Show a popup when client_version_unsupported.

Show only one popup

Tue, Apr 16, 3:04 AM
inka added a comment to D11643: [web] Show a popup when client_version_unsupported.

A bit confused about the scenario you describe. How is the user able to log in after being logged out, if they can't auth with the authoritative keyserver? Doesn't the authoritative keyserver make the version check during auth?

Tue, Apr 16, 1:53 AM

Mon, Apr 15

inka requested review of D11643: [web] Show a popup when client_version_unsupported.

Requesting review because now:

  1. We can still see this modal more than once - for other keyservers. Is this that we want??
  2. For the auth keyserver, the user is logged out. If they dismiss the modal, but ignore it and log in, they will be logged out and will NOT see the modal again. Is this ok or should I make logging in reset this state?
Mon, Apr 15, 9:13 AM
inka updated the diff for D11643: [web] Show a popup when client_version_unsupported.

Memoize list of components, only display the alert once for each keyserver

Mon, Apr 15, 9:11 AM
inka accepted D11654: [lib] Don't clear authoritative keyserver cookie during identity auth.

Okay, this makes to me sense now

Mon, Apr 15, 8:58 AM
inka updated the test plan for D11643: [web] Show a popup when client_version_unsupported.
Mon, Apr 15, 7:12 AM
inka added a comment to D11643: [web] Show a popup when client_version_unsupported.

Can't we simply reload the page when the client version is unsupported?

Mon, Apr 15, 4:29 AM
inka attached a referenced file: F1548897: image.png.
Mon, Apr 15, 2:39 AM
inka added a comment to D11643: [web] Show a popup when client_version_unsupported.

Now the modal looks like this:

image.png (142×220 px, 9 KB)

Mon, Apr 15, 2:38 AM
inka updated the summary of D11643: [web] Show a popup when client_version_unsupported.
Mon, Apr 15, 2:37 AM
inka updated the diff for D11643: [web] Show a popup when client_version_unsupported.

Address review

Mon, Apr 15, 2:37 AM
inka added inline comments to D11643: [web] Show a popup when client_version_unsupported.
Mon, Apr 15, 2:36 AM
inka added inline comments to D11632: [lib][web][native] Pass preRequestUserState into invalidSessionRecovery.
Mon, Apr 15, 2:07 AM
inka added a comment to D11654: [lib] Don't clear authoritative keyserver cookie during identity auth.

It is also weird to me that we try to auth with the keyserver before identity login success. Maybe we should change that?

Mon, Apr 15, 1:08 AM
inka accepted D11656: [lib] Use useDerivedObject to reduce renders due to preRequestUserState.
Mon, Apr 15, 1:00 AM
inka accepted D11655: [lib] Introduce usePreRequestUserState.
Mon, Apr 15, 12:44 AM
inka added a comment to D11654: [lib] Don't clear authoritative keyserver cookie during identity auth.

I worry that this may cause problems. Identity login and register clear data in case they are dispatched before logout success, so before user's data is cleared. This change makes it technically possible that the following will happen:

  1. User A logs in with identity and the keyserver - gets a user cookie
  2. User A logs out
  3. User B logs in, and a login success is dispatched before logout success

Now user B has user A's keyserver cookie

Mon, Apr 15, 12:43 AM

Fri, Apr 12

inka accepted D11644: Extract shareable logic from CreateSIWEBackupMessage component.
Fri, Apr 12, 6:54 AM
inka requested review of D11643: [web] Show a popup when client_version_unsupported.
Fri, Apr 12, 1:59 AM

Thu, Apr 11

inka requested review of D11632: [lib][web][native] Pass preRequestUserState into invalidSessionRecovery.
Thu, Apr 11, 6:25 AM
inka requested review of D11631: [lib] Stop attempting recovery when client version unsupported.
Thu, Apr 11, 5:20 AM

Wed, Apr 10

inka updated the diff for D11141: [IGNORE] Client hacks for testing multiple keyservers.

Rebase

Wed, Apr 10, 4:07 AM
inka requested review of D11619: [lib] Add client_version_unsupported connectionIssue.
Wed, Apr 10, 3:52 AM
inka accepted D11533: [web][native] Reset the state iff current user ID changes.
Wed, Apr 10, 2:46 AM

Tue, Apr 9

inka accepted D11534: [web][native] Extract the common logic determining when to clear the data.

Please remove the unnecessary code in all places before landing. Other than that looks good

Tue, Apr 9, 2:30 AM

Fri, Apr 5

inka closed D11565: [lib] Simplify sorting local ids.
Fri, Apr 5, 7:26 AM
inka committed rCOMM9259a5fd4b26: [lib] Simplify sorting local ids (authored by inka).
[lib] Simplify sorting local ids
Fri, Apr 5, 7:26 AM
inka closed D11564: [lib] Fix sorting local messages.
Fri, Apr 5, 7:26 AM
inka committed rCOMM57aa051186e2: [lib] Fix sorting local messages (authored by inka).
[lib] Fix sorting local messages
Fri, Apr 5, 7:26 AM
inka closed D11542: [keyserver] Login or register before tables are created.
Fri, Apr 5, 5:58 AM
inka closed D11540: [keyserver] Refactor registerOrLogIn to take callbacks.
Fri, Apr 5, 5:58 AM
inka committed rCOMMaf3bd6da97b5: [keyserver] Login or register before tables are created (authored by inka).
[keyserver] Login or register before tables are created
Fri, Apr 5, 5:58 AM
inka committed rCOMMd7b2b0417a8e: [keyserver] Refactor registerOrLogIn to take callbacks (authored by inka).
[keyserver] Refactor registerOrLogIn to take callbacks
Fri, Apr 5, 5:58 AM
inka closed D11530: [scripts] Improve prompt.
Fri, Apr 5, 5:58 AM
inka committed rCOMM99d77585156c: [scripts] Improve prompt (authored by inka).
[scripts] Improve prompt
Fri, Apr 5, 5:58 AM
inka updated the diff for D11542: [keyserver] Login or register before tables are created.

Rename function

Fri, Apr 5, 5:29 AM
inka closed D11553: [lib][web][native] Remove nextLocalID from redux.
Fri, Apr 5, 3:43 AM
inka closed D11552: [lib][web][native] Use uuid for next local id.
Fri, Apr 5, 3:43 AM