inka (Inka Sokołowska)
User

Projects

User does not belong to any projects.

User Details

User Since: Jul 13 2022, 2:18 AM (106 w, 2 d)

Recent Activity
View All

Today

inka added inline comments to D12881: [lib] DMOperationSpec for change thread settings operation.

Fri, Jul 26, 6:32 AM

inka added inline comments to D12872: [lib] DMOperationSpec for remove members operation.

Fri, Jul 26, 5:31 AM

inka closed D12869: [native][web] Fill target_message column for sidebar source.

Fri, Jul 26, 5:28 AM

inka committed rCOMM093bb2f18a91: [native][web] Fill target_message column for sidebar source (authored by inka).

[native][web] Fill target_message column for sidebar source

Fri, Jul 26, 5:28 AM

inka closed D12867: [native][web] Fetch related messages for search.

Fri, Jul 26, 5:28 AM

inka closed D12866: [native][web] Fix timestamp type in cpp.

Fri, Jul 26, 5:28 AM

inka committed rCOMM86b47afb4189: [native][web] Fetch related messages for search (authored by inka).

[native][web] Fetch related messages for search

Fri, Jul 26, 5:28 AM

inka committed rCOMM58811e6bd9af: [native][web] Fix timestamp type in cpp (authored by inka).

[native][web] Fix timestamp type in cpp

Fri, Jul 26, 5:28 AM

inka closed D12865: [keyserver][lib][web][native] use local search for thick threads.

Fri, Jul 26, 5:28 AM

inka committed rCOMMb4354b47dc17: [keyserver][lib][web][native] use local search for thick threads (authored by inka).

[keyserver][lib][web][native] use local search for thick threads

Fri, Jul 26, 5:28 AM

inka added inline comments to D12871: [lib] DMOperationSpec for leave thread operation.

Fri, Jul 26, 3:52 AM

inka added inline comments to D12869: [native][web] Fill target_message column for sidebar source.

Fri, Jul 26, 3:37 AM

inka updated the diff for D12869: [native][web] Fill target_message column for sidebar source.

Fix case

Fri, Jul 26, 3:36 AM

inka updated the diff for D12869: [native][web] Fill target_message column for sidebar source.

Change case

Fri, Jul 26, 3:33 AM

inka updated the diff for D12869: [native][web] Fill target_message column for sidebar source.

Rename

Fri, Jul 26, 3:23 AM

inka updated the diff for D12869: [native][web] Fill target_message column for sidebar source.

Add newline

Fri, Jul 26, 3:11 AM

inka requested review of D12869: [native][web] Fill target_message column for sidebar source.

Requesting review because I am not familiar with cpp and a lot of decisions had to be made

Fri, Jul 26, 3:10 AM

inka updated the diff for D12869: [native][web] Fill target_message column for sidebar source.

Use MessageType::SIDEBAR_SOURCE, update MessageType. Had to move MessageType to avoid importing folly on web

Fri, Jul 26, 3:09 AM

inka added inline comments to D12867: [native][web] Fetch related messages for search.

Fri, Jul 26, 2:23 AM

Yesterday

inka added a comment to D12866: [native][web] Fix timestamp type in cpp.

In D12866#364118, @tomek wrote:

Have you tested it on both platforms?

Thu, Jul 25, 5:08 AM

inka updated the diff for D12869: [native][web] Fill target_message column for sidebar source.

Rebase

Thu, Jul 25, 5:03 AM

inka updated the diff for D12867: [native][web] Fetch related messages for search.

Rebase

Thu, Jul 25, 5:01 AM

inka updated the diff for D12866: [native][web] Fix timestamp type in cpp.

Address review

Thu, Jul 25, 4:58 AM

inka added inline comments to D12865: [keyserver][lib][web][native] use local search for thick threads.

Thu, Jul 25, 3:29 AM

inka updated the diff for D12865: [keyserver][lib][web][native] use local search for thick threads.

Address review

Thu, Jul 25, 3:29 AM

inka added inline comments to D12870: [lib] DMOperationSpec for join thread operation.

Thu, Jul 25, 3:02 AM

inka added inline comments to D12835: [lib] DMOperationSpec for add members operation.

Thu, Jul 25, 2:49 AM

inka added inline comments to D12835: [lib] DMOperationSpec for add members operation.

Thu, Jul 25, 2:41 AM

inka added inline comments to D12865: [keyserver][lib][web][native] use local search for thick threads.

Thu, Jul 25, 1:53 AM

inka added inline comments to D12867: [native][web] Fetch related messages for search.

Thu, Jul 25, 1:29 AM

inka requested review of D12869: [native][web] Fill target_message column for sidebar source.

Thu, Jul 25, 1:18 AM

inka accepted D12807: [lib] DMOperationSpec for edit operation.

Thu, Jul 25, 1:04 AM

inka accepted D12806: [lib] DMOperationSpec for reaction operation.

Thu, Jul 25, 1:03 AM

Wed, Jul 24

inka requested review of D12867: [native][web] Fetch related messages for search.

Wed, Jul 24, 9:38 AM

inka requested review of D12866: [native][web] Fix timestamp type in cpp.

Wed, Jul 24, 2:36 AM

inka added a comment to D12865: [keyserver][lib][web][native] use local search for thick threads.

One thing that doesn’t work in thick threads is fetching next pages of results. This is because timestamps exceed cpp int, so SQLiteQueryExecutor::searchMessages doesn’t bind them to sql query correctly. Fixing this is tracked in ENG-8893

Wed, Jul 24, 2:18 AM

inka added 1 blocking reviewer(s) for D12865: [keyserver][lib][web][native] use local search for thick threads: kamil.

Wed, Jul 24, 2:17 AM

inka requested review of D12865: [keyserver][lib][web][native] use local search for thick threads.

Wed, Jul 24, 2:15 AM

Tue, Jul 23

inka accepted D12851: [SQLite] implement tests for messages search.

Tue, Jul 23, 6:44 AM

inka accepted D12844: [SQLite] implement query for searching messages.

Tue, Jul 23, 6:22 AM

inka accepted D12843: [SQLite] add method for message search to SQLiteQueryExecutor for both web and native.

Tue, Jul 23, 6:14 AM

inka closed D12833: [lib][web][native] Create message search store ops.

Tue, Jul 23, 6:12 AM

inka committed rCOMM4d163ea41aef: [lib][web][native] Create message search store ops (authored by inka).

[lib][web][native] Create message search store ops

Tue, Jul 23, 6:12 AM

inka closed D12801: [lib][web] Add worker logic for adding search messages.

Tue, Jul 23, 6:12 AM

inka closed D12796: [native] Add CommCoreModule code for inserting into the search table.

Tue, Jul 23, 6:12 AM

inka committed rCOMM42a24e328e36: [native] Add CommCoreModule code for inserting into the search table (authored by inka).

[native] Add CommCoreModule code for inserting into the search table

Tue, Jul 23, 6:12 AM

inka committed rCOMMed2425b8704c: [lib][web] Add worker logic for adding search messages (authored by inka).

[lib][web] Add worker logic for adding search messages

Tue, Jul 23, 6:12 AM

inka closed D12795: [native] Add message search store.

Tue, Jul 23, 6:12 AM

inka committed rCOMMd41f5271dfed: [native] Add message search store (authored by inka).

[native] Add message search store

Tue, Jul 23, 6:12 AM

inka updated the diff for D12801: [lib][web] Add worker logic for adding search messages.

Rebase

Tue, Jul 23, 5:23 AM

inka updated the diff for D12833: [lib][web][native] Create message search store ops.

Move code to db-ops-reducer.js

Tue, Jul 23, 3:07 AM

inka closed D12794: [native] Add MessageSearchStoreOperations.

Tue, Jul 23, 2:44 AM

inka closed D12783: [web] Add bindings for inserting into the search table.

Tue, Jul 23, 2:44 AM

inka committed rCOMMefc7925c78bb: [native] Add MessageSearchStoreOperations (authored by inka).

[native] Add MessageSearchStoreOperations

Tue, Jul 23, 2:44 AM

inka closed D12778: [native] Add SQLiteQueryExecutor code for inserting into the search table.

Tue, Jul 23, 2:44 AM

inka committed rCOMM7b41e0ca3666: [web] Add bindings for inserting into the search table (authored by inka).

[web] Add bindings for inserting into the search table

Tue, Jul 23, 2:44 AM

inka committed rCOMM725ce1367367: [native] Add SQLiteQueryExecutor code for inserting into the search table (authored by inka).

[native] Add SQLiteQueryExecutor code for inserting into the search table

Tue, Jul 23, 2:44 AM

inka closed D12694: [native](web) Add message_search fts5 table.

Tue, Jul 23, 2:44 AM

inka committed rCOMMb6f1abd14fe2: [native](web) Add message_search fts5 table (authored by inka).

[native](web) Add message_search fts5 table

Tue, Jul 23, 2:44 AM

inka closed D12693: [native][web] Add fts5 extension to SQLite.

Tue, Jul 23, 2:44 AM

inka committed rCOMM66b8401f6f21: [native][web] Add fts5 extension to SQLite (authored by inka).

[native][web] Add fts5 extension to SQLite

Tue, Jul 23, 2:44 AM

inka updated the test plan for D12778: [native] Add SQLiteQueryExecutor code for inserting into the search table.

Tue, Jul 23, 2:41 AM

inka updated the diff for D12801: [lib][web] Add worker logic for adding search messages.

Rebase

Tue, Jul 23, 2:37 AM

inka updated the diff for D12795: [native] Add message search store.

Rebase

Tue, Jul 23, 2:31 AM

inka updated the diff for D12783: [web] Add bindings for inserting into the search table.

wasm

Tue, Jul 23, 1:28 AM

inka updated the diff for D12778: [native] Add SQLiteQueryExecutor code for inserting into the search table.

wasm

Tue, Jul 23, 1:27 AM

inka updated the diff for D12694: [native](web) Add message_search fts5 table.

wasm

Tue, Jul 23, 1:25 AM

inka updated the diff for D12795: [native] Add message search store.

Add CMake changes. Tested that android builds and no errors are thrown

Tue, Jul 23, 1:22 AM

Mon, Jul 22

inka updated the diff for D12801: [lib][web] Add worker logic for adding search messages.

Make read-only

Mon, Jul 22, 11:26 PM

inka added inline comments to D12801: [lib][web] Add worker logic for adding search messages.

Mon, Jul 22, 11:25 PM

inka planned changes to D12795: [native] Add message search store.

Mon, Jul 22, 11:24 PM

inka updated the diff for D12778: [native] Add SQLiteQueryExecutor code for inserting into the search table.

Fix indentation

Mon, Jul 22, 11:20 PM

inka updated the diff for D12694: [native](web) Add message_search fts5 table.

Fix indentation

Mon, Jul 22, 11:17 PM

inka updated the diff for D12783: [web] Add bindings for inserting into the search table.

Rebase

Mon, Jul 22, 8:17 AM

inka updated the diff for D12778: [native] Add SQLiteQueryExecutor code for inserting into the search table.

Rebase

Mon, Jul 22, 8:15 AM

inka updated the diff for D12694: [native](web) Add message_search fts5 table.

Move code

Mon, Jul 22, 8:11 AM

inka added a comment to D12806: [lib] DMOperationSpec for reaction operation.

On the keyserver, when reactionMessageCreationResponder is called, it calls createMessages which in turn calls updateRepliesCount. Do we need to do something like this for DMs?

Mon, Jul 22, 6:44 AM

inka added a comment to D12764: [lib] Introduce useGetLatestMessageEdit.

This solution requires us to query for every message separately. This seems very inefficient. Is this necessary?

Mon, Jul 22, 6:40 AM

inka accepted D12834: [web][native] Increase number of actions kept in Redux debugger.

Mon, Jul 22, 5:24 AM

inka requested review of D12833: [lib][web][native] Create message search store ops.

Mon, Jul 22, 3:12 AM

inka updated the diff for D12783: [web] Add bindings for inserting into the search table.

Rebase

Mon, Jul 22, 12:26 AM

inka updated the diff for D12778: [native] Add SQLiteQueryExecutor code for inserting into the search table.

Rebase

Mon, Jul 22, 12:25 AM

inka updated the diff for D12694: [native](web) Add message_search fts5 table.

Rebase

Mon, Jul 22, 12:00 AM

Sun, Jul 21

inka updated the diff for D12693: [native][web] Add fts5 extension to SQLite.

Rebase

Sun, Jul 21, 11:59 PM

Fri, Jul 19

inka updated the diff for D12795: [native] Add message search store.

Add newline

Fri, Jul 19, 8:06 AM

inka added inline comments to D12795: [native] Add message search store.

Fri, Jul 19, 8:06 AM

inka updated the diff for D12795: [native] Add message search store.

Rename

Fri, Jul 19, 8:03 AM

inka updated the diff for D12794: [native] Add MessageSearchStoreOperations.

Rename to UpdateMessageSearchIndexOperation

Fri, Jul 19, 8:00 AM

inka added inline comments to D12801: [lib][web] Add worker logic for adding search messages.

Fri, Jul 19, 4:06 AM

inka requested review of D12801: [lib][web] Add worker logic for adding search messages.

Fri, Jul 19, 3:33 AM

inka added inline comments to D12795: [native] Add message search store.

Fri, Jul 19, 2:59 AM

inka added inline comments to D12794: [native] Add MessageSearchStoreOperations.

Fri, Jul 19, 2:58 AM

Thu, Jul 18

inka updated the diff for D12783: [web] Add bindings for inserting into the search table.

Rename fix

Thu, Jul 18, 8:36 AM

inka requested review of D12796: [native] Add CommCoreModule code for inserting into the search table.

Thu, Jul 18, 8:30 AM

inka requested review of D12795: [native] Add message search store.

Thu, Jul 18, 8:24 AM

inka accepted D12650: Update extractKeyserverIDFromID so that it returns null for DMs.

Thu, Jul 18, 8:23 AM

inka requested review of D12794: [native] Add MessageSearchStoreOperations.

Thu, Jul 18, 8:21 AM

inka updated the test plan for D12793: [lib] Stop requesting device lists for users that don't have them.

Thu, Jul 18, 7:56 AM

inka requested review of D12793: [lib] Stop requesting device lists for users that don't have them.

Thu, Jul 18, 7:53 AM

inka updated the diff for D12783: [web] Add bindings for inserting into the search table.

Update wasm

Thu, Jul 18, 5:59 AM