User Details
- User Since
- Jul 13 2022, 2:18 AM (93 w, 2 d)
Today
Should we rename siweAuthActionTypes to legacySiweAuthActionTypes and keyserverRegisterActionTypes to legacyKeyserverRegisterActionTypes?
Remove unnecessary code
Address review
Yesterday
Make the code safer
Wed, Apr 24
Tue, Apr 23
Remove all actions but setAccessTokenActionType.
In the next diff I will move this reducer to native
Mon, Apr 22
Rebase
Fri, Apr 19
Thu, Apr 18
Remove unnecessary lines
I tested this and I was indeed able to login and register without these lines!
Wed, Apr 17
Tue, Apr 16
Rename
Show only one popup
A bit confused about the scenario you describe. How is the user able to log in after being logged out, if they can't auth with the authoritative keyserver? Doesn't the authoritative keyserver make the version check during auth?
Mon, Apr 15
Requesting review because now:
- We can still see this modal more than once - for other keyservers. Is this that we want??
- For the auth keyserver, the user is logged out. If they dismiss the modal, but ignore it and log in, they will be logged out and will NOT see the modal again. Is this ok or should I make logging in reset this state?
Memoize list of components, only display the alert once for each keyserver
Okay, this makes to me sense now
Now the modal looks like this:
Address review
It is also weird to me that we try to auth with the keyserver before identity login success. Maybe we should change that?
I worry that this may cause problems. Identity login and register clear data in case they are dispatched before logout success, so before user's data is cleared. This change makes it technically possible that the following will happen:
- User A logs in with identity and the keyserver - gets a user cookie
- User A logs out
- User B logs in, and a login success is dispatched before logout success
Now user B has user A's keyserver cookie
Fri, Apr 12
Thu, Apr 11
Wed, Apr 10
Rebase
Tue, Apr 9
Please remove the unnecessary code in all places before landing. Other than that looks good
Fri, Apr 5
Rename function