[native][web] Fix timestamp type in cpp
ClosedPublic
Actions

Authored by inka on Jul 24 2024, 2:15 AM.

Details

Reviewers

tomek
kamil

Commits

rCOMM58811e6bd9af: [native][web] Fix timestamp type in cpp

Summary

issue: ENG-8893
Timestamps exceed int, we need to use long long

Test Plan

Tested by commenting out isThreadThin check, and commenting out extractKeyserverIDFromIDOptional(messageInfo.threadID) check in getMessageSearchStoreOps. This allowed me to treat a thin thread as if it were thick, and execute local search on it.

Tested that this change fixed message search - next pages or results are now correctly fetched

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

inka created this revision.Jul 24 2024, 2:15 AM

Herald added a subscriber: ashoat. · View Herald TranscriptJul 24 2024, 2:15 AM

inka added a parent revision: D12865: [keyserver][lib][web][native] use local search for thick threads.Jul 24 2024, 2:17 AM

Harbormaster completed remote builds in B30628: Diff 42724.Jul 24 2024, 2:36 AM

inka requested review of this revision.Jul 24 2024, 2:36 AM

inka added a child revision: D12867: [native][web] Fetch related messages for search.Jul 24 2024, 3:28 AM

Have you tested it on both platforms?

This revision is now accepted and ready to land.Jul 24 2024, 5:46 AM

Thanks for fixing it!

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp
2591–2593 ↗	(On Diff #42724)	I think this should be `int64_t` like defined in here and you can use `bindInt64ToSQL` like in other places
native/cpp/CommonCpp/DatabaseManagers/entities/SQLiteDataConverters.cpp
51 ↗	(On Diff #42724)	the return type is `int` - see docs