Paths

Table of Contentst

-
native/cpp/CommonCpp/DatabaseManagers/
-
cpp/
-
CommonCpp/
-
DatabaseManagers/
-
SQLiteConnectionManager.cpp
-
web/
-
cpp/
-
SQLiteQueryExecutorBindings.cpp
-
shared-worker/_generated/
-
_generated/
-
comm_query_executor.wasm

Differential D14515

[SQLite] add logging to `handleSQLiteError`
AcceptedPublic
Actions

Authored by kamil on Thu, Apr 3, 2:16 AM.

Details

Reviewers

bartek

Summary

ENG-10474.

Test Plan

I added this while investigating the issue, and it helped

Diff Detail

Repository

rCOMM Comm

Branch

backup-publish

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Thu, Apr 3, 2:16 AM

kamil held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptThu, Apr 3, 2:16 AM

kamil edited the test plan for this revision. (Show Details)Thu, Apr 3, 2:17 AM

kamil mentioned this in D14516: [SQLite] refactor `backedUpTablesBlocklist` to be allowlist approach.Thu, Apr 3, 2:22 AM

kamil added a child revision: D14516: [SQLite] refactor `backedUpTablesBlocklist` to be allowlist approach.Thu, Apr 3, 2:27 AM

Harbormaster completed remote builds in B33870: Diff 47620.Thu, Apr 3, 2:35 AM

kamil published this revision for review.Thu, Apr 3, 3:03 AM

kamil added inline comments.

web/cpp/SQLiteQueryExecutorBindings.cpp
273–278	caused by running `yarn clang-format-all`

bartek accepted this revision.Thu, Apr 3, 3:20 AM

This revision is now accepted and ready to land.Thu, Apr 3, 3:20 AM

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

DatabaseManagers/

SQLiteConnectionManager.cpp

6 lines

web/

cpp/

SQLiteQueryExecutorBindings.cpp

6 lines

shared-worker/

_generated/

comm_query_executor.wasm

Diff 47620

View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteConnectionManager.cpp

View Options

web/cpp/SQLiteQueryExecutorBindings.cpp

View Options

web/shared-worker/_generated/comm_query_executor.wasm

[SQLite] add logging to `handleSQLiteError`AcceptedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 47620

native/cpp/CommonCpp/DatabaseManagers/SQLiteConnectionManager.cpp

web/cpp/SQLiteQueryExecutorBindings.cpp

web/shared-worker/_generated/comm_query_executor.wasm

[SQLite] add logging to `handleSQLiteError`
AcceptedPublic
Actions

Revision Contents
Changeset List