Paths

Table of Contentst

Differential D14531

[native] implement triggering backup compaction on dev
ClosedPublic
Actions

Authored by kamil on Apr 3 2025, 11:22 AM.

Tags

None

Referenced Files

None

Subscribers

Details

Reviewers

Commits

rCOMMfb2dbebf180d: [native] implement triggering backup compaction on dev

Summary

Depends on D14530

Test Plan

Test that user Data Upload works

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Apr 3 2025, 11:22 AM

kamil held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptApr 3 2025, 11:22 AM

kamil published this revision for review.Apr 3 2025, 11:31 AM

kamil added a child revision: D14532: [lib] attempt restoring User Data after QR auth.Apr 3 2025, 11:35 AM

Harbormaster completed remote builds in B33886: Diff 47636.Apr 3 2025, 11:39 AM

bartek added inline comments.Apr 3 2025, 12:03 PM

native/backup/backup-handler-context-provider.js
188 ↗	(On Diff #47636)	Shouldn't it run only on primary?
212–217 ↗	(On Diff #47636)	Now they both do the same, but isn't `shouldUploadCompaction` more specific than `shouldUploadBackup`? I'm worried that else-if will jump over the compaction case if the user keys boolean is falsey.
native/backup/use-migration-to-new-flow.js
87–89 ↗	(On Diff #47636)	My preference, but up to you
98–99 ↗	(On Diff #47636)	Now it isn't only UserKeys

address review

native/backup/backup-handler-context-provider.js
188 ↗	(On Diff #47636)	Sure, good catch
212–217 ↗	(On Diff #47636)	Agree, I also did some renames to make is easier to read

bartek accepted this revision.Apr 7 2025, 11:22 AM

This revision is now accepted and ready to land.Apr 7 2025, 11:22 AM

Harbormaster completed remote builds in B33922: Diff 47694.Apr 7 2025, 11:39 AM

Closed by commit rCOMMfb2dbebf180d: [native] implement triggering backup compaction on dev. · Explain WhyApr 7 2025, 11:46 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMfb2dbebf180d: [native] implement triggering backup compaction on dev.

Revision Contents
Changeset List

Path

Size

native/

backup/

backup-handler-context-provider.js

42 lines

use-client-backup.js

10 lines

use-migration-to-new-flow.js

18 lines

profile/

backup-menu.react.js

6 lines

Diff 47699

native/backup/backup-handler-context-provider.js

Loading...

native/backup/use-client-backup.js

Loading...

native/backup/use-migration-to-new-flow.js

Loading...

native/profile/backup-menu.react.js

Loading...