Page MenuHomePhabricator
Differential D14531

[native] implement triggering backup compaction on dev
ClosedPublic
Actions

Authored by kamil on Thu, Apr 3, 4:22 AM.
Tags
None
Referenced Files
F6059399: D14531.diff
Sun, Apr 20, 8:19 AM
Unknown Object (File)
Fri, Apr 18, 9:58 PM
Unknown Object (File)
Fri, Apr 18, 1:52 AM
Unknown Object (File)
Thu, Apr 17, 1:05 AM
Unknown Object (File)
Thu, Apr 17, 12:40 AM
Unknown Object (File)
Tue, Apr 15, 1:06 AM
Unknown Object (File)
Mon, Apr 14, 10:57 PM
Unknown Object (File)
Mon, Apr 14, 10:16 AM
View All 26 Files
Subscribers
ashoat
tomek

Details

Reviewers
bartek
Commits
rCOMMfb2dbebf180d: [native] implement triggering backup compaction on dev
Summary

ENG-10482.

Depends on D14530

Test Plan

Test that user Data Upload works

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Thu, Apr 3, 4:22 AM
kamil held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptThu, Apr 3, 4:22 AM
kamil published this revision for review.Thu, Apr 3, 4:31 AM
kamil added a child revision: D14532: [lib] attempt restoring User Data after QR auth.Thu, Apr 3, 4:35 AM
Harbormaster completed remote builds in B33886: Diff 47636.Thu, Apr 3, 4:39 AM
bartek added inline comments.Thu, Apr 3, 5:03 AM
native/backup/backup-handler-context-provider.js
188 ↗(On Diff #47636)

Shouldn't it run only on primary?

212–217 ↗(On Diff #47636)

Now they both do the same, but isn't shouldUploadCompaction more specific than shouldUploadBackup? I'm worried that else-if will jump over the compaction case if the user keys boolean is falsey.

native/backup/use-migration-to-new-flow.js
87–89 ↗(On Diff #47636)

My preference, but up to you

98–99 ↗(On Diff #47636)

Now it isn't only UserKeys

kamil updated this revision to Diff 47694.Mon, Apr 7, 4:22 AM

address review

native/backup/backup-handler-context-provider.js
188 ↗(On Diff #47636)

Sure, good catch

212–217 ↗(On Diff #47636)

Agree, I also did some renames to make is easier to read

bartek accepted this revision.Mon, Apr 7, 4:22 AM
This revision is now accepted and ready to land.Mon, Apr 7, 4:22 AM
Harbormaster completed remote builds in B33922: Diff 47694.Mon, Apr 7, 4:39 AM
Closed by commit rCOMMfb2dbebf180d: [native] implement triggering backup compaction on dev (authored by kamil). · Explain WhyMon, Apr 7, 4:46 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMMfb2dbebf180d: [native] implement triggering backup compaction on dev.

Revision Contents
Changeset List

Diff 47699

View Options

native/backup/backup-handler-context-provider.js

Loading...
View Options

native/backup/use-client-backup.js

Loading...
View Options

native/backup/use-migration-to-new-flow.js

Loading...
View Options

native/profile/backup-menu.react.js

Loading...