Page MenuHomePhabricator
Differential D14575

[native] update `persistConfig` comment
ClosedPublic
Actions

Authored by kamil on Mon, Apr 14, 6:54 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 19, 2:37 AM
Unknown Object (File)
Fri, Apr 18, 4:18 AM
Unknown Object (File)
Thu, Apr 17, 8:17 PM
Unknown Object (File)
Thu, Apr 17, 1:16 PM
Unknown Object (File)
Thu, Apr 17, 11:06 AM
Unknown Object (File)
Thu, Apr 17, 6:14 AM
Unknown Object (File)
Thu, Apr 17, 12:42 AM
Unknown Object (File)
Thu, Apr 17, 12:22 AM
View All 11 Files
Subscribers
ashoat
tomek

Details

Reviewers
bartek
Commits
rCOMMfa534b0d4790: [native] update `persistConfig` comment
Summary

Follow-up to D14522, I discovered that this comment is no longer relevant.

Depends on D14522

Test Plan

N/A

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
native/
redux/
4 lines
3 lines

Diff 47805

View Options

native/redux/persist-constants.js

  • This file was added.
// @flow
import type {
DMOperationSpec,
ProcessDMOperationUtilities,
} from './dm-op-spec.js';
import type { DMSendMultimediaMessageOperation } from '../../types/dm-ops.js';
import { messageTypes } from '../../types/message-types-enum.js';
import type { MediaMessageData } from '../../types/messages/media.js';
import type { ClientUpdateInfo } from '../../types/update-types.js';
import { rawMessageInfoFromMessageData } from '../message-utils.js';
function createMessageDataFromDMOperation(
dmOperation: DMSendMultimediaMessageOperation,
): MediaMessageData {
const { threadID, creatorID, time, media } = dmOperation;
return {
type: messageTypes.MULTIMEDIA,
threadID,
creatorID,
time,
media,
};
}
const sendMultimediaMessageSpec: DMOperationSpec<DMSendMultimediaMessageOperation> =
Object.freeze({
notificationsCreationData: async (
dmOperation: DMSendMultimediaMessageOperation,
) => {
const messageData = createMessageDataFromDMOperation(dmOperation);
return { messageDatas: [messageData] };
},
processDMOperation: async (
dmOperation: DMSendMultimediaMessageOperation,
) => {
const { messageID } = dmOperation;
const messageData = createMessageDataFromDMOperation(dmOperation);
const rawMessageInfos = [
rawMessageInfoFromMessageData(messageData, messageID),
];
const updateInfos: Array<ClientUpdateInfo> = [];
return {
rawMessageInfos,
updateInfos,
};
},
canBeProcessed(
dmOperation: DMSendMultimediaMessageOperation,
viewerID: string,
utilities: ProcessDMOperationUtilities,
) {
if (utilities.threadInfos[dmOperation.threadID]) {
return { isProcessingPossible: true };
}
return {
isProcessingPossible: false,
reason: {
type: 'missing_thread',
threadID: dmOperation.threadID,
},
};
},
supportsAutoRetry: false,
});
export { sendMultimediaMessageSpec };
View Options

native/redux/persist.js

  • This file was added.
// @flow
import type {
DMOperationSpec,
ProcessDMOperationUtilities,
} from './dm-op-spec.js';
import type { DMSendMultimediaMessageOperation } from '../../types/dm-ops.js';
import { messageTypes } from '../../types/message-types-enum.js';
import type { MediaMessageData } from '../../types/messages/media.js';
import type { ClientUpdateInfo } from '../../types/update-types.js';
import { rawMessageInfoFromMessageData } from '../message-utils.js';
function createMessageDataFromDMOperation(
dmOperation: DMSendMultimediaMessageOperation,
): MediaMessageData {
const { threadID, creatorID, time, media } = dmOperation;
return {
type: messageTypes.MULTIMEDIA,
threadID,
creatorID,
time,
media,
};
}
const sendMultimediaMessageSpec: DMOperationSpec<DMSendMultimediaMessageOperation> =
Object.freeze({
notificationsCreationData: async (
dmOperation: DMSendMultimediaMessageOperation,
) => {
const messageData = createMessageDataFromDMOperation(dmOperation);
return { messageDatas: [messageData] };
},
processDMOperation: async (
dmOperation: DMSendMultimediaMessageOperation,
) => {
const { messageID } = dmOperation;
const messageData = createMessageDataFromDMOperation(dmOperation);
const rawMessageInfos = [
rawMessageInfoFromMessageData(messageData, messageID),
];
const updateInfos: Array<ClientUpdateInfo> = [];
return {
rawMessageInfos,
updateInfos,
};
},
canBeProcessed(
dmOperation: DMSendMultimediaMessageOperation,
viewerID: string,
utilities: ProcessDMOperationUtilities,
) {
if (utilities.threadInfos[dmOperation.threadID]) {
return { isProcessingPossible: true };
}
return {
isProcessingPossible: false,
reason: {
type: 'missing_thread',
threadID: dmOperation.threadID,
},
};
},
supportsAutoRetry: false,
});
export { sendMultimediaMessageSpec };