Differential D14520

[lib] add logging to `createMissingSession`
ClosedPublic
Actions

Authored by kamil on Thu, Apr 3, 3:14 AM.

Tags

None

Referenced Files

	F5310232: D14520.id47625.diff
	Tue, Apr 8, 7:32 AM

	F5309656: D14520.id.diff
	Tue, Apr 8, 7:05 AM

	F5287853: D14520.diff
	Mon, Apr 7, 2:05 PM

	Unknown Object (File)
	Sun, Apr 6, 7:33 PM

	Unknown Object (File)
	Sun, Apr 6, 3:54 PM

	Unknown Object (File)
	Sun, Apr 6, 3:38 PM

	Unknown Object (File)
	Sun, Apr 6, 10:22 AM

	Unknown Object (File)
	Sat, Apr 5, 8:19 PM

View All 9 Files

Subscribers

Details

Reviewers

Commits

rCOMMb466463e3372: [lib] add logging to `createMissingSession`

Summary

I was seeing a random error in my dev console and had a hard time finding where it came from, this should help in the future.

Test Plan

After adding lgo here, I was able to identifythe exact place in the code where the error was caught,

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Thu, Apr 3, 3:14 AM

kamil held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptThu, Apr 3, 3:14 AM

kamil added a child revision: D14521: [lib][native] refactor login/restore hooks to return `IdentityAuthResult`.Thu, Apr 3, 3:18 AM

Harbormaster completed remote builds in B33875: Diff 47625.Thu, Apr 3, 3:32 AM

kamil published this revision for review.Thu, Apr 3, 3:49 AM

kamil edited the summary of this revision. (Show Details)

kamil edited the test plan for this revision. (Show Details)

bartek accepted this revision.Thu, Apr 3, 3:52 AM

This revision is now accepted and ready to land.Thu, Apr 3, 3:52 AM

Closed by commit rCOMMb466463e3372: [lib] add logging to `createMissingSession` (authored by kamil). · Explain WhyMon, Apr 7, 3:34 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMb466463e3372: [lib] add logging to `createMissingSession`.

Revision Contents
Changeset List

Path

Size

lib/

tunnelbroker/

peer-to-peer-context.js

20 lines

Diff 47683

lib/tunnelbroker/peer-to-peer-context.js

	// @flow			// @flow

	import t from 'tcomb';			import t from 'tcomb';
	import type { TInterface, TUnion } from 'tcomb';			import type { TInterface, TUnion } from 'tcomb';

	import { mixedRawThreadInfoValidator } from 'lib/permissions/minimally-encoded-thread-permissions-validators.js';			import { mixedRawThreadInfoValidator } from 'lib/permissions/minimally-encoded-raw-thread-info-validators.js';
	import { mediaValidator } from 'lib/types/media-types.js';			import { mediaValidator } from 'lib/types/media-types.js';
	import {			import {
	rawMessageInfoValidator,			rawMessageInfoValidator,
	messageTruncationStatusesValidator,			messageTruncationStatusesValidator,
	} from 'lib/types/message-types.js';			} from 'lib/types/message-types.js';
	import { userSurfacedPermissionValidator } from 'lib/types/thread-permission-types.js';			import { userSurfacedPermissionValidator } from 'lib/types/thread-permission-types.js';
	import { threadTypes } from 'lib/types/thread-types-enum.js';			import { threadTypes } from 'lib/types/thread-types-enum.js';
	import {			import {
	▲ Show 20 Lines • Show All 325 Lines • Show Last 20 Lines