Paths

Table of Contentst

Differential D14516

[SQLite] refactor `backedUpTablesBlocklist` to be allowlist approach
ClosedPublic
Actions

Authored by kamil on Apr 3 2025, 9:22 AM.

Details

Reviewers

bartek

Commits

rCOMM709bb9123ee5: [SQLite] refactor `backedUpTablesBlocklist` to be allowlist approach

Summary

ENG-10463.

Depends on D14515

Test Plan

Upload compaction and make sure it contains only tables included in backedUpTablesAllowlist

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Apr 3 2025, 9:22 AM

kamil held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptApr 3 2025, 9:22 AM

kamil edited the summary of this revision. (Show Details)Apr 3 2025, 9:27 AM

kamil added a parent revision: D14515: [SQLite] add logging to `handleSQLiteError`.

kamil added a child revision: D14517: [SQLite] implement method to copy table between databases.Apr 3 2025, 9:37 AM

Harbormaster completed remote builds in B33871: Diff 47621.Apr 3 2025, 9:40 AM

kamil published this revision for review.Apr 3 2025, 10:05 AM

kamil added inline comments.

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp
43–51 ↗	(On Diff #47621)	This is only set for testing purposes now, it will be replaced with new tables after Stop backing up thin thread data

bartek accepted this revision.Apr 3 2025, 10:27 AM

bartek added inline comments.

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp
3118–3125 ↗	(On Diff #47621)	👍 for replacing string concat with stringstream

This revision is now accepted and ready to land.Apr 3 2025, 10:27 AM

Closed by commit rCOMM709bb9123ee5: [SQLite] refactor `backedUpTablesBlocklist` to be allowlist approach. · Explain WhyApr 7 2025, 10:30 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM709bb9123ee5: [SQLite] refactor `backedUpTablesBlocklist` to be allowlist approach.

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

DatabaseManagers/

SQLiteQueryExecutor.h

4 lines

SQLiteQueryExecutor.cpp

71 lines

Diff 47679

View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.h