Page MenuHomePhabricator
Differential D12866

[native][web] Fix timestamp type in cpp
ClosedPublic
Actions

Authored by inka on Jul 24 2024, 2:15 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 20, 8:31 AM
Unknown Object (File)
Sun, Apr 20, 2:44 AM
Unknown Object (File)
Sat, Apr 19, 2:06 PM
Unknown Object (File)
Fri, Apr 18, 8:27 PM
Unknown Object (File)
Fri, Apr 18, 6:48 AM
Unknown Object (File)
Mar 4 2025, 10:04 PM
Unknown Object (File)
Feb 24 2025, 8:42 PM
Unknown Object (File)
Feb 21 2025, 4:37 AM
View All 51 Files
Subscribers
ashoat

Details

Reviewers
tomek
kamil
Commits
rCOMM58811e6bd9af: [native][web] Fix timestamp type in cpp
Summary

issue: ENG-8893
Timestamps exceed int, we need to use long long

Test Plan

Tested by commenting out isThreadThin check, and commenting out extractKeyserverIDFromIDOptional(messageInfo.threadID) check in getMessageSearchStoreOps. This allowed me to treat a thin thread as if it were thick, and execute local search on it.

Tested that this change fixed message search - next pages or results are now correctly fetched

Diff Detail

Repository
rCOMM Comm
Branch
inka/search
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

inka created this revision.Jul 24 2024, 2:15 AM
Herald added a subscriber: ashoat. · View Herald TranscriptJul 24 2024, 2:15 AM
inka added a parent revision: D12865: [keyserver][lib][web][native] use local search for thick threads.Jul 24 2024, 2:17 AM
Harbormaster completed remote builds in B30628: Diff 42724.Jul 24 2024, 2:36 AM
inka requested review of this revision.Jul 24 2024, 2:36 AM
inka added a child revision: D12867: [native][web] Fetch related messages for search.Jul 24 2024, 3:28 AM
tomek accepted this revision.Jul 24 2024, 5:46 AM

Have you tested it on both platforms?

This revision is now accepted and ready to land.Jul 24 2024, 5:46 AM
kamil accepted this revision.Jul 25 2024, 1:38 AM

Thanks for fixing it!

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp
2591–2593

I think this should be int64_t like defined in here and you can use bindInt64ToSQL like in other places

native/cpp/CommonCpp/DatabaseManagers/entities/SQLiteDataConverters.cpp
51

the return type is int - see docs

inka updated this revision to Diff 42769.Jul 25 2024, 4:58 AM

Address review

inka added a comment.Jul 25 2024, 5:08 AM
In D12866#364118, @tomek wrote:

Have you tested it on both platforms?

Yes I have

Harbormaster completed remote builds in B30665: Diff 42769.Jul 25 2024, 5:15 AM
Closed by commit rCOMM58811e6bd9af: [native][web] Fix timestamp type in cpp (authored by inka). · Explain WhyJul 26 2024, 5:28 AM
This revision was automatically updated to reflect the committed changes.
inka added a commit: rCOMM58811e6bd9af: [native][web] Fix timestamp type in cpp.

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
DatabaseManagers/
6 lines
entities/
1 line
4 lines
web/
shared-worker/
_generated/

Diff 42724

View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

Loading...
View Options

native/cpp/CommonCpp/DatabaseManagers/entities/SQLiteDataConverters.h

Loading...
View Options

native/cpp/CommonCpp/DatabaseManagers/entities/SQLiteDataConverters.cpp

Loading...
View Options

web/shared-worker/_generated/comm_query_executor.wasm

Loading...