Page MenuHomePhabricator
Feed Advanced Search

Today

inka closed D11736: [lib] Fix error when deleting a keyserver.
Tue, Apr 23, 4:56 AM
inka committed rCOMM69c181651591: [lib] Fix error when deleting a keyserver (authored by inka).
[lib] Fix error when deleting a keyserver
Tue, Apr 23, 4:56 AM
inka requested review of D11738: [lib][native] Move reduceServicesAccessToken and setAccessTokenActionType to native.
Tue, Apr 23, 4:54 AM
inka updated the summary of D11395: [lib][native] Only reduce CSAT on setAccessTokenActionType.
Tue, Apr 23, 4:36 AM
inka updated the test plan for D11395: [lib][native] Only reduce CSAT on setAccessTokenActionType.
Tue, Apr 23, 4:35 AM
inka retitled D11395: [lib][native] Only reduce CSAT on setAccessTokenActionType from [lib][native] Stop deleting CSAT on login actions to [lib][native] Only reduce CSAT on setAccessTokenActionType.
Tue, Apr 23, 4:34 AM
inka updated the diff for D11395: [lib][native] Only reduce CSAT on setAccessTokenActionType.

Remove all actions but setAccessTokenActionType.
In the next diff I will move this reducer to native

Tue, Apr 23, 4:33 AM
inka requested review of D11736: [lib] Fix error when deleting a keyserver.
Tue, Apr 23, 4:17 AM
inka accepted D11692: [lib] Don't reduce KEYSERVER_AUTH_SUCCESS in reduceCurrentUserInfo.
Tue, Apr 23, 1:20 AM

Yesterday

inka added inline comments to D11692: [lib] Don't reduce KEYSERVER_AUTH_SUCCESS in reduceCurrentUserInfo.
Mon, Apr 22, 7:57 AM
inka accepted D11708: [keyserver] Use keyserverID instead of userID when creating invite link blobs.
Mon, Apr 22, 4:58 AM
inka published D11708: [keyserver] Use keyserverID instead of userID when creating invite link blobs for review.
Mon, Apr 22, 4:57 AM
inka updated the diff for D11141: [IGNORE] Client hacks for testing multiple keyservers.

Rebase

Mon, Apr 22, 4:50 AM
inka closed D11701: [web] Remove authoritativeKeyserverID check from getInitialReduxState.
Mon, Apr 22, 4:36 AM
inka committed rCOMMfaa0659b1a25: [web] Remove authoritativeKeyserverID check from getInitialReduxState (authored by inka).
[web] Remove authoritativeKeyserverID check from getInitialReduxState
Mon, Apr 22, 4:35 AM

Fri, Apr 19

inka requested review of D11701: [web] Remove authoritativeKeyserverID check from getInitialReduxState.
Fri, Apr 19, 9:11 AM

Thu, Apr 18

inka updated the diff for D11141: [IGNORE] Client hacks for testing multiple keyservers.

Remove unnecessary lines

Thu, Apr 18, 4:42 AM
inka added a comment to D11141: [IGNORE] Client hacks for testing multiple keyservers.

I tested this and I was indeed able to login and register without these lines!

Thu, Apr 18, 4:41 AM

Wed, Apr 17

inka added inline comments to D11670: [native][web] Don't stamp SQLite database until authoritative keyserver auth.
Wed, Apr 17, 6:01 AM

Tue, Apr 16

inka closed D11643: [web] Show a popup when client_version_unsupported.
Tue, Apr 16, 5:18 AM
inka committed rCOMMe54b3a74315b: [web] Show a popup when client_version_unsupported (authored by inka).
[web] Show a popup when client_version_unsupported
Tue, Apr 16, 5:18 AM
inka closed D11632: [lib][web][native] Pass preRequestUserState into invalidSessionRecovery.
Tue, Apr 16, 5:18 AM
inka closed D11631: [lib] Stop attempting recovery when client version unsupported.
Tue, Apr 16, 5:18 AM
inka committed rCOMM7b3fd475e97a: [lib][web][native] Pass preRequestUserState into invalidSessionRecovery (authored by inka).
[lib][web][native] Pass preRequestUserState into invalidSessionRecovery
Tue, Apr 16, 5:18 AM
inka committed rCOMMabe65dc59251: [lib] Stop attempting recovery when client version unsupported (authored by inka).
[lib] Stop attempting recovery when client version unsupported
Tue, Apr 16, 5:18 AM
inka closed D11619: [lib] Add client_version_unsupported connectionIssue.
Tue, Apr 16, 5:18 AM
inka committed rCOMMa766dc8d4a21: [lib] Add client_version_unsupported connectionIssue (authored by inka).
[lib] Add client_version_unsupported connectionIssue
Tue, Apr 16, 5:18 AM
inka updated the diff for D11643: [web] Show a popup when client_version_unsupported.

Rename

Tue, Apr 16, 4:50 AM
inka updated the diff for D11643: [web] Show a popup when client_version_unsupported.

Show only one popup

Tue, Apr 16, 3:04 AM
inka added a comment to D11643: [web] Show a popup when client_version_unsupported.

A bit confused about the scenario you describe. How is the user able to log in after being logged out, if they can't auth with the authoritative keyserver? Doesn't the authoritative keyserver make the version check during auth?

Tue, Apr 16, 1:53 AM

Mon, Apr 15

inka requested review of D11643: [web] Show a popup when client_version_unsupported.

Requesting review because now:

  1. We can still see this modal more than once - for other keyservers. Is this that we want??
  2. For the auth keyserver, the user is logged out. If they dismiss the modal, but ignore it and log in, they will be logged out and will NOT see the modal again. Is this ok or should I make logging in reset this state?
Mon, Apr 15, 9:13 AM
inka updated the diff for D11643: [web] Show a popup when client_version_unsupported.

Memoize list of components, only display the alert once for each keyserver

Mon, Apr 15, 9:11 AM
inka accepted D11654: [lib] Don't clear authoritative keyserver cookie during identity auth.

Okay, this makes to me sense now

Mon, Apr 15, 8:58 AM
inka updated the test plan for D11643: [web] Show a popup when client_version_unsupported.
Mon, Apr 15, 7:12 AM
inka added a comment to D11643: [web] Show a popup when client_version_unsupported.

Can't we simply reload the page when the client version is unsupported?

Mon, Apr 15, 4:29 AM
inka attached a referenced file: F1548897: image.png.
Mon, Apr 15, 2:39 AM
inka added a comment to D11643: [web] Show a popup when client_version_unsupported.

Now the modal looks like this:

image.png (142×220 px, 9 KB)

Mon, Apr 15, 2:38 AM
inka updated the summary of D11643: [web] Show a popup when client_version_unsupported.
Mon, Apr 15, 2:37 AM
inka updated the diff for D11643: [web] Show a popup when client_version_unsupported.

Address review

Mon, Apr 15, 2:37 AM
inka added inline comments to D11643: [web] Show a popup when client_version_unsupported.
Mon, Apr 15, 2:36 AM
inka added inline comments to D11632: [lib][web][native] Pass preRequestUserState into invalidSessionRecovery.
Mon, Apr 15, 2:07 AM
inka added a comment to D11654: [lib] Don't clear authoritative keyserver cookie during identity auth.

It is also weird to me that we try to auth with the keyserver before identity login success. Maybe we should change that?

Mon, Apr 15, 1:08 AM
inka accepted D11656: [lib] Use useDerivedObject to reduce renders due to preRequestUserState.
Mon, Apr 15, 1:00 AM
inka accepted D11655: [lib] Introduce usePreRequestUserState.
Mon, Apr 15, 12:44 AM
inka added a comment to D11654: [lib] Don't clear authoritative keyserver cookie during identity auth.

I worry that this may cause problems. Identity login and register clear data in case they are dispatched before logout success, so before user's data is cleared. This change makes it technically possible that the following will happen:

  1. User A logs in with identity and the keyserver - gets a user cookie
  2. User A logs out
  3. User B logs in, and a login success is dispatched before logout success

Now user B has user A's keyserver cookie

Mon, Apr 15, 12:43 AM

Fri, Apr 12

inka accepted D11644: Extract shareable logic from CreateSIWEBackupMessage component.
Fri, Apr 12, 6:54 AM
inka requested review of D11643: [web] Show a popup when client_version_unsupported.
Fri, Apr 12, 1:59 AM

Thu, Apr 11

inka requested review of D11632: [lib][web][native] Pass preRequestUserState into invalidSessionRecovery.
Thu, Apr 11, 6:25 AM
inka requested review of D11631: [lib] Stop attempting recovery when client version unsupported.
Thu, Apr 11, 5:20 AM

Wed, Apr 10

inka updated the diff for D11141: [IGNORE] Client hacks for testing multiple keyservers.

Rebase

Wed, Apr 10, 4:07 AM
inka requested review of D11619: [lib] Add client_version_unsupported connectionIssue.
Wed, Apr 10, 3:52 AM
inka accepted D11533: [web][native] Reset the state iff current user ID changes.
Wed, Apr 10, 2:46 AM

Tue, Apr 9

inka accepted D11534: [web][native] Extract the common logic determining when to clear the data.

Please remove the unnecessary code in all places before landing. Other than that looks good

Tue, Apr 9, 2:30 AM

Fri, Apr 5

inka closed D11565: [lib] Simplify sorting local ids.
Fri, Apr 5, 7:26 AM
inka committed rCOMM9259a5fd4b26: [lib] Simplify sorting local ids (authored by inka).
[lib] Simplify sorting local ids
Fri, Apr 5, 7:26 AM
inka closed D11564: [lib] Fix sorting local messages.
Fri, Apr 5, 7:26 AM
inka committed rCOMM57aa051186e2: [lib] Fix sorting local messages (authored by inka).
[lib] Fix sorting local messages
Fri, Apr 5, 7:26 AM
inka closed D11542: [keyserver] Login or register before tables are created.
Fri, Apr 5, 5:58 AM
inka closed D11540: [keyserver] Refactor registerOrLogIn to take callbacks.
Fri, Apr 5, 5:58 AM
inka committed rCOMMaf3bd6da97b5: [keyserver] Login or register before tables are created (authored by inka).
[keyserver] Login or register before tables are created
Fri, Apr 5, 5:58 AM
inka committed rCOMMd7b2b0417a8e: [keyserver] Refactor registerOrLogIn to take callbacks (authored by inka).
[keyserver] Refactor registerOrLogIn to take callbacks
Fri, Apr 5, 5:58 AM
inka closed D11530: [scripts] Improve prompt.
Fri, Apr 5, 5:58 AM
inka committed rCOMM99d77585156c: [scripts] Improve prompt (authored by inka).
[scripts] Improve prompt
Fri, Apr 5, 5:58 AM
inka updated the diff for D11542: [keyserver] Login or register before tables are created.

Rename function

Fri, Apr 5, 5:29 AM
inka closed D11553: [lib][web][native] Remove nextLocalID from redux.
Fri, Apr 5, 3:43 AM
inka closed D11552: [lib][web][native] Use uuid for next local id.
Fri, Apr 5, 3:43 AM
inka committed rCOMMf2ad39d004ef: [lib][web][native] Use uuid for next local id (authored by inka).
[lib][web][native] Use uuid for next local id
Fri, Apr 5, 3:43 AM
inka committed rCOMM5e92d20068ea: [lib][web][native] Remove nextLocalID from redux (authored by inka).
[lib][web][native] Remove nextLocalID from redux
Fri, Apr 5, 3:43 AM
inka requested review of D11565: [lib] Simplify sorting local ids.
Fri, Apr 5, 3:43 AM
inka added inline comments to D11542: [keyserver] Login or register before tables are created.
Fri, Apr 5, 3:39 AM
inka requested review of D11564: [lib] Fix sorting local messages.
Fri, Apr 5, 3:33 AM
inka updated the diff for D11553: [lib][web][native] Remove nextLocalID from redux.

Rebase

Fri, Apr 5, 3:09 AM

Thu, Apr 4

inka updated the diff for D11553: [lib][web][native] Remove nextLocalID from redux.

Add migration

Thu, Apr 4, 9:02 AM
inka requested review of D11553: [lib][web][native] Remove nextLocalID from redux.
Thu, Apr 4, 7:33 AM
inka requested review of D11552: [lib][web][native] Use uuid for next local id.
Thu, Apr 4, 7:31 AM
inka updated the diff for D11530: [scripts] Improve prompt.

Address review

Thu, Apr 4, 5:36 AM
inka added inline comments to D11534: [web][native] Extract the common logic determining when to clear the data.
Thu, Apr 4, 4:00 AM
inka added inline comments to D11533: [web][native] Reset the state iff current user ID changes.
Thu, Apr 4, 3:59 AM
inka added inline comments to D11533: [web][native] Reset the state iff current user ID changes.
Thu, Apr 4, 3:46 AM
inka accepted D11532: [web][native] Refactor reset state logic in reducers.
Thu, Apr 4, 3:20 AM

Wed, Apr 3

inka requested review of D11542: [keyserver] Login or register before tables are created.
Wed, Apr 3, 7:35 AM
inka requested review of D11540: [keyserver] Refactor registerOrLogIn to take callbacks.
Wed, Apr 3, 6:48 AM
inka updated subscribers of D11395: [lib][native] Only reduce CSAT on setAccessTokenActionType.
Wed, Apr 3, 5:49 AM
inka requested review of D11530: [scripts] Improve prompt.
Wed, Apr 3, 2:05 AM
inka updated the diff for D11141: [IGNORE] Client hacks for testing multiple keyservers.

Rebase

Wed, Apr 3, 1:21 AM

Fri, Mar 29

inka closed D11394: [lib][web][native] Handle idnentity login in reducers.
Fri, Mar 29, 4:58 AM
inka closed D11437: [lib] Wipe keyserver store on login.
Fri, Mar 29, 4:58 AM
inka committed rCOMM8ba944173c98: [lib] Wipe keyserver store on login (authored by inka).
[lib] Wipe keyserver store on login
Fri, Mar 29, 4:58 AM
inka committed rCOMM362fadd02e70: [lib][web][native] Handle idnentity login in reducers (authored by inka).
[lib][web][native] Handle idnentity login in reducers
Fri, Mar 29, 4:58 AM
inka closed D11393: [lib] Add preRequestUserState to identity login.
Fri, Mar 29, 4:58 AM
inka committed rCOMM4b6ffdaba055: [lib] Add preRequestUserState to identity login (authored by inka).
[lib] Add preRequestUserState to identity login
Fri, Mar 29, 4:58 AM
inka added inline comments to D11395: [lib][native] Only reduce CSAT on setAccessTokenActionType.
Fri, Mar 29, 4:29 AM
inka accepted D11440: [lib] Set default state when wiping out a keyserver store.

I think this is fine. And this also addresses the fact that we forgot to include wiping activeSessionRecovery here

Fri, Mar 29, 1:44 AM
inka updated the diff for D11393: [lib] Add preRequestUserState to identity login.

Simplify

Fri, Mar 29, 1:37 AM

Thu, Mar 28

inka requested review of D11437: [lib] Wipe keyserver store on login.
Thu, Mar 28, 7:22 AM
inka updated the diff for D11393: [lib] Add preRequestUserState to identity login.

Make preRequestUserState optional

Thu, Mar 28, 6:32 AM
inka added inline comments to D11393: [lib] Add preRequestUserState to identity login.
Thu, Mar 28, 6:32 AM
inka updated the diff for D11141: [IGNORE] Client hacks for testing multiple keyservers.

Rebase

Thu, Mar 28, 6:21 AM

Wed, Mar 27

inka added inline comments to D11394: [lib][web][native] Handle idnentity login in reducers.
Wed, Mar 27, 8:34 AM
inka requested review of D11395: [lib][native] Only reduce CSAT on setAccessTokenActionType.
Wed, Mar 27, 5:13 AM