Page MenuHomePhabricator
Differential D13333

[lib] update threadLabel to handle thick threads
ClosedPublic
Actions

Authored by inka on Fri, Sep 13, 5:45 AM.
Tags
None
Referenced Files
F2745703: D13333.id44173.diff
Wed, Sep 18, 6:35 AM
F2744956: D13333.id44185.diff
Wed, Sep 18, 5:04 AM
F2743649: D13333.id44159.diff
Wed, Sep 18, 3:31 AM
F2738262: D13333.diff
Tue, Sep 17, 8:03 PM
Unknown Object (File)
Mon, Sep 16, 2:15 AM
Unknown Object (File)
Sun, Sep 15, 7:47 AM
Unknown Object (File)
Sat, Sep 14, 8:10 AM
Unknown Object (File)
Fri, Sep 13, 8:44 AM
View All 12 Files
Subscribers
None

Details

Reviewers
tomek
kamil
ashoat
Commits
rCOMM48db54e22644: [lib] update threadLabel to handle thick threads
Summary

issue: ENG-9173

Test Plan

Tested that when creating a chat:

  • if a chat for the selected list of users exists and is thin, proper label for the thin tye is shown
  • if the chat for the selected list of users doesn't exist - "Local DM" is shown, with a lock icon

Tested that in thread settings:

  • if thread is thick, "Local DM" is shown, with a lock icon
  • if thread is thick sidebar, "Thread" with the align-right icon is shown
  • if thread is thin, proper label and icon are shown

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

inka created this revision.Fri, Sep 13, 5:45 AM
inka added a parent revision: D13320: [web][native] Update UI to not display GENESIS over thick threads.Fri, Sep 13, 5:45 AM
inka edited parent revisions, added: D13275: Update search header in chat creation on native not to show GENESIS for thick threads; removed: D13320: [web][native] Update UI to not display GENESIS over thick threads.
Harbormaster completed remote builds in B31610: Diff 44159.Fri, Sep 13, 6:02 AM
inka requested review of this revision.Fri, Sep 13, 6:02 AM
tomek accepted this revision.Fri, Sep 13, 6:07 AM
tomek added inline comments.
lib/shared/thread-utils.js
1223–1224 ↗(On Diff #44159)

Isn't it already handled by threadTypeIsSidebar(threadType)?

This revision is now accepted and ready to land.Fri, Sep 13, 6:07 AM
inka updated this revision to Diff 44173.Fri, Sep 13, 6:14 AM

Simplify

tomek accepted this revision.Fri, Sep 13, 6:15 AM
Harbormaster completed remote builds in B31613: Diff 44173.Fri, Sep 13, 6:31 AM
inka added a child revision: D13335: [lib][web][native] Refactor usingOlmViaTunnelbrokerForDMs.Fri, Sep 13, 6:58 AM
Closed by commit rCOMM48db54e22644: [lib] update threadLabel to handle thick threads (authored by inka). · Explain WhyFri, Sep 13, 8:59 AM
This revision was automatically updated to reflect the committed changes.
inka added a commit: rCOMM48db54e22644: [lib] update threadLabel to handle thick threads.

Revision Contents
Changeset List

PathSize
lib/
shared/
2 lines

Diff 44185

View Options

lib/shared/thread-utils.js

Loading...