Page MenuHomePhabricator
Differential D13320

[web][native] Update UI to not display GENESIS over thick threads
ClosedPublic
Actions

Authored by inka on Fri, Sep 13, 3:11 AM.
Tags
None
Referenced Files
F2736679: D13320.diff
Tue, Sep 17, 4:45 PM
F2723759: D13320.diff
Mon, Sep 16, 9:28 PM
Unknown Object (File)
Fri, Sep 13, 8:44 AM
Unknown Object (File)
Fri, Sep 13, 8:44 AM
Unknown Object (File)
Fri, Sep 13, 8:44 AM
Unknown Object (File)
Fri, Sep 13, 8:43 AM
F2679332: Screenshot 2024-09-13 at 12.08.12.png
Fri, Sep 13, 3:12 AM
F2679333: Screenshot 2024-09-13 at 12.08.33.png
Fri, Sep 13, 3:12 AM
Subscribers
None

Details

Reviewers
tomek
kamil
ashoat
Commits
rCOMM529b78e6344c: [web][native] Update UI to not display GENESIS over thick threads
Summary

issue: ENG-8931

Test Plan

Please see the screenshots:

Screenshot 2024-09-13 at 12.08.33.png (704×702 px, 137 KB)

Screenshot 2024-09-13 at 12.08.12.png (662×798 px, 74 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

inka created this revision.Fri, Sep 13, 3:11 AM
inka edited the test plan for this revision. (Show Details)EditedFri, Sep 13, 3:12 AM
inka attached a referenced file: F2679332: Screenshot 2024-09-13 at 12.08.12.png. (Show Details)
inka attached a referenced file: F2679333: Screenshot 2024-09-13 at 12.08.33.png. (Show Details)

I changed some things compared to what we discussed on linear: I updated spacing, and changed the color of the icon on web to match breadcrumbs

inka added inline comments.Fri, Sep 13, 3:16 AM
web/chat/chat-thread-list.css
297 ↗(On Diff #44124)

Text is 18px high, and has padding padding: 8px 0 2px 0;. The icon is 19px high. I wanted the text and icon to be more or less aligned

Harbormaster completed remote builds in B31587: Diff 44124.Fri, Sep 13, 3:28 AM
inka requested review of this revision.Fri, Sep 13, 3:28 AM
tomek accepted this revision.Fri, Sep 13, 3:55 AM
tomek added inline comments.
native/chat/chat-thread-list-item.react.js
154–158 ↗(On Diff #44124)

I don't think the memoization is beneficial here.

This revision is now accepted and ready to land.Fri, Sep 13, 3:55 AM
inka added a child revision: D13333: [lib] update threadLabel to handle thick threads.Fri, Sep 13, 5:45 AM
inka removed a child revision: D13333: [lib] update threadLabel to handle thick threads.
inka updated this revision to Diff 44171.Fri, Sep 13, 5:49 AM

Remove unecessary memos

tomek accepted this revision.Fri, Sep 13, 5:56 AM
Harbormaster completed remote builds in B31611: Diff 44171.Fri, Sep 13, 6:06 AM
ashoat accepted this revision.Fri, Sep 13, 7:12 AM
inka added a parent revision: D13335: [lib][web][native] Refactor usingOlmViaTunnelbrokerForDMs.Fri, Sep 13, 7:19 AM
inka mentioned this in D13336: [lib] Update useAncestorThreads to consider thick threads.Fri, Sep 13, 7:23 AM
inka added a child revision: D13336: [lib] Update useAncestorThreads to consider thick threads.Fri, Sep 13, 7:24 AM
Closed by commit rCOMM529b78e6344c: [web][native] Update UI to not display GENESIS over thick threads (authored by inka). · Explain WhyFri, Sep 13, 8:59 AM
This revision was automatically updated to reflect the committed changes.
inka added a commit: rCOMM529b78e6344c: [web][native] Update UI to not display GENESIS over thick threads.
inka mentioned this in rCOMM1a48c411011f: [lib] Update useAncestorThreads to consider thick threads.

Revision Contents
Changeset List

Diff 44187

View Options

native/chat/chat-thread-list-item.react.js

Loading...
View Options

native/components/thread-ancestors-label.react.js

Loading...
View Options

web/chat/chat-thread-list-item.react.js

Loading...
View Options

web/chat/chat-thread-list.css

Loading...