Differential D13336

[lib] Update useAncestorThreads to consider thick threads
ClosedPublic
Actions

Authored by inka on Fri, Sep 13, 7:23 AM.

Details

Reviewers

tomek

Commits

rCOMM1a48c411011f: [lib] Update useAncestorThreads to consider thick threads

Summary

issue: ENG-9260
We want to remove breadcrumbs from NavStateInfoBar when creating a new thread

Test Plan

Tested that breadcrumbs are no longer present in NavStateInfoBar when creating a thick thread
Checked all places where useAncestorThreads is used and verified that the bahviour is correct for all of them (it is provided D13320 is also applied)

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

inka created this revision.Fri, Sep 13, 7:23 AM

Herald added a subscriber: ashoat. · View Herald TranscriptFri, Sep 13, 7:23 AM

inka added a parent revision: D13320: [web][native] Update UI to not display GENESIS over thick threads.Fri, Sep 13, 7:24 AM

Harbormaster completed remote builds in B31615: Diff 44175.Fri, Sep 13, 7:41 AM

inka requested review of this revision.Fri, Sep 13, 7:41 AM

tomek accepted this revision.Fri, Sep 13, 8:00 AM

tomek added inline comments.

lib/shared/ancestor-threads.js
32–34 ↗	(On Diff #44175)	Shouldn't we check the thread type instead?

This revision is now accepted and ready to land.Fri, Sep 13, 8:00 AM

Address review

Harbormaster completed remote builds in B31617: Diff 44183.Fri, Sep 13, 8:56 AM

Closed by commit rCOMM1a48c411011f: [lib] Update useAncestorThreads to consider thick threads (authored by inka). · Explain WhyFri, Sep 13, 8:59 AM

This revision was automatically updated to reflect the committed changes.

inka added a commit: rCOMM1a48c411011f: [lib] Update useAncestorThreads to consider thick threads.

Revision Contents
Changeset List

Path

Size

lib/

shared/

ancestor-threads.js

7 lines

Diff 44188

View Options

lib/shared/ancestor-threads.js

[lib] Update useAncestorThreads to consider thick threadsClosedPublicActions